standard 0.4.5 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 66a00109a56907165a97df2ceba38b8575b697890232bc295311dcb9d2adae39
-  data.tar.gz: 398c841fad077613fe1ddfadb000ccafe3bb313243846513c857303e5444d648
+  metadata.gz: b2fc5c4feabb2ffb3f4a2879ce84aff4d91003578d1a512e2456e6591e276cbb
+  data.tar.gz: dc8636c2d82e16c035720aa0a17084f038989fbaf489b8ddb42a16362aaf548c
 SHA512:
-  metadata.gz: 1b0300c97dd07f13c0242af3e5276fc48a89abb12b16ec6e22921b5d1dcf3f3112a5adae5ddb976dbed76b3f9438d5256743b7784335d560a3543c88ff20fe00
-  data.tar.gz: 6e851d45878a4705f480c12a4942b962de3034c1c2b8b7c96b336268ec678b3f4fea4658ace3639a03cc1ee3b0e83205da38f8bb9ffdf0f50f72e97a3e9dfb54
+  metadata.gz: c3926b153706b0f45bd467e24ea41cc2a5886fcbb0d1cd98657b0ce5ee767f7e69a2e6d347abf0b595e21ff69f0c9250747cbaea794c3f6bd6d4ff7c7574627e
+  data.tar.gz: 8624a8b222b3bebfcf9d8132bffd3220542daa45fd29a0ff4113c04422deddc8cd2efd64d2b8262e78df24f8606978ffe91bc623a1b5e5d5c2337f1b8a58d4f7

data/.github/workflows/test.yml

@@ -0,0 +1,23 @@
+name: Tests
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+    - name: Install dependencies
+      run: bundle
+    - name: Run tests
+      run: bundle exec rake

data/CHANGELOG.md

@@ -1,5 +1,76 @@
 # Changelog
 
+## 0.5.2
+
+* Turned off `Lint/MissingSuper`, because it effectively bans a common idiom in
+  Sorbet ([#195](https://github.com/testdouble/standard/issues/195)) and might
+  be a bit too heavy-handed/opinionated for cases where a class is designed
+  intentionally to not run its parent's initializer (like abstract superclasses
+  more generally)
+
+## 0.5.1
+
+* Enabled `Style/MultilineWhenThen`
+
+## 0.5.0
+
+* Update Rubocop from
+  [0.85.0](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md#0850-2020-06-01)
+  to
+  [0.89.1](https://github.com/rubocop-hq/rubocop/releases/tag/v0.89.1),
+  enabling:
+  * `Lint/BinaryOperatorWithIdenticalOperands`
+  * `Lint/DuplicateElsifCondition`
+  * `Lint/DuplicateRescueException`
+  * `Lint/FloatComparison`
+  * `Lint/MissingSuper`
+  * `Lint/OutOfRangeRegexpRef`
+  * `Lint/RedundantRequireStatement`
+  * `Lint/RedundantSplatExpansion`
+  * `Lint/SafeNavigationWithEmpty`
+  * `Lint/SelfAssignment`
+  * `Lint/TopLevelReturnWithArgument`
+  * `Style/GlobalStdStream`
+  * `Style/RedundantAssignment`
+  * `Style/RedundantFetchBlock`
+  * `Style/RedundantFileExtensionInRequire`
+* Update rubocop-performance from 1.6.0 to 1.7.1, enabling:
+  * `Performance/BigDecimalWithNumericArgument`
+  * `Performance/RedundantSortBlock`
+  * `Performance/RedundantStringChars`
+  * `Performance/ReverseFirst`
+  * `Performance/SortReverse`
+  * `Performance/Squeeze`
+
+## 0.4.7
+
+* Update Rubocop from
+  [0.83.0](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md#0830-2020-05-11)
+  to
+  [0.85.0](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md#0850-2020-06-01), notably:
+
+  * Enable
+    [Lint/MixedRegexpCaptureTypes](https://rubocop.readthedocs.io/en/stable/cops_lint/#lintmixedregexpcapturetypes)
+  * Enable
+    [Lint/DeprecatedOpenSSLConstant](https://rubocop.readthedocs.io/en/stable/cops_lint/#lintdeprecatedopensslconstant)
+  * Enable
+    [Style/RedundantRegexpCharacterClass](https://github.com/rubocop-hq/rubocop/pull/8055)
+  * Enable
+    [Style/RedundantRegexpEscape](https://github.com/rubocop-hq/rubocop/pull/7908)
+* Update rubocop-performance to
+  [1.6.0](https://github.com/rubocop-hq/rubocop-performance/blob/master/CHANGELOG.md#160-2020-05-22),
+  enabling:
+  * [Performance/BindCall](https://github.com/rubocop-hq/rubocop-performance/issues/77)
+  * [Performance/DeletePrefix](https://github.com/rubocop-hq/rubocop-performance/pull/105)
+  * [Performance/DeleteSuffix](https://github.com/rubocop-hq/rubocop-performance/pull/105)
+
+
+## 0.4.6
+
+* Disable `Naming/BinaryOperatorParameterName` because (when non-ascii method
+  names are used), it incorrectly identifies them as being `+()` operator
+  overrides (overly aggressive)
+
 ## 0.4.5
 
 * Disable `Naming/AsciiIdentifiers` for the same reason as mentioned below in

data/Gemfile.lock

@@ -1,42 +1,47 @@
 PATH
   remote: .
   specs:
-    standard (0.4.5)
-      rubocop (~> 0.83.0)
-      rubocop-performance (~> 1.5.2)
+    standard (0.5.2)
+      rubocop (~> 0.89.1)
+      rubocop-performance (~> 1.7.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.0)
-    coderay (1.1.2)
+    ast (2.4.1)
+    coderay (1.1.3)
     docile (1.3.2)
     gimme (0.5.0)
-    method_source (0.9.2)
-    minitest (5.14.0)
-    parallel (1.19.1)
-    parser (2.7.1.2)
-      ast (~> 2.4.0)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
+    method_source (1.0.0)
+    minitest (5.14.1)
+    parallel (1.19.2)
+    parser (2.7.1.4)
+      ast (~> 2.4.1)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
     rainbow (3.0.0)
     rake (13.0.1)
+    regexp_parser (1.7.1)
     rexml (3.2.4)
-    rubocop (0.83.0)
+    rubocop (0.89.1)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.7)
       rexml
+      rubocop-ast (>= 0.3.0, < 1.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-performance (1.5.2)
-      rubocop (>= 0.71.0)
+    rubocop-ast (0.3.0)
+      parser (>= 2.7.1.4)
+    rubocop-performance (1.7.1)
+      rubocop (>= 0.82.0)
     ruby-progressbar (1.10.1)
-    simplecov (0.18.2)
+    simplecov (0.18.5)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
-    simplecov-html (0.12.0)
+    simplecov-html (0.12.2)
     unicode-display_width (1.7.0)
 
 PLATFORMS

data/README.md

@@ -1,6 +1,6 @@
 ## Standard - Ruby style guide, linter, and formatter
 
-[![CircleCI](https://circleci.com/gh/testdouble/standard.svg?style=svg)](https://circleci.com/gh/testdouble/standard)
+[![Tests](https://github.com/testdouble/standard/workflows/Tests/badge.svg)](https://github.com/testdouble/standard/actions?query=workflow%3ATests)
 [![Ruby Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://github.com/testdouble/standard)
 [![Gem Version](https://badge.fury.io/rb/standard.svg)](https://rubygems.org/gems/standard)
 
@@ -166,7 +166,7 @@ Because StandardRB is essentially a wrapper on top of
 vast majority of CLI and ENV arguments to RuboCop.
 
 You can see a list of
-[RuboCop](https://docs.rubocop.org/en/latest/basic_usage/#other-useful-command-line-flags)'s
+[RuboCop](https://docs.rubocop.org/rubocop/usage/basic_usage.html#command-line-flags)'s
 CLI flags here.
 
 ## Why should I use Ruby Standard Style?
@@ -211,6 +211,10 @@ if you've used StandardJS.)
 * [Level UP Solutions](https://levups.com)
 * [Honeybadger](https://www.honeybadger.io)
 * [Amazon Web Services](https://aws.amazon.com/)
+* [Envoy](https://www.envoy.com)
+* [myRent](https://www.myrent.co.nz)
+* [Renuo](https://www.renuo.ch/)
+* [JetThoughts](https://www.jetthoughts.com/)
 * And that's about it so far!
 
 If your team starts using Standard, [send a pull

data/config/base.yml

@@ -160,7 +160,6 @@ Layout/FirstHashElementIndentation:
 
 Layout/HeredocIndentation:
   Enabled: true
-  EnforcedStyle: squiggly
 
 Layout/IndentationConsistency:
   Enabled: true
@@ -327,6 +326,9 @@ Lint/AssignmentInCondition:
 Lint/BigDecimalNew:
   Enabled: true
 
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
 Lint/BooleanSymbol:
   Enabled: true
 
@@ -339,15 +341,24 @@ Lint/Debugger:
 Lint/DeprecatedClassMethods:
   Enabled: true
 
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
 Lint/DuplicateCaseCondition:
   Enabled: true
 
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
 Lint/DuplicateMethods:
   Enabled: true
 
 Lint/DuplicateHashKey:
   Enabled: true
 
+Lint/DuplicateRescueException:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 
@@ -377,6 +388,9 @@ Lint/ErbNewArguments:
 Lint/FlipFlop:
   Enabled: true
 
+Lint/FloatComparison:
+  Enabled: true
+
 Lint/FloatOutOfRange:
   Enabled: true
 
@@ -409,6 +423,9 @@ Lint/MissingCopEnableDirective:
   Enabled: true
   MaximumRangeSize: .inf
 
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
 Lint/MultipleComparison:
   Enabled: true
 
@@ -430,6 +447,9 @@ Lint/NonLocalExitFromIterator:
 Lint/OrderedMagicComments:
   Enabled: true
 
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
 
@@ -442,6 +462,12 @@ Lint/RaiseException:
 Lint/RandOne:
   Enabled: true
 
+Lint/RedundantRequireStatement:
+  Enabled: true
+
+Lint/RedundantSplatExpansion:
+  Enabled: true
+
 Lint/RedundantStringCoercion:
   Enabled: true
 
@@ -484,6 +510,12 @@ Lint/SafeNavigationConsistency:
     - try
     - try!
 
+Lint/SafeNavigationWithEmpty:
+  Enabled: true
+
+Lint/SelfAssignment:
+  Enabled: true
+
 Lint/ShadowedArgument:
   Enabled: true
   IgnoreImplicitReferences: false
@@ -497,16 +529,13 @@ Layout/SpaceAroundMethodCallOperator:
 Lint/Syntax:
   Enabled: true
 
-Lint/UnderscorePrefixedVariableName:
-  Enabled: true
-
-Lint/UnifiedInteger:
+Lint/TopLevelReturnWithArgument:
   Enabled: true
 
-Lint/RedundantRequireStatement:
+Lint/UnderscorePrefixedVariableName:
   Enabled: true
 
-Lint/RedundantSplatExpansion:
+Lint/UnifiedInteger:
   Enabled: true
 
 Lint/UnreachableCode:
@@ -521,9 +550,6 @@ Lint/UriRegexp:
 Lint/UselessAssignment:
   Enabled: true
 
-Lint/UselessComparison:
-  Enabled: true
-
 Lint/UselessElseWithoutRescue:
   Enabled: true
 
@@ -537,9 +563,6 @@ Lint/Void:
 Migration/DepartmentName:
   Enabled: true
 
-Naming/BinaryOperatorParameterName:
-  Enabled: true
-
 Naming/ClassAndModuleCamelCase:
   Enabled: true
 
@@ -561,6 +584,12 @@ Naming/VariableName:
   Enabled: true
   EnforcedStyle: snake_case
 
+Performance/BigDecimalWithNumericArgument:
+  Enabled: true
+
+Performance/BindCall:
+  Enabled: true
+
 Performance/Caller:
   Enabled: true
 
@@ -570,6 +599,12 @@ Performance/CompareWithBlock:
 Performance/Count:
   Enabled: true
 
+Performance/DeletePrefix:
+  Enabled: true
+
+Performance/DeleteSuffix:
+  Enabled: true
+
 Performance/Detect:
   Enabled: true
 
@@ -579,8 +614,6 @@ Performance/DoubleStartEndWith:
 
 Performance/EndWith:
   Enabled: true
-  SafeAutoCorrect: false
-  AutoCorrect: false
 
 Performance/FixedSize:
   Enabled: true
@@ -604,19 +637,32 @@ Performance/RedundantMerge:
   Enabled: true
   MaxKeyValuePairs: 2
 
+Performance/RedundantSortBlock:
+  Enabled: true
+
+Performance/RedundantStringChars:
+  Enabled: true
+
 Performance/RegexpMatch:
   Enabled: true
 
 Performance/ReverseEach:
   Enabled: true
 
+Performance/ReverseFirst:
+  Enabled: true
+
 Performance/Size:
   Enabled: true
 
+Performance/SortReverse:
+  Enabled: true
+
+Performance/Squeeze:
+  Enabled: true
+
 Performance/StartWith:
   Enabled: true
-  SafeAutoCorrect: false
-  AutoCorrect: false
 
 Performance/StringReplacement:
   Enabled: true
@@ -778,6 +824,9 @@ Style/For:
   Enabled: true
   EnforcedStyle: each
 
+Style/GlobalStdStream:
+  Enabled: true
+
 Style/GlobalVars:
   Enabled: true
   AllowedVariables: []
@@ -814,9 +863,6 @@ Style/MethodCallWithoutArgsParentheses:
   Enabled: true
   IgnoredMethods: []
 
-Style/MethodMissingSuper:
-  Enabled: true
-
 Style/MissingRespondToMissing:
   Enabled: true
 
@@ -837,6 +883,9 @@ Style/MultilineMemoization:
   Enabled: true
   EnforcedStyle: keyword
 
+Style/MultilineWhenThen:
+  Enabled: true
+
 Style/NegatedIf:
   Enabled: true
   EnforcedStyle: both
@@ -916,6 +965,9 @@ Style/Proc:
 Style/RandomWithOffset:
   Enabled: true
 
+Style/RedundantAssignment:
+  Enabled: true
+
 Style/RedundantBegin:
   Enabled: true
 
@@ -925,12 +977,24 @@ Style/RedundantConditional:
 Style/RedundantException:
   Enabled: true
 
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
 Style/RedundantFreeze:
   Enabled: true
 
 Style/RedundantParentheses:
   Enabled: true
 
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
 Style/RedundantReturn:
   Enabled: true
   AllowMultipleReturnValues: false

data/lib/standard/detects_fixability.rb

@@ -3,7 +3,7 @@ module Standard
     def call(offenses)
       offenses.any? { |offense|
         cop = cop_instance(offense.cop_name)
-        cop.support_autocorrect? && safe?(cop)
+        cop.correctable? && cop.safe_autocorrect?
       }
     end
 
@@ -12,9 +12,5 @@ module Standard
     def cop_instance(cop_name)
       RuboCop::Cop.const_get(cop_name.gsub("/", "::")).new
     end
-
-    def safe?(cop)
-      cop.cop_config.fetch("SafeAutoCorrect", true)
-    end
   end
 end

data/lib/standard/formatter.rb

@@ -4,10 +4,20 @@ require_relative "detects_fixability"
 
 module Standard
   class Formatter < RuboCop::Formatter::BaseFormatter
-    CALL_TO_ACTION_MESSAGE = <<-CALL_TO_ACTION.gsub(/^ {6}/, "")
+    STANDARD_GREETING = <<-MSG.gsub(/^ {6}/, "")
+      standard: Use Ruby Standard Style (https://github.com/testdouble/standard)
+    MSG
+
+    CALL_TO_ACTION_MESSAGE = <<-MSG.gsub(/^ {6}/, "")
       Notice: Disagree with these rules? While StandardRB is pre-1.0.0, feel free to submit suggestions to:
         https://github.com/testdouble/standard/issues/new
-    CALL_TO_ACTION
+    MSG
+
+    def self.fixable_error_message(command)
+      <<-MSG.gsub(/^ {8}/, "")
+        standard: Run `#{command}` to automatically fix some problems.
+      MSG
+    end
 
     def initialize(*args)
       super
@@ -42,9 +52,7 @@ module Standard
     def print_header_once
       return if @header_printed_already
 
-      output.print <<-HEADER.gsub(/^ {8}/, "")
-        standard: Use Ruby Standard Style (https://github.com/testdouble/standard)
-      HEADER
+      output.print STANDARD_GREETING
 
       @header_printed_already = true
     end
@@ -57,9 +65,7 @@ module Standard
           "standardrb --fix"
         end
 
-        output.print <<-HEADER.gsub(/^ {10}/, "")
-          standard: Run `#{command}` to automatically fix some problems.
-        HEADER
+        output.print self.class.fixable_error_message(command)
         @fix_suggestion_printed_already = true
       end
     end

data/lib/standard/version.rb

@@ -1,3 +1,3 @@
 module Standard
-  VERSION = Gem::Version.new("0.4.5")
+  VERSION = Gem::Version.new("0.5.2")
 end

data/standard.gemspec

@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.83.0"
-  spec.add_dependency "rubocop-performance", "~> 1.5.2"
+  spec.add_dependency "rubocop", "~> 0.89.1"
+  spec.add_dependency "rubocop-performance", "~> 1.7.1"
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "minitest", "~> 5.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard
 version: !ruby/object:Gem::Version
-  version: 0.4.5
+  version: 0.5.2
 platform: ruby
 authors:
 - Justin Searls
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-05-25 00:00:00.000000000 Z
+date: 2020-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.83.0
+        version: 0.89.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.83.0
+        version: 0.89.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.7.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -122,7 +122,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: 
+description:
 email:
 - searls@gmail.com
 executables:
@@ -130,7 +130,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".circleci/config.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".standard.yml"
 - CHANGELOG.md
@@ -173,7 +173,7 @@ files:
 homepage: https://github.com/testdouble/standard
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -189,7 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Ruby Style Guide, with linter & automatic code fixer
 test_files: []

data/.circleci/config.yml

@@ -1,36 +0,0 @@
-# Ruby CircleCI 2.0 configuration file
-#
-# Check https://circleci.com/docs/2.0/language-ruby/ for more details
-#
-version: 2
-jobs:
-  build:
-    docker:
-       - image: circleci/ruby:2.7.0-node-browsers
-    working_directory: ~/repo
-
-    steps:
-      - checkout
-      - restore_cache:
-          keys:
-          - v1-dependencies-{{ checksum "Gemfile.lock" }}
-          - v1-dependencies-
-
-      - run:
-          name: install dependencies
-          command: |
-            bundle update --bundler
-            bundle install --jobs=4 --retry=3 --path vendor/bundle
-
-      - save_cache:
-          paths:
-            - ./vendor/bundle
-          key: v1-dependencies-{{ checksum "Gemfile.lock" }}
-
-      - run:
-          name: test
-          command: bundle exec rake test
-
-      - run:
-          name: lint
-          command: bundle exec rake standard:fix