standard 0.3.0 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7368d84b38b7c89c397955507edcf80bec5faf78ec478c9f5b70969abd1f3cd8
-  data.tar.gz: f74eb8f5da9fd6459c9aee08c16ab5a5de09392230e545e9812d29ac3d745720
+  metadata.gz: 52b7339d067d0811936bea5389c8b39efc85924dec8126a6f75ad1c673e5901e
+  data.tar.gz: 215b552f83cf2bb2a29e2771ccdc3eb64a8a9c939afcbb716bb185448e8f2fc0
 SHA512:
-  metadata.gz: a357e1a42c1114344a68531cb65a22d2f82256dc98ce9b96ecea78959bae66a9beca785b266ec02d4f09ccbb2e3b2823ea30835682c917c2519b86c2e012b3f2
-  data.tar.gz: 2acd01cc74605a7d97e367e24d439a22ee1aa8c3520d1da76f763a0491b2fff31bc3ab6d9884c14d7921f349d2d93039ea5346f3f64ad394574a177784a4ee42
+  metadata.gz: 7f91b781300a5bf99b633a56dc5408abf4af8089ed744b8b9b639f6869b36eb0f3ad666f98679f8f28733a354c97dd2834caa4921d184182979ec8314b9e48f6
+  data.tar.gz: 6cb189748d42164961d0e3af9340d74be4552db45ccbe1dad3ab125a27db36cc779025db04689eed1d2ba32361fb070222a9de48bbdc017bb3fcf4c54e26fa81

data/CHANGELOG.md

@@ -0,0 +1,34 @@
+# Changelog
+
+## 0.4.4
+
+* Disable `Naming/MethodName` cop. While `snake_case` is the conventional way to
+  name a Ruby method, the cop is too restrictive in that it also prevents
+  non-ASCII characters from being included in method names
+
+## 0.4.3
+
+* Improve output of the todo feature
+
+## 0.4.2
+
+* Track Rubocop
+  [0.83.0](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md#0830-2020-05-11)
+  * Update our default to allow trailing whitespace in heredocs
+  * Disable auto-correct for a cop that changed `:true` to `true`, as that's not
+    safe
+  * Allow comments in empty `when` blocks
+
+
+## 0.4.1
+
+* add given/given! as `{}` friendly blocks [#172](https://github.com/testdouble/standard/pull/172)
+
+## 0.4.0
+
+* Add `--todo` mode for incremental adoption of Standard to a project ([PR](https://github.com/testdouble/standard/pull/155) by [@mrbiggred](https://github.com/mrbiggred))
+
+## 0.3.0
+
+* Update Standard to track Rubocop 0.82.0 ([commit](https://github.com/testdouble/standard/commit/d663ea62d519c659087ad606bfed031c6303ff20))
+

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    standard (0.3.0)
-      rubocop (~> 0.82.0)
+    standard (0.4.4)
+      rubocop (~> 0.83.0)
       rubocop-performance (~> 1.5.2)
 
 GEM
@@ -12,7 +12,6 @@ GEM
     coderay (1.1.2)
     docile (1.3.2)
     gimme (0.5.0)
-    jaro_winkler (1.5.4)
     method_source (0.9.2)
     minitest (5.14.0)
     parallel (1.19.1)
@@ -24,8 +23,7 @@ GEM
     rainbow (3.0.0)
     rake (13.0.1)
     rexml (3.2.4)
-    rubocop (0.82.0)
-      jaro_winkler (~> 1.5.1)
+    rubocop (0.83.0)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)

data/README.md

@@ -47,7 +47,7 @@ flag.
 - **Leading dots on multi-line method chains** - chosen for
   [these](https://github.com/testdouble/standard/issues/75) reasons.
 - **Spaces inside blocks, but not hash literals** - In Ruby, the `{` and `}`
-  characters do a lot of heavy lifting. To visually distinguish array literals
+  characters do a lot of heavy lifting. To visually distinguish hash literals
   from blocks, Standard enforces that (like arrays), no leading or trailing
   spaces be added to pad hashes
 - **And a good deal more**
@@ -88,6 +88,20 @@ $ bundle exec standardrb "lib/**/*.rb" test
 **Note:** by default, StandardRB will look for all `*.rb` files (and some other
 files typically associated with Ruby like `*.gemspec` and `Gemfile`)
 
+If you have an existing project but aren't ready to fix all the files yet you can
+generate a todo file:
+
+```bash
+$ bundle exec standardrb --generate-todo
+```
+
+This will create a `.standard_todo.yml` that lists all the files that contain errors.
+When you run Standard in the future it will ignore these files as if they lived under the
+`ignore` section in the `.standard.yml` file.
+
+As you refactor your existing project you can remove files from the list.  You can
+also regenerate the todo file at anytime by re-running the above command.
+
 ### Using with Rake
 
 Standard also ships with Rake tasks. If you're using Rails, these should
@@ -120,7 +134,7 @@ $ rake standard STANDARDOPTS="lib \"app/**/*\""
 ## What you might do if you're clever
 
 If you want or need to configure Standard, there are a _handful_ of options
-are available creating a `.standard.yml` file in the root of your project.
+available by creating a `.standard.yml` file in the root of your project.
 
 Here's an example yaml file with every option set:
 
@@ -143,11 +157,13 @@ cannot be found by ascending the current working directory (i.e., against a
 temporary file buffer in your editor), you can specify the config location with
 `--config path/to/.standard.yml`.
 
+Similarly, for the `.standard_todo.yml` file, you can specify `--todo path/to/.standard_todo.yml`.
+
 ## What you might do if you're REALLY clever
 
 Because StandardRB is essentially a wrapper on top of
 [RuboCop](https://github.com/rubocop-hq/rubocop), it will actually forward the
-vast majority of CLI and ENV arguments forward to RuboCop.
+vast majority of CLI and ENV arguments to RuboCop.
 
 You can see a list of
 [RuboCop](https://docs.rubocop.org/en/latest/basic_usage/#other-useful-command-line-flags)'s
@@ -241,7 +257,12 @@ problems are fixable, but some errors must be fixed manually.
 
 ## Can I override the `fix: true` config setting?
 
-Also yes! You can use `standardrb --no-fix`. Not `fix`ing is the default behavior, but this flag will override the `fix: true` setting in your [`.standard.yml` config](#what-you-might-do-if-youre-clever). This is especially useful for checking your projects compliance with `standardrb` in CI environments while keeping the `fix: true` option enabled locally.
+Also yes! You can use `standardrb --no-fix`. Not `fix`ing is the default
+behavior, but this flag will override the `fix: true` setting in your
+[`.standard.yml` config](#what-you-might-do-if-youre-clever).
+This is especially useful for checking your project's compliance with
+`standardrb` in CI environments while keeping the `fix: true` option enabled
+locally.
 
 ## How do I ignore files?
 
@@ -361,6 +382,7 @@ from editor plugins:
 
 * [Pronto](https://github.com/julianrubisch/pronto-standardrb)
 * [Spring](https://github.com/lakim/spring-commands-standard)
+* [Guard](https://github.com/JodyVanden/guard-standardrb)
 
 ## Contributing
 

data/config/base.yml

@@ -312,7 +312,7 @@ Layout/TrailingEmptyLines:
 
 Layout/TrailingWhitespace:
   Enabled: true
-  AllowInHeredoc: false
+  AllowInHeredoc: true
 
 Lint/AmbiguousOperator:
   Enabled: true
@@ -329,7 +329,6 @@ Lint/BigDecimalNew:
 
 Lint/BooleanSymbol:
   Enabled: true
-  AutoCorrect: true
 
 Lint/CircularArgumentReference:
   Enabled: true
@@ -367,6 +366,7 @@ Lint/EmptyInterpolation:
 
 Lint/EmptyWhen:
   Enabled: true
+  AllowComments: true
 
 Lint/EnsureReturn:
   Enabled: true
@@ -553,10 +553,6 @@ Naming/HeredocDelimiterCase:
   Enabled: true
   EnforcedStyle: uppercase
 
-Naming/MethodName:
-  Enabled: true
-  EnforcedStyle: snake_case
-
 Naming/BlockParameterName:
   Enabled: true
   MinNameLength: 1
@@ -667,6 +663,8 @@ Standard/SemanticBlocks:
     # Rails
     - transaction
   FunctionalMethods:
+    - given
+    - given!
     - let
     - let!
     - subject

data/lib/standard/builds_config.rb

@@ -7,13 +7,17 @@ module Standard
 
   class BuildsConfig
     def initialize
+      @parses_cli_option = ParsesCliOption.new
       @loads_yaml_config = LoadsYamlConfig.new
       @merges_settings = MergesSettings.new
       @creates_config_store = CreatesConfigStore.new
     end
 
     def call(argv, search_path = Dir.pwd)
-      standard_config = @loads_yaml_config.call(argv, search_path)
+      standard_yaml_path = determine_yaml_file(argv, search_path, "--config", ".standard.yml")
+      todo_yaml_path = determine_yaml_file(argv, search_path, "--todo", ".standard_todo.yml")
+      standard_config = @loads_yaml_config.call(standard_yaml_path, todo_yaml_path)
+
       settings = @merges_settings.call(argv, standard_config)
       Config.new(
         settings.runner,
@@ -22,5 +26,11 @@ module Standard
         @creates_config_store.call(standard_config)
       )
     end
+
+    private
+
+    def determine_yaml_file(argv, search_path, option_name, default_file)
+      @parses_cli_option.call(argv, option_name) || FileFinder.new.call(default_file, search_path)
+    end
   end
 end

data/lib/standard/formatter.rb

@@ -1,3 +1,4 @@
+require "yaml"
 require "rubocop"
 require_relative "detects_fixability"
 
@@ -16,6 +17,10 @@ module Standard
       @any_uncorrected_offenses = false
     end
 
+    def started(_target_files)
+      print_todo_warning
+    end
+
     def file_finished(file, offenses)
       return unless (uncorrected_offenses = offenses.reject(&:corrected?)).any?
       @any_uncorrected_offenses = true
@@ -59,6 +64,22 @@ module Standard
       end
     end
 
+    def print_todo_warning
+      todo_file = options[:todo_file]
+      return unless todo_file
+
+      todo_ignore_files = options[:todo_ignore_files]
+      return unless todo_ignore_files
+
+      output.print <<-HEADER.gsub(/^ {8}/, "")
+        WARNING: this project is being migrated to standard gradually via `#{todo_file}` and is ignoring these files:
+      HEADER
+
+      todo_ignore_files.each do |f|
+        output.printf("  %s\n", f)
+      end
+    end
+
     def path_to(file)
       Pathname.new(file).relative_path_from(Pathname.new(Dir.pwd))
     end

data/lib/standard/loads_yaml_config.rb

@@ -5,14 +5,11 @@ require_relative "parses_cli_option"
 
 module Standard
   class LoadsYamlConfig
-    def initialize
-      @parses_cli_option = ParsesCliOption.new
-    end
+    def call(standard_yaml_path, todo_yaml_path)
+      standard_yaml = load_standard_yaml(standard_yaml_path)
+      todo_yaml = load_standard_yaml(todo_yaml_path)
 
-    def call(argv, search_path)
-      yaml_path = @parses_cli_option.call(argv, "--config") ||
-        FileFinder.new.call(".standard.yml", search_path)
-      construct_config(yaml_path, load_standard_yaml(yaml_path))
+      construct_config(standard_yaml_path, standard_yaml, todo_yaml_path, todo_yaml)
     end
 
     private
@@ -25,15 +22,17 @@ module Standard
       end
     end
 
-    def construct_config(yaml_path, standard_yaml)
+    def construct_config(yaml_path, standard_yaml, todo_path, todo_yaml)
       {
         ruby_version: Gem::Version.new((standard_yaml["ruby_version"] || RUBY_VERSION)),
         fix: !!standard_yaml["fix"],
         format: standard_yaml["format"],
         parallel: !!standard_yaml["parallel"],
-        ignore: expand_ignore_config(standard_yaml["ignore"]),
+        ignore: expand_ignore_config(standard_yaml["ignore"]) + expand_ignore_config(todo_yaml["ignore"]),
         default_ignores: standard_yaml.key?("default_ignores") ? !!standard_yaml["default_ignores"] : true,
-        config_root: yaml_path ? Pathname.new(yaml_path).dirname.to_s : nil
+        config_root: yaml_path ? Pathname.new(yaml_path).dirname.to_s : nil,
+        todo_file: todo_path,
+        todo_ignore_files: todo_yaml["ignore"] || []
       }
     end
 

data/lib/standard/merges_settings.rb

@@ -20,7 +20,7 @@ module Standard
 
     def separate_argv(argv)
       argv.partition { |flag|
-        ["--fix", "--no-fix", "--version", "-v", "--help", "-h"].include?(flag)
+        ["--generate-todo", "--fix", "--no-fix", "--version", "-v", "--help", "-h"].include?(flag)
       }
     end
 
@@ -41,6 +41,8 @@ module Standard
         :help
       elsif (argv & ["--version", "-v"]).any?
         :version
+      elsif (argv & ["--generate-todo"]).any?
+        :genignore
       else
         :rubocop
       end
@@ -51,7 +53,9 @@ module Standard
         auto_correct: standard_yaml[:fix],
         safe_auto_correct: standard_yaml[:fix],
         formatters: [[standard_yaml[:format] || "Standard::Formatter", nil]],
-        parallel: standard_yaml[:parallel]
+        parallel: standard_yaml[:parallel],
+        todo_file: standard_yaml[:todo_file],
+        todo_ignore_files: standard_yaml[:todo_ignore_files]
       }.merge(standard_cli_flags).merge(rubocop_cli_flags)
     end
 

data/lib/standard/runners/genignore.rb

@@ -0,0 +1,48 @@
+require "tempfile"
+require "yaml"
+require_relative "rubocop"
+
+module Standard
+  module Runners
+    class Genignore
+      def call(config)
+        # Place to temporally store the ignored files.
+        temp_file = Tempfile.new("excluded.txt")
+        begin
+          # Run Rubocop to generate the files with errors into the temp file.
+          config.rubocop_options[:formatters] = [["files", temp_file.path]]
+          config.rubocop_options[:format] = "files"
+          config.rubocop_options[:out] = temp_file.path
+          Runners::Rubocop.new.call(config)
+
+          # Read in the files with errors.  It will have the absolute paths
+          # of the files but we only want the relative path.
+          files_with_errors = temp_file.readlines.map(&:chomp)
+          files_with_errors.map! do |file|
+            # Get the relative file path.  Don't use the
+            # relative_path_from method as it will raise an
+            # error in Ruby 2.4.1 and possibly other versions.
+            #
+            # https://bugs.ruby-lang.org/issues/10011
+            #
+            file.sub(Dir.pwd + File::SEPARATOR, "")
+          end
+
+          # Read the files with errors from the temp file.
+          yaml_format_errors = {"ignore" => files_with_errors}
+
+          # Regenerate the todo file.
+          File.open(".standard_todo.yml", "w") do |file|
+            file.puts "# Auto generated files with errors to ignore."
+            file.puts "# Remove from this list as you refactor files."
+            file.write(yaml_format_errors.to_yaml)
+          end
+        ensure
+          # Clean up temp file.
+          temp_file.close
+          temp_file.unlink
+        end
+      end
+    end
+  end
+end

data/lib/standard/version.rb

@@ -1,3 +1,3 @@
 module Standard
-  VERSION = Gem::Version.new("0.3.0")
+  VERSION = Gem::Version.new("0.4.4")
 end

data/standard.gemspec

@@ -7,6 +7,7 @@ Gem::Specification.new do |spec|
   spec.version = Standard::VERSION
   spec.authors = ["Justin Searls"]
   spec.email = ["searls@gmail.com"]
+  spec.required_ruby_version = ">= 2.4.0"
 
   spec.summary = "Ruby Style Guide, with linter & automatic code fixer"
   spec.homepage = "https://github.com/testdouble/standard"
@@ -18,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.82.0"
+  spec.add_dependency "rubocop", "~> 0.83.0"
   spec.add_dependency "rubocop-performance", "~> 1.5.2"
 
   spec.add_development_dependency "bundler"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.4
 platform: ruby
 authors:
 - Justin Searls
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-04 00:00:00.000000000 Z
+date: 2020-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.83.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.83.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -133,6 +133,7 @@ files:
 - ".circleci/config.yml"
 - ".gitignore"
 - ".standard.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -163,6 +164,7 @@ files:
 - lib/standard/railtie.rb
 - lib/standard/rake.rb
 - lib/standard/rubocop/ext.rb
+- lib/standard/runners/genignore.rb
 - lib/standard/runners/help.rb
 - lib/standard/runners/rubocop.rb
 - lib/standard/runners/version.rb
@@ -179,7 +181,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="