standard-rails 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5eeb3e6ba8d4da6c2401a846947814610787ca970fb46f12a9e3afbdb5b5b17e
-  data.tar.gz: 267862f4b09d3a910eee0f38c7851443a6e4a7264502ca22c1e43424e7315fd3
+  metadata.gz: 9a8e0a868c15dffa225605d8233191a4c1193847290ae27c38182eb049f2f088
+  data.tar.gz: 7ce125bd0b23320baa7f47c6a9cc176cbcbe076bc013be49fe34e6115c88d719
 SHA512:
-  metadata.gz: 63d213467768a22f8dd7bcb589c048e84661d26c5d86f547bc46113d37fe6c993efd61018222b0bcd9d064103b982751e64387194dadb13d149b0f3b9dfa9a43
-  data.tar.gz: 85ec0dcdce846df434133d9ebd0bf0bb7f4044b4766297b828904a528e80d90850954853e31e89283df2902159a56d32fa763a8b5a6649fae3e8396aadc2b334
+  metadata.gz: c9c41b4f8cfcbfb09d89051f781b01ca1f6bba083c8cd05220ad423f914e2dc9504e56756a15605d73f4dfcd4ae1345cae54d42d86f1faa0d65914c5367fb644
+  data.tar.gz: e5cf5f65ca9775f942b0a6ff2b71739cfbff596f27ff36a6920903e1ffdb9f2172bea011867d8b8425c1fbeab8dd7d6c48249b4035286718d785e14cf9f9b1f5

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [1.1.0]
+
+- Minimum Ruby version increased to 3.0
+- rubocop-rails upgraded to 2.25.x
+- Lots of rule cleanup
+
+## [1.0.2]
+
+- Clear warnings about cops extended by rubocop-rails [#25](https://github.com/standardrb/standard-rails/issues/25)
+
+## [1.0.1]
+
+- Fix errors int he initial config [#24](https://github.com/standardrb/standard-rails/pull/24)
+
 ## [1.0.0]
 
 - Update Rubocop Rails to [v2.23.1](https://github.com/rubocop/rubocop-rails/releases/tag/v2.23.1)

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    standard-rails (1.0.1)
+    standard-rails (1.1.0)
       lint_roller (~> 1.0)
-      rubocop-rails (~> 2.23.1)
+      rubocop-rails (~> 2.25.0)
 
 GEM
   remote: https://rubygems.org/
@@ -37,7 +37,7 @@ GEM
     minitest (5.20.0)
     mutex_m (0.2.0)
     parallel (1.24.0)
-    parser (3.3.0.2)
+    parser (3.3.3.0)
       ast (~> 2.4.1)
       racc
     racc (1.7.3)
@@ -57,16 +57,16 @@ GEM
       rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.30.0)
-      parser (>= 3.2.1.0)
+    rubocop-ast (1.31.3)
+      parser (>= 3.3.1.0)
     rubocop-performance (1.20.2)
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.30.0, < 2.0)
-    rubocop-rails (2.23.1)
+    rubocop-rails (2.25.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     standard (1.33.0)
@@ -89,6 +89,7 @@ PLATFORMS
   arm64-darwin-20
   arm64-darwin-21
   arm64-darwin-22
+  arm64-darwin-23
   x86_64-linux
 
 DEPENDENCIES
@@ -99,4 +100,4 @@ DEPENDENCIES
   standard-rails!
 
 BUNDLED WITH
-   2.4.10
+   2.5.11

data/config/base.yml

@@ -19,15 +19,6 @@ AllCops:
   # as the default.
   TargetRailsVersion: ~
 
-# This cop from rubocop was added to the Rubocop-Rails
-# config as part of this PR:
-# https://github.com/rubocop/rubocop-rails/pull/1014
-# in order to support some Rails-specific methods. At the
-# time of writing, it's disabled in Standard, so it's
-# disabled here.
-Lint/RedundantSafeNavigation:
-  Enabled: false
-
 Lint/SafeNavigationChain:
   Enabled: true
   AllowedMethods:
@@ -46,7 +37,7 @@ Rails/ActionControllerTestCase:
   Enabled: false
 
 Rails/ActionFilter:
-  Enabled: true
+  Enabled: false
 
 Rails/ActionOrder:
   Enabled: false
@@ -143,7 +134,7 @@ Rails/DurationArithmetic:
   Enabled: true
 
 Rails/DynamicFindBy:
-  Enabled: true
+  Enabled: false
 
 Rails/EagerEvaluationLogMessage:
   Enabled: true
@@ -248,7 +239,7 @@ Rails/NotNullColumn:
   Enabled: false
 
 Rails/OrderById:
-  Enabled: true
+  Enabled: false
 
 Rails/Output:
   Enabled: true
@@ -263,7 +254,7 @@ Rails/Pluck:
   Enabled: true
 
 Rails/PluckId:
-  Enabled: true
+  Enabled: false
 
 Rails/PluckInWhere:
   Enabled: true
@@ -347,7 +338,7 @@ Rails/SafeNavigationWithBlank:
   Enabled: true
 
 Rails/SaveBang:
-  Enabled: true
+  Enabled: false
 
 Rails/SchemaComment:
   Enabled: false
@@ -405,7 +396,7 @@ Rails/UnknownEnv:
   Enabled: false
 
 Rails/UnusedIgnoredColumns:
-  Enabled: true
+  Enabled: false
 
 Rails/UnusedRenderContent:
   Enabled: true
@@ -428,5 +419,5 @@ Rails/WhereNot:
 Rails/WhereNotWithMultipleConditions:
   Enabled: false
 
-Style/InvertibleUnlessCondition:
-  Enabled: false
+Rails/WhereRange:
+  Enabled: true

data/lib/standard/rails/load_rubocop_rails_without_the_monkey_patch.rb

@@ -7,7 +7,7 @@
 # of RuboCop built-in cops in this file, we need to monitor it for changes
 # in rubocop-rails and keep it up to date.
 #
-# Last updated from rubocop-rails v2.23.1
+# Last updated from rubocop-rails v2.25.0
 
 # frozen_string_literal: true
 

data/lib/standard/rails/plugin.rb

@@ -27,7 +27,9 @@ module Standard
         LintRoller::Rules.new(
           type: :object,
           config_format: :rubocop,
-          value: rules_with_config_applied
+          value: without_extended_rule_configs(
+            rules_with_config_applied
+          )
         )
       end
 
@@ -44,6 +46,18 @@ module Standard
         )
       end
 
+      # rubocop-rails adds additional options to a couple out-of-the-box cops
+      # but Standard (1) doesn't enable these to begin with and (2) doesn't
+      # allow rules' configs to be edited once they are defined, so we'll just
+      # remove them here
+      #
+      # See: https://github.com/standardrb/standard-rails/issues/25#issuecomment-1881127173
+      def without_extended_rule_configs(rules)
+        rules.reject { |(name, _)|
+          ["Style/InvertibleUnlessCondition", "Lint/SafeNavigationChain"].include?(name)
+        }.to_h
+      end
+
       # This is not fantastic.
       #
       # When you `require "rubocop-rails"`, it will not only load the cops,

data/lib/standard/rails/version.rb

@@ -1,5 +1,5 @@
 module Standard
   module Rails
-    VERSION = "1.0.1"
+    VERSION = "1.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-01-08 00:00:00.000000000 Z
+date: 2024-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: lint_roller
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.23.1
+        version: 2.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.23.1
+        version: 2.25.0
 description:
 email:
 - searls@gmail.com
@@ -75,14 +75,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.7.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.21
+rubygems_version: 3.5.9
 signing_key:
 specification_version: 4
 summary: A Standard plugin that adds Rails-specific rules to Standard