standard-rails 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab3080f565a9c7d7580405c2007ab6c06d1bea30f1e7dffd505d0ef9c0c390e6
-  data.tar.gz: 77d4a5d0a5b645f86d3a13aa492eb2c7319989f515b25f06c125b689abff434b
+  metadata.gz: 0d8f82a084fe4ff317a8e3d62666fbaffc7ffe522aa07c7d79cad211cd545a81
+  data.tar.gz: 1826baad658442833a6ccbd87d201581f9cfb21e479046e8fb79deccbc1b23db
 SHA512:
-  metadata.gz: fafc62eb0a95ff6eeb6c170218ac4297ccdba6187a6a741058fc777802542ca463f211faa44a6ccb8e019edecc117278799c1d87dcf3603a6a553102e6915a70
-  data.tar.gz: e1ffb63b3a0d5419e975a63f6b2992e0211ba2e1bafc4b2f272b2ea9a64d0d3052495e83b22cc8c5bdaebec79fd41c67ac01cd38ff31b76cb771811dd8e2792f
+  metadata.gz: 7b1e95ca9e40fc91e4dc6ff21d5a5b59c65fdf3f8b1814444648f5147c171eb0b0be15d6b349e41d6e683487c61f3e4ccebbb20964cdb6c929c9c8c3f69f1ca2
+  data.tar.gz: c7353988d76a4bfb252395fd85960831750a07e899c0ae1f5b87c333ef5717d0755723e91cff1c6222439511cbba2dd969f7b9f6dff7e4c0791cc490f82afb5e

data/.standard.yml

@@ -1,3 +1,3 @@
 # For available configuration options, see:
 #   https://github.com/testdouble/standard
-ruby_version: 2.6
+ruby_version: 2.7

data/CHANGELOG.md

@@ -1,5 +1,9 @@
-## 0.0.1
+## [Unreleased]
 
-- Initial release. Doesn't actually exist as a plugin yet, but can be imported
-  via `extend_config`. We don't recommend this, however, as all the values are
-  currently set to rubocop-rails defaults!
+## [0.1.0]
+
+- Configure the cops as agreed upon at RailsConf 2023
+
+## [0.0.1]
+
+- Initial release

data/Gemfile

@@ -1,8 +1,7 @@
 source "https://rubygems.org"
 
-# Specify your gem's dependencies in standard-rails.gemspec
 gemspec
-
 gem "rake"
 gem "minitest"
 gem "standard"
+gem "m"

data/Gemfile.lock

@@ -1,8 +1,9 @@
 PATH
   remote: .
   specs:
-    standard-rails (0.0.1)
-      rubocop-rails (~> 2.18.0)
+    standard-rails (0.1.0)
+      lint_roller (~> 1.0)
+      rubocop-rails (~> 2.19.0)
 
 GEM
   remote: https://rubygems.org/
@@ -18,9 +19,14 @@ GEM
       concurrent-ruby (~> 1.0)
     json (2.6.3)
     language_server-protocol (3.17.0.3)
+    lint_roller (1.0.0)
+    m (1.6.1)
+      method_source (>= 0.6.7)
+      rake (>= 0.9.2.2)
+    method_source (1.0.0)
     minitest (5.18.0)
     parallel (1.22.1)
-    parser (3.2.1.1)
+    parser (3.2.2.0)
       ast (~> 2.4.1)
     rack (3.0.7)
     rainbow (3.1.1)
@@ -37,32 +43,34 @@ GEM
       rubocop-ast (>= 1.26.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.27.0)
+    rubocop-ast (1.28.0)
       parser (>= 3.2.1.0)
     rubocop-performance (1.16.0)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.18.0)
+    rubocop-rails (2.19.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
     ruby-progressbar (1.13.0)
-    standard (1.25.2)
+    standard (1.26.0)
       language_server-protocol (~> 3.17.0.2)
-      rubocop (= 1.48.1)
-      rubocop-performance (= 1.16.0)
+      rubocop (~> 1.48.1)
+      rubocop-performance (~> 1.16.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.4.2)
 
 PLATFORMS
   arm64-darwin-22
+  x86_64-linux
 
 DEPENDENCIES
+  m
   minitest
   rake
   standard
   standard-rails!
 
 BUNDLED WITH
-   2.4.8
+   2.4.10

data/README.md

@@ -1,8 +1,35 @@
 # standard-rails
 
-This gem will be the first official plugin for the
-[standard](https://github.com/testdouble/standard) gem, which is a Ruby code
-linter and formatter.
+This gem provides a [lint_roller](https://github.com/standardrb/lint_roller)
+plugin configuration for the
+[rubocop-rails](https://github.com/rubocop/rubocop-rails) ruleset, for use
+as an extension to the [Standard Ruby
+gem](https://github.com/standardrb/standard).
+
+To install it, you'll want to start by adding it to your Gemfile:
+
+```ruby
+gem "standard-rails"
+```
+
+## Configuration
+
+In your `.standard.yml` file, you can simply list `standard-rails` as a plugin:
+
+```yaml
+plugins:
+  - standard-rails
+```
+
+Even though it'll usually be inferred automatically, you can specify the exact
+version of Rails you want the rules to run against by converting the string to
+a nested hash:
+
+```yaml
+plugins:
+  - standard-rails:
+      target_rails_version: 7.0
+```
 
 ## Code of Conduct
 
@@ -12,3 +39,4 @@ including (but not limited to) one-on-one communications, public posts/comments,
 code reviews, pull requests, and GitHub issues. If violations occur, Test Double
 will take any action they deem appropriate for the infraction, up to and
 including blocking a user from the organization's repositories.
+

data/Rakefile

@@ -7,6 +7,47 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList["test/**/*_test.rb"]
 end
 
+task :copy_rubocop_rails_entry_point_and_comment_out_monkey_patch do
+  gem_spec = Gem.loaded_specs["rubocop-rails"]
+  gem_require_path = Pathname.new(gem_spec.full_require_paths.first)
+  entry_point_contents = File.read(gem_require_path.join("rubocop-rails.rb"))
+  already_printed_load_path_veriable = false
+  entry_point_without_monkey_patch = entry_point_contents.split("\n").map { |line|
+    if line.include?("Inject.defaults!") || line.include?("rails/inject")
+      line.prepend("# ")
+    elsif line.include?("require_relative")
+      relative_path = line.match(/require_relative ['"](.*)['"]/)[1]
+
+      if !already_printed_load_path_veriable
+        already_printed_load_path_veriable = true
+        [
+          "require_path = Pathname.new(Gem.loaded_specs[\"rubocop-rails\"].full_require_paths.first)",
+          "require require_path.join(#{relative_path.inspect})"
+        ]
+      else
+        "require require_path.join(#{relative_path.inspect})"
+      end
+    else
+      line
+    end
+  }.flatten.join("\n")
+
+  File.write "lib/standard/rails/load_rubocop_rails_without_the_monkey_patch.rb", <<~RUBY
+    # GENERATED FILE - DO NOT EDIT
+    #
+    # This file should look just like: https://github.com/rubocop/rubocop-rails/blob/master/lib/rubocop-rails.rb
+    # Except without the `Inject.defaults!` monkey patching.
+    #
+    # Because there are both necessary require statements and additional patching
+    # of RuboCop built-in cops in this file, we need to monitor it for changes
+    # in rubocop-rails and keep it up to date.
+    #
+    # Last updated from #{gem_spec.name} v#{gem_spec.version}
+
+    #{entry_point_without_monkey_patch}
+  RUBY
+end
+
 require "standard/rake"
 
-task default: %i[test standard:fix]
+task default: %i[copy_rubocop_rails_entry_point_and_comment_out_monkey_patch standard:fix test]