standard-procedure-plumbing 0.5.0 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 90c456ba1b4ae2cebb75d1fe5ac49f806c6156387a5907980255e2f224b11f54
-  data.tar.gz: b40ea0aa31ce5608d94721c90d56a351cdf834660fe32398d4c2e6e5c0dd4827
+  metadata.gz: 8071e0d012d60099bd30afaaabe7274fe4572a88686115e9b8db86fe880a0734
+  data.tar.gz: 212b5f27a5309d3cd638e354d8a41cbd77dcf0a5b9f22d5976e04403cea200a4
 SHA512:
-  metadata.gz: b2a394f3a3924edc4963252e59170fec110c7190d2305e90e5ecb483e84cfff818c75074abeb975f4561ca01086cad1c7971d26b91eec3be0da8c6a46c0fa869
-  data.tar.gz: b3b790c91098bea951a175ec9d2b8676e2e630fb4c4eef6e225855b5b7a472782bc6eb6f98f1c5c3f339878560fbad5c060a75cecec15748105735320ab09379
+  metadata.gz: 82e7bf5617439df2e00886e7d95e9c4215e5f2e7dcf91a6a5de3673cd132bbc069c301fd0cdeb4cd315faff76981a4282898da66771be57ce19c7d9589fa7a30
+  data.tar.gz: c64ee286c7fec70b9025bd32ceaa39379751d26f7e7947934f07c5651f62f564407a87a4227fd2e4202c042b2d9db7df48008e67ba06aea9f15b269b7606cd15

data/README.md

@@ -41,9 +41,14 @@ require 'plumbing'
 Plumbing.config mode: :async
 ```
 
+## Development
 
+### To Do
 
-## Development
+- [ ] Add a debouncing filter for pipes
+- [ ] Pass the mode as a block parameter in `Plumbing::Spec.modes`
+- [ ] Move Plumbing::Actor::Transporter to Plumbing::Transporter ?? (planning to use it outside of Plumbing so would make sense not to imply it is tied to Actors)
+- [X] Ensure transporters deal with GlobalID models not being found / errors when unpacking
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
@@ -51,7 +56,7 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/standard_procedure/plumbing. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/standard_procedure/plumbing/blob/main/CODE_OF_CONDUCT.md).
+Bug reports and pull requests are welcome on GitHub at <https://github.com/standard_procedure/plumbing>. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/standard_procedure/plumbing/blob/main/CODE_OF_CONDUCT.md).
 
 ## Code of Conduct
 

data/lib/plumbing/actor/transporter.rb

@@ -55,6 +55,9 @@ module Plumbing
 
       def unpack_string argument
         argument.start_with?("gid://") ? GlobalID::Locator.locate(argument) : argument
+      rescue => ex
+        Plumbing.config.logger.error "!!!! #{self.class}##{__callee__} - #{argument} => #{ex}"
+        argument
       end
     end
   end

data/lib/plumbing/actor.rb

@@ -86,7 +86,7 @@ module Plumbing
       instance_eval(&)
       nil
     rescue => ex
-      Plumbing.config.logger.error { "!!!! #{self.class}#perform_safely => #{ex}" }
+      Plumbing.config.logger.error { "!!!! #{self.class}##{__callee__} => #{ex}" }
       nil
     end
   end

data/lib/plumbing/pipe.rb

@@ -9,12 +9,12 @@ module Plumbing
     # @param event_name [String] representing the type of event this is
     # @param data [Hash] representing the event-specific data to be passed to the observers
     def notify event_name, **data
-      Plumbing.config.logger.debug { "-> #{self.class}#notify #{event_name}" }
+      Plumbing.config.logger.debug { "-> #{self.class}##{__callee__} #{event_name}" }
       observers.each do |observer|
-        Plumbing.config.logger.debug { "===> #{self.class}#dispatch #{event_name}(#{data}) to #{observer}" }
+        Plumbing.config.logger.debug { "===> #{self.class}#call #{event_name}(#{data}) to #{observer}" }
         observer.call event_name, data
       rescue => ex
-        Plumbing.config.logger.error { "!!!! #{self.class}#dispatch #{event_name} => #{ex}" }
+        Plumbing.config.logger.error { "!!!! #{self.class}##{__callee__} #{event_name} => #{ex}" }
         ex
       end
     end
@@ -58,6 +58,5 @@ module Plumbing
 
     require_relative "pipe/filter"
     require_relative "pipe/junction"
-
   end
 end

data/lib/plumbing/pipeline/contracts.rb

@@ -7,7 +7,7 @@ module Plumbing
       # @yield [Object] input the input data to be validated
       # @yieldreturn [Boolean] true to accept the input, false to reject it
       def pre_condition name, &validator
-        pre_conditions[name.to_sym] = validator
+        pre_conditions << ConditionValidator.new(name.to_s, validator)
       end
 
       # @param [String] contract_class the class name of the [Dry::Validation::Contract] that will be used to validate the input data
@@ -20,17 +20,21 @@ module Plumbing
       # @yield [Object] output the output data to be validated
       # @yieldreturn [Boolean] true to accept the output, false to reject it
       def post_condition name, &validator
-        post_conditions[name.to_sym] = validator
+        post_conditions << ConditionValidator.new(name.to_s, validator)
       end
 
       private
 
+      class ConditionValidator < Struct.new(:name, :validator)
+        def call(input) = validator.call input
+      end
+
       def pre_conditions
-        @pre_conditions ||= {}
+        @pre_conditions ||= []
       end
 
       def post_conditions
-        @post_conditions ||= {}
+        @post_conditions ||= []
       end
 
       def validate_contract_for input
@@ -41,14 +45,22 @@ module Plumbing
       end
 
       def validate_preconditions_for input
-        failed_preconditions = pre_conditions.select { |name, validator| !validator.as(Callable).call(input) }
-        raise PreConditionError, failed_preconditions.keys.join(", ") if failed_preconditions.any?
+        failed_preconditions = pre_conditions.select do |validator|
+          !validator.call(input)
+        rescue
+          true
+        end
+        raise PreConditionError, failed_preconditions.map(&:name).join(", ") if failed_preconditions.any?
         input
       end
 
       def validate_postconditions_for output
-        failed_postconditions = post_conditions.select { |name, validator| !validator.as(Callable).call(output) }
-        raise PostConditionError, failed_postconditions.keys.join(", ") if failed_postconditions.any?
+        failed_postconditions = post_conditions.select do |validator|
+          !validator.call(output)
+        rescue
+          true
+        end
+        raise PostConditionError, failed_postconditions.map(&:name).join(", ") if failed_postconditions.any?
         output
       end
     end

data/lib/plumbing/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Plumbing
-  VERSION = "0.5.0"
+  VERSION = "0.5.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: standard-procedure-plumbing
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.2
 platform: ruby
 authors:
 - Rahoul Baruah
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-09-20 00:00:00.000000000 Z
+date: 2024-10-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: globalid
@@ -81,7 +81,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.12
+rubygems_version: 3.5.20
 signing_key:
 specification_version: 4
 summary: Plumbing - various pipelines for your ruby application