stackup 1.8.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cb7a5ebe9211d108f0289506fc5e917f58f7499823206dc22228f31b36992bcc
-  data.tar.gz: ba7d5a374e7a694fd52a1e7831d77b8dc1187d8dc3d1864dc19fbd6d00f76a3d
+  metadata.gz: 69cdd62ad2bb3be36ed7990f24d9e14b3714e3f273acd2e977d0ec175061385d
+  data.tar.gz: 6725bad04804d6ae53041e6b710930be51653ac3e24eac4eedff7223b9eb634e
 SHA512:
-  metadata.gz: 957ccabd6908e09039974ccd4204bcbbb0efb709fd46730a1d7da4559dffb98092845ce10bfc5a7325a3d4d38bf3c380a76fb3bc032de44714e0c6b5e0cc3dea
-  data.tar.gz: e94af1775282fbddfe2cfd9a895f557c55a09d79ca9d89738ef9be8219b0a448d74b178d553dd32738cffcab68b067fbcef7078b69fa0d08807124ed2fdae706
+  metadata.gz: c5eb54e984f3114f1c802ac49be06a4ee26d58391fa1e7a9a55e594990c9cdb326fc5b7ec307cfad4883ebe0422c5796720ddb2ecff812ff524d7b48f7819098
+  data.tar.gz: 13913200ac349f177e811868854c9841b67eabd7dec644052956264fc31a4aaafdaf41e92943fef841c29812ebc61018c949876b707c01a2f847a56584c6cea9

data/CHANGES.md

@@ -1,5 +1,15 @@
 # CHANGES
 
+## 1.9.0 (2025-02-27)
+
+* Fix: Convert param input to String [#105](https://github.com/realestate-com-au/stackup/pull/105)
+
+## 1.8.1 (2023-09-12)
+
+* Addresses rate limiting errors in #87 by configuring the following retry behaviours:
+  * Updates `retry_mode` from `legacy` to `standard`
+  * Increase the value of `max_attempts` to 50
+
 ## 1.8.0 (2022-08-23)
 
 * Feature: Add support for ruby 3.1

data/lib/stackup/main_command.rb

@@ -90,12 +90,18 @@ module Stackup
       Stackup(aws_config)
     end
 
+    # In standard retry_mode max_attempts = 3 so the SDK will only retry twice (initial request + 2 retries)
+    # Now we're setting max_attempts = 50 (initial request + 49 retries) which gives us some breathing room
+    MAX_SDK_ATTEMPTS = 50
+
     def base_aws_config
       {
         :log_level => :debug,
         :logger => logger,
         :region => region,
-        :retry_limit => retry_limit
+        :retry_limit => retry_limit,
+        :max_attempts => MAX_SDK_ATTEMPTS,
+        :retry_mode => "standard"
       }.reject { |_k, v| v.nil? }
     end
 

data/lib/stackup/parameters.rb

@@ -45,7 +45,7 @@ module Stackup
           if value == :use_previous_value
             record[:use_previous_value] = true
           else
-            record[:parameter_value] = value
+            record[:parameter_value] = ParameterValue.new(value).to_param
           end
         end
       end
@@ -75,7 +75,26 @@ module Stackup
       if use_previous_value
         :use_previous_value
       else
-        parameter_value
+        ParameterValue.new(parameter_value).to_param
+      end
+    end
+
+  end
+
+  class ParameterValue
+
+    def initialize(value)
+      @value = value
+    end
+
+    def to_param
+      case @value
+      when TrueClass, FalseClass, Integer then
+        @value.to_s
+      when Array
+        @value.map { |v| ParameterValue.new(v).to_param }.join(",")
+      else
+        @value
       end
     end
 

data/lib/stackup/version.rb

@@ -2,6 +2,6 @@
 
 module Stackup
 
-  VERSION = "1.8.0"
+  VERSION = "1.9.0"
 
 end

data/spec/stackup/parameters_spec.rb

@@ -146,6 +146,51 @@ describe Stackup::Parameters do
 
     end
 
+    context "with non-string values" do
+
+      let(:input_records) do
+        [
+          { :parameter_key => "Integer", :parameter_value => 123_456_789 },
+          { :parameter_key => "Truthy", :parameter_value => true },
+          { :parameter_key => "Falsey", :parameter_value => false },
+          { :parameter_key => "Null", :parameter_value => nil },
+          { :parameter_key => "Array", :parameter_value => ["one", 2] },
+          { :parameter_key => "String", :parameter_value => "string" }
+        ]
+      end
+
+      subject(:parameters) { Stackup::Parameters.new(input_records) }
+
+      describe "#to_hash" do
+        it "converts the to strings where appropriate" do
+          expected = {
+            "Integer" => "123456789",
+            "Truthy" => "true",
+            "Falsey" => "false",
+            "Null" => nil,
+            "Array" => "one,2",
+            "String" => "string"
+          }
+          expect(parameters.to_hash).to eql(expected)
+        end
+      end
+
+      describe "#to_a" do
+        it "converts the to strings where appropriate" do
+          expected = [
+            { :parameter_key => "Integer", :parameter_value => "123456789" },
+            { :parameter_key => "Truthy", :parameter_value => "true" },
+            { :parameter_key => "Falsey", :parameter_value => "false" },
+            { :parameter_key => "Null", :parameter_value => nil },
+            { :parameter_key => "Array", :parameter_value => "one,2" },
+            { :parameter_key => "String", :parameter_value => "string" }
+          ]
+          expect(parameters.to_a).to eql(expected)
+        end
+      end
+
+    end
+
     context "with empty parameter file" do
 
       let(:input_records) { false }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stackup
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.9.0
 platform: ruby
 authors:
 - Danial Pearce
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-23 00:00:00.000000000 Z
+date: 2025-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-cloudformation