stackone_migration 1.4.1 → 1.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cadc4aeca4df2a3e2fb255bf8707c2a2d367ec91fef4f37730f4721200eb280d
-  data.tar.gz: 721ca5cd0cd33b92cfbaba84f39b15261804846b19abc3a247a945f001fa9581
+  metadata.gz: 12f55eba7877d4d7d35e0001c386bfb990fb341df546ef503e96bacf0ea3f452
+  data.tar.gz: 35628efb66506a70f4e812994f83d7ba846ba9f25dc25f9a44db9486dd6c2e6c
 SHA512:
-  metadata.gz: bfed002c6274ece9c15edd5e63ad44a7e1043f1e0057813cc42a969bd1b550dd2c92d6923c13eaa3bda9f924824c9eb0aba6d64a6edb04f606d561d55fddd5df
-  data.tar.gz: 6a16939ca863b8e00c3d769322f56caca5e3a253efcb61152c34505326539d75d566906e19c89cf3511b1c871f1d860e0f35a141b0e34bb33231d4b6be099c00
+  metadata.gz: fb4b210b5afdd18c2bd965660307ba57e8c1b36affe6d154bd48b68cedfca10bd4f2ace68a7c22fb9a05b7ade2a74badf91e35cec8395fc3833a2620f0f1cc6c
+  data.tar.gz: 868f0f74f6ad9070ce8c2ca8634340947271398d9a23f286c0a620a1faa06a37fcae7cda6fcd6679dabad0a4ba321f59f39ff799bf0303f7ade94431f3d6d861

data/Gemfile

@@ -11,4 +11,4 @@ group :development, :test do
 end
 
 gem 'merge_hris_client', '~> 3.0'
-gem 'stackone_hris_client', '~> 1.5.1'
+gem 'stackone_hris_client', '~> 1.5.2'

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    stackone_migration (1.4.1)
+    stackone_migration (1.4.3)
       merge_hris_client (~> 3.0)
-      stackone_hris_client (~> 1.5.1)
+      stackone_hris_client (~> 1.5.2)
 
 GEM
   remote: https://rubygems.org/
@@ -58,7 +58,7 @@ GEM
     rubocop-ast (1.27.0)
       parser (>= 3.2.1.0)
     ruby-progressbar (1.13.0)
-    stackone_hris_client (1.5.1)
+    stackone_hris_client (1.5.2)
       typhoeus (~> 1.0, >= 1.0.1)
     typhoeus (1.4.0)
       ethon (>= 0.9.0)
@@ -73,7 +73,7 @@ DEPENDENCIES
   rake (~> 13.0.1)
   rspec (~> 3.6, >= 3.6.0)
   rubocop (~> 1.48.0)
-  stackone_hris_client (~> 1.5.1)
+  stackone_hris_client (~> 1.5.2)
   stackone_migration!
 
 BUNDLED WITH

data/lib/stackone_migration/mappers/employees_mapper.rb

@@ -97,7 +97,7 @@ module StackOneMigration
         :first_name => employee.first_name,
         :last_name => employee.last_name,
         :display_full_name => employee.display_name,
-        :avatar => employee.avatar_url,
+        :avatar => employee.avatar&.url,
         :personal_email => employee.personal_email,
         :work_email => employee.work_email,
         :mobile_phone_number => employee.personal_phone_number || employee.work_phone_number,

data/lib/stackone_migration/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StackOneMigration
-  VERSION = '1.4.1'
+  VERSION = '1.4.3'
 end

data/spec/mappers/employees_mapper_spec.rb

@@ -10,7 +10,7 @@ describe StackOneMigration::EmployeesMapper do
       :last_name => 'Harrington',
       :display_name => 'Jean Harrington',
       :name => 'Jean Marie Harrington',
-      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :avatar => StackOneHRIS::Image.new(url: 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200'),
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
       :personal_phone_number => '(715) 658-9486',
@@ -56,7 +56,7 @@ describe StackOneMigration::EmployeesMapper do
       :last_name => 'Shaw',
       :display_name => 'Allie Shaw',
       :name => 'Allie Jennifer Shaw',
-      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :avatar => StackOneHRIS::Image.new(base64: 'this_is_a_base64_string'),
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
       :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
@@ -75,7 +75,10 @@ describe StackOneMigration::EmployeesMapper do
       :last_name => 'Shaw',
       :display_name => 'Allie Shaw',
       :name => 'Allie Jennifer Shaw',
-      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :avatar => StackOneHRIS::Image.new(
+        url: 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+        base64: 'this_is_a_base64_string'
+      ),
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
       :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
@@ -87,14 +90,13 @@ describe StackOneMigration::EmployeesMapper do
       :department => 'Human Resources',
     )   
   }
-  let(:employee_with_no_phone_number) { 
+  let(:employee_with_no_phone_number_and_avatar) { 
     StackOneHRIS::Employee.new(
       :id => '456',
       :first_name => 'Allie',
       :last_name => 'Shaw',
       :display_name => 'Allie Shaw',
       :name => 'Allie Jennifer Shaw',
-      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
       :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
@@ -138,6 +140,30 @@ describe StackOneMigration::EmployeesMapper do
       expect(target_model.employment_status).to have_attributes(:value => 'INACTIVE')
     end
 
+    context 'when the employee record has the avatar base64 field instead of url' do
+      it 'fills the avatar field with nil' do
+        target_model = described_class.map_to_employee_model(other_sample_employee)
+
+        expect(target_model.avatar).to be_nil
+      end
+    end
+
+    context 'when the employee record has both avatar fields' do
+      it 'fills the avatar field with the url value' do
+        target_model = described_class.map_to_employee_model(another_sample_employee)
+
+        expect(target_model.avatar).to eq('https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200')
+      end
+    end
+
+    context 'when the employee record has no avatar' do
+      it 'fills the avatar field with nil' do
+        target_model = described_class.map_to_employee_model(employee_with_no_phone_number_and_avatar)
+
+        expect(target_model.avatar).to be_nil
+      end
+    end
+
     context 'when the employee record has both personal and work phone number' do
       it 'fills the mobile phone number with personal phone number' do
         target_model = described_class.map_to_employee_model(sample_employee)
@@ -164,7 +190,7 @@ describe StackOneMigration::EmployeesMapper do
 
     context 'when the employee record does not have phone numbers' do
       it 'fills the mobile phone number with nil' do
-        target_model = described_class.map_to_employee_model(employee_with_no_phone_number)
+        target_model = described_class.map_to_employee_model(employee_with_no_phone_number_and_avatar)
 
         expect(target_model.mobile_phone_number).to be_nil
       end

data/stackone_migration.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.7'
 
   s.add_runtime_dependency 'merge_hris_client', '~> 3.0'
-  s.add_runtime_dependency 'stackone_hris_client', '~> 1.5.1'
+  s.add_runtime_dependency 'stackone_hris_client', '~> 1.5.2'
 
   s.add_development_dependency 'rspec', '~> 3.6', '>= 3.6.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stackone_migration
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.4.3
 platform: ruby
 authors:
 - StackOne
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-10 00:00:00.000000000 Z
+date: 2023-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: merge_hris_client
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.5.2
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement