stackone_migration 1.4.0 → 1.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 67a03369917c2e312bf393a5f96d3493d5b6430647fc8f080d3b2a37be59c29a
-  data.tar.gz: ac3404c9425e9a1bddbf0613025bfaa84e1091e6afc5b137dc12f4eaa1cdfd18
+  metadata.gz: d847c0bb8a3646c4fb2f47428321883eaecaa10bf171300292f823e91e105b8e
+  data.tar.gz: 808f3aac0a165982d78a166bf39e368cab711e419684fd83e0c3dcb0dc264541
 SHA512:
-  metadata.gz: 603295af5e304db4088764640a04a6c5d61a5cb0f569d66aec876732b49c659e6054eaa7b870c511d244a244dc7f47b194e8c20440c22cc1bd9e18792c0f59ed
-  data.tar.gz: 1e766c8704c8ab85cdb04607819dced4e65b6516c550c322975bb95de60cd6bc20e7419d013389158466b8353ed1f87f391f180567a87fdfe70839975196dfec
+  metadata.gz: 2e5b2dadc6c0fe202af202f29f5013a2d26a93ef054715619419c16442aafb45c9f902ef44ae4249b09c15120283bf1b163d9c54bc3c90402c2dbafbca5ec295
+  data.tar.gz: aa419a3ec1a10634b2744f3202f0705e860f009213fb0d82c42d3e244e53ff7d2fe4a3aca3b33402d03c22042db9caf4c9eb8878ddda76f5da7e9b461e838bd5

data/Gemfile

@@ -11,4 +11,4 @@ group :development, :test do
 end
 
 gem 'merge_hris_client', '~> 3.0'
-gem 'stackone_hris_client', '~> 1.5.1'
+gem 'stackone_hris_client', '~> 1.5.2'

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    stackone_migration (1.4.0)
+    stackone_migration (1.4.2)
       merge_hris_client (~> 3.0)
-      stackone_hris_client (~> 1.5.1)
+      stackone_hris_client (~> 1.5.2)
 
 GEM
   remote: https://rubygems.org/
@@ -58,7 +58,7 @@ GEM
     rubocop-ast (1.27.0)
       parser (>= 3.2.1.0)
     ruby-progressbar (1.13.0)
-    stackone_hris_client (1.5.1)
+    stackone_hris_client (1.5.2)
       typhoeus (~> 1.0, >= 1.0.1)
     typhoeus (1.4.0)
       ethon (>= 0.9.0)
@@ -73,7 +73,7 @@ DEPENDENCIES
   rake (~> 13.0.1)
   rspec (~> 3.6, >= 3.6.0)
   rubocop (~> 1.48.0)
-  stackone_hris_client (~> 1.5.1)
+  stackone_hris_client (~> 1.5.2)
   stackone_migration!
 
 BUNDLED WITH

data/lib/stackone_migration/mappers/employees_mapper.rb

@@ -97,11 +97,11 @@ module StackOneMigration
         :first_name => employee.first_name,
         :last_name => employee.last_name,
         :display_full_name => employee.display_name,
-        :avatar => employee.avatar_url,
+        :avatar => employee.avatar&.url || employee.avatar&.base64,
         :personal_email => employee.personal_email,
         :work_email => employee.work_email,
-        :mobile_phone_number => employee.personal_phone_number,
-        :gender => MergeHRISClient::GenderEnum.build_from_hash(map_enum(gender_enum_hash,employee.gender)),
+        :mobile_phone_number => employee.personal_phone_number || employee.work_phone_number,
+        :gender => MergeHRISClient::GenderEnum.build_from_hash(map_enum(gender_enum_hash, employee.gender)),
         :date_of_birth => employee.date_of_birth,
         :start_date => employee.start_date,
         :manager => employee.manager_id,

data/lib/stackone_migration/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StackOneMigration
-  VERSION = '1.4.0'
+  VERSION = '1.4.2'
 end

data/spec/mappers/employees_mapper_spec.rb

@@ -10,7 +10,7 @@ describe StackOneMigration::EmployeesMapper do
       :last_name => 'Harrington',
       :display_name => 'Jean Harrington',
       :name => 'Jean Marie Harrington',
-      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :avatar => StackOneHRIS::Image.new(url: 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200'),
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
       :personal_phone_number => '(715) 658-9486',
@@ -56,10 +56,9 @@ describe StackOneMigration::EmployeesMapper do
       :last_name => 'Shaw',
       :display_name => 'Allie Shaw',
       :name => 'Allie Jennifer Shaw',
-      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :avatar => StackOneHRIS::Image.new(base64: 'this_is_a_base64_string'),
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
-      :personal_phone_number => '(715) 658-9486',
       :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
       :date_of_birth => '1990-01-01',
       :start_date => '2018-01-01',
@@ -69,6 +68,45 @@ describe StackOneMigration::EmployeesMapper do
       :department => 'Human Resources',
     )   
   }
+  let(:another_sample_employee) { 
+    StackOneHRIS::Employee.new(
+      :id => '456',
+      :first_name => 'Allie',
+      :last_name => 'Shaw',
+      :display_name => 'Allie Shaw',
+      :name => 'Allie Jennifer Shaw',
+      :avatar => StackOneHRIS::Image.new(
+        url: 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+        base64: 'this_is_a_base64_string'
+      ),
+      :personal_email => 'ija@egje.wf',
+      :work_email => 'kota@efpiphi.kw',
+      :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
+      :date_of_birth => '1990-01-01',
+      :start_date => '2018-01-01',
+      :manager_id => '417b5e62-e011-5e69-a906-0aefade9ded1',
+      :personal_phone_number => '(715) 658-9486',
+      :job_title => 'Manager',
+      :department => 'Human Resources',
+    )   
+  }
+  let(:employee_with_no_phone_number_and_avatar) { 
+    StackOneHRIS::Employee.new(
+      :id => '456',
+      :first_name => 'Allie',
+      :last_name => 'Shaw',
+      :display_name => 'Allie Shaw',
+      :name => 'Allie Jennifer Shaw',
+      :personal_email => 'ija@egje.wf',
+      :work_email => 'kota@efpiphi.kw',
+      :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
+      :date_of_birth => '1990-01-01',
+      :start_date => '2018-01-01',
+      :manager_id => '417b5e62-e011-5e69-a906-0aefade9ded1',
+      :job_title => 'Manager',
+      :department => 'Human Resources',
+    )   
+  }
 
   context '.map_to_employee_model' do
     it 'maps the employee to the target employee class' do
@@ -102,6 +140,62 @@ describe StackOneMigration::EmployeesMapper do
       expect(target_model.employment_status).to have_attributes(:value => 'INACTIVE')
     end
 
+    context 'when the employee record has the avatar base64 field instead of url' do
+      it 'fills the avatar field with the base64 value' do
+        target_model = described_class.map_to_employee_model(other_sample_employee)
+
+        expect(target_model.avatar).to eq('this_is_a_base64_string')
+      end
+    end
+
+    context 'when the employee record has both avatar fields' do
+      it 'fills the avatar field with the url value' do
+        target_model = described_class.map_to_employee_model(another_sample_employee)
+
+        expect(target_model.avatar).to eq('https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200')
+      end
+    end
+
+    context 'when the employee record has no avatar' do
+      it 'fills the avatar field with nil' do
+        target_model = described_class.map_to_employee_model(employee_with_no_phone_number_and_avatar)
+
+        expect(target_model.avatar).to be_nil
+      end
+    end
+
+    context 'when the employee record has both personal and work phone number' do
+      it 'fills the mobile phone number with personal phone number' do
+        target_model = described_class.map_to_employee_model(sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(715) 658-9486')
+      end
+    end
+
+    context 'when the employee record only has personal phone number' do
+      it 'fills the mobile phone number with personal phone number' do
+        target_model = described_class.map_to_employee_model(another_sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(715) 658-9486')
+      end
+    end
+
+    context 'when the employee record only has work phone number' do
+      it 'fills the mobile phone number with work phone number' do
+        target_model = described_class.map_to_employee_model(other_sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(456) 787-3508')
+      end
+    end
+
+    context 'when the employee record does not have phone numbers' do
+      it 'fills the mobile phone number with nil' do
+        target_model = described_class.map_to_employee_model(employee_with_no_phone_number_and_avatar)
+
+        expect(target_model.mobile_phone_number).to be_nil
+      end
+    end
+
     context 'when the employee record to map is nil' do
       it 'returns nil' do
         target_model = described_class.map_to_employee_model(nil)

data/stackone_migration.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.7'
 
   s.add_runtime_dependency 'merge_hris_client', '~> 3.0'
-  s.add_runtime_dependency 'stackone_hris_client', '~> 1.5.1'
+  s.add_runtime_dependency 'stackone_hris_client', '~> 1.5.2'
 
   s.add_development_dependency 'rspec', '~> 3.6', '>= 3.6.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stackone_migration
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.2
 platform: ruby
 authors:
 - StackOne
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-09 00:00:00.000000000 Z
+date: 2023-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: merge_hris_client
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.5.2
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -85,6 +85,7 @@ files:
 - spec/helpers/account_helper_spec.rb
 - spec/mappers/employees_mapper_spec.rb
 - spec/spec_helper.rb
+- stackone_migration-1.4.1.gem
 - stackone_migration.gemspec
 homepage: https://stackone.com
 licenses: