stackone_migration 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 67a03369917c2e312bf393a5f96d3493d5b6430647fc8f080d3b2a37be59c29a
-  data.tar.gz: ac3404c9425e9a1bddbf0613025bfaa84e1091e6afc5b137dc12f4eaa1cdfd18
+  metadata.gz: cadc4aeca4df2a3e2fb255bf8707c2a2d367ec91fef4f37730f4721200eb280d
+  data.tar.gz: 721ca5cd0cd33b92cfbaba84f39b15261804846b19abc3a247a945f001fa9581
 SHA512:
-  metadata.gz: 603295af5e304db4088764640a04a6c5d61a5cb0f569d66aec876732b49c659e6054eaa7b870c511d244a244dc7f47b194e8c20440c22cc1bd9e18792c0f59ed
-  data.tar.gz: 1e766c8704c8ab85cdb04607819dced4e65b6516c550c322975bb95de60cd6bc20e7419d013389158466b8353ed1f87f391f180567a87fdfe70839975196dfec
+  metadata.gz: bfed002c6274ece9c15edd5e63ad44a7e1043f1e0057813cc42a969bd1b550dd2c92d6923c13eaa3bda9f924824c9eb0aba6d64a6edb04f606d561d55fddd5df
+  data.tar.gz: 6a16939ca863b8e00c3d769322f56caca5e3a253efcb61152c34505326539d75d566906e19c89cf3511b1c871f1d860e0f35a141b0e34bb33231d4b6be099c00

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    stackone_migration (1.4.0)
+    stackone_migration (1.4.1)
       merge_hris_client (~> 3.0)
       stackone_hris_client (~> 1.5.1)
 

data/lib/stackone_migration/mappers/employees_mapper.rb

@@ -100,8 +100,8 @@ module StackOneMigration
         :avatar => employee.avatar_url,
         :personal_email => employee.personal_email,
         :work_email => employee.work_email,
-        :mobile_phone_number => employee.personal_phone_number,
-        :gender => MergeHRISClient::GenderEnum.build_from_hash(map_enum(gender_enum_hash,employee.gender)),
+        :mobile_phone_number => employee.personal_phone_number || employee.work_phone_number,
+        :gender => MergeHRISClient::GenderEnum.build_from_hash(map_enum(gender_enum_hash, employee.gender)),
         :date_of_birth => employee.date_of_birth,
         :start_date => employee.start_date,
         :manager => employee.manager_id,

data/lib/stackone_migration/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StackOneMigration
-  VERSION = '1.4.0'
+  VERSION = '1.4.1'
 end

data/spec/mappers/employees_mapper_spec.rb

@@ -59,7 +59,6 @@ describe StackOneMigration::EmployeesMapper do
       :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
-      :personal_phone_number => '(715) 658-9486',
       :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
       :date_of_birth => '1990-01-01',
       :start_date => '2018-01-01',
@@ -69,6 +68,43 @@ describe StackOneMigration::EmployeesMapper do
       :department => 'Human Resources',
     )   
   }
+  let(:another_sample_employee) { 
+    StackOneHRIS::Employee.new(
+      :id => '456',
+      :first_name => 'Allie',
+      :last_name => 'Shaw',
+      :display_name => 'Allie Shaw',
+      :name => 'Allie Jennifer Shaw',
+      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :personal_email => 'ija@egje.wf',
+      :work_email => 'kota@efpiphi.kw',
+      :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
+      :date_of_birth => '1990-01-01',
+      :start_date => '2018-01-01',
+      :manager_id => '417b5e62-e011-5e69-a906-0aefade9ded1',
+      :personal_phone_number => '(715) 658-9486',
+      :job_title => 'Manager',
+      :department => 'Human Resources',
+    )   
+  }
+  let(:employee_with_no_phone_number) { 
+    StackOneHRIS::Employee.new(
+      :id => '456',
+      :first_name => 'Allie',
+      :last_name => 'Shaw',
+      :display_name => 'Allie Shaw',
+      :name => 'Allie Jennifer Shaw',
+      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :personal_email => 'ija@egje.wf',
+      :work_email => 'kota@efpiphi.kw',
+      :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
+      :date_of_birth => '1990-01-01',
+      :start_date => '2018-01-01',
+      :manager_id => '417b5e62-e011-5e69-a906-0aefade9ded1',
+      :job_title => 'Manager',
+      :department => 'Human Resources',
+    )   
+  }
 
   context '.map_to_employee_model' do
     it 'maps the employee to the target employee class' do
@@ -102,6 +138,38 @@ describe StackOneMigration::EmployeesMapper do
       expect(target_model.employment_status).to have_attributes(:value => 'INACTIVE')
     end
 
+    context 'when the employee record has both personal and work phone number' do
+      it 'fills the mobile phone number with personal phone number' do
+        target_model = described_class.map_to_employee_model(sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(715) 658-9486')
+      end
+    end
+
+    context 'when the employee record only has personal phone number' do
+      it 'fills the mobile phone number with personal phone number' do
+        target_model = described_class.map_to_employee_model(another_sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(715) 658-9486')
+      end
+    end
+
+    context 'when the employee record only has work phone number' do
+      it 'fills the mobile phone number with work phone number' do
+        target_model = described_class.map_to_employee_model(other_sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(456) 787-3508')
+      end
+    end
+
+    context 'when the employee record does not have phone numbers' do
+      it 'fills the mobile phone number with nil' do
+        target_model = described_class.map_to_employee_model(employee_with_no_phone_number)
+
+        expect(target_model.mobile_phone_number).to be_nil
+      end
+    end
+
     context 'when the employee record to map is nil' do
       it 'returns nil' do
         target_model = described_class.map_to_employee_model(nil)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stackone_migration
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - StackOne
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-09 00:00:00.000000000 Z
+date: 2023-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: merge_hris_client