stackone_migration 1.3.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: daa32597a9e8c833693f8b94f572af6fee65310b673ede6e67a99f6772ee0d87
-  data.tar.gz: fc23f733389cce570bb07754170e84f59d7f065f6b69931e8ddb941b25002fad
+  metadata.gz: cadc4aeca4df2a3e2fb255bf8707c2a2d367ec91fef4f37730f4721200eb280d
+  data.tar.gz: 721ca5cd0cd33b92cfbaba84f39b15261804846b19abc3a247a945f001fa9581
 SHA512:
-  metadata.gz: 149a32da85baab2c457cda99adb372a5bdb520927f8f28768f1c9a365a9cd878d9817029313f710f4e908ad49860db43ec9ec17f981ecf0d259664a52ea40124
-  data.tar.gz: 1598674e96bb4bd3724e087382cc5ad53c183c83ad3826d7d224ca56c0764d0da49b3f1f13bb46ff3d96112acdf108a8f10960ba434deb0d4ca958d19ce44421
+  metadata.gz: bfed002c6274ece9c15edd5e63ad44a7e1043f1e0057813cc42a969bd1b550dd2c92d6923c13eaa3bda9f924824c9eb0aba6d64a6edb04f606d561d55fddd5df
+  data.tar.gz: 6a16939ca863b8e00c3d769322f56caca5e3a253efcb61152c34505326539d75d566906e19c89cf3511b1c871f1d860e0f35a141b0e34bb33231d4b6be099c00

data/Gemfile

@@ -11,4 +11,4 @@ group :development, :test do
 end
 
 gem 'merge_hris_client', '~> 3.0'
-gem 'stackone_hris_client', '~> 1.4.0'
+gem 'stackone_hris_client', '~> 1.5.1'

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    stackone_migration (1.3.0)
+    stackone_migration (1.4.1)
       merge_hris_client (~> 3.0)
-      stackone_hris_client (~> 1.4.0)
+      stackone_hris_client (~> 1.5.1)
 
 GEM
   remote: https://rubygems.org/
@@ -58,7 +58,7 @@ GEM
     rubocop-ast (1.27.0)
       parser (>= 3.2.1.0)
     ruby-progressbar (1.13.0)
-    stackone_hris_client (1.4.0)
+    stackone_hris_client (1.5.1)
       typhoeus (~> 1.0, >= 1.0.1)
     typhoeus (1.4.0)
       ethon (>= 0.9.0)
@@ -73,7 +73,7 @@ DEPENDENCIES
   rake (~> 13.0.1)
   rspec (~> 3.6, >= 3.6.0)
   rubocop (~> 1.48.0)
-  stackone_hris_client (~> 1.4.0)
+  stackone_hris_client (~> 1.5.1)
   stackone_migration!
 
 BUNDLED WITH

data/lib/stackone_migration/mappers/employees_mapper.rb

@@ -100,8 +100,8 @@ module StackOneMigration
         :avatar => employee.avatar_url,
         :personal_email => employee.personal_email,
         :work_email => employee.work_email,
-        :mobile_phone_number => employee.personal_phone_number,
-        :gender => MergeHRISClient::GenderEnum.build_from_hash(map_enum(gender_enum_hash,employee.gender)),
+        :mobile_phone_number => employee.personal_phone_number || employee.work_phone_number,
+        :gender => MergeHRISClient::GenderEnum.build_from_hash(map_enum(gender_enum_hash, employee.gender)),
         :date_of_birth => employee.date_of_birth,
         :start_date => employee.start_date,
         :manager => employee.manager_id,
@@ -129,7 +129,7 @@ module StackOneMigration
         :city => location.city,
         :state => location.state,
         :zip_code => location.zip_code,
-        :country => MergeHRISClient::CountryEnum.build_from_hash(location.country),
+        :country => map_country_enum(location.country),
         :location_type => MergeHRISClient::LocationTypeEnum.build_from_hash(map_enum(location_type_enum_hash, location.location_type)),
       )
     end
@@ -196,5 +196,13 @@ module StackOneMigration
 
       enum.source_value
     end
+
+    def self.map_country_enum(enum)
+      return nil if enum.nil? || enum.value.nil?
+
+      enum_value = enum.value != 'unmapped_value' ? enum.value : enum.source_value
+
+      MergeHRISClient::CountryEnum.build_from_hash(enum_value)
+    end
   end
 end

data/lib/stackone_migration/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StackOneMigration
-  VERSION = '1.3.0'
+  VERSION = '1.4.1'
 end

data/spec/mappers/employees_mapper_spec.rb

@@ -32,7 +32,7 @@ describe StackOneMigration::EmployeesMapper do
            :city => "San Francisco",
            :state => "CA",
            :zip_code => "94105",
-           :country => "US",
+           :country => StackOneHRIS::CountryCodeEnum.new(value: 'US', source_value: 'United States'),
            :location_type => StackOneHRIS::LocationTypeEnum.new(value: 'home', source_value: 'home'),
         ),
       :work_location => nil,
@@ -59,7 +59,6 @@ describe StackOneMigration::EmployeesMapper do
       :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
-      :personal_phone_number => '(715) 658-9486',
       :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
       :date_of_birth => '1990-01-01',
       :start_date => '2018-01-01',
@@ -69,6 +68,43 @@ describe StackOneMigration::EmployeesMapper do
       :department => 'Human Resources',
     )   
   }
+  let(:another_sample_employee) { 
+    StackOneHRIS::Employee.new(
+      :id => '456',
+      :first_name => 'Allie',
+      :last_name => 'Shaw',
+      :display_name => 'Allie Shaw',
+      :name => 'Allie Jennifer Shaw',
+      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :personal_email => 'ija@egje.wf',
+      :work_email => 'kota@efpiphi.kw',
+      :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
+      :date_of_birth => '1990-01-01',
+      :start_date => '2018-01-01',
+      :manager_id => '417b5e62-e011-5e69-a906-0aefade9ded1',
+      :personal_phone_number => '(715) 658-9486',
+      :job_title => 'Manager',
+      :department => 'Human Resources',
+    )   
+  }
+  let(:employee_with_no_phone_number) { 
+    StackOneHRIS::Employee.new(
+      :id => '456',
+      :first_name => 'Allie',
+      :last_name => 'Shaw',
+      :display_name => 'Allie Shaw',
+      :name => 'Allie Jennifer Shaw',
+      :avatar_url => 'https://www.gravatar.com/avatar/0c1c0c1c0c1c0c1c0c1c0c1c0c1c0c1c?d=mm&s=200',
+      :personal_email => 'ija@egje.wf',
+      :work_email => 'kota@efpiphi.kw',
+      :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
+      :date_of_birth => '1990-01-01',
+      :start_date => '2018-01-01',
+      :manager_id => '417b5e62-e011-5e69-a906-0aefade9ded1',
+      :job_title => 'Manager',
+      :department => 'Human Resources',
+    )   
+  }
 
   context '.map_to_employee_model' do
     it 'maps the employee to the target employee class' do
@@ -102,6 +138,38 @@ describe StackOneMigration::EmployeesMapper do
       expect(target_model.employment_status).to have_attributes(:value => 'INACTIVE')
     end
 
+    context 'when the employee record has both personal and work phone number' do
+      it 'fills the mobile phone number with personal phone number' do
+        target_model = described_class.map_to_employee_model(sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(715) 658-9486')
+      end
+    end
+
+    context 'when the employee record only has personal phone number' do
+      it 'fills the mobile phone number with personal phone number' do
+        target_model = described_class.map_to_employee_model(another_sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(715) 658-9486')
+      end
+    end
+
+    context 'when the employee record only has work phone number' do
+      it 'fills the mobile phone number with work phone number' do
+        target_model = described_class.map_to_employee_model(other_sample_employee)
+
+        expect(target_model.mobile_phone_number).to eq('(456) 787-3508')
+      end
+    end
+
+    context 'when the employee record does not have phone numbers' do
+      it 'fills the mobile phone number with nil' do
+        target_model = described_class.map_to_employee_model(employee_with_no_phone_number)
+
+        expect(target_model.mobile_phone_number).to be_nil
+      end
+    end
+
     context 'when the employee record to map is nil' do
       it 'returns nil' do
         target_model = described_class.map_to_employee_model(nil)
@@ -120,7 +188,7 @@ describe StackOneMigration::EmployeesMapper do
         :city => "San Francisco",
         :state => "CA",
         :zip_code => "94105",
-        :country => "US"
+        :country => StackOneHRIS::CountryCodeEnum.new(value: 'US', source_value: 'United States'),
       )
 
       target_model = described_class.map_to_location_model(sample_location)
@@ -138,7 +206,7 @@ describe StackOneMigration::EmployeesMapper do
         :city => "San Francisco",
         :state => "CA",
         :zip_code => "94105",
-        :country => "US",
+        :country => StackOneHRIS::CountryCodeEnum.new(value: 'US', source_value: 'United States'),
         :location_type => StackOneHRIS::LocationTypeEnum.new(value: 'home', source_value: 'home'),
       )
 
@@ -153,11 +221,39 @@ describe StackOneMigration::EmployeesMapper do
       expect(target_model.city).to eq("San Francisco")
       expect(target_model.state).to eq("CA")
       expect(target_model.zip_code).to eq("94105")
-      expect(target_model.country).to have_attributes(:raw_value => 'US')
+      expect(target_model.country).to have_attributes(:value => 'US')
       expect(target_model.location_type).to have_attributes(:value => 'HOME')
     end
   end
 
+  context '.map_country_enum' do
+    it 'maps a country to correct class' do
+      sample_country = StackOneHRIS::CountryCodeEnum.new(value: 'US', source_value: 'United States')
+
+      target_model = described_class.map_country_enum(sample_country)
+
+      expect(target_model).to be_a(MergeHRISClient::CountryEnum)
+    end
+
+    it 'maps to a country with the right attributes' do
+      sample_country = StackOneHRIS::CountryCodeEnum.new(value: 'US', source_value: 'United States')
+
+      target_model = described_class.map_country_enum(sample_country)
+
+      expect(target_model).to have_attributes(:value => 'US', :raw_value => 'US')
+    end
+
+    context 'when the original enum is an unmapped value' do
+      it 'maps to a country with non standard value' do
+        sample_country = StackOneHRIS::CountryCodeEnum.new(value: 'unmapped_value', source_value: 'United States')
+
+        target_model = described_class.map_country_enum(sample_country)
+
+        expect(target_model).to have_attributes(:value => 'MERGE_NONSTANDARD_VALUE', :raw_value => 'United States')
+      end
+    end
+  end
+
   context '.map_to_employment_model' do
     it 'maps a employeement to correct class' do
       sample_employment = StackOneHRIS::Employment.new( 

data/stackone_migration.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.7'
 
   s.add_runtime_dependency 'merge_hris_client', '~> 3.0'
-  s.add_runtime_dependency 'stackone_hris_client', '~> 1.4.0'
+  s.add_runtime_dependency 'stackone_hris_client', '~> 1.5.1'
 
   s.add_development_dependency 'rspec', '~> 3.6', '>= 3.6.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stackone_migration
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.1
 platform: ruby
 authors:
 - StackOne
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-05-04 00:00:00.000000000 Z
+date: 2023-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: merge_hris_client
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.5.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.4.0
+        version: 1.5.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement