stackone_migration 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 764e6b26eb6bf1d91be9ef1c94bc5c86eec039f268bccc2a06bad4096e7211c9
-  data.tar.gz: 863ff416beda7f5984cd037648a88be4fede27e9ecef4871dad7af27447e1aaa
+  metadata.gz: daa32597a9e8c833693f8b94f572af6fee65310b673ede6e67a99f6772ee0d87
+  data.tar.gz: fc23f733389cce570bb07754170e84f59d7f065f6b69931e8ddb941b25002fad
 SHA512:
-  metadata.gz: 3b74cf2823822fa167ec101c7198ecabd34d931a06af69919d62915c7ed76c144f9b3a09cc811b6d104f52e86a4f54b92461b3b0523998793090f1c982a617e8
-  data.tar.gz: d5144d115eef1dd54f0dd098fa43eaa6e34ef5c0bb796270aa363df9757de0456989a42dcc9926006c311f4c8d948e6e88b114b46003b744711c5750a9645995
+  metadata.gz: 149a32da85baab2c457cda99adb372a5bdb520927f8f28768f1c9a365a9cd878d9817029313f710f4e908ad49860db43ec9ec17f981ecf0d259664a52ea40124
+  data.tar.gz: 1598674e96bb4bd3724e087382cc5ad53c183c83ad3826d7d224ca56c0764d0da49b3f1f13bb46ff3d96112acdf108a8f10960ba434deb0d4ca958d19ce44421

data/Gemfile

@@ -11,4 +11,4 @@ group :development, :test do
 end
 
 gem 'merge_hris_client', '~> 3.0'
-gem 'stackone_hris_client', '~> 1.3.1'
+gem 'stackone_hris_client', '~> 1.4.0'

data/Gemfile.lock

@@ -1,9 +1,9 @@
 PATH
   remote: .
   specs:
-    stackone_migration (1.2.1)
+    stackone_migration (1.3.0)
       merge_hris_client (~> 3.0)
-      stackone_hris_client (~> 1.3.1)
+      stackone_hris_client (~> 1.4.0)
 
 GEM
   remote: https://rubygems.org/
@@ -58,7 +58,7 @@ GEM
     rubocop-ast (1.27.0)
       parser (>= 3.2.1.0)
     ruby-progressbar (1.13.0)
-    stackone_hris_client (1.3.1)
+    stackone_hris_client (1.4.0)
       typhoeus (~> 1.0, >= 1.0.1)
     typhoeus (1.4.0)
       ethon (>= 0.9.0)
@@ -73,7 +73,7 @@ DEPENDENCIES
   rake (~> 13.0.1)
   rspec (~> 3.6, >= 3.6.0)
   rubocop (~> 1.48.0)
-  stackone_hris_client (~> 1.3.1)
+  stackone_hris_client (~> 1.4.0)
   stackone_migration!
 
 BUNDLED WITH

data/lib/stackone_migration/mappers/employees_mapper.rb

@@ -101,52 +101,50 @@ module StackOneMigration
         :personal_email => employee.personal_email,
         :work_email => employee.work_email,
         :mobile_phone_number => employee.personal_phone_number,
-        :gender => MergeHRISClient::GenderEnum.build_from_hash(gender_enum_hash[employee.gender&.to_sym]),
+        :gender => MergeHRISClient::GenderEnum.build_from_hash(map_enum(gender_enum_hash,employee.gender)),
         :date_of_birth => employee.date_of_birth,
         :start_date => employee.start_date,
         :manager => employee.manager_id,
-        :ethnicity => MergeHRISClient::EthnicityEnum.build_from_hash(ethnicity_enum_hash[employee.ethnicity&.to_sym]),
-        :marital_status => MergeHRISClient::MaritalStatusEnum.build_from_hash(marital_status_enum_hash[employee.marital_status&.to_sym]),
+        :ethnicity => MergeHRISClient::EthnicityEnum.build_from_hash(map_enum(ethnicity_enum_hash, employee.ethnicity)),
+        :marital_status => MergeHRISClient::MaritalStatusEnum.build_from_hash(map_enum(marital_status_enum_hash, employee.marital_status)),
         :hire_date => employee.hire_date,
-        :employment_status => MergeHRISClient::EmploymentStatusEnum.build_from_hash(employment_status_enum_hash[employee.employment_status&.to_sym]),
+        :employment_status => MergeHRISClient::EmploymentStatusEnum.build_from_hash(map_enum(employment_status_enum_hash, employee.employment_status)),
         :termination_date => employee.termination_date,
-        :company => json_str_to_hash(employee.company),
-        :home_location => json_str_to_hash(employee.home_location),
-        :work_location => json_str_to_hash(employee.work_location),
+        :home_location => map_to_location_model(employee.home_location),
+        :work_location => map_to_location_model(employee.work_location),
         :employments => map_employments(employee.employments),
       )
     end
 
-    def self.json_str_to_hash(hash_string)
-      begin
-        return nil if hash_string.nil?
-
-        new_str = hash_string
-          .gsub(/:(\w+)/, '"\1"')
-          .gsub('=>', ':')
-          .gsub('nil', 'null')
-
-        hash = JSON.parse(new_str)
-
-        hash.transform_keys(&:to_sym)
-      rescue JSON::ParserError => e
-        puts "Error parsing JSON string: #{e.message}"
-
-        hash_string
-      end
+    def self.map_to_location_model(location)
+      return nil if location.nil?
+
+      MergeHRISClient::Location.new(
+        :id => location.id,
+        :remote_id => location.id,
+        :name => location.name,
+        :phone_number => location.phone_number,
+        :street_1 => location.street_1,
+        :street_2 => location.street_2,
+        :city => location.city,
+        :state => location.state,
+        :zip_code => location.zip_code,
+        :country => MergeHRISClient::CountryEnum.build_from_hash(location.country),
+        :location_type => MergeHRISClient::LocationTypeEnum.build_from_hash(map_enum(location_type_enum_hash, location.location_type)),
+      )
     end
 
     def self.map_to_employment_model(employment)
       return nil if employment.nil?
 
       MergeHRISClient::Employment.new(
-        :job_title => employment[:job_title],
-        :pay_rate => employment[:pay_rate],
-        :pay_period => MergeHRISClient::PayPeriodEnum.build_from_hash(pay_period_enum_hash[employment[:pay_period]&.to_sym]),
-        :pay_frequency => MergeHRISClient::PayFrequencyEnum.build_from_hash(pay_frequency_enum_hash[employment[:pay_frequency]&.to_sym]),
-        :pay_currency => MergeHRISClient::PayCurrencyEnum.build_from_hash(employment[:pay_currency]&.to_s.upcase),
-        :effective_date => employment[:effective_date],
-        :employment_type => MergeHRISClient::EmploymentTypeEnum.build_from_hash(employment_type_enum_hash[employment[:employment_type]&.to_sym]),
+        :job_title => employment.job_title,
+        :pay_rate => employment.pay_rate,
+        :pay_period => MergeHRISClient::PayPeriodEnum.build_from_hash(map_enum(pay_period_enum_hash, employment.pay_period)),
+        :pay_frequency => MergeHRISClient::PayFrequencyEnum.build_from_hash(map_enum(pay_frequency_enum_hash, employment.pay_frequency)),
+        :pay_currency => MergeHRISClient::PayCurrencyEnum.build_from_hash(employment.pay_currency&.to_s&.upcase),
+        :effective_date => employment.effective_date,
+        :employment_type => MergeHRISClient::EmploymentTypeEnum.build_from_hash(map_enum(employment_type_enum_hash, employment.employment_type)),
       )
     end
 
@@ -189,5 +187,14 @@ module StackOneMigration
         :previous => nil
       )
     end
+
+    def self.map_enum(enum_hash, enum)
+      return nil if enum.nil? || enum.value.nil?
+
+      mapped_enum = enum_hash[enum&.value&.to_sym]
+      return mapped_enum unless mapped_enum.nil? || mapped_enum == 'MERGE_NONSTANDARD_VALUE'
+
+      enum.source_value
+    end
   end
 end

data/lib/stackone_migration/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StackOneMigration
-  VERSION = '1.2.1'
+  VERSION = '1.3.0'
 end

data/spec/mappers/employees_mapper_spec.rb

@@ -14,39 +14,38 @@ describe StackOneMigration::EmployeesMapper do
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
       :personal_phone_number => '(715) 658-9486',
-      :gender => 'female',
+      :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
       :date_of_birth => '1990-01-01',
       :start_date => '2018-01-01',
       :manager_id => '417b5e62-e011-5e69-a906-0aefade9ded1',
-      :ethnicity => 'white',
-      :marital_status => 'married',
-      :employment_status => 'terminated',
+      :ethnicity => StackOneHRIS::EthnicityEnum.new(value: 'white', source_value: 'white'),
+      :marital_status => StackOneHRIS::MaritalStatusEnum.new(value: 'married', source_value: 'married'),
+      :employment_status => StackOneHRIS::EmploymentStatusEnum.new(value: 'terminated', source_value: 'terminated'),
       :work_phone_number => '(456) 787-3508',
       :job_title => 'Manager',
       :department => 'Human Resources',
-      :home_location => "{
-        :phone_number => \"(456) 787-3508\",
-        :street_1 => \"123 Main' St\",
-        :street_2 => \"Apt 1\",
-        :city => \"San Francisco\",
-        :state => \"CA\",
-        :zip_code => \"94105\",
-        :country => \"US\"
-      }",
+      :home_location => 
+         StackOneHRIS::Location.new(
+           :phone_number => "(456) 787-3508",
+           :street_1 => "123 Main' St",
+           :street_2 => "Apt 1",
+           :city => "San Francisco",
+           :state => "CA",
+           :zip_code => "94105",
+           :country => "US",
+           :location_type => StackOneHRIS::LocationTypeEnum.new(value: 'home', source_value: 'home'),
+        ),
       :work_location => nil,
-      :company => "{
-        \"display_name\": \"StackOne\"
-      }",
       :employments => [
-        { 
-          job_title: 'Manager',
-          pay_rate: 100000,
-          pay_period: 'yearly',
-          pay_frequency: 'weekly',
-          pay_currency: 'USD',
-          effective_date: '2018-01-01',
-          employee_type: 'full_time',
-        }
+        StackOneHRIS::Employment.new( 
+          :job_title => 'Manager',
+          :pay_rate => 100000,
+          :pay_period => StackOneHRIS::PayPeriodEnum.new(value: 'year', source_value: 'year'),
+          :pay_frequency => StackOneHRIS::PayFrequencyEnum.new(value: 'weekly', source_value: 'weekly'),
+          :pay_currency => 'USD',
+          :effective_date => '2018-01-01',
+          :employment_type => StackOneHRIS::EmploymentTypeEnum.new(value: 'full_time', source_value: 'full_time'),
+        )
       ]
     )
   }
@@ -61,7 +60,7 @@ describe StackOneMigration::EmployeesMapper do
       :personal_email => 'ija@egje.wf',
       :work_email => 'kota@efpiphi.kw',
       :personal_phone_number => '(715) 658-9486',
-      :gender => 'female',
+      :gender => StackOneHRIS::GenderEnum.new(value: 'female', source_value: 'female'),
       :date_of_birth => '1990-01-01',
       :start_date => '2018-01-01',
       :manager_id => '417b5e62-e011-5e69-a906-0aefade9ded1',
@@ -94,19 +93,8 @@ describe StackOneMigration::EmployeesMapper do
         :date_of_birth => '1990-01-01',
         :start_date => '2018-01-01',
         :manager => '417b5e62-e011-5e69-a906-0aefade9ded1',
-        :home_location => {
-          phone_number: '(456) 787-3508',
-          street_1: '123 Main\' St',
-          street_2: 'Apt 1',
-          city: 'San Francisco',
-          state: 'CA',
-          zip_code: '94105',
-          country: 'US',
-        },
         :work_location => nil,
-        :company => {
-          display_name: 'StackOne',
-        },
+        :company => nil,
       )
       expect(target_model.gender).to have_attributes(:value => 'FEMALE')
       expect(target_model.ethnicity).to have_attributes(:value => 'WHITE')
@@ -123,33 +111,80 @@ describe StackOneMigration::EmployeesMapper do
     end
   end
 
+  context '.map_to_location_model' do
+    it 'maps a location to correct class' do
+      sample_location = StackOneHRIS::Location.new(
+        :phone_number => "(456) 787-3508",
+        :street_1 => "123 Main' St",
+        :street_2 => "Apt 1",
+        :city => "San Francisco",
+        :state => "CA",
+        :zip_code => "94105",
+        :country => "US"
+      )
+
+      target_model = described_class.map_to_location_model(sample_location)
+
+      expect(target_model).to be_a(MergeHRISClient::Location)
+    end
+
+    it 'maps a location with the right attributes' do
+      sample_location = StackOneHRIS::Location.new(
+        :id => '123',
+        :name => 'David Leonard',
+        :phone_number => "(456) 787-3508",
+        :street_1 => "123 Main' St",
+        :street_2 => "Apt 1",
+        :city => "San Francisco",
+        :state => "CA",
+        :zip_code => "94105",
+        :country => "US",
+        :location_type => StackOneHRIS::LocationTypeEnum.new(value: 'home', source_value: 'home'),
+      )
+
+      target_model = described_class.map_to_location_model(sample_location)
+
+      expect(target_model.id).to eq('123')
+      expect(target_model.remote_id).to eq('123')
+      expect(target_model.name).to eq('David Leonard')
+      expect(target_model.phone_number).to eq('(456) 787-3508')
+      expect(target_model.street_1).to eq("123 Main' St")
+      expect(target_model.street_2).to eq("Apt 1")
+      expect(target_model.city).to eq("San Francisco")
+      expect(target_model.state).to eq("CA")
+      expect(target_model.zip_code).to eq("94105")
+      expect(target_model.country).to have_attributes(:raw_value => 'US')
+      expect(target_model.location_type).to have_attributes(:value => 'HOME')
+    end
+  end
+
   context '.map_to_employment_model' do
-    it 'maps a employeement hash to correct class' do
-      sample_employment = { 
-            job_title: 'Manager',
-            pay_rate: 100000,
-            pay_period: 'yearly',
-            pay_frequency: 'weekly',
-            pay_currency: 'USD',
-            effective_date: '2018-01-01',
-            employment_type: 'full_time',
-          }
+    it 'maps a employeement to correct class' do
+      sample_employment = StackOneHRIS::Employment.new( 
+        :job_title => 'Manager',
+        :pay_rate => 100000,
+        :pay_period => StackOneHRIS::PayPeriodEnum.new(value: 'year', source_value: 'year'),
+        :pay_frequency => StackOneHRIS::PayFrequencyEnum.new(value: 'weekly', source_value: 'weekly'),
+        :pay_currency => 'USD',
+        :effective_date => '2018-01-01',
+        :employment_type => StackOneHRIS::EmploymentTypeEnum.new(value: 'full_time', source_value: 'full_time'),
+      )
 
       target_model = described_class.map_to_employment_model(sample_employment)
 
       expect(target_model).to be_a(MergeHRISClient::Employment)
     end
 
-    it 'maps a employeement hash with the right attributes' do
-      sample_employment = { 
-            job_title: 'Manager',
-            pay_rate: 100000,
-            pay_period: 'year',
-            pay_frequency: 'weekly',
-            pay_currency: 'usd',
-            effective_date: '2018-01-01',
-            employment_type: 'full_time',
-          }
+    it 'maps a employeement with the right attributes' do
+      sample_employment = StackOneHRIS::Employment.new( 
+        :job_title => 'Manager',
+        :pay_rate => 100000,
+        :pay_period => StackOneHRIS::PayPeriodEnum.new(value: 'year', source_value: 'year'),
+        :pay_frequency => StackOneHRIS::PayFrequencyEnum.new(value: 'weekly', source_value: 'weekly'),
+        :pay_currency => 'USD',
+        :effective_date => '2018-01-01',
+        :employment_type => StackOneHRIS::EmploymentTypeEnum.new(value: 'full_time', source_value: 'full_time'),
+      )
 
       target_model = described_class.map_to_employment_model(sample_employment)
 
@@ -232,4 +267,59 @@ describe StackOneMigration::EmployeesMapper do
        end
      end
   end
+
+  context '.map_enum' do
+    it 'returns the mapped enum' do
+      target_value = described_class.map_enum(
+        described_class.pay_period_enum_hash,
+        StackOneHRIS::PayPeriodEnum.new(value: 'year', source_value: 'year')
+      )
+
+      expect(target_value).to eq('YEAR')
+    end
+
+    context 'when the enum is nil' do
+      it 'returns nil' do
+        target_value = described_class.map_enum(
+          described_class.pay_period_enum_hash,
+          nil
+        )
+
+        expect(target_value).to be_nil
+      end
+    end
+
+    context 'when the enum value is nil' do
+      it 'returns nil' do
+        target_value = described_class.map_enum(
+          described_class.pay_period_enum_hash,
+          StackOneHRIS::PayPeriodEnum.new(value: nil, source_value: 'year')
+        )
+
+        expect(target_value).to be_nil
+      end
+    end
+
+    context 'when the enum value is an unmapped value' do
+      it 'returns the source value' do
+        target_value = described_class.map_enum(
+          described_class.pay_period_enum_hash,
+          StackOneHRIS::PayPeriodEnum.new(value: 'unmapped_value', source_value: 'year_custom_value')
+        )
+
+        expect(target_value).to eq('year_custom_value')
+      end
+    end
+
+    context 'when the enum value maps to a MERGE_NONSTANDARD_VALUE' do
+      it 'returns the mapped enum' do
+        target_value = described_class.map_enum(
+          described_class.marital_status_enum_hash,
+          StackOneHRIS::MaritalStatusEnum.new(value: 'other', source_value: 'other_status')
+        )
+
+        expect(target_value).to eq('other_status')
+      end
+    end
+  end
 end

data/stackone_migration.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.7'
 
   s.add_runtime_dependency 'merge_hris_client', '~> 3.0'
-  s.add_runtime_dependency 'stackone_hris_client', '~> 1.3.1'
+  s.add_runtime_dependency 'stackone_hris_client', '~> 1.4.0'
 
   s.add_development_dependency 'rspec', '~> 3.6', '>= 3.6.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stackone_migration
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - StackOne
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-21 00:00:00.000000000 Z
+date: 2023-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: merge_hris_client
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement