stackify-ruby-apm 1.14.5 → 1.14.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81a16e2527e1237952803d7082cd0869b932e2af04dd3263490e5bd6538debbd
-  data.tar.gz: 3df0659ad3e96984f67c9850e69f38c20fae65ced83948b2791a2a9fe63012af
+  metadata.gz: 881446a181c81d422cdd81f2de4b4ccef409989171d96a53833bbe425f8105c0
+  data.tar.gz: ed31e237779e881ab4a57d7db2c4dcc7936bbe01b6af256ac4f53d9ae4c96054
 SHA512:
-  metadata.gz: d6a34b33a19b3a59c69fdfa105255b234a77b3be6b81a0bbdac68bc39bdc92eb327c33d236d49beb064dafe87b6f4e882df53fb29365b2152572f4d9cf7fdf08
-  data.tar.gz: e05ee709696f67a2bb4c7780a2b762393f5be5507c3af5b327c825e500fd3a18786827f2ba2e8d98df8e926af6cc2d4a5dc79fd380f8392fdd8443e04a998c5c
+  metadata.gz: 293677dce94cf22be5e9a45fb1e7d9b7090fcbbe76a4a1bb679da719896d3ced92c5e34bc6ef0315ef8c05c3ee8621bcd51bac552e6f02bfce635aa13205f23e
+  data.tar.gz: 581165dd6ee9b10a02d206a7f985b6980ee1ddb46a9a2de05e194a6a9578596114823eff12cd4dab96277e82e533bb9c742c0ee72e109de2a8e819405fb5f4ce

data/lib/stackify_apm/helper/database_helper.rb

@@ -19,6 +19,8 @@ module DatabaseHelper
       'db2'
     elsif driver.include? 'sqlite'
       'sqlite'
+    else
+      'generic'
     end
   end
   # rubocop:enable Metrics/CyclomaticComplexity

data/lib/stackify_apm/normalizers/active_record.rb

@@ -14,8 +14,6 @@ module StackifyRubyAPM
 
         def initialize(*args)
           super(*args)
-
-          @type = format('db.%s.sql', lookup_adapter || 'unknown').freeze
         end
 
         def normalize(_transaction, _name, payload)
@@ -25,7 +23,9 @@ module StackifyRubyAPM
           check_prepared_stmt(statement, payload)
           name = payload[:sql] || payload[:name] || 'Default'
           context = Span::Context.new(statement)
-          [name, @type, context]
+
+          type = format('db.%s.sql', lookup_adapter(payload) || 'unknown').freeze
+          [name, type, context]
         end
 
         private
@@ -33,7 +33,7 @@ module StackifyRubyAPM
         def query_variables(payload)
           adapter_config = lookup_adapter_config
           props = get_common_db_properties
-          props[:PROVIDER] = get_profiler(lookup_adapter)
+          props[:PROVIDER] = get_profiler(lookup_adapter(payload))
           props[:SQL] = payload[:sql]
           if adapter_config
             props[:URL] = "#{adapter_config[:host]}:#{adapter_config[:port]}"
@@ -41,8 +41,52 @@ module StackifyRubyAPM
           props
         end
 
-        def lookup_adapter
-          ::ActiveRecord::Base.connection.adapter_name.downcase
+        # Ideally the application doesn't connect to the database during boot,
+        # but sometimes it does. In case it did, we want to empty out the
+        # connection pools so that a non-database-using process (e.g. a master
+        # process in a forking server model) doesn't retain a needless
+        # connection. If it was needed, the incremental cost of reestablishing
+        # this connection is trivial: the rest of the pool would need to be
+        # populated anyway.
+        #
+        # Reference: https://github.com/rails/rails/blob/main/activerecord/lib/active_record/railtie.rb#L253
+        #
+        # Miko: Considering we are getting the connection method, it is retrieving connection from the connection pool
+        # Connection Method: lib/active_record/connection_handling.rb#L264
+        # Retrieve Connection: lib/active_record/connection_handling.rb#L309
+        # Handler Retrieve Connection: lib/active_record/connection_adapters/abstract/connection_pool.rb#L1111
+        
+        def lookup_adapter(payload)
+          connection = nil
+          if (payload.key?(:connection))
+            connection = payload[:connection]
+          elsif ::ActiveRecord::Base.connection_pool.instance_variable_defined?(:@reserved_connections) and payload.key?(:connection_id)
+            connection_id = payload[:connection_id] # Connection ID here is the object_id of the connection object
+            connections = ::ActiveRecord::Base.connection_pool.instance_variable_get(:@reserved_connections) # Lets check the reserved connections
+
+            if (
+                (connections.class != nil and connections.respond_to?(:class) and
+                  (connections.class.to_s == 'ThreadSafe::Cache' or connections.class.to_s == 'Hash')
+                ) and connections.size()
+            )
+              connections.each_value do |val|
+                if val.object_id == connection_id
+                  connection = val
+                  break
+                end
+              end
+            end
+          end
+
+          if (connection.nil?)
+            return 'generic'
+          end
+
+          if (connection.respond_to?(:adapter_name) && connection.adapter_name.nil?)
+            return 'generic'
+          end
+
+          connection.adapter_name.downcase
         rescue StandardError => error
           debug '[SqlNormalizer] lookup_adapter err: ' + error.inspect.to_s
           nil
@@ -61,7 +105,7 @@ module StackifyRubyAPM
 
         def check_prepared_stmt(statement, payload)
           if StackifyRubyAPM.agent.config.prefix_enabled
-            case get_profiler(lookup_adapter)
+            case get_profiler(lookup_adapter(payload))
             when 'generic', 'mysql', 'sqlite', 'oracle', 'db2'
               check_prepared_stmt_by_placeholder(payload[:sql].include?('?'), statement, payload)
             when 'postgresql'

data/lib/stackify_apm/version.rb

@@ -2,5 +2,5 @@
 
 # Sets the version of the APM
 module StackifyRubyAPM
-  VERSION = '1.14.5'.freeze
+  VERSION = '1.14.7'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stackify-ruby-apm
 version: !ruby/object:Gem::Version
-  version: 1.14.5
+  version: 1.14.7
 platform: ruby
 authors:
 - Stackify
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-01 00:00:00.000000000 Z
+date: 2021-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails