stacker_bee 2.1.1.pre324 → 2.1.1

data/spec/integration/request_spec.rb

@@ -1,20 +1,16 @@
+require 'spec_helper'
 require 'logger'
 
 describe 'A response to a request sent to the CloudStack API', :vcr do
   subject { client.list_accounts }
 
-  let(:config_url) { CONFIG['url'] }
-  let(:uri) { URI.parse(config_url) }
-  let(:url) { uri.to_s }
-  let(:api_path) { CONFIG['api_path'] }
+  let(:url) { CONFIG['url'] }
   let(:config_hash) do
     {
-      url:          url,
-      api_path:     api_path,
-      console_path: CONFIG['console_path'],
-      api_key:      CONFIG['api_key'],
-      secret_key:   CONFIG['secret_key'],
-      middlewares:  middlewares
+      url:         url,
+      api_key:     CONFIG['api_key'],
+      secret_key:  CONFIG['secret_key'],
+      middlewares: middlewares
     }
   end
   let(:middlewares) { proc {} }
@@ -33,30 +29,18 @@ describe 'A response to a request sent to the CloudStack API', :vcr do
   end
 
   context 'failing to connect' do
-    let(:url) { 'http://127.0.0.1:666' }
+    let(:url) { 'http://127.0.0.1:666/client/api' }
     it 'raises a helpful exception' do
       klass = StackerBee::ConnectionError
       expect { subject }.to raise_error klass, /#{url}/
     end
   end
 
-  context 'with a nonexistant path', :regression do
-    let(:api_path) { '/not/a/real/endpoint' }
-    it 'raises a client error' do
-      expect { subject }.to raise_error(StackerBee::RequestError)
-    end
-  end
-
-  context 'trailing slash in API path', :regression do
-    let(:api_path) { api_path_without_slash + '/' }
-    let(:api_path_without_slash) { api_path_from_config.sub(/\/$/, '') }
-    let(:api_path_from_config) { CONFIG.fetch('api_path', '/client/api') }
+  context 'trailing slash in URL', :regression do
+    let(:url) { CONFIG['url'].gsub(/\/$/, '') + '/' }
     it 'makes request with trailing slash' do
-      stub = stub_request(:get, /#{api_path_without_slash}\?apiKey/)
-             .to_return(body: '{"foo": {}}')
-
+      stub = stub_request(:get, /#{url}/).to_return(body: '{"foo": {}}')
       subject
-
       expect(stub).to have_been_requested
     end
   end

data/spec/spec_helper.rb

@@ -1,5 +1,12 @@
 require 'simplecov'
 
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# Require this file using `require "spec_helper"` to ensure that it is only
+# loaded once.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+
 require File.expand_path('../../lib/stacker_bee', __FILE__)
 
 require 'yaml'

data/spec/units/stacker_bee/api_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::API do
   subject { api }
 

data/spec/units/stacker_bee/client_spec.rb

@@ -1,3 +1,4 @@
+require 'spec_helper'
 require 'ostruct'
 
 describe StackerBee::Client, '.api' do

data/spec/units/stacker_bee/configuration_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Configuration do
   describe "setting an attribute that doesn't exist" do
     [:ssl_verify?, :url?, :other_attr].each do |attr|
@@ -42,36 +44,6 @@ describe StackerBee::Configuration do
     end
   end
 
-  describe '#api_path' do
-    subject { configuration.api_path }
-
-    context 'when not set' do
-      let(:configuration) { described_class.new }
-      it { is_expected.to eq '/client/api' }
-    end
-
-    context 'when set' do
-      let(:configuration) { described_class.new(api_path: setting) }
-      let(:setting) { '/new-path/cloudstack' }
-      it { is_expected.to eq setting }
-    end
-  end
-
-  describe '#console_path' do
-    subject { configuration.console_path }
-
-    context 'when not set' do
-      let(:configuration) { described_class.new }
-      it { is_expected.to eq '/client/console' }
-    end
-
-    context 'when set' do
-      let(:configuration) { described_class.new(console_path: setting) }
-      let(:setting) { '/new-path/cloudstack' }
-      it { is_expected.to eq setting }
-    end
-  end
-
   describe '#secret_key' do
     subject { configuration.secret_key }
 

data/spec/units/stacker_bee/connection_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Connection do
   subject(:get) { connection.get(path, query_params) }
   before { allow(Faraday).to receive_messages new: faraday }

data/spec/units/stacker_bee/middleware/adapter_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::Adapter do
   let(:env) do
     StackerBee::Middleware::Environment.new(
@@ -8,7 +10,7 @@ describe StackerBee::Middleware::Adapter do
   end
   let(:app) { double(:app, call: response) }
   let(:response) { double(:response) }
-  let(:path) { '/the/path' }
+  let(:path) { double(:path) }
 
   let(:params) { { 'z' => 'z', 'a' => 'a' } }
   let(:connection) { double(:connection, get: raw_response) }
@@ -43,14 +45,6 @@ describe StackerBee::Middleware::Adapter do
     it 'sorts the paramers' do
       expect(connection).to have_received(:get).with(path, [%w(a a), %w(z z)])
     end
-
-    context 'when the path ends in a slash' do
-      let(:path) { '/my/path/' }
-      it 'discards the trailing slash' do
-        expect(connection).to \
-          have_received(:get).with('/my/path', [%w(a a), %w(z z)])
-      end
-    end
   end
 
   describe '#endpoint_name_for' do

data/spec/units/stacker_bee/middleware/base_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::Base do
   let(:env) { StackerBee::Middleware::Environment.new(params: params) }
   let(:params) { {} }

data/spec/units/stacker_bee/middleware/cloud_stack_api_spec.rb

@@ -1,13 +1,14 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::CloudStackAPI do
   let(:env) do
     StackerBee::Middleware::Environment.new(
-      endpoint_name: 'endpoint-name'
+      endpoint_name: 'endpoint-name',
+      path:          path
     )
   end
-  let(:middleware) do
-    described_class.new(api_key: 'API-KEY', api_path: api_path)
-  end
-  let(:api_path) { '/my/path' }
+  let(:middleware) { described_class.new(api_key: 'API-KEY', params: {}) }
+  let(:path) { nil }
 
   before do
     middleware.before(env)
@@ -16,7 +17,15 @@ describe StackerBee::Middleware::CloudStackAPI do
   describe 'request' do
     subject { env.request }
 
-    its(:path) { should == '/my/path' }
+    context 'when the path is not set' do
+      let(:path) { nil }
+      its(:path) { should == described_class::DEFAULT_PATH }
+    end
+
+    context 'when the path is already set' do
+      let(:path) { 'already set'  }
+      its(:path) { should == path }
+    end
   end
 
   describe 'params' do

data/spec/units/stacker_bee/middleware/console_access_spec.rb

@@ -1,20 +1,19 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::ConsoleAccess do
   let(:env) do
     StackerBee::Middleware::Environment.new(endpoint_name: endpoint_name)
   end
 
-  let(:middleware) do
-    described_class.new(app: app, console_path: console_path)
-  end
+  let(:middleware) { described_class.new(app: app) }
   let(:app) { double(:app) }
-  let(:console_path) { '/path/to/console' }
 
   context 'when it matches the endpoint' do
     let(:endpoint_name) { described_class::ENDPOINT }
 
     it 'adds its path to the env' do
       middleware.before(env)
-      expect(env.request.path).to eq console_path
+      expect(env.request.path).to eq described_class::PATH
     end
 
     it 'adds cmd to the parameters' do
@@ -28,7 +27,7 @@ describe StackerBee::Middleware::ConsoleAccess do
     before { middleware.before(env) }
 
     it "doesn't add it's path" do
-      expect(env.request.path).to be_nil
+      expect(env.request.path).not_to eq described_class::PATH
     end
 
     it "doesn't add cmd to the parameters" do

data/spec/units/stacker_bee/middleware/dictionary_flattener_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::DictionaryFlattener do
   let(:lb)               { described_class::LB }
   let(:rb)               { described_class::RB }

data/spec/units/stacker_bee/middleware/endpoint_normalizer_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::EndpointNormalizer do
   let(:middleware) { described_class.new(app: app, api: api) }
   let(:app) { double(:app) }

data/spec/units/stacker_bee/middleware/error_message_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::ErrorMessage do
   subject { env.response }
   before { middleware.after(env) }

data/spec/units/stacker_bee/middleware/format_keys_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::FormatKeys do
   subject { described_class.new.transform_params(params) }
 

data/spec/units/stacker_bee/middleware/format_values_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::FormatValues do
   subject { described_class.new.transform_params(params) }
 

data/spec/units/stacker_bee/middleware/http_status_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::HTTPStatus do
   subject { env.response }
   before { middleware.after(env) }

data/spec/units/stacker_bee/middleware/log_response_spec.rb

@@ -1,3 +1,4 @@
+require 'spec_helper'
 describe StackerBee::Middleware::LogResponse do
   describe 'after' do
     let(:logger) { FakeLogger.new }

data/spec/units/stacker_bee/middleware/raise_on_http_errors_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::RaiseOnHTTPError do
   skip
 end

data/spec/units/stacker_bee/middleware/remove_empty_strings_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 # TODO: does this really need to work with nested hashes?
 describe StackerBee::Middleware::RemoveEmptyStrings do
   # rubocop:disable RSpec/InstanceVariable

data/spec/units/stacker_bee/middleware/remove_nils_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Middleware::RemoveNils do
   it 'removes pairs with nil values from the params' do
     expect(subject.transform_params(something: 'something', nothing: nil))

data/spec/units/stacker_bee/rash_spec.rb

@@ -1,9 +1,11 @@
+require 'spec_helper'
+
 shared_examples_for 'a Rash' do |mapping|
   mapping.each_pair { |key, value| its([key]) { should == value } }
 end
 
 describe StackerBee::Rash do
-  subject(:rash) { described_class.new(hash) }
+  subject { rash }
 
   let(:wiz) { [{ 'aB_C' => 'abc' }, { 'X_yZ' => 'xyz' }] }
   let(:ziz) do
@@ -28,6 +30,7 @@ describe StackerBee::Rash do
     end
   end
   let(:dissimilar_hash) { hash.dup.tap { |loud| loud.delete 'foo' } }
+  let(:rash) { described_class.new(hash) }
 
   it { is_expected.to include 'FOO' }
 
@@ -81,21 +84,4 @@ describe StackerBee::Rash do
     subject { rash.values_at 'FOO', 'WIZ', 'WRONG' }
     it { is_expected.to eq ['foo', wiz, nil] }
   end
-
-  describe 'with preferred keys' do
-    subject { described_class.new(hash, preferred_keys) }
-    let(:preferred_keys) { [:foo, 'BAR', :b_a_z] }
-    let(:hash) do
-      {
-        f_o_o:  'foo',
-        ba_r:   'bar',
-        baz:    'baz',
-        Ot_her: 'other'
-      }
-    end
-
-    it 'is stored as preferred if mentioned, otherwise as uncased' do
-      expect(subject.keys).to match_array [:foo, 'BAR', :b_a_z, 'other']
-    end
-  end
 end

data/spec/units/stacker_bee/request_error_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe 'An error occuring' do
   let(:env)      { double(response: response) }
   let(:response) { double(status: status, error: error_text) }

data/spec/units/stacker_bee/utilities_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee::Utilities do
   include described_class
 

data/spec/units/stacker_bee_spec.rb

@@ -1,3 +1,5 @@
+require 'spec_helper'
+
 describe StackerBee do
   it { expect(StackerBee::VERSION).not_to be_nil }
 end

data/stacker_bee.gemspec

@@ -26,16 +26,17 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler',   '~> 1.3'
   spec.add_development_dependency 'rake',      '~> 10.0'
-  spec.add_development_dependency 'rspec',     '~> 3.1.0'
-  spec.add_development_dependency 'rspec-its', '~> 1.1.0'
+  spec.add_development_dependency 'rspec',     '~> 3.0.0'
+  spec.add_development_dependency 'rspec-its', '~> 1.0'
   spec.add_development_dependency 'webmock',   '~> 1.15'
   spec.add_development_dependency 'vcr',       '~> 2.9'
+  spec.add_development_dependency 'pry'
   spec.add_development_dependency 'coveralls'
 
   # It should be consistent for Travis and all developers, since we don't check
   # in the Gemfile.lock
-  spec.add_development_dependency 'rubocop',       '0.27.1'
-  spec.add_development_dependency 'rubocop-rspec', '1.2.1'
+  spec.add_development_dependency 'rubocop',       '0.24.1'
+  spec.add_development_dependency 'rubocop-rspec', '1.1.0'
 
   # Release every merge to master as a prerelease
   if ENV['TRAVIS']

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stacker_bee
 version: !ruby/object:Gem::Version
-  version: 2.1.1.pre324
+  version: 2.1.1
 platform: ruby
 authors:
 - Greg Sterndale
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-25 00:00:00.000000000 Z
+date: 2014-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -93,28 +93,28 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -143,18 +143,32 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.9'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -163,28 +177,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.27.1
+        version: 0.24.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.27.1
+        version: 0.24.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.1.0
 description: Ruby CloudStack client and CLI
 email:
 - team@promptworks.com
@@ -245,13 +259,17 @@ files:
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/a_request_parameter_with_an_Array/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/a_request_parameter_with_and_empty_string/properly_executes_the_request.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/a_request_that_triggers_an_error/properly_signs_the_request.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/containing_an_error/.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/containing_an_error/should_log_response_as_error.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/first/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/first_item/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/first_item/_account_type_/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/first_item/_accounttype_/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/middleware/a_middleware_that_doesn_t_match_the_content_type/uses_the_middleware.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/middleware/a_middleware_that_matches_the_content_type/uses_the_middleware.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/should_log_request.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/should_not_log_response_as_error.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/space_character_in_a_request_parameter/properly_signs_the_request.yml
-- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/with_a_nonexistant_path/raises_a_client_error.yml
 - spec/fixtures/4.2.json
 - spec/fixtures/simple.json
 - spec/integration/configure_middleware_spec.rb
@@ -293,17 +311,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>'
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Ruby CloudStack client
@@ -315,13 +333,17 @@ test_files:
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/a_request_parameter_with_an_Array/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/a_request_parameter_with_and_empty_string/properly_executes_the_request.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/a_request_that_triggers_an_error/properly_signs_the_request.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/containing_an_error/.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/containing_an_error/should_log_response_as_error.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/first/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/first_item/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/first_item/_account_type_/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/first_item/_accounttype_/.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/middleware/a_middleware_that_doesn_t_match_the_content_type/uses_the_middleware.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/middleware/a_middleware_that_matches_the_content_type/uses_the_middleware.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/should_log_request.yml
+- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/should_not_log_response_as_error.yml
 - spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/space_character_in_a_request_parameter/properly_signs_the_request.yml
-- spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/with_a_nonexistant_path/raises_a_client_error.yml
 - spec/fixtures/4.2.json
 - spec/fixtures/simple.json
 - spec/integration/configure_middleware_spec.rb
@@ -352,3 +374,4 @@ test_files:
 - spec/units/stacker_bee/request_error_spec.rb
 - spec/units/stacker_bee/utilities_spec.rb
 - spec/units/stacker_bee_spec.rb
+has_rdoc: