stacker_bee 2.1.0.pre232 → 2.1.0.pre236

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    OTk2OTE3ZWYwM2UxNDdjMjFiNDMzZGFhNTA0NTYyYmYzYTIzMTliNA==
+    ZGMwMTczNmU3MjVmMjM2ZGM2OGI1MzU1M2NhNDI1MTE0NDdiYjhiYQ==
   data.tar.gz: !binary |-
-    ZDMyNTJjOWJkMTI1YmIwZGMwZGM2NjA1MTNlMTAyMmQ4MTRlMGMwMQ==
+    ZDZkZWJjMDkyNWNjMTc2YmUxYmFkYzYxOTgzZTlkMDNlMjEzY2NmMQ==
 SHA512:
   metadata.gz: !binary |-
-    ZDRjNzdmMGZkZTBiZDAxZDFmMzZlNGFiNWI1MTY1ZTEwNGUzYmY2NDkxMmEx
-    YzRiZjAwNGNlM2Y1MGRkNTM5YzM3YTkwMDYwMWY4MDg3NjUwZmZkNWY2OThj
-    N2UyMzVjMzQxOTk1NTI4MjE2OGNlZDZmNjg2YWMxMWQzNzU5ZTk=
+    NDhhNmFjNWJlY2FjMTQzNDk1MzFjOGU5NGFhZDA3ODMwYzU1YjBlNzJkNmFl
+    ZWUyNTY5YmVjM2VkZWE3Y2VmYjk1YTdhODczOGFhMWM2ZGYzNmRjZWQyN2Q0
+    ZmYxNzE5OTJiZDVlZWJkZTZjYzA2ZGI1ZDI3YWUxMGNmNGIwN2M=
   data.tar.gz: !binary |-
-    ZmJjZWZmNTZkNTRhYjJkMDdiNzBiMzJiZTg0ZmMxYzdhNjNmZTQ2MDBjNWE4
-    ZGEyNTNjYTg2NTBmYzQ0ODMzYzEwMjA5ZTE3MmU5M2VhNDA5M2QyNDRmYzMz
-    ZGI2OTVmMDRlMzk0ZTA3ZjYzOWMxZjAxMWNmZTYwYWY2MmQwZWQ=
+    ZjUxZTg3YmE0ZmVlYTBmNjUwNmE1ZWNkYjg3MWM4ODYwOGFkOTc3ZmQ1Mjdl
+    MGE0NzkzNTJhZTYzYjZjOTI2ZWIwNWY2ZTc3ZmZkODY0MGY2ZGYzMjNlY2I1
+    YzA0MDdmYTBlZGE4MzJiMTAzNjkyOGQyYmY1NDEwNzU3N2UwODI=

data/lib/stacker_bee/middleware/dictionary_flattener.rb

@@ -25,7 +25,7 @@ module StackerBee
 
       def flatten_map_values(params, hashes)
         hashes.each do |hash_name, hash|
-          remove_empties(hash).each_with_index do |(key, value), index|
+          remove_falseish(hash).each_with_index do |(key, value), index|
             hash_url_key = self.class.tokenize("#{hash_name}[#{index}]")
 
             params["#{hash_url_key}.key"]   = key
@@ -37,8 +37,8 @@ module StackerBee
       end
 
       # TODO: isn't this done with the RemoveEmptyStrings middleware?
-      def remove_empties(hash)
-        hash.reject { |_, v| v.nil? || v == "" }
+      def remove_falseish(hash)
+        hash.reject { |_, v| v == "" || v =~ /false/i || !v }
       end
     end
   end

data/spec/units/stacker_bee/middleware/dictionary_flattener_spec.rb

@@ -19,31 +19,43 @@ describe StackerBee::Middleware::DictionaryFlattener do
   describe ".new" do
     subject { described_class.new.params(params) }
 
-    def prefix(number)
+    def param(number)
       described_class.tokenize "rebels[#{number}]"
     end
 
     let(:params) do
       { "time" => "long ago",
-        "rebels" => { "r2" => "d2", "r1" => "", "father" => false } }
+        "rebels" => {
+          "r2"      => "d2",
+          "blank"   => "",
+          "falsey"  => "false",
+          "false"   => false,
+          "droid"   => true } }
     end
 
     it "flattens objects in the manner that cloudstack expects" do
-      subject["#{prefix(0)}.name"].should eq "r2"
-      subject["#{prefix(0)}.key"].should eq "r2"
-      subject["#{prefix(0)}.value"].should eq "d2"
+      subject["#{param(0)}.name"].should eq "r2"
+      subject["#{param(0)}.key"].should eq "r2"
+      subject["#{param(0)}.value"].should eq "d2"
     end
 
     it "does not flatten empty hashes" do
-      subject.should_not have_key "#{prefix(2)}.name"
+      subject.should_not have_key "#{param(2)}.name"
     end
 
-    it "handles booleans" do
-      subject["#{prefix(1)}.name"].should eq "father"
+    it "handles true booleans" do
+      subject["#{param(1)}.name"].should eq "droid"
+      subject["#{param(1)}.value"].should be_true
     end
 
     it "removes original map params" do
       subject.should_not have_key "rebels"
     end
+
+    it "doesnt send false to CloudStack" do
+      # This assumption is based on CloudStack UI behavior
+      subject.values.should_not include false
+      subject.values.should_not include "false"
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stacker_bee
 version: !ruby/object:Gem::Version
-  version: 2.1.0.pre232
+  version: 2.1.0.pre236
 platform: ruby
 authors:
 - Greg Sterndale
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-16 00:00:00.000000000 Z
+date: 2014-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday