stacker_bee 2.0.0.pre178 → 2.0.0

data/spec/cassettes/A_response_to_a_request_sent_to_the_CloudStack_API/a_request_parameter_with_a_Map/object.yml

@@ -0,0 +1,153 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: <CLOUD_STACK_URL>?apiKey=<CLOUD_STACK_API_KEY>&command=listZones&response=json&signature=/MnHgTBKGc%2BXx0Z8KwMllvw92vg=
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.8.8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - ! '*/*'
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - text/javascript; charset=UTF-8
+      Content-Length:
+      - '403'
+      Server:
+      - Jetty(6.1.26)
+    body:
+      encoding: US-ASCII
+      string: ! '{ "listzonesresponse" : { "count":1 ,"zone" : [  {"id":"39e9e31e-925c-4b55-8d33-f99912b73dfc","name":"Sandbox-simulator","dns1":"10.147.28.6","internaldns1":"10.147.28.6","guestcidraddress":"10.1.1.0/24","networktype":"Advanced","securitygroupsenabled":false,"allocationstate":"Enabled","zonetoken":"ea3acbc4-cae8-3b82-b42f-7492ddfede00","dhcpprovider":"VirtualRouter","localstorageenabled":false}
+        ] } }'
+    http_version: 
+  recorded_at: Wed, 18 Dec 2013 21:25:06 GMT
+- request:
+    method: get
+    uri: <CLOUD_STACK_URL>?apiKey=<CLOUD_STACK_API_KEY>&command=listNetworkOfferings&response=json&signature=BAdYatJ5Rjcffi6sU8P%2BZtLhSF8=&supportedServices=sourcenat&type=isolated
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.8.8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - ! '*/*'
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - text/javascript; charset=UTF-8
+      Content-Length:
+      - '6006'
+      Server:
+      - Jetty(6.1.26)
+    body:
+      encoding: US-ASCII
+      string: ! '{ "listnetworkofferingsresponse" : { "count":4 ,"networkoffering"
+        : [  {"id":"fa126319-f822-4786-9cd3-30bd0c55ca94","name":"DefaultIsolatedNetworkOfferingWithSourceNatService","displaytext":"Offering
+        for Isolated networks with Source Nat service enabled","traffictype":"Guest","isdefault":true,"specifyvlan":false,"conservemode":true,"specifyipranges":false,"availability":"Required","networkrate":200,"state":"Enabled","guestiptype":"Isolated","serviceofferingid":"983410fa-b51b-439c-b8ba-be973804c38f","service":[{"name":"SourceNat","provider":[{"name":"VirtualRouter"}],"capability":[{"name":"SupportedSourceNatTypes","value":"peraccount","canchooseservicecapability":false},{"name":"RedundantRouter","value":"false","canchooseservicecapability":false}]},{"name":"Dns","provider":[{"name":"VirtualRouter"}]},{"name":"UserData","provider":[{"name":"VirtualRouter"}]},{"name":"PortForwarding","provider":[{"name":"VirtualRouter"}]},{"name":"Firewall","provider":[{"name":"VirtualRouter"}]},{"name":"Lb","provider":[{"name":"VirtualRouter"}],"capability":[{"name":"SupportedLBIsolation","value":"dedicated","canchooseservicecapability":false},{"name":"ElasticLb","value":"false","canchooseservicecapability":false},{"name":"InlineMode","value":"false","canchooseservicecapability":false}]},{"name":"Dhcp","provider":[{"name":"VirtualRouter"}]},{"name":"Vpn","provider":[{"name":"VirtualRouter"}]},{"name":"StaticNat","provider":[{"name":"VirtualRouter"}],"capability":[{"name":"ElasticIp","value":"false","canchooseservicecapability":false},{"name":"AssociatePublicIP","value":"true","canchooseservicecapability":false}]}],"forvpc":false,"ispersistent":false,"egressdefaultpolicy":false},
+        {"id":"7e70b3b5-5e2c-42cb-9b49-93a87c13a675","name":"DefaultIsolatedNetworkOfferingForVpcNetworks","displaytext":"Offering
+        for Isolated Vpc networks with Source Nat service enabled","traffictype":"Guest","isdefault":true,"specifyvlan":false,"conservemode":false,"specifyipranges":false,"availability":"Optional","networkrate":200,"state":"Enabled","guestiptype":"Isolated","serviceofferingid":"983410fa-b51b-439c-b8ba-be973804c38f","service":[{"name":"SourceNat","provider":[{"name":"VpcVirtualRouter"}],"capability":[{"name":"SupportedSourceNatTypes","value":"peraccount","canchooseservicecapability":false},{"name":"RedundantRouter","value":"false","canchooseservicecapability":false}]},{"name":"Dns","provider":[{"name":"VpcVirtualRouter"}]},{"name":"UserData","provider":[{"name":"VpcVirtualRouter"}]},{"name":"PortForwarding","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Lb","provider":[{"name":"VpcVirtualRouter"}],"capability":[{"name":"SupportedLBIsolation","value":"dedicated","canchooseservicecapability":false},{"name":"ElasticLb","value":"false","canchooseservicecapability":false},{"name":"InlineMode","value":"false","canchooseservicecapability":false}]},{"name":"Dhcp","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Vpn","provider":[{"name":"VpcVirtualRouter"}]},{"name":"StaticNat","provider":[{"name":"VpcVirtualRouter"}],"capability":[{"name":"ElasticIp","value":"false","canchooseservicecapability":false},{"name":"AssociatePublicIP","value":"true","canchooseservicecapability":false}]},{"name":"NetworkACL","provider":[{"name":"VpcVirtualRouter"}]}],"forvpc":true,"ispersistent":false,"egressdefaultpolicy":false},
+        {"id":"a9d78d52-f306-44c5-bb6d-c121a507db05","name":"DefaultIsolatedNetworkOfferingForVpcNetworksNoLB","displaytext":"Offering
+        for Isolated Vpc networks with Source Nat service enabled and LB service Disabled","traffictype":"Guest","isdefault":true,"specifyvlan":false,"conservemode":false,"specifyipranges":false,"availability":"Optional","networkrate":200,"state":"Enabled","guestiptype":"Isolated","serviceofferingid":"983410fa-b51b-439c-b8ba-be973804c38f","service":[{"name":"SourceNat","provider":[{"name":"VpcVirtualRouter"}],"capability":[{"name":"SupportedSourceNatTypes","value":"peraccount","canchooseservicecapability":false},{"name":"RedundantRouter","value":"false","canchooseservicecapability":false}]},{"name":"Dns","provider":[{"name":"VpcVirtualRouter"}]},{"name":"UserData","provider":[{"name":"VpcVirtualRouter"}]},{"name":"PortForwarding","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Dhcp","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Vpn","provider":[{"name":"VpcVirtualRouter"}]},{"name":"StaticNat","provider":[{"name":"VpcVirtualRouter"}],"capability":[{"name":"ElasticIp","value":"false","canchooseservicecapability":false},{"name":"AssociatePublicIP","value":"true","canchooseservicecapability":false}]},{"name":"NetworkACL","provider":[{"name":"VpcVirtualRouter"}]}],"forvpc":true,"ispersistent":false,"egressdefaultpolicy":false},
+        {"id":"f9a7b0d0-ce61-4f8d-a360-be1040d67287","name":"DefaultIsolatedNetworkOfferingForVpcNetworksWithInternalLB","displaytext":"Offering
+        for Isolated Vpc networks with Internal LB support","traffictype":"Guest","isdefault":true,"specifyvlan":false,"conservemode":false,"specifyipranges":false,"availability":"Optional","networkrate":200,"state":"Enabled","guestiptype":"Isolated","serviceofferingid":"983410fa-b51b-439c-b8ba-be973804c38f","service":[{"name":"SourceNat","provider":[{"name":"VpcVirtualRouter"}],"capability":[{"name":"SupportedSourceNatTypes","value":"peraccount","canchooseservicecapability":false},{"name":"RedundantRouter","value":"false","canchooseservicecapability":false}]},{"name":"Dns","provider":[{"name":"VpcVirtualRouter"}]},{"name":"UserData","provider":[{"name":"VpcVirtualRouter"}]},{"name":"Lb","provider":[{"name":"InternalLbVm"}],"capability":[{"name":"SupportedLBIsolation","value":"dedicated","canchooseservicecapability":false},{"name":"ElasticLb","value":"false","canchooseservicecapability":false},{"name":"InlineMode","value":"false","canchooseservicecapability":false}]},{"name":"Dhcp","provider":[{"name":"VpcVirtualRouter"}]},{"name":"NetworkACL","provider":[{"name":"VpcVirtualRouter"}]}],"forvpc":true,"ispersistent":false,"egressdefaultpolicy":false}
+        ] } }'
+    http_version: 
+  recorded_at: Wed, 18 Dec 2013 21:25:06 GMT
+- request:
+    method: get
+    uri: <CLOUD_STACK_URL>?apiKey=<CLOUD_STACK_API_KEY>&command=createNetwork&displaytext=John&name=John&networkOfferingId=fa126319-f822-4786-9cd3-30bd0c55ca94&response=json&signature=UDcfFqlzwpHJib/9kLKzR0%2BCbyc=&zoneId=39e9e31e-925c-4b55-8d33-f99912b73dfc
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.8.8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - ! '*/*'
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - text/javascript; charset=UTF-8
+      Content-Length:
+      - '4441'
+      Server:
+      - Jetty(6.1.26)
+    body:
+      encoding: US-ASCII
+      string: ! '{ "createnetworkresponse" :  { "network" : {"id":"02e5fd84-e9ea-49f7-ba6a-6d63ea23a27f","name":"John","displaytext":"John","broadcastdomaintype":"Vlan","traffictype":"Guest","gateway":"10.1.1.1","netmask":"255.255.255.0","cidr":"10.1.1.0/24","zoneid":"39e9e31e-925c-4b55-8d33-f99912b73dfc","zonename":"Sandbox-simulator","networkofferingid":"fa126319-f822-4786-9cd3-30bd0c55ca94","networkofferingname":"DefaultIsolatedNetworkOfferingWithSourceNatService","networkofferingdisplaytext":"Offering
+        for Isolated networks with Source Nat service enabled","networkofferingconservemode":true,"networkofferingavailability":"Required","issystem":false,"state":"Allocated","related":"02e5fd84-e9ea-49f7-ba6a-6d63ea23a27f","dns1":"10.147.28.6","type":"Isolated","acltype":"Account","account":"admin","domainid":"ce4585b8-41f5-11e3-aaa7-d6558ad1fb9f","domain":"ROOT","service":[{"name":"SourceNat","capability":[{"name":"SupportedSourceNatTypes","value":"peraccount","canchooseservicecapability":false},{"name":"RedundantRouter","value":"true","canchooseservicecapability":false}]},{"name":"Dns","capability":[{"name":"AllowDnsSuffixModification","value":"true","canchooseservicecapability":false}]},{"name":"UserData"},{"name":"PortForwarding"},{"name":"Firewall","capability":[{"name":"TrafficStatistics","value":"per
+        public ip","canchooseservicecapability":false},{"name":"SupportedTrafficDirection","value":"ingress,
+        egress","canchooseservicecapability":false},{"name":"SupportedProtocols","value":"tcp,udp,icmp","canchooseservicecapability":false},{"name":"MultipleIps","value":"true","canchooseservicecapability":false},{"name":"SupportedEgressProtocols","value":"tcp,udp,icmp,
+        all","canchooseservicecapability":false}]},{"name":"Lb","capability":[{"name":"SupportedLbAlgorithms","value":"roundrobin,leastconn,source","canchooseservicecapability":false},{"name":"LbSchemes","value":"Public","canchooseservicecapability":false},{"name":"SupportedStickinessMethods","value":"[{\"methodname\":\"LbCookie\",\"paramlist\":[{\"paramname\":\"cookie-name\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"},{\"paramname\":\"mode\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"},{\"paramname\":\"nocache\",\"required\":false,\"isflag\":true,\"description\":\"
+        \"},{\"paramname\":\"indirect\",\"required\":false,\"isflag\":true,\"description\":\"
+        \"},{\"paramname\":\"postonly\",\"required\":false,\"isflag\":true,\"description\":\"
+        \"},{\"paramname\":\"domain\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"}],\"description\":\"This is loadbalancer cookie based stickiness method.\"},{\"methodname\":\"AppCookie\",\"paramlist\":[{\"paramname\":\"cookie-name\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"},{\"paramname\":\"length\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"},{\"paramname\":\"holdtime\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"},{\"paramname\":\"request-learn\",\"required\":false,\"isflag\":true,\"description\":\"
+        \"},{\"paramname\":\"prefix\",\"required\":false,\"isflag\":true,\"description\":\"
+        \"},{\"paramname\":\"mode\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"}],\"description\":\"This is App session based sticky method. Define session
+        stickiness on an existing application cookie. It can be used only for a specific
+        http traffic\"},{\"methodname\":\"SourceBased\",\"paramlist\":[{\"paramname\":\"tablesize\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"},{\"paramname\":\"expire\",\"required\":false,\"isflag\":false,\"description\":\"
+        \"}],\"description\":\"This is source based Stickiness method, it can be used
+        for any type of protocol.\"}]","canchooseservicecapability":false},{"name":"SupportedProtocols","value":"tcp,
+        udp","canchooseservicecapability":false},{"name":"SupportedLBIsolation","value":"dedicated","canchooseservicecapability":false}]},{"name":"Dhcp","capability":[{"name":"DhcpAccrossMultipleSubnets","value":"true","canchooseservicecapability":false}]},{"name":"Vpn","capability":[{"name":"SupportedVpnTypes","value":"pptp,l2tp,ipsec","canchooseservicecapability":false},{"name":"VpnTypes","value":"removeaccessvpn","canchooseservicecapability":false}]},{"name":"StaticNat"}],"networkdomain":"cs2sandbox.simulator","physicalnetworkid":"46d08659-81e9-4f31-a589-a15aca972af0","restartrequired":false,"specifyipranges":false,"canusefordeploy":true,"ispersistent":false,"tags":[],"displaynetwork":true}
+        }  }'
+    http_version: 
+  recorded_at: Wed, 18 Dec 2013 21:25:06 GMT
+- request:
+    method: get
+    uri: <CLOUD_STACK_URL>?apiKey=<CLOUD_STACK_API_KEY>&command=createTags&resourceIds=02e5fd84-e9ea-49f7-ba6a-6d63ea23a27f&resourceType=Network&response=json&signature=KnWoymoA3Q34Iz%2BZ9iFEc8R0lEo=&tags%5B0%5D%5B.key%5D=speed&tags%5B0%5D%5B.name%5D=speed&tags%5B0%5D%5B.value%5D=fast
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Faraday v0.8.8
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - ! '*/*'
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Content-Type:
+      - text/javascript; charset=UTF-8
+      Content-Length:
+      - '75'
+      Server:
+      - Jetty(6.1.26)
+    body:
+      encoding: US-ASCII
+      string: ! '{ "createtagsresponse" : {"jobid":"90bdb3e9-dcd5-4aac-9aa9-1879863082cc"}
+        }'
+    http_version: 
+  recorded_at: Wed, 18 Dec 2013 21:25:07 GMT
+recorded_with: VCR 2.8.0

data/spec/spec_helper.rb

@@ -41,10 +41,6 @@ VCR.configure do |c|
   c.filter_sensitive_data('<CLOUD_STACK_URL>') do
     CONFIG["url"]
   end
-  c.filter_sensitive_data('<CLOUD_STACK_HOST>') do
-    uri = URI.parse(CONFIG["url"])
-    "#{uri.scheme}://#{uri.host}:#{uri.port}"
-  end
   c.filter_sensitive_data('<CLOUD_STACK_API_KEY>') do
     CONFIG["api_key"]
   end

data/spec/units/faraday_graylog_middleware_spec.rb

@@ -11,7 +11,7 @@ describe FaradayMiddleware::Graylog do
   let(:log_data) { logger.data }
   let(:logger)   { DummyLogger.new }
 
-  let(:dummy_adapter) { ->(env) { Faraday::Response.new(env) } }
+  let(:dummy_adapter) { ->(env){ Faraday::Response.new(env) } }
   let(:middleware) do
     described_class.new(dummy_adapter, logger, facility: facility)
   end

data/spec/units/stacker_bee/client_spec.rb

@@ -13,7 +13,7 @@ describe StackerBee::Client, ".api" do
 end
 
 describe StackerBee::Client, "calling endpoint" do
-  let(:url)         { "http://cloud-stack.com" }
+  let(:url)         { "cloud-stack.com" }
   let(:api_key)     { "cloud-stack-api-key" }
   let(:secret_key)  { "cloud-stack-secret-key" }
   let(:config_hash) do
@@ -42,7 +42,7 @@ describe StackerBee::Client, "calling endpoint" do
     ) do
       request
     end
-    connection.stub(:get).with(request, "") { raw_response }
+    connection.stub(:get).with(request) { raw_response }
     StackerBee::Response.stub(:new).with(raw_response) { response }
   end
 
@@ -59,7 +59,7 @@ describe StackerBee::Client, "#request" do
   let(:endpoint)    { "listVirtualMachines" }
   let(:params)      { { list: :all } }
 
-  let(:url)         { "http://cloud-stack.com" }
+  let(:url)         { "cloud-stack.com" }
   let(:api_key)     { "cloud-stack-api-key" }
   let(:secret_key)  { "cloud-stack-secret-key" }
   let(:config_hash) do
@@ -80,7 +80,7 @@ describe StackerBee::Client, "#request" do
     StackerBee::Request.should_receive(:new).with(endpoint, api_key, params) do
       request
     end
-    connection.should_receive(:get).with(request, "") { raw_response }
+    connection.should_receive(:get).with(request) { raw_response }
     StackerBee::Response.should_receive(:new).with(raw_response) { response }
   end
 
@@ -93,7 +93,7 @@ describe StackerBee::Client, "#request" do
 end
 
 describe StackerBee::Client, "configuration" do
-  let(:default_url)         { "http://default_cloud-stack.com" }
+  let(:default_url)         { "default_cloud-stack.com" }
   let(:default_api_key)     { "default-cloud-stack-api-key" }
   let(:default_secret_key)  { "default-cloud-stack-secret-key" }
   let(:default_config_hash) do
@@ -108,7 +108,7 @@ describe StackerBee::Client, "configuration" do
   let!(:default_configuration) do
     StackerBee::Configuration.new(default_config_hash)
   end
-  let(:instance_url)        { "http://instance-cloud-stack.com" }
+  let(:instance_url)        { "instance-cloud-stack.com" }
   let(:instance_api_key)    { "instance-cloud-stack-api-key" }
   let(:instance_secret_key) { "instance-cloud-stack-secret-key" }
   let(:instance_config_hash) do
@@ -163,7 +163,7 @@ describe StackerBee::Client, "configuration" do
     end
 
     describe "#url" do
-      let(:other_url) { "http://other-cloud-stack.com" }
+      let(:other_url) { "other-cloud-stack.com" }
       before { subject.url = other_url }
       its(:url) { should eq other_url }
     end
@@ -181,44 +181,3 @@ describe StackerBee::Client, "configuration" do
     end
   end
 end
-
-describe StackerBee::Client, "#console_access" do
-  let(:config_hash) do
-    {
-      url:        CONFIG["url"],
-      api_key:    CONFIG["api_key"],
-      secret_key: CONFIG["secret_key"]
-    }
-  end
-
-  let(:client) do
-    StackerBee::Client.new(config_hash)
-  end
-
-  let(:vm) { "36f9c08b-f17a-4d0e-ac9b-d45ce2d34fcd" }
-
-  let(:body) { "<body></body>" }
-  let(:headers) { { 'content-type' => 'text/html' } }
-  let(:response_stub) do
-    double(StackerBee::Response, success?: true, body: body, headers: headers)
-  end
-
-  subject(:console_access) { client.console_access(vm: vm) }
-
-  it "makes a request with the consoleAccess endpoint" do
-    expect(client).to receive(:request).with(
-      "consoleAccess", cmd: 'access', vm: vm
-    )
-
-    console_access
-  end
-
-  it "makes a get request to the connection" do
-    expect(client.send(:connection)).to receive(:get) do |request, path|
-      expect(request.endpoint).to eq("consoleAccess")
-      expect(path).to eq("/client/console")
-    end.and_return(response_stub)
-
-    expect(console_access).to eq(body)
-  end
-end

data/spec/units/stacker_bee/connection_spec.rb

@@ -2,32 +2,26 @@ require "spec_helper"
 
 describe StackerBee::Connection do
   let(:url)           { "http://test.com:1234/foo/bar/" }
-  let(:path)          { "/foo/bar" }
   let(:secret_key)    { "shhh" }
+  let(:configuration) { double url: url, secret_key: secret_key }
   let(:query_params)  { [[:foo, :bar]] }
   let(:request)       { double query_params: query_params }
   let(:response)      { double }
   let(:faraday)       { double get: response }
   let(:connection)    { StackerBee::Connection.new configuration }
-  let(:configuration) do
-    double url: url, secret_key: secret_key, ssl_verify: nil
-  end
-
-  subject(:get) { connection.get request, path }
-
+  subject { connection.get request }
   before do
     Faraday.stub(:new) { faraday }
   end
 
   context "successfully connecting" do
     before do
-      faraday.should_receive(:get).with('/foo/bar', query_params) { response }
+      faraday.should_receive(:get).with('/foo/bar/', query_params) { response }
     end
     it { should be response }
     it "specifies url without path when creating connection" do
-      get
-      Faraday.should have_received(:new).with(url: "http://test.com:1234",
-                                              ssl: { verify: true })
+      subject
+      Faraday.should have_received(:new).with(url: "http://test.com:1234")
     end
   end
 
@@ -37,7 +31,7 @@ describe StackerBee::Connection do
     end
     it "should raise helpful exception" do
       klass = StackerBee::ConnectionError
-      expect { get }.to raise_error klass, /#{url}/
+      expect(-> { subject }).to raise_error klass, /#{url}/
     end
   end
 
@@ -45,26 +39,7 @@ describe StackerBee::Connection do
     let(:url) { "wrong.com" }
     it "should raise helpful exception" do
       klass = StackerBee::ConnectionError
-      expect { get }.to raise_error klass, /no protocol/
-    end
-  end
-
-  context "when given a path" do
-    let(:path) { '/baz' }
-    it "makes a request to the correct path" do
-      expect(faraday).to receive(:get).with(path, query_params)
-      connection.get request, path
-    end
-  end
-
-  context "when verifying an ssl connection" do
-    let(:configuration) do
-      double url: url, secret_key: secret_key, ssl_verify: false
-    end
-    it "specifies the ssl verify option when creating a connection" do
-      get
-      Faraday.should have_received(:new).with(url: "http://test.com:1234",
-                                              ssl: { verify: false })
+      expect(-> { subject }).to raise_error klass, /no protocol/
     end
   end
 end

data/spec/units/stacker_bee/graylog_faraday_middleware_spec.rb

@@ -11,7 +11,7 @@ describe StackerBee::GraylogFaradayMiddleware do
   let(:log_data) { logger.data }
   let(:logger)   { DummyLogger.new }
 
-  let(:dummy_adapter) { ->(env) { Faraday::Response.new(env) } }
+  let(:dummy_adapter) { ->(env){ Faraday::Response.new(env) } }
   let(:middleware) { described_class.new(dummy_adapter, logger) }
   let(:status) { 200 }
 
@@ -32,20 +32,4 @@ describe StackerBee::GraylogFaradayMiddleware do
   end
 
   its([:facility]) { should == "stacker-bee" }
-
-  context "without a command in the url" do
-    let(:env) do
-      {
-        body: "DATA",
-        response_headers: {},
-        response: {},
-        status: status,
-        url: URI.parse("http://a.b/?key=KEY&&val=val")
-      }
-    end
-
-    it "sets a custom short message" do
-      log_data[:short_message].should eq "StackerBee"
-    end
-  end
 end

data/spec/units/stacker_bee/middleware/logger_spec.rb

@@ -0,0 +1,55 @@
+require "spec_helper"
+
+describe StackerBee::Middleware::Logger do
+  let(:app)        { double }
+  let(:io)         { StringIO.new }
+  let(:logger)     { Logger.new(io) }
+  let(:log_string) { io.string }
+  let(:middleware) { described_class.new app, logger }
+  subject { middleware }
+
+  context "with a no logger specified" do
+    let(:middleware) { described_class.new app, nil }
+    its(:logger) { should be_a Logger }
+  end
+
+  describe "logging request" do
+    let(:env) do
+      {
+        method:          "PATCH",
+        url:             "http://localhost",
+        request_headers: { "User-Agent" => "RSpec" }
+      }
+    end
+    before do
+      middleware.log_request(env)
+    end
+    subject { log_string }
+    it { should include "PATCH" }
+    it { should include "localhost" }
+    it { should include "User-Agent" }
+  end
+
+  describe "logging a response" do
+    let(:status) { 200 }
+    let(:env) do
+      {
+        status:           status,
+        body:             "OK",
+        response_headers: { "Server" => "RSpec" }
+      }
+    end
+    before do
+      middleware.log_response(env)
+    end
+    subject { log_string }
+    it { should =~ /INFO.*#{status}/ }
+    it { should include "OK" }
+    it { should include "Server" }
+
+    context "failing status" do
+      let(:status) { 401 }
+      it { should =~ /ERROR.*#{status}/ }
+    end
+  end
+end

data/spec/units/stacker_bee/request_error_spec.rb

@@ -1,9 +1,7 @@
 require "spec_helper"
 
 describe StackerBee::RequestError, ".for" do
-  let(:raw_response) do
-    double status: status, body: '{"foo": "bar"}', headers: {}
-  end
+  let(:raw_response) { double status: status, body: '{"foo": "bar"}' }
   subject { StackerBee::RequestError.for raw_response }
 
   context "HTTP status in the 400s" do
@@ -23,7 +21,7 @@ end
 describe StackerBee::RequestError do
   let(:http_status) { 431 }
   let(:message) do
-    "Unable to execute API command deployvirtualmachine " \
+    "Unable to execute API command deployvirtualmachine " +
     "due to missing parameter zoneid"
   end
   let(:raw_body) do
@@ -38,9 +36,7 @@ describe StackerBee::RequestError do
     }
     EOS
   end
-  let(:raw_response) do
-    double body: raw_body, :success? => false, status: 431, headers: {}
-  end
+  let(:raw_response) { double body: raw_body, :success? => false, status: 431 }
   let(:client_error) { StackerBee::ClientError.new raw_response }
   subject { client_error }
   its(:status) { should eq http_status }

data/spec/units/stacker_bee/response_spec.rb

@@ -2,12 +2,8 @@ require "spec_helper"
 
 describe StackerBee::Response do
   let(:raw_body)          { '{ "json": "here" }' }
-  let(:raw_response) do
-    double(body: raw_body, success?: true, headers: headers)
-  end
-  let(:response)     { StackerBee::Response.new raw_response }
-  let(:headers)      { { 'content-type' => content_type } }
-  let(:content_type) { "application/json; charset=UTF-8" }
+  let(:raw_response)  { double body: raw_body, :success? => true }
+  let(:response)      { StackerBee::Response.new raw_response }
   subject { response }
   its(:body) { should == 'here' }
 
@@ -48,8 +44,7 @@ describe StackerBee::Response do
       double(
         :body     => '{ "foo": "bar" }',
         :success? => false,
-        :status   => 431,
-        :headers  => {}
+        :status   => 431
       )
     end
     it { expect { subject }.to raise_exception StackerBee::ClientError }
@@ -67,8 +62,7 @@ describe StackerBee::Response do
           { "createprojectresponse" :
             {"uuidList":[],"errorcode":401,"errortext":"#{message}"} } ],
         success?: false,
-        status: 401,
-        headers: {}
+        status: 401
       )
     end
     let(:client_error) { StackerBee::AuthenticationError.new raw_response }
@@ -82,12 +76,4 @@ describe StackerBee::Response do
     end
   end
 
-  context "with an html response" do
-    let(:raw_body) { "<html><body>hi</body><html>" }
-    let(:content_type) { "text/html" }
-
-    it "returns the raw html without parsing" do
-      expect(response.body).to eq(raw_body)
-    end
-  end
 end

data/stacker_bee.gemspec

@@ -19,11 +19,10 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "faraday",            "~> 0.8", "< 0.9"
-  spec.add_runtime_dependency 'multi_json',         "~> 1.8"
-
+  spec.add_runtime_dependency "faraday",            "~> 0.8"
   # this is a dependency for FaradayMiddleware::Graylog
   spec.add_runtime_dependency "faraday_middleware", "~> 0.9"
+  spec.add_runtime_dependency 'multi_json',         "~> 1.8"
 
   spec.add_development_dependency "bundler",  "~> 1.3"
   spec.add_development_dependency "rake",     "~> 10.0"
@@ -32,7 +31,4 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "vcr",      "~> 2.6"
   spec.add_development_dependency "rubocop"
   spec.add_development_dependency "pry"
-
-  # Release every merge to master as a prerelease
-  spec.version = "#{spec.version}.pre#{ENV['TRAVIS_BUILD_NUMBER']}" if ENV['TRAVIS']
 end