stacked 0.5.0 → 1.0.0.beta1

data/lib/stacked/{usertimeline.rb → user_timeline.rb}

@@ -1,14 +1,14 @@
 module Stacked
-  # I would really *love* to call this UserTimeline but alas, the API fails me.
-  class Usertimeline < Base
+  # Stacked::UserTimeline class.
+  class UserTimeline < Base
     attr_accessor :action,
                   :comment_id,
                   :creation_date,
                   :description,
                   :detail,
                   :post_id,
-                  :timeline_type
-
-    alias_method :created_at, :creation_date
+                  :post_type,
+                  :timeline_type,
+                  :user_id
   end
 end

data/lib/stacked/version.rb

@@ -0,0 +1,4 @@
+module Stacked
+  # Stacked version number.
+  VERSION = '1.0.0.beta1'
+end

data/spec/sorted_by_spec.rb

@@ -1,6 +1,6 @@
-require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+require 'spec_helper'
 
-describe Spec::Matchers::Sortedby do
+describe RSpec::Matchers::SortedBy do
   before do
     @questions = []
     @questions << Stacked::Question.new(:last_edit_date => Time.now.to_i)

data/spec/spec_helper.rb

@@ -1,16 +1,18 @@
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+require 'rspec'
 require 'stacked'
-require 'spec'
-require 'spec/autorun'
-require 'fakeweb'
+require 'webmock'
 
-Dir["spec/support/**/*.rb"].each { |f| require f }
+Dir[File.dirname(__FILE__) + "/support/**/*.rb"].each { |f| require f }
 
 # Uncomment only for debugging as we only ever want to test against the real API.
 # At least, until it becomes stable.
 # FakeWeb.allow_net_connect = false
 
-Spec::Runner.configure do |config|
-
+RSpec.configure do |c|
+  c.include(WebMock::API)
+  c.before(:all) do
+    Stacked::Client.configure do |config|
+      config.api_key = "FAKE"
+    end
+  end
 end

data/spec/stacked/answer_spec.rb

@@ -1,4 +1,4 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Stacked::Answer do
   context "class methods" do
@@ -8,21 +8,22 @@ describe Stacked::Answer do
   end
 
   context "instance methods" do
+    before(:all) do
+      fake "answers/1237127", :query => { :body => true }
+      fake "questions/1236996"
+    end
+
     subject { Stacked::Answer.find(1237127, :body => true) }
+
     it "finds the user for an answer" do
-      subject.user.display_name.should eql("Daniel Vandersluis")
+      subject.owner.should be_is_a(Stacked::User)
+      subject.owner.display_name.should eql("Daniel Vandersluis")
     end
 
     it "finds the question for an answer" do
       subject.question.should be_is_a(Stacked::Question)
     end
 
-    aliases(:views      => :view_count,
-            :up_votes   => :up_vote_count,
-            :answer_id  => :id,
-            :created_at => :creation_date,
-            :updated_at => :last_edit_date)
-
     it "has a body" do
       subject.body.should_not be_blank
     end

data/spec/stacked/badge_spec.rb

@@ -1,9 +1,17 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Stacked::Badge do
   subject { Stacked::Badge }
+  
+  before :all do
+    fake "badges"
+    fake "badges/name"
+    fake "badges/tags"
+  end
+  
   it "finds all badges" do
-    subject.all.first.should be_is_a(Stacked::Badge)
+    badge = subject.all.first
+    badge.should be_is_a(Stacked::Badge)
   end
 
   it "finds all badges ordered by name" do
@@ -11,7 +19,7 @@ describe Stacked::Badge do
   end
 
   it "finds all badges based on tags" do
-    subject.tags.first.name.should eql(".net")
+    subject.tags.first.name.should eql(".htaccess")
   end
 
 end

data/spec/stacked/base_spec.rb

@@ -1,16 +1,25 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Stacked::Base do
   context "common methods" do
     # We cannot use Stacked::Base here obviously because SO does not have Bases!
     # So we use User instead.
     subject { Stacked::User }
+    
+    before(:all) do
+      fake "users"
+      fake "users/index-page2", :url_path => 'users', :query => { :page => 2 }
+      fake "users/index-pagesize1", :url_path => 'users', :query => { :pagesize => 1 }
+      fake "stats"
+    end
 
     it "retrieves a list of a resource" do
+      #pending("Crack::ParseError: Invalid JSON string")
       subject.all.all? { |u| u.is_a?(subject) }.should be_true
     end
 
     it "paginates through the resource" do
+      #pending("Crack::ParseError: Invalid JSON string")
       subject.all.first.should_not eql(subject.all(:page => 2).first)
     end
 
@@ -19,7 +28,20 @@ describe Stacked::Base do
     end
     
     it "stats" do
-      Stacked::Base.stats.keys.sort.should eql(["answers_per_minute", "api_version", "badges_per_minute", "questions_per_minute", "total_answers", "total_badges", "total_comments", "total_questions", "total_unanswered", "total_users", "total_votes"])
+      Stacked::Base.stats.keys.sort.should eql(["answers_per_minute",
+                                                "api_version",
+                                                "badges_per_minute",
+                                                "questions_per_minute",
+                                                "site",
+                                                "total_accepted",
+                                                "total_answers",
+                                                "total_badges",
+                                                "total_comments",
+                                                "total_questions",
+                                                "total_unanswered",
+                                                "total_users",
+                                                "total_votes",
+                                                "views_per_day"])
     end
 
   end

data/spec/stacked/comment_spec.rb

@@ -1,7 +1,13 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Stacked::Comment do
   subject { Stacked::Comment }
+  
+  before(:all) do
+    fake "comments/2561833"
+    fake "comments/1063043"
+    fake "answers/2558700" # referenced by subject.post
+  end
 
   context "class methods" do
 
@@ -12,25 +18,21 @@ describe Stacked::Comment do
     it "finds a single comment" do
       comment = Stacked::Comment.find(2561833)
       comment.should be_is_a(Stacked::Comment)
-      comment.owner_user_id.should eql(22656)
+      comment.owner.should be_is_a(Stacked::User)
+      comment.owner.user_id.should eql(22656)
     end
   end
 
   context "instance methods" do
     subject { Stacked::Comment.find(2561833) }
 
-    aliases(:comment_id => :id,
-            :created_at => :creation_date,
-            :owner      => :user,
-            :edits      => :edit_count)
-
     it "finds the related post for this comment" do
       subject.post.should be_is_a(Stacked::Answer)
     end
 
     it "finds who the comment was directed at, or nobody if nobody" do
-      Stacked::Comment.find(2561833).reply_to.should be_is_a(Stacked::User)
-      Stacked::Comment.find(1063043).reply_to.should be_nil
+      Stacked::Comment.find(2561833).reply_to_user.should be_is_a(Stacked::User)
+      Stacked::Comment.find(1063043).reply_to_user.should be_nil
     end
 
     it "finds the user who wrote the comment" do

data/spec/stacked/question_spec.rb

@@ -1,108 +1,96 @@
-require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+require 'spec_helper'
 
 describe Stacked::Question do
+  
   context "class methods" do
+    
     subject { Stacked::Question }
+    
+    before(:all) do
+      #fake "questions", :query => { :answers => true, :comments => true, :body => true }
+      
+      fake "questions"
+      fake "questions/withcomments", :url_path => 'questions', :query => { :comments => true }
+      
+      fake "questions/search", :url_path => 'search', :query => { :intitle => 'ImageMagick' }
+      fake "questions/unanswered"
+      fake "questions/4839321/answers"
+      fake "questions/tagged", :url_path => 'questions', :query => { :tagged => ["ruby", "ruby-on-rails"].join(';') }
+    end
+    
     it "gets a list of all questions" do
+      #pending("Crack::ParseError: Invalid JSON string")
       subject.all.all? { |q| q.is_a?(subject) }.should be_true
     end
-
+    
     it "gets a list of questions with comments" do
-      pending("Cannot currently get a list of questions with comments")
-      subject.all(:comments => true)
-    end
-
-    it "active" do
-      subject.active(:pagesize => 1).first.last_activity_date.should be_within(1.day)
-    end
-
-    it "newest" do
-      subject.newest(:pagesize => 1).first.creation_date.should be_within(1.day)
-    end
-
-    it "featured" do
-      (subject.featured(:pagesize => 1).first.bounty_closes_date > Time.now.to_i).should be_true
-    end
-
-    it "hot" do
-      # It was 3555 as of 3rd April 2010.
-      (subject.hot(:pagesize => 1).first.view_count > 3555).should be_true
+      subject.all(:comments => true).first.comments.should_not be_nil
     end
-
-    it "month" do
-      subject.month(:pagesize => 1).first.creation_date.should be_within(1.month)
-    end
-
-    it "week" do
-      subject.week(:pagesize => 1).first.creation_date.should be_within(1.week)
-    end
-
-    it "votes" do
-      subject.votes(:pagesize => 1).first.up_vote_count.should eql(1190)
+    
+    it "search" do
+      #pending("Endpoint appears to be broken at the time of testing. Always returning no results.")
+      question = subject.search(:intitle => 'ImageMagick').first
+      question.title.should =~ /ImageMagick/i
     end
 
-    it "unanswered by votes" do
-      question = subject.unanswered_by_votes(:pagesize => 1).first
+    it "unanswered" do
+      question = subject.unanswered.first
       question.should be_is_a(Stacked::Question)
       question.answers.should be_blank
     end
 
     it "tagged" do
-      question = subject.tagged(:tags => ["ruby", "ruby-on-rails"], :pagesize => 1).first
+      question = subject.all(:tagged => ["ruby", "ruby-on-rails"].join(';')).first
       question.tags.map(&:name).should include("ruby")
       question.tags.map(&:name).should include("ruby-on-rails")
     end
   end
 
   context "instance methods" do
-    subject { Stacked::Question.find(1236996, :comments => true, :body => true) }
-
-    aliases(
-            :created_at => :creation_date,
-            :down_votes => :down_vote_count,
-            :favorites  => :favorite_count,
-            :favourites => :favorite_count,
-            :id         => :question_id,
-            :updated_at => :last_edit_date,
-            :up_votes   => :up_vote_count,
-            :user       => :owner,
-            :views      => :view_count
-            )
-
+    before(:all) do
+      fake "questions/1236996", :query => { :answers => true, :comments => true, :body => true }
+      fake "questions/1236996-comments", :url_path => 'questions/1236996/comments' # question.comments
+      fake "questions/1236996-answers", :url_path => 'questions/1236996/answers' # question.answers
+      fake "questions/1236996-timeline", :url_path => 'questions/1236996/timeline' # question.timeline
+      fake "answers/1237127" # question.accepted_answer
+      
+      # Ensure only one API request per resouce
+      @question = Stacked::Question.find(1236996, :answers => true, :comments => true, :body => true)
+    end
 
     it "is the right question" do
-      subject.title.should eql("Calculating the distance between two times")
+      @question.title.should eql("Calculating the distance between two times")
     end
 
     it "has a body" do
-      subject.body.should_not be_blank
+      @question.body.should_not be_blank
     end
-
+    
     it "retreives comments" do
-      subject.comments.should_not be_empty
-      subject.comments.first.should be_is_a(Stacked::Comment)
+      @question.comments.should_not be_empty
+      @question.comments.first.should be_is_a(Stacked::Comment)
     end
 
     it "retreives answers" do
-      subject.answers.should_not be_empty
-      subject.answers.first.should be_is_a(Stacked::Answer)
+      @question.answers.should_not be_empty
+      @question.answers.first.should be_is_a(Stacked::Answer)
     end
 
     it "retreives tags" do
-      subject.tags.should_not be_empty
-      subject.tags.first.should be_is_a(Stacked::Tag)
+      @question.tags.should_not be_empty
+      @question.tags.first.should be_is_a(Stacked::Tag)
     end
 
     it "finds the user for a question" do
-      subject.user.should be_is_a(Stacked::User)
+      @question.owner.should be_is_a(Stacked::User)
     end
 
     it "finds the accepted answer" do
-      subject.accepted_answer.should be_is_a(Stacked::Answer)
+      @question.accepted_answer.should be_is_a(Stacked::Answer)
     end
 
     it "shows the timeline of the question" do
-      subject.timeline.first.should be_is_a(Stacked::Posttimeline)
+      @question.timeline.first.should be_is_a(Stacked::PostTimeline)
     end
 
   end