stackable_flash 0.0.3 → 0.0.4

data/README.md

@@ -31,13 +31,13 @@ In an environment file, or application.rb
     # You can use a lambda instead of a proc
     StackableFlash::Config.configure do
       # Leave it as an array
-      config[:stack_with_proc] = Proc.new {|arr| arr } )
+      config[:stack_with_proc] = Proc.new {|arr| arr }
       # Make a set of statements separated by br tags
-      config[:stack_with_proc] = Proc.new {|arr| arr.join('<br/>') } )   # THIS IS DEFAULT IF LEFT UNCONFIGURED
+      config[:stack_with_proc] = Proc.new {|arr| arr.join('<br/>') }   # THIS IS DEFAULT IF LEFT UNCONFIGURED
       # Make a set of p tags:
-      config[:stack_with_proc] = Proc.new {|arr| arr.map! {|x| "<p>#{x}</p>"}.join } } )
+      config[:stack_with_proc] = Proc.new {|arr| arr.map! {|x| "<p>#{x}</p>"}.join }
       # Make an unordered list of tags:
-      config[:stack_with_proc] = Proc.new {|arr| '<ul>' + arr.map! {|x| "<li>#{x}</li>"}.join + '</ul> } } )
+      config[:stack_with_proc] = Proc.new {|arr| '<ul>' + arr.map! {|x| "<li>#{x}</li>"}.join + '</ul>' }
     end
 
 ## Usage
@@ -96,10 +96,21 @@ And
       flash[:notice].stack  # => NoMethodError !!!
     end
 
+## Sightings
+
+This gem is used by the cacheable_flash gem to provide stacking flashes.  You can check it out for a working example.
+
 ## Contributing
 
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Added some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+5. Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
+6. Create new Pull Request
+
+== Copyright
+
+Licensed under the MIT License.
+
+- Copyright (c) 2012 Peter H. Boling (http://peterboling.com). See LICENSE for further details.

data/lib/stackable_flash/stack_layer.rb

@@ -5,9 +5,26 @@ module StackableFlash
     def self.included(base)
       base.class_eval do
         alias_method_chain :[]=, :stacking
+        alias_method_chain :[], :stacking
       end
     end
 
+    define_method "[]_with_stacking" do |key|
+      if StackableFlash.stacking
+        #Do it in a non-stacking block so we get normal behavior from flash[:notice] calls
+        StackableFlash.not_stacked do
+          actual = send("[]_without_stacking", key)
+          if actual.nil?
+            send("[]_with_stacking=", key, StackableFlash::FlashStack.new)
+          end
+        end
+      else
+        # All StackableFlash functionality is completely bypassed
+        send("[]_without_stacking", key)
+      end
+      return send("[]_without_stacking", key)
+    end
+
     define_method "[]_with_stacking=" do |key, value|
       if StackableFlash.stacking
         # Do it in a non-stacking block so we get normal behavior from flash[:notice] calls

data/lib/stackable_flash/version.rb

@@ -1,3 +1,3 @@
 module StackableFlash
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/controllers/dummy_controller_spec.rb

@@ -4,18 +4,27 @@ describe DummyController do
 
   render_views
 
+  it "should handle multiple keys" do
+    get :multiple_keys
+    controller.flash[:notice].should == ['This is a Notice']
+    controller.flash[:errors].should == ['This is an Error']
+  end
+
   it "should override" do
     get :override
+    controller.flash[:notice].should_not == ['original']
     controller.flash[:notice].should == ['message']
   end
 
-  it "should build a stack" do
+  it "should stack" do
     get :stack
     controller.flash[:notice].should == ['original','message','another']
+    controller.flash[:notice].stack.should == 'original<br/>message<br/>another'
   end
 
-  it "should allow transformation" do
-    get :stack
+  it "should cold boot" do
+    get :cold_boot
+    controller.flash[:notice].should == ['original','message','another']
     controller.flash[:notice].stack.should == 'original<br/>message<br/>another'
   end
 

data/spec/dummy/app/controllers/dummy_controller.rb

@@ -1,14 +1,29 @@
 class DummyController < ApplicationController
-  include StackableFlash
+
+  def multiple_keys
+    flash[:notice] = 'This is a Notice'
+    flash[:errors] = 'This is an Error'
+    render :text => 'Foo'
+  end
+
   def override
     flash[:notice] = 'original'
     flash[:notice] = 'message'
+    render :text => 'Foo'
   end
 
   def stack
     flash[:notice] = 'original'
     flash[:notice] << 'message'
     flash[:notice] << 'another'
+    render :text => 'Foo'
+  end
+
+  def cold_boot
+    flash[:notice] << 'original'
+    flash[:notice] << 'message'
+    flash[:notice] << 'another'
+    render :text => 'Foo'
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stackable_flash
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-21 00:00:00.000000000 Z
+date: 2012-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails