stack_master 2.17.0 → 2.18.0

data/lib/stack_master/parameter_resolvers/env.rb

@@ -1,7 +1,6 @@
 module StackMaster
   module ParameterResolvers
     class Env < Resolver
-
       def initialize(config, stack_definition)
         @config = config
         @stack_definition = stack_definition
@@ -10,9 +9,9 @@ module StackMaster
       def resolve(value)
         environment_variable = ENV[value]
         raise ArgumentError, "The environment variable #{value} is not set" if environment_variable.nil?
+
         environment_variable
       end
-
     end
   end
 end

data/lib/stack_master/parameter_resolvers/latest_ami_by_tags.rb

@@ -10,7 +10,7 @@ module StackMaster
       end
 
       def resolve(value)
-        filters = @ami_finder.build_filters_from_string(value, prefix = "tag")
+        filters = @ami_finder.build_filters_from_string(value, prefix = 'tag')
         @ami_finder.find_latest_ami(filters)&.image_id
       end
     end

data/lib/stack_master/parameter_resolvers/latest_container.rb

@@ -10,7 +10,7 @@ module StackMaster
 
       def resolve(parameters)
         if parameters['repository_name'].nil?
-          raise ArgumentError, "repository_name parameter is required but was not supplied"
+          raise ArgumentError, 'repository_name parameter is required but was not supplied'
         end
 
         @region = parameters['region'] || @stack_definition.region
@@ -28,7 +28,8 @@ module StackMaster
         latest_image = images.first
 
         # aws_account_id.dkr.ecr.region.amazonaws.com/repository@sha256:digest
-        "#{latest_image.registry_id}.dkr.ecr.#{@region}.amazonaws.com/#{parameters['repository_name']}@#{latest_image.image_digest}"
+        "#{latest_image.registry_id}.dkr.ecr.#{@region}.amazonaws.com/#{parameters['repository_name']}@" \
+        "#{latest_image.image_digest}"
       end
 
       private
@@ -36,15 +37,16 @@ module StackMaster
       def fetch_images(repository_name, registry_id, ecr)
         images = []
         next_token = nil
-        while
-          resp = ecr.describe_images({
+        while resp = ecr.describe_images(
+          {
             repository_name: repository_name,
             registry_id: registry_id,
             next_token: next_token,
             filter: {
-              tag_status: "TAGGED",
-            },
-          })
+              tag_status: 'TAGGED'
+            }
+          }
+        )
 
           images += resp.image_details
           next_token = resp.next_token

data/lib/stack_master/parameter_resolvers/one_password.rb

@@ -13,15 +13,19 @@ module StackMaster
         @stack_definition = stack_definition
       end
 
-      def resolve(params={})
-        raise OnePasswordNotAbleToAuthenticate, "1password requires the `OP_SESSION_<name>` to be set, (remember to sign in?)" if ENV.keys.grep(/OP_SESSION_\w+$/).empty?    
+      def resolve(params = {})
+        if ENV.keys.grep(/OP_SESSION_\w+$/).empty?
+          raise OnePasswordNotAbleToAuthenticate,
+                '1password requires the `OP_SESSION_<name>` to be set, (remember to sign in?)'
+        end
+
         get_items(params)
       end
 
       private
 
       def validate_op_installed?
-        %x(op --version)
+        `op --version`
       rescue Errno::ENOENT => exception
         raise OnePasswordBinaryNotFound, "The op cli needs to be installed and in the PATH, #{exception}"
       end
@@ -40,7 +44,7 @@ module StackMaster
       end
 
       def password_item(data)
-        data.details.password 
+        data.details.password
       end
 
       def login_item(data)
@@ -49,7 +53,7 @@ module StackMaster
 
       def op_get_item(item, vault)
         validate_op_installed?
-        item = %x(op get item --vault='#{vault}' '#{item}' 2>&1)
+        item = `op get item --vault='#{vault}' '#{item}' 2>&1`
         item if validate_response?(item)
       end
 
@@ -75,9 +79,9 @@ module StackMaster
       def get_items(params)
         case params['type']
         when 'password'
-          return get_password(params['title'], params['vault'])
+          get_password(params['title'], params['vault'])
         when 'secureNote'
-          return get_secure_note(params['title'], params['vault'])
+          get_secure_note(params['title'], params['vault'])
         end
       end
     end

data/lib/stack_master/parameter_resolvers/parameter_store.rb

@@ -1,7 +1,6 @@
 module StackMaster
   module ParameterResolvers
     class ParameterStore < Resolver
-
       ParameterNotFound = Class.new(StandardError)
 
       def initialize(config, stack_definition)
@@ -12,10 +11,7 @@ module StackMaster
       def resolve(value)
         begin
           ssm = Aws::SSM::Client.new({ region: @stack_definition.region })
-          resp = ssm.get_parameter({
-            name: value,
-            with_decryption: true
-          })
+          resp = ssm.get_parameter({ name: value, with_decryption: true })
         rescue Aws::SSM::Errors::ParameterNotFound
           raise ParameterNotFound, "Unable to find #{value} in Parameter Store"
         end

data/lib/stack_master/parameter_resolvers/security_group.rb

@@ -12,7 +12,7 @@ module StackMaster
         security_group_finder.find(value)
       end
 
-    private
+      private
 
       def security_group_finder
         StackMaster::SecurityGroupFinder.new(@stack_definition.region)

data/lib/stack_master/parameter_resolvers/sso_group_id.rb

@@ -12,9 +12,10 @@ module StackMaster
         sso_group_id_finder.find(value)
       end
 
-    private
+      private
+
       def sso_group_id_finder
-        StackMaster::SsoGroupIdFinder.new()
+        StackMaster::SsoGroupIdFinder.new
       end
     end
   end

data/lib/stack_master/parameter_resolvers/stack_output.rb

@@ -17,16 +17,14 @@ module StackMaster
       def resolve(value)
         region, stack_name, output_name = parse!(value)
         stack = find_stack(stack_name, region)
-        if stack
-          output = stack.outputs.find { |stack_output| stack_output.output_key == output_name.camelize || stack_output.output_key == output_name }
-          if output
-            output.output_value
-          else
-            raise StackOutputNotFound, "Stack exists (#{stack_name}), but output does not: #{output_name}"
-          end
-        else
-          raise StackNotFound, "Stack in StackOutput not found: #{value}"
+        raise StackNotFound, "Stack in StackOutput not found: #{value}" unless stack
+
+        output = stack.outputs.find do |stack_output|
+          stack_output.output_key == output_name.camelize || stack_output.output_key == output_name
         end
+        raise StackOutputNotFound, "Stack exists (#{stack_name}), but output does not: #{output_name}" unless output
+
+        output.output_value
       end
 
       private

data/lib/stack_master/parameter_validator.rb

@@ -9,15 +9,12 @@ module StackMaster
 
     def error_message
       return nil unless missing_parameters?
+
       message = "Empty/blank parameters detected. Please provide values for these parameters:\n"
       missing_parameters.each do |parameter_name|
         message << " - #{parameter_name}\n"
       end
-      if @stack_definition.parameter_files.empty?
-        message << message_for_parameter_globs
-      else
-        message << message_for_parameter_files
-      end
+      message << (@stack_definition.parameter_files.empty? ? message_for_parameter_globs : message_for_parameter_files)
       message
     end
 

data/lib/stack_master/prompter.rb

@@ -4,18 +4,19 @@ module StackMaster
   module Prompter
     def ask?(question)
       StackMaster.stdout.print question
-      answer = if StackMaster.interactive?
-        if StackMaster.stdin.tty? && StackMaster.stdout.tty?
-          StackMaster.stdin.getch.chomp
+      answer =
+        if StackMaster.interactive?
+          if StackMaster.stdin.tty? && StackMaster.stdout.tty?
+            StackMaster.stdin.getch.chomp
+          else
+            StackMaster.stdout.puts
+            StackMaster.stdout.puts 'STDOUT or STDIN was not a TTY. Defaulting to no. To force yes use -y'
+            'n'
+          end
         else
-          StackMaster.stdout.puts
-          StackMaster.stdout.puts "STDOUT or STDIN was not a TTY. Defaulting to no. To force yes use -y"
-          'n'
+          print StackMaster.non_interactive_answer
+          StackMaster.non_interactive_answer
         end
-      else
-        print StackMaster.non_interactive_answer
-        StackMaster.non_interactive_answer
-      end
       StackMaster.stdout.puts
       answer == 'y'
     end

data/lib/stack_master/resolver_array.rb

@@ -13,13 +13,13 @@ module StackMaster
       end
 
       def resolver_class
-        fail "Method resolver_class not implemented on #{self.class}"
+        raise "Method resolver_class not implemented on #{self.class}"
       end
     end
 
     class Resolver
       def self.array_resolver(options = {})
-        resolver_class ||= Object.const_get(self.name)
+        resolver_class ||= Object.const_get(name)
         array_resolver_class_name = options[:class_name] || resolver_class.to_s.demodulize.pluralize
 
         klass = Class.new(ResolverArray) do
@@ -32,4 +32,3 @@ module StackMaster
     end
   end
 end
-

data/lib/stack_master/role_assumer.rb

@@ -44,11 +44,13 @@ module StackMaster
     def assume_role_credentials(account, role)
       credentials_key = "#{account}:#{role}"
       @credentials.fetch(credentials_key) do
-        @credentials[credentials_key] = Aws::AssumeRoleCredentials.new({
-          region: StackMaster.cloud_formation_driver.region,
-          role_arn: "arn:aws:iam::#{account}:role/#{role}",
-          role_session_name: "stack-master-role-assumer"
-        })
+        @credentials[credentials_key] = Aws::AssumeRoleCredentials.new(
+          {
+            region: StackMaster.cloud_formation_driver.region,
+            role_arn: "arn:aws:iam::#{account}:role/#{role}",
+            role_session_name: 'stack-master-role-assumer'
+          }
+        )
       end
     end
   end

data/lib/stack_master/security_group_finder.rb

@@ -8,15 +8,17 @@ module StackMaster
     end
 
     def find(reference)
-      raise ArgumentError, 'Security group references must be non-empty strings' unless reference.is_a?(String) && !reference.empty?
+      unless reference.is_a?(String) && !reference.empty?
+        raise ArgumentError, 'Security group references must be non-empty strings'
+      end
 
       groups = @resource.security_groups({
                                            filters: [
                                              {
-                                               name: "group-name",
-                                               values: [reference],
-                                             },
-                                           ],
+                                               name: 'group-name',
+                                               values: [reference]
+                                             }
+                                           ]
                                          })
 
       raise SecurityGroupNotFound, "No security group with name #{reference} found" unless groups.any?

data/lib/stack_master/sns_topic_finder.rb

@@ -7,7 +7,9 @@ module StackMaster
     end
 
     def find(reference)
-      raise ArgumentError, 'SNS topic references must be non-empty strings' unless reference.is_a?(String) && !reference.empty?
+      unless reference.is_a?(String) && !reference.empty?
+        raise ArgumentError, 'SNS topic references must be non-empty strings'
+      end
 
       topic = @resource.topics.detect { |t| topic_name_from_arn(t.arn) == reference }
 
@@ -19,8 +21,7 @@ module StackMaster
     private
 
     def topic_name_from_arn(arn)
-      arn.split(":")[5]
+      arn.split(':')[5]
     end
-
   end
 end

data/lib/stack_master/sparkle_formation/compile_time/allowed_pattern_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class AllowedPatternValidator < ValueValidator
-
         KEY = :allowed_pattern
 
         def initialize(name, definition, parameter)
@@ -17,18 +16,18 @@ module StackMaster
 
         def check_is_valid
           return true unless @definition.key?(KEY)
+
           invalid_values.empty?
         end
 
         def invalid_values
           values = build_values(@definition, @parameter)
-          values.reject { |value| value.to_s.match(%r{#{@definition[KEY]}}) }
+          values.reject { |value| value.to_s.match(/#{@definition[KEY]}/) }
         end
 
         def create_error
           "#{@name}:#{invalid_values} does not match #{KEY}:#{@definition[KEY]}"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/allowed_values_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class AllowedValuesValidator < ValueValidator
-
         KEY = :allowed_values
 
         def initialize(name, definition, parameter)
@@ -17,20 +16,20 @@ module StackMaster
 
         def check_is_valid
           return true unless @definition.key?(KEY)
+
           invalid_values.empty?
         end
 
         def invalid_values
           values = build_values(@definition, @parameter)
           values.reject do |value|
-            @definition[KEY].any? { |allowed_value| allowed_value.to_s == value.to_s}
+            @definition[KEY].any? { |allowed_value| allowed_value.to_s == value.to_s }
           end
         end
 
         def create_error
           "#{@name}:#{invalid_values} is not in #{KEY}:#{@definition[KEY]}"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/definitions_validator.rb

@@ -4,16 +4,17 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class DefinitionsValidator
-
-        VALID_TYPES = [:string, :number]
+        VALID_TYPES = %i[string number]
         def initialize(definitions)
           @definitions = definitions
         end
 
         def validate
-          @definitions.each do|name, definition|
+          @definitions.each do |name, definition|
             type = definition[:type]
-            raise ArgumentError.new "Unknown compile time parameter type: #{create_error(name, type)}" unless is_valid(type)
+            unless is_valid(type)
+              raise ArgumentError.new "Unknown compile time parameter type: #{create_error(name, type)}"
+            end
           end
         end
 
@@ -26,8 +27,7 @@ module StackMaster
         def create_error(name, type)
           "#{name}:#{type} valid types are #{VALID_TYPES}"
         end
-
       end
     end
   end
-end
+end

data/lib/stack_master/sparkle_formation/compile_time/empty_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class EmptyValidator < ValueValidator
-
         def initialize(name, definition, parameter)
           @name = name
           @definition = definition
@@ -25,7 +24,6 @@ module StackMaster
         def create_error
           "#{@name} cannot contain empty parameters:#{@parameter.inspect}"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/max_length_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class MaxLengthValidator < ValueValidator
-
         KEY = :max_length
 
         def initialize(name, definition, parameter)
@@ -18,6 +17,7 @@ module StackMaster
         def check_is_valid
           return true unless @definition[:type] == :string
           return true unless @definition.key?(KEY)
+
           invalid_values.empty?
         end
 
@@ -29,7 +29,6 @@ module StackMaster
         def create_error
           "#{@name}:#{invalid_values} must not exceed #{KEY}:#{@definition[KEY]} characters"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/max_size_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class MaxSizeValidator < ValueValidator
-
         KEY = :max_size
 
         def initialize(name, definition, parameter)
@@ -18,6 +17,7 @@ module StackMaster
         def check_is_valid
           return true unless @definition[:type] == :number
           return true unless @definition.key?(KEY)
+
           invalid_values.empty?
         end
 
@@ -29,7 +29,6 @@ module StackMaster
         def create_error
           "#{@name}:#{invalid_values} must not be greater than #{KEY}:#{@definition[KEY]}"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/min_length_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class MinLengthValidator < ValueValidator
-
         KEY = :min_length
 
         def initialize(name, definition, parameter)
@@ -18,18 +17,18 @@ module StackMaster
         def check_is_valid
           return true unless @definition[:type] == :string
           return true unless @definition.key?(KEY)
+
           invalid_values.empty?
         end
 
         def invalid_values
           values = build_values(@definition, @parameter)
-          values.select { |value| value.length < @definition[KEY].to_i}
+          values.select { |value| value.length < @definition[KEY].to_i }
         end
 
         def create_error
           "#{@name}:#{invalid_values} must be at least #{KEY}:#{@definition[KEY]} characters"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/min_size_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class MinSizeValidator < ValueValidator
-
         KEY = :min_size
 
         def initialize(name, definition, parameter)
@@ -18,18 +17,18 @@ module StackMaster
         def check_is_valid
           return true unless @definition[:type] == :number
           return true unless @definition.key?(KEY)
+
           invalid_values.empty?
         end
 
         def invalid_values
           values = build_values(@definition, @parameter)
-          values.select { |value| value.to_f < @definition[KEY].to_f}
+          values.select { |value| value.to_f < @definition[KEY].to_f }
         end
 
         def create_error
           "#{@name}:#{invalid_values} must not be lesser than #{KEY}:#{@definition[KEY]}"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/number_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class NumberValidator < ValueValidator
-
         def initialize(name, definition, parameter)
           @name = name
           @definition = definition
@@ -15,6 +14,7 @@ module StackMaster
 
         def check_is_valid
           return true unless @definition[:type] == :number
+
           invalid_values.empty?
         end
 
@@ -28,7 +28,6 @@ module StackMaster
         def create_error
           "#{@name}:#{invalid_values} are not Numbers"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/parameters_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class ParametersValidator
-
         def initialize(definitions, parameters)
           @definitions = definitions
           @parameters = parameters

data/lib/stack_master/sparkle_formation/compile_time/state_builder.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class StateBuilder
-
         def initialize(definitions, parameters)
           @definitions = definitions
           @parameters = parameters
@@ -25,7 +24,6 @@ module StackMaster
         def create_value(definition, parameter)
           ValueBuilder.new(definition, parameter).build
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/string_validator.rb

@@ -4,7 +4,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class StringValidator < ValueValidator
-
         def initialize(name, definition, parameter)
           @name = name
           @definition = definition
@@ -15,18 +14,18 @@ module StackMaster
 
         def check_is_valid
           return true unless @definition[:type] == :string
+
           invalid_values.empty?
         end
 
         def invalid_values
           values = build_values(@definition, @parameter)
-          values.reject { |value| value.is_a?(String)}
+          values.reject { |value| value.is_a?(String) }
         end
 
         def create_error
           "#{@name}:#{invalid_values} are not Strings"
         end
-
       end
     end
   end

data/lib/stack_master/sparkle_formation/compile_time/value_builder.rb

@@ -2,7 +2,6 @@ module StackMaster
   module SparkleFormation
     module CompileTime
       class ValueBuilder
-
         def initialize(definition, parameter)
           @definition = definition
           @parameter = parameter
@@ -22,18 +21,17 @@ module StackMaster
         end
 
         def convert_strings_to_array
-          if @definition[:multiple] && @value.is_a?(String)
-            @value = @value.split(',').map(&:strip)
-          end
+          return unless @definition[:multiple] && @value.is_a?(String)
+
+          @value = @value.split(',').map(&:strip)
         end
 
         def convert_strings_to_numbers
-          if @definition[:type] == :number
-            @value = @value.to_f if @value.is_a?(String)
-            @value = @value.map { |item| item.is_a?(String) ? item.to_f : item } if @value.is_a?(Array)
-          end
-        end
+          return if @definition[:type] != :number
 
+          @value = @value.to_f if @value.is_a?(String)
+          @value = @value.map { |item| item.is_a?(String) ? item.to_f : item } if @value.is_a?(Array)
+        end
       end
     end
   end