stack_master 0.0.4 → 0.1.0

data/features/status.feature

@@ -61,15 +61,9 @@ Feature: Status command
 {
 }
       """
-    And I set the environment variables to:
-      | variable | value |
-      | STUB_AWS | true  |
 
   Scenario: Run status command and get a list of stack statuii
-    Given I set the environment variables to:
-      | variable | value |
-      | ANSWER   | y     |
-    And I stub the following stacks:
+    Given I stub the following stacks:
       | stack_id | stack_name | parameters     | region    | stack_status    |
       |        1 | stack1     | KeyName=my-key | us-east-1 | CREATE_COMPLETE |
       |        2 | stack2     |                | us-east-1 | UPDATE_COMPLETE |
@@ -112,7 +106,7 @@ Feature: Status command
 }
       """
 
-    When I run `stack_master status --trace` interactively
+    When I run `stack_master status --trace`
     And the output should contain all of these lines:
       | REGION    \| STACK_NAME \| STACK_STATUS    \| DIFFERENT |
       | ----------\|------------\|-----------------\|---------- |

data/features/step_definitions/stack_steps.rb

@@ -1,3 +1,11 @@
+Before do
+  StackMaster.non_interactive_answer = 'y'
+end
+
+Given(/^I will answer prompts with "([^"]*)"$/) do |answer|
+  StackMaster.non_interactive_answer = answer
+end
+
 Given(/^I stub the following stack events:$/) do |table|
   table.hashes.each do |row|
     row.symbolize_keys!
@@ -48,3 +56,11 @@ Then(/^the stack "([^"]*)" should contain this notification ARN "([^"]*)"$/) do
   expect(stack).to be
   expect(stack.notification_arns).to include notification_arn
 end
+
+Given(/^I stub CloudFormation validate calls to pass validation$/) do
+  allow(StackMaster.cloud_formation_driver).to receive(:validate_template).and_return(true)
+end
+
+Given(/^I stub CloudFormation validate calls to fail validation with message "([^"]*)"$/) do |message|
+  allow(StackMaster.cloud_formation_driver).to receive(:validate_template).and_raise(Aws::CloudFormation::Errors::ValidationError.new('', message))
+end

data/features/support/env.rb

@@ -3,6 +3,7 @@ require 'stack_master'
 require 'stack_master/testing'
 require 'aruba/in_process'
 require 'pry'
+require 'cucumber/rspec/doubles'
 
 Aruba.configure do |config|
   config.command_launcher = :in_process

data/features/validate.feature

@@ -0,0 +1,46 @@
+Feature: Validate command
+
+  Background:
+    Given a file named "stack_master.yml" with:
+      """
+      stacks:
+        us_east_1:
+          stack1:
+            template: stack1.json
+      """
+    And a directory named "parameters"
+    And a file named "parameters/stack1.yml" with:
+      """
+      InstanceTypeParameter: my-type
+      """
+    And a directory named "templates"
+    And a file named "templates/stack1.json" with:
+      """
+{
+  "AWSTemplateFormatVersion": "2010-09-09",
+  "Description": "Test template",
+  "Parameters": {
+    "InstanceTypeParameter" : { "Type" : "String" }
+  },
+  "Mappings": {},
+  "Resources": {
+    "MyAwesomeQueue" : {
+      "Type" : "AWS::SQS::Queue",
+      "Properties" : {
+        "VisibilityTimeout" : "1"
+      }
+    }
+  },
+  "Outputs": {}
+}
+      """
+
+  Scenario: Validate successfully
+    Given I stub CloudFormation validate calls to pass validation
+    And I run `stack_master validate us-east-1 stack1`
+    Then the output should contain "stack1: valid"
+
+  Scenario: Validate unsuccessfully
+    Given I stub CloudFormation validate calls to fail validation with message "Blah"
+    And I run `stack_master validate us-east-1 stack1`
+    Then the output should contain "stack1: invalid. Blah"

data/lib/stack_master.rb

@@ -26,6 +26,7 @@ require "stack_master/sns_topic_finder"
 require "stack_master/security_group_finder"
 require "stack_master/parameter_loader"
 require "stack_master/parameter_resolver"
+require "stack_master/resolver_array"
 require "stack_master/parameter_resolvers/stack_output"
 require "stack_master/parameter_resolvers/secret"
 require "stack_master/parameter_resolvers/sns_topic_name"
@@ -35,6 +36,7 @@ require "stack_master/utils"
 require "stack_master/config"
 require "stack_master/stack_definition"
 require "stack_master/template_compiler"
+require "stack_master/commands/terminal_helper"
 require "stack_master/commands/apply"
 require "stack_master/commands/events"
 require "stack_master/commands/outputs"
@@ -52,6 +54,21 @@ require "stack_master/cli"
 module StackMaster
   extend self
 
+  def interactive?
+    !non_interactive?
+  end
+
+  def non_interactive?
+    @non_interactive || false
+  end
+
+  def non_interactive!
+    @non_interactive = true
+  end
+
+  attr_accessor :non_interactive_answer
+  @non_interactive_answer = 'y'
+
   def base_dir
     File.expand_path(File.join(File.dirname(__FILE__), ".."))
   end
@@ -72,6 +89,10 @@ module StackMaster
     @stdout = io
   end
 
+  def stdin
+    $stdin
+  end
+
   def stderr
     @stderr || $stderr
   end

data/lib/stack_master/aws_driver/cloud_formation.rb

@@ -11,7 +11,9 @@ module StackMaster
       end
 
       def describe_stacks(options)
-        cf.describe_stacks(options)
+        retry_with_backoff do
+          cf.describe_stacks(options)
+        end
       end
 
       def cancel_update_stack(options)
@@ -51,6 +53,23 @@ module StackMaster
       def cf
         @cf ||= Aws::CloudFormation::Client.new(region: @region)
       end
+
+      def retry_with_backoff
+        delay       = 1
+        max_delay   = 30
+        begin
+          yield
+        rescue Aws::CloudFormation::Errors::Throttling => e
+          if e.message =~ /Rate exceeded/
+            sleep delay
+            delay *= 2
+            if delay > max_delay
+              delay = max_delay
+            end
+            retry
+          end
+        end
+      end
     end
   end
 end

data/lib/stack_master/cli.rb

@@ -12,12 +12,24 @@ module StackMaster
       TablePrint::Config.io = StackMaster.stdout
     end
 
+    def default_config_file
+      "stack_master.yml"
+    end
+
     def execute!
       program :name, 'StackMaster'
       program :version, '0.0.1'
       program :description, 'AWS Stack Management'
 
-      global_option '-c', '--config FILE', 'Config file to use'
+      global_option '-c', '--config FILE', String, 'Config file to use'
+      global_option '-y', '--yes', 'Run in non-interactive mode answering yes to any prompts' do
+        StackMaster.non_interactive!
+        StackMaster.non_interactive_answer = 'y'
+      end
+      global_option '-n', '--no', 'Run in non-interactive mode answering no to any prompts' do
+        StackMaster.non_interactive!
+        StackMaster.non_interactive_answer = 'n'
+      end
 
       command :apply do |c|
         c.syntax = 'stack_master apply [region_or_alias] [stack_name]'
@@ -25,7 +37,8 @@ module StackMaster
         c.description = "Creates or updates a stack. Shows a diff of the proposed stack's template and parameters. Tails stack events until CloudFormation has completed."
         c.example 'update a stack named myapp-vpc in us-east-1', 'stack_master apply us-east-1 myapp-vpc'
         c.action do |args, options|
-          execute_stack_command(StackMaster::Commands::Apply, args, options)
+          options.defaults config: default_config_file
+          execute_stacks_command(StackMaster::Commands::Apply, args, options)
         end
       end
 
@@ -34,7 +47,8 @@ module StackMaster
         c.summary = 'Displays outputs for a stack'
         c.description = "Displays outputs for a stack"
         c.action do |args, options|
-          execute_stack_command(StackMaster::Commands::Outputs, args, options)
+          options.defaults config: default_config_file
+          execute_stacks_command(StackMaster::Commands::Outputs, args, options)
         end
       end
 
@@ -44,6 +58,7 @@ module StackMaster
         c.description = 'Initialises the expected directory structure and stack_master.yml file'
         c.option('--overwrite', 'Overwrite existing files')
         c.action do |args, options|
+          options.defaults config: default_config_file
           unless args.size == 2
             say "Invalid arguments. stack_master init [region] [stack_name]"
           else
@@ -58,7 +73,8 @@ module StackMaster
         c.description = "Shows a diff of the proposed stack's template and parameters"
         c.example 'diff a stack named myapp-vpc in us-east-1', 'stack_master diff us-east-1 myapp-vpc'
         c.action do |args, options|
-          execute_stack_command(StackMaster::Commands::Diff, args, options)
+          options.defaults config: default_config_file
+          execute_stacks_command(StackMaster::Commands::Diff, args, options)
         end
       end
 
@@ -71,7 +87,8 @@ module StackMaster
         c.option '--all', 'Show all events'
         c.option '--tail', 'Tail events'
         c.action do |args, options|
-          execute_stack_command(StackMaster::Commands::Events, args, options)
+          options.defaults config: default_config_file
+          execute_stacks_command(StackMaster::Commands::Events, args, options)
         end
       end
 
@@ -80,7 +97,8 @@ module StackMaster
         c.summary = "Shows stack resources"
         c.description = "Shows stack resources"
         c.action do |args, options|
-          execute_stack_command(StackMaster::Commands::Resources, args, options)
+          options.defaults config: default_config_file
+          execute_stacks_command(StackMaster::Commands::Resources, args, options)
         end
       end
 
@@ -89,6 +107,7 @@ module StackMaster
         c.summary = 'List stack definitions'
         c.description = 'List stack definitions'
         c.action do |args, options|
+          options.defaults config: default_config_file
           say "Invalid arguments." if args.size > 0
           config = load_config(options.config)
           StackMaster::Commands::ListStacks.perform(config)
@@ -101,7 +120,8 @@ module StackMaster
         c.description = 'Validate a template'
         c.example 'validate a stack named myapp-vpc in us-east-1', 'stack_master validate us-east-1 myapp-vpc'
         c.action do |args, options|
-          execute_stack_command(StackMaster::Commands::Validate, args, options)
+          options.defaults config: default_config_file
+          execute_stacks_command(StackMaster::Commands::Validate, args, options)
         end
       end
 
@@ -111,6 +131,7 @@ module StackMaster
         c.description = 'Checks the status of all stacks defined in the stack_master.yml file. Warning this operation can be somewhat slow.'
         c.example 'description', 'Check the status of all stack definitions'
         c.action do |args, options|
+          options.defaults config: default_config_file
           say "Invalid arguments. stack_master status" and return unless args.size == 0
           config = load_config(options.config)
           StackMaster::Commands::Status.perform(config)
@@ -123,17 +144,20 @@ module StackMaster
         c.description = 'Deletes a stack. The stack does not necessarily have to appear in the stack_master.yml file.'
         c.example 'description', 'Delete a stack'
         c.action do |args, options|
+          options.default config: default_config_file
           unless args.size == 2
             say "Invalid arguments. stack_master delete [region] [stack_name]"
             return
           end
-	  # Because delete can work without a stack_master.yml
-	  if options.config and File.file?(options.config)
+
+          # Because delete can work without a stack_master.yml
+          if options.config and File.file?(options.config)
             config = load_config(options.config)
             region = Utils.underscore_to_hyphen(config.unalias_region(args[0]))
-	  else
-	    region = args[0]
-	  end
+          else
+            region = args[0]
+          end
+
           StackMaster.cloud_formation_driver.set_region(region)
           StackMaster::Commands::Delete.perform(region, args[1])
         end
@@ -143,29 +167,32 @@ module StackMaster
     end
 
     def load_config(file)
-      stack_file = file || 'stack_master.yml'
+      stack_file = file || default_config_file
       StackMaster::Config.load!(stack_file)
     rescue Errno::ENOENT => e
       say "Failed to load config file #{stack_file}"
       exit 1
     end
 
-    def execute_stack_command(command, args, options)
-      unless args.size == 2
-        say "Invalid arguments. stack_master #{command.name.split('::').last.downcase} [region] [stack_name]"
-        return
-      end
+    def execute_stacks_command(command, args, options)
+      command_results = []
       config = load_config(options.config)
-      aliased_region, stack_name = args
-      region = Utils.underscore_to_hyphen(config.unalias_region(aliased_region))
-      stack_name = Utils.underscore_to_hyphen(stack_name)
-      StackMaster.cloud_formation_driver.set_region(region)
-      stack_definition ||= config.find_stack(region, stack_name)
-      if stack_definition.nil?
-        say "Could not find stack definition #{stack_name} in region #{region}"
-        return
+      args = [nil, nil] if args.size == 0
+      args.each_slice(2) do |aliased_region, stack_name|
+        region = Utils.underscore_to_hyphen(config.unalias_region(aliased_region))
+        stack_name = Utils.underscore_to_hyphen(stack_name)
+        stack_definitions = config.filter(region, stack_name)
+        if stack_definitions.empty?
+          say "Could not find stack definition #{stack_name} in region #{region}"
+        end
+        stack_definitions.each do |stack_definition|
+          StackMaster.cloud_formation_driver.set_region(stack_definition.region)
+          command_results.push command.perform(config, stack_definition, options).success?
+        end
       end
-      command.perform(config, stack_definition, options)
+
+      # Return success/failure
+      command_results.all?
     end
   end
 end

data/lib/stack_master/command.rb

@@ -6,8 +6,16 @@ module StackMaster
 
     module ClassMethods
       def perform(*args)
-        new(*args).perform
+        new(*args).tap { |command| command.perform }
       end
     end
+
+    def failed
+      @failed = true
+    end
+
+    def success?
+      @failed != true
+    end
   end
 end

data/lib/stack_master/commands/apply.rb

@@ -25,6 +25,8 @@ module StackMaster
         rescue StackMaster::CtrlC
           cancel
         end
+      rescue Aws::CloudFormation::Errors::ServiceError => e
+        StackMaster.stdout.puts "#{e.class} #{e.message}"
       end
 
       private

data/lib/stack_master/commands/list_stacks.rb

@@ -3,12 +3,14 @@ module StackMaster
     class ListStacks
       include Command
       include Commander::UI
+      include StackMaster::Commands::TerminalHelper
 
       def initialize(config)
         @config = config
       end
 
       def perform
+        tp.set :max_width, self.window_size
         tp @config.stacks, :region, :stack_name
       end
     end

data/lib/stack_master/commands/outputs.rb

@@ -3,6 +3,7 @@ module StackMaster
     class Outputs
       include Command
       include Commander::UI
+      include StackMaster::Commands::TerminalHelper
 
       def initialize(config, stack_definition, options = {})
         @config = config
@@ -11,7 +12,7 @@ module StackMaster
 
       def perform
         if stack
-          tp.set :max_width, 80
+          tp.set :max_width, self.window_size
           tp stack.outputs, :output_key, :output_value, :description
         else
           StackMaster.stdout.puts "Stack doesn't exist"

data/lib/stack_master/commands/status.rb

@@ -2,6 +2,7 @@ module StackMaster
   module Commands
     class Status
       include Command
+      include StackMaster::Commands::TerminalHelper
 
       def initialize(config, show_progress = true)
         @config = config
@@ -15,6 +16,7 @@ module StackMaster
           progress.increment if @show_progress
           status
         end
+        tp.set :max_width, self.window_size
         tp.set :io, StackMaster.stdout
         tp status
         StackMaster.stdout.puts " * No echo parameters can't be diffed"