stack_master 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5a3ed3d56cf859f61ca5a72f89d42cfefea0cd0d
-  data.tar.gz: af141896b5817e2ff3a30b3811c3b3fedb1cade9
+  metadata.gz: 47ceb9c3a194f4352336f7994f8c4034c8d0ff6e
+  data.tar.gz: a990f7e54348aee9b55378ea9518c1518ae4d4eb
 SHA512:
-  metadata.gz: 13e318d63d1a51aa9c379a571694cf43bc640aabc9e55d4cc0fb6570d0e44031609cd463fb655805620c39e60877d816d79a4ad6f1fbb909df652bdb27a3ebb1
-  data.tar.gz: 5fa3fad8464793c9d2d91738095e3e22e09d4029fcff28888f46f9fa30b92ff576761ad0db3df7ce74bc86d2c6237f9ff6813a2b9d81874008bc8659e99d691a
+  metadata.gz: 8dafc6386c511101ab2da220d0c632b823fc2add8f6d88430d0cf11f6c94c8256c7b99bc1661f5db3e62051e0383952b3f769baa31dfcae8919305db4390a27e
+  data.tar.gz: fa452352356d15ba2fc08ab728e6709a72f793250bd325fa990cc8cb9ccfa15a7ec1b75ea5c5af65deedf3b0dd7f952691f0b5797f1d10c042faa83b48121304

data/.travis.yml

@@ -0,0 +1,6 @@
+language: ruby
+rvm:
+  - 2.2
+sudo: false
+script:
+  - bundle exec rake spec features

data/README.md

@@ -169,6 +169,41 @@ web_ami:
   latest_ami_by_tags: role=web,application=myapp
 ```
 
+### Custom parameter resolvers
+
+New parameter resolvers can be created in a separate gem.
+
+To create a resolver named my_resolver:
+  * Create a new gem using your favorite tool
+  * The gem structure must contain the following path:
+```
+lib/stack_master/parameter_resolvers/my_resolver.rb
+```
+  * That file need to contain a class named `StackMaster::ParameterResolvers::MyResolver`
+    that implements a `resolve` method and an initializer taking 2 parameters :
+```ruby
+module StackMaster
+  module ParameterResolvers
+    class MyResolver
+      def initialize(config, stack_definition)
+        @config = config
+        @stack_definition = stack_definition
+      end
+
+      def resolve(value)
+        value
+      end
+    end
+  end
+end
+```
+  * Note that the filename and classname are both derived from the resolver name
+    passed in the parameter file. In our case, the parameters YAML would look like:
+```yaml
+vpc_id:
+  my_resolver: dummy_value
+```
+
 ## Commands
 
 ```bash

data/Rakefile

@@ -9,3 +9,17 @@ task :console => :environment do
   require 'pry'
   binding.pry
 end
+
+# Add specs and features tests
+begin
+  require 'cucumber/rake/task'
+  Cucumber::Rake::Task.new(:features) do |t|
+    t.cucumber_opts = "features --format pretty"
+  end
+
+  require 'rspec/core/rake_task'
+  RSpec::Core::RakeTask.new(:spec) do |t|
+    t.rspec_opts = "--format doc"
+  end
+rescue LoadError
+end

data/lib/stack_master/parameter_resolver.rb

@@ -27,19 +27,49 @@ module StackMaster
 
     private
 
+    def require_parameter_resolver(file_name)
+      require "stack_master/parameter_resolvers/#{file_name}"
+    rescue LoadError
+      raise ResolverNotFound.new(file_name)
+    end
+
+    def load_parameter_resolver(class_name)
+      # Check if the class name already exists
+      resolver_class_const(class_name)
+    rescue NameError
+      # If it doesn't, try to load it
+      require_parameter_resolver(class_name.underscore)
+    end
+
     def resolve_parameter_value(parameter_value)
       return parameter_value if String === parameter_value || parameter_value.nil?
       raise InvalidParameter, parameter_value unless Hash === parameter_value
       raise InvalidParameter, parameter_value unless parameter_value.keys.size == 1
-      resolver_class_name = parameter_value.keys.first.to_s.camelize
+
+      resolver_name = parameter_value.keys.first.to_s
+      load_parameter_resolver(resolver_name)
+
       value = parameter_value.values.first
-      resolver_class(resolver_class_name).resolve(value)
+      resolver_class_name = resolver_name.camelize
+      call_resolver(resolver_class_name, value)
+    end
+
+    def call_resolver(class_name, value)
+      resolver_class(class_name).resolve(value)
+    end
+
+    def resolver_class_name(class_name)
+      "StackMaster::ParameterResolvers::#{class_name.camelize}"
+    end
+
+    def resolver_class_const(class_name)
+      Kernel.const_get(resolver_class_name(class_name))
     end
 
     def resolver_class(class_name)
       @resolvers.fetch(class_name) do
         begin
-          @resolvers[class_name] = Kernel.const_get("StackMaster::ParameterResolvers::#{class_name}").new(@config, @stack_definition)
+          @resolvers[class_name] = resolver_class_const(class_name).new(@config, @stack_definition)
         rescue NameError
           raise ResolverNotFound, "Could not find parameter resolver called #{class_name}, please double check your configuration"
         end

data/lib/stack_master/version.rb

@@ -1,3 +1,3 @@
 module StackMaster
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/stack_master/parameter_resolver_spec.rb

@@ -1,5 +1,12 @@
 RSpec.describe StackMaster::ParameterResolver do
+  subject(:parameter_resolver) { StackMaster::ParameterResolver.new(config, region, params) }
+  let(:params) do
+    {
+      param: { my_resolver: 2 }
+    }
+  end
   let(:config) { double }
+  let(:region) { 'us-east-1' }
   let(:my_resolver) {
     Class.new do
       def initialize(config, region)
@@ -10,11 +17,11 @@ RSpec.describe StackMaster::ParameterResolver do
       end
     end
   }
+
   before do
     stub_const('StackMaster::ParameterResolvers::MyResolver', my_resolver)
   end
 
-
   def resolve(params)
     StackMaster::ParameterResolver.resolve(config, 'us-east-1', params)
   end
@@ -55,4 +62,29 @@ RSpec.describe StackMaster::ParameterResolver do
       expect(resolve(param: { my_resolver: 2 }, param2: { my_resolver: 2 })).to eq(param: 10, param2: 10)
     end
   end
+
+  context 'when the resolver class already exist' do
+    it 'does not try to load it' do
+      expect(parameter_resolver).to receive(:load_parameter_resolver).once.and_call_original
+      expect(parameter_resolver).not_to receive(:require_parameter_resolver)
+
+      parameter_resolver.resolve
+    end
+  end
+
+  context 'when the resolver class does not exist' do
+    let(:params) do
+      {
+        param: { dummy_resolver: 2 }
+      }
+    end
+
+    it 'tries to load it' do
+      expect(parameter_resolver).to receive(:load_parameter_resolver).once.and_call_original
+      expect(parameter_resolver).to receive(:require_parameter_resolver).and_return nil
+      expect(parameter_resolver).to receive(:call_resolver).and_return nil
+
+      parameter_resolver.resolve
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stack_master
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Steve Hodgkiss
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-09 00:00:00.000000000 Z
+date: 2015-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -274,6 +274,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -395,7 +396,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.2.3
 signing_key: 
 specification_version: 4
 summary: StackMaster is a sure-footed way of creating, updating and keeping track