stack_frames 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c404f9278a85b107921a9ecb3fce96b487843140922499441eaf01f6615955c1
-  data.tar.gz: daf9693bff25c25e07c0cbf169b04f56e3b716888ae3c501a031e997e275963a
+  metadata.gz: 2238db3a0eba08ae5a8faa43f18e315b5f8be27d5758429d6c168aa2017375fc
+  data.tar.gz: 70ef59c3d901559ffd7137a7720b5d921b511c8a68162de29b8ff8c3fba1b8bd
 SHA512:
-  metadata.gz: c62e52062931e7e5e288a30bfa9524584146e198f2f5f9466f9e9d1fc8ade8cc8d2b2e70c108de426844036f25a3fa516d575fae7f3ba38529c2a463f07823ed
-  data.tar.gz: ce7b41fd1c8ca4eccba5535ab3efaef3d29e412d7a55bb53fdac3b634354dcf56d5928e4627160d048fedf8a15db39b5f67666a0d7566c00d16de790debd729c
+  metadata.gz: ea5b8152852b6afade78b89c96b875d3d0585055c549ff07eb8e9d9eefe1614e71e4e69098793766397a8471a24dbd53a0c37298c02ea3fa5822b187c826c8ad
+  data.tar.gz: c29732481c3a7f4d198cdd26265f2b680b300d74e419f3a6c319b98420dffaf62b9750fc39c2e68ea31ef6a9d0358238ec650eb6df801082f6ffacbb4c949293

data/.github/workflows/ci.yml

@@ -14,6 +14,7 @@ jobs:
           '2.7',
           '3.0',
           '3.1',
+          '3.2',
         ]
     steps:
     - uses: actions/checkout@v2
@@ -22,3 +23,14 @@ jobs:
         ruby-version: ${{ matrix.ruby }}
         bundler-cache: true
     - run: bundle exec rake
+
+  valgrind:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.1'
+          bundler-cache: true
+      - run: sudo apt-get install -y valgrind
+      - run: bundle exec rake test:valgrind

data/.github/workflows/cla.yml

@@ -0,0 +1,22 @@
+name: Contributor License Agreement (CLA)
+
+on:
+  pull_request_target:
+    types: [opened, synchronize]
+  issue_comment:
+    types: [created]
+
+jobs:
+  cla:
+    runs-on: ubuntu-latest
+    if: |
+      (github.event.issue.pull_request 
+        && !github.event.issue.pull_request.merged_at
+        && contains(github.event.comment.body, 'signed')
+      ) 
+      || (github.event.pull_request && !github.event.pull_request.merged)
+    steps:
+      - uses: Shopify/shopify-cla-action@v1
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          cla-token: ${{ secrets.CLA_TOKEN }}

data/Rakefile

@@ -1,6 +1,9 @@
 require "bundler/gem_tasks"
 require "rake/testtask"
 require 'rake/extensiontask'
+require "ruby_memcheck"
+
+RubyMemcheck.config(binary_name: "stack_frames")
 
 ENV['STACK_FRAMES_DEV'] = '1'
 
@@ -8,10 +11,14 @@ Rake::ExtensionTask.new("stack_frames") do |ext|
   ext.lib_dir = 'lib/stack_frames'
 end
 
-Rake::TestTask.new(test: :compile) do |t|
+test_config = lambda do |t|
   t.libs << "test"
   t.libs << "lib"
   t.test_files = FileList["test/**/*_test.rb"]
 end
+Rake::TestTask.new(test: :compile, &test_config)
+namespace :test do
+  RubyMemcheck::TestTask.new(valgrind: :compile, &test_config)
+end
 
 task :default => :test

data/ext/stack_frames/buffer.c

@@ -33,7 +33,7 @@ static size_t buffer_memsize(const void *ptr)
     return sizeof(buffer_t);
 }
 
-const rb_data_type_t buffer_data_type = {
+static const rb_data_type_t buffer_data_type = {
     "stack_frames_buffer",
     { buffer_mark, buffer_free, buffer_memsize, },
     NULL, NULL, RUBY_TYPED_FREE_IMMEDIATELY

data/ext/stack_frames/extconf.rb

@@ -1,4 +1,4 @@
 require 'mkmf'
-$CFLAGS << ' -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers'
+$CFLAGS << ' -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden'
 $CFLAGS << ' -Werror' if ENV['STACK_FRAMES_DEV']
 create_makefile("stack_frames/stack_frames")

data/ext/stack_frames/frame.c

@@ -14,18 +14,14 @@ static void frame_mark(void *ptr)
     rb_gc_mark(frame->buffer);
 }
 
-static void frame_free(void *ptr)
-{
-}
-
 static size_t frame_memsize(const void *ptr)
 {
     return sizeof(frame_t);
 }
 
-const rb_data_type_t frame_data_type = {
+static const rb_data_type_t frame_data_type = {
     "stack_frames_frame",
-    { frame_mark, frame_free, frame_memsize, },
+    { frame_mark, RUBY_DEFAULT_FREE, frame_memsize, },
     NULL, NULL, RUBY_TYPED_FREE_IMMEDIATELY
 };
 

data/ext/stack_frames/stack_frames.c

@@ -2,7 +2,7 @@
 #include "frame.h"
 #include "buffer.h"
 
-void Init_stack_frames() {
+RUBY_FUNC_EXPORTED void Init_stack_frames(void) {
     VALUE mStackFrames = rb_define_module("StackFrames");
     stack_buffer_define(mStackFrames);
     stack_frame_define(mStackFrames);

data/lib/stack_frames/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StackFrames
-  VERSION = "0.1.1"
+  VERSION = "0.1.3"
 end

data/stack_frames.gemspec

@@ -31,4 +31,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake-compiler', '~> 1.0'
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "stackprof", "~> 0.2.13"
+  spec.add_development_dependency "ruby_memcheck"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stack_frames
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - Dylan Thacker-Smith
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-02-04 00:00:00.000000000 Z
+date: 2023-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.2.13
+- !ruby/object:Gem::Dependency
+  name: ruby_memcheck
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - gems@shopify.com
@@ -88,8 +102,8 @@ extensions:
 - ext/stack_frames/extconf.rb
 extra_rdoc_files: []
 files:
-- ".github/probots.yml"
 - ".github/workflows/ci.yml"
+- ".github/workflows/cla.yml"
 - ".gitignore"
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
@@ -131,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: Zero allocation backtraces using MRI's profile frames API

data/.github/probots.yml

@@ -1,3 +0,0 @@
-# .github/probots.yml
-enabled:
-  - cla