stack_frames 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7eb6415831cb725f642009b7e3faffaa31cc12e53986a50cc6c66afb22a40858
-  data.tar.gz: 785cae19b0d65246275c483009711bf7adfbd99b2cee6c146f13711e1e87bf74
+  metadata.gz: 18a74c610d900bb78ed82f751d93c498d8c573f5a95cfc3984597abc504bffa0
+  data.tar.gz: ebff4be1938e844e1434e1320be9dba6f04376e4d451354e2245b30d351aacef
 SHA512:
-  metadata.gz: b31829453fe42d5852a08f272a9604a0a8011faabb1e099c301311167b6b03db7c5eade3239d3b6a495c4164348af8d645a84315d3f4c4bc5a0c1352636cb194
-  data.tar.gz: c06d4ad28aad9e559c4bb9702f12b69af603cbce2617fa4fbf8929fa2054c1b101587ea32776c398b12594ac361e21d8d97f3c1a1e917786c15a285c855a76f9
+  metadata.gz: 45279be5693b045b5ba53e1461bf92dc1df2db2b9ac4f357d2b6ee81899373287606050de8d72558be1b7cbbb0a141762f5c597c81375421584afcf0ac383e6c
+  data.tar.gz: 4620f5ff6607947f6f73e2940562e69101b40093a539ae56e0d7c0b32c2d11515056579d4662570d3bb002da6646b74145f02a6233d6dd758e11bd5de5d672c7

data/.github/workflows/ci.yml

@@ -0,0 +1,35 @@
+name: Tests
+
+on:
+  push
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [
+          '2.6', # minimum supported
+          '2.7',
+          '3.0',
+          '3.1',
+        ]
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler-cache: true
+    - run: bundle exec rake
+
+  valgrind:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.1'
+          bundler-cache: true
+      - run: sudo apt-get install -y valgrind
+      - run: bundle exec rake test:valgrind

data/.github/workflows/cla.yml

@@ -0,0 +1,22 @@
+name: Contributor License Agreement (CLA)
+
+on:
+  pull_request_target:
+    types: [opened, synchronize]
+  issue_comment:
+    types: [created]
+
+jobs:
+  cla:
+    runs-on: ubuntu-latest
+    if: |
+      (github.event.issue.pull_request 
+        && !github.event.issue.pull_request.merged_at
+        && contains(github.event.comment.body, 'signed')
+      ) 
+      || (github.event.pull_request && !github.event.pull_request.merged)
+    steps:
+      - uses: Shopify/shopify-cla-action@v1
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          cla-token: ${{ secrets.CLA_TOKEN }}

data/Rakefile

@@ -1,6 +1,9 @@
 require "bundler/gem_tasks"
 require "rake/testtask"
 require 'rake/extensiontask'
+require "ruby_memcheck"
+
+RubyMemcheck.config(binary_name: "stack_frames")
 
 ENV['STACK_FRAMES_DEV'] = '1'
 
@@ -8,10 +11,14 @@ Rake::ExtensionTask.new("stack_frames") do |ext|
   ext.lib_dir = 'lib/stack_frames'
 end
 
-Rake::TestTask.new(test: :compile) do |t|
+test_config = lambda do |t|
   t.libs << "test"
   t.libs << "lib"
   t.test_files = FileList["test/**/*_test.rb"]
 end
+Rake::TestTask.new(test: :compile, &test_config)
+namespace :test do
+  RubyMemcheck::TestTask.new(valgrind: :compile, &test_config)
+end
 
 task :default => :test

data/ext/stack_frames/buffer.c

@@ -58,11 +58,12 @@ static VALUE buffer_initialize(VALUE self, VALUE size) {
     TypedData_Get_Struct(self, buffer_t, &buffer_data_type, buffer);
     buffer->profile_frames = ALLOC_N(VALUE, capacity);
     buffer->lines = ALLOC_N(int, capacity);
-    buffer->capacity = capacity;
     buffer->frames = ALLOC_N(VALUE, capacity);
 
+    buffer->capacity = 0;
     for (int i = 0; i < capacity; i++) {
         buffer->frames[i] = stack_frame_new(self, i);
+        buffer->capacity++;
     }
     return Qnil;
 }

data/ext/stack_frames/frame.c

@@ -14,10 +14,6 @@ static void frame_mark(void *ptr)
     rb_gc_mark(frame->buffer);
 }
 
-static void frame_free(void *ptr)
-{
-}
-
 static size_t frame_memsize(const void *ptr)
 {
     return sizeof(frame_t);
@@ -25,7 +21,7 @@ static size_t frame_memsize(const void *ptr)
 
 const rb_data_type_t frame_data_type = {
     "stack_frames_frame",
-    { frame_mark, frame_free, frame_memsize, },
+    { frame_mark, RUBY_DEFAULT_FREE, frame_memsize, },
     NULL, NULL, RUBY_TYPED_FREE_IMMEDIATELY
 };
 
@@ -72,6 +68,8 @@ DEFINE_FRAME_ACCESSOR(qualified_method_name)
 
 void stack_frame_define(VALUE mStackFrames) {
     cFrame = rb_define_class_under(mStackFrames, "Frame", rb_cObject);
+    rb_global_variable(&cFrame);
+
     rb_define_alloc_func(cFrame, frame_allocate);
     rb_define_method(cFrame, "lineno", frame_lineno, 0);
     rb_define_method(cFrame, "path", frame_path, 0);

data/ext/stack_frames/stack_frames.c

@@ -2,10 +2,8 @@
 #include "frame.h"
 #include "buffer.h"
 
-VALUE mStackFrames;
-
 void Init_stack_frames() {
-    mStackFrames = rb_define_module("StackFrames");
+    VALUE mStackFrames = rb_define_module("StackFrames");
     stack_buffer_define(mStackFrames);
     stack_frame_define(mStackFrames);
 }

data/lib/stack_frames/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module StackFrames
-  VERSION = "0.1.0"
+  VERSION = "0.1.2"
 end

data/stack_frames.gemspec

@@ -14,6 +14,8 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/Shopify/stack_frames"
   spec.license       = "MIT"
 
+  spec.metadata["allowed_push_host"] = "https://rubygems.org"
+
   spec.extensions    = ['ext/stack_frames/extconf.rb']
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -25,8 +27,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency 'rake-compiler', '~> 1.0'
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "stackprof", "~> 0.2.13"
+  spec.add_development_dependency "ruby_memcheck"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stack_frames
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Dylan Thacker-Smith
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-02-04 00:00:00.000000000 Z
+date: 2022-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rake-compiler
   requirement: !ruby/object:Gem::Requirement
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.2.13
+- !ruby/object:Gem::Dependency
+  name: ruby_memcheck
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - gems@shopify.com
@@ -88,9 +102,9 @@ extensions:
 - ext/stack_frames/extconf.rb
 extra_rdoc_files: []
 files:
-- ".github/probots.yml"
+- ".github/workflows/ci.yml"
+- ".github/workflows/cla.yml"
 - ".gitignore"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
@@ -114,7 +128,8 @@ files:
 homepage: https://github.com/Shopify/stack_frames
 licenses:
 - MIT
-metadata: {}
+metadata:
+  allowed_push_host: https://rubygems.org
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -130,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.3.3
 signing_key: 
 specification_version: 4
 summary: Zero allocation backtraces using MRI's profile frames API

data/.github/probots.yml

@@ -1,3 +0,0 @@
-# .github/probots.yml
-enabled:
-  - cla

data/.travis.yml

@@ -1,8 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-rvm:
-  - 2.4.9 # minimum supported
-  - 2.7.0 # latest released
-before_install: gem install bundler -v 1.17.3