stack_commander 0.0.5.pre.2 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1dae7fd632f00edc3706a9f842914a777c1627b0
-  data.tar.gz: 3c04261a6b4cec730cea9a7d5738769af9f95ad6
+  metadata.gz: 595990555153b67f3183dbca5f68d2e1f10fe746
+  data.tar.gz: 097710148b29367a54622fc4181c22b3175edb1f
 SHA512:
-  metadata.gz: fee8c6a2d3c1ad2652d918d1880b0889c8eae16f6896ae576eca932f80c0095031c9e9c22580530e158c2211414c6b38d0bf825c43243005dbb60d0190593b9d
-  data.tar.gz: f27cb2d4341f3015bbe93d069bcf7cd7e0870296644a35929dd519a81b8fa0f1042b1f696c928f0bcbd6f6e6c3aa53523039838842a9f38458b4c83f4bb7b8a8
+  metadata.gz: 29509d72c79c3dad4cd4fbe788eead74769472bb09ad70bfe3a6a7b66896ca32d0997ea39cf352319fc9f311d03f38552755c9acea666beae5c37b890be229d6
+  data.tar.gz: 420c6a813a99c4fe2f06c7b12477d755c903791ce4879363f370d67e1bf16bedad6dff237855159f4c60a1973fe86e5edfae4153ae47da171807565d612f1054

data/README.md

@@ -101,6 +101,10 @@ other command insurance
 command insurance
 ```
 
+# TODO
+* figure out how to configure commands without need of subclassing  
+  for example Command Gzip accepts a file and outputs a gzipped file, how you can use this command twice in one stack?
+
 ## Contributing
 
 1. Fork it ( https://github.com/mikz/stack_commander/fork )

data/lib/stack_commander/command.rb

@@ -1,12 +1,9 @@
 module StackCommander
   module Command
-    def self.included(base)
-      base.extend(ClassMethods)
-    end
-
     def call(stack)
       action
       stack.call
+      cleanup
     rescue => exception
       recover(exception)
       raise
@@ -14,6 +11,9 @@ module StackCommander
       insurance
     end
 
+    def cleanup
+    end
+
     def action
     end
 
@@ -22,31 +22,5 @@ module StackCommander
 
     def insurance
     end
-
-    def configuration
-      self.class.configuration
-    end
-
-    private
-
-    module ClassMethods
-      CONFIGURATION = :@@configuration
-
-      def configuration
-        class_variable_get(CONFIGURATION) if class_variable_defined?(CONFIGURATION)
-      end
-
-      def dependency_injection(&block)
-        class_variable_set(:@@dependency_injection, block)
-      end
-
-      # Creates an anonymous subclass of current command, configured with passed value
-      # then all instances of that command will have the same configuration
-      def [](value)
-        subclass = Class.new(self)
-        subclass.class_variable_set(CONFIGURATION, value)
-        subclass
-      end
-    end
   end
 end

data/lib/stack_commander/dependency_injection.rb

@@ -2,8 +2,6 @@ module StackCommander
   class DependencyInjection
     InvalidScope = Class.new(StandardError)
 
-    CVAR = :@@dependency_injection
-
     def initialize(klass)
       @klass = klass
     end
@@ -17,29 +15,20 @@ module StackCommander
       Array(parameters)
     end
 
-    def configured_parameters
-      parameters = @klass.class_variable_defined?(CVAR) && @klass.class_variable_get(CVAR)
-      parameters && parameters.respond_to?(:to_proc) ? @klass.instance_exec(:initialize, &parameters) : parameters
-    end
-
-    def parameters
-      configured_parameters || required_parameters
-    end
-
-    def matching?(scope)
-      parameters.all? do |param|
+    def matches?(scope)
+      required_parameters.all? do |param|
         scope.respond_to?(param)
       end
     end
 
     def match!(scope)
-      raise InvalidScope, scope unless matching?(scope)
+      raise InvalidScope, scope unless matches?(scope)
     end
 
     def extract(scope)
       match!(scope)
 
-      parameters.map do |param|
+      required_parameters.map do |param|
         scope.public_send(param)
       end
     end

data/lib/stack_commander/version.rb

@@ -1,3 +1,3 @@
 module StackCommander
-  VERSION = '0.0.5.pre.2'
+  VERSION = '0.0.5'
 end

data/spec/command_spec.rb

@@ -11,6 +11,7 @@ describe StackCommander::Command do
 
     expect_it { to respond_to(:action) }
     expect_it { to respond_to(:insurance) }
+    expect_it { to respond_to(:cleanup) }
     expect_it { to respond_to(:recover).with(1).argument }
 
 
@@ -26,6 +27,11 @@ describe StackCommander::Command do
       subject.call(stack)
     end
 
+    it 'calls cleanup' do
+      expect(subject).to receive(:cleanup)
+      subject.call(stack)
+    end
+
     it 'calls insurance' do
       expect(subject).to receive(:insurance)
       subject.call(stack)
@@ -51,43 +57,10 @@ describe StackCommander::Command do
         expect(subject).to receive(:recover).with(an_instance_of(StandardError))
         expect{ subject.call(stack) }.to raise_error(StandardError)
       end
-    end
-  end
-
-  context 'classes including command' do
-    subject(:command) { Class.new{ include StackCommander::Command } }
-
-    before do
-      stub_const('TestCommand', command)
-    end
-
-    it 'has name' do
-      expect(command.to_s).to eq('TestCommand')
-    end
-
-    it 'has configuration' do
-      expect(command.configuration).to be_nil
-    end
-
-    context 'with config' do
-      subject(:configured_command) { command[:test] }
-
-      expect_it { to be }
-
-      it 'does not have a name' do
-        expect(configured_command.to_s).not_to eq('TestCommand')
-      end
-
-      it 'has configuration' do
-        expect(configured_command.configuration).to eq(:test)
-      end
 
-      context 'an instance' do
-        subject(:instance) { configured_command.new }
-
-        it 'has configuration' do
-          expect(instance.configuration).to eq(:test)
-        end
+      it 'does not call cleanup' do
+        expect(subject).not_to receive(:cleanup)
+        expect{ subject.call(stack) }.to raise_error(StandardError)
       end
     end
   end

data/spec/dependency_injection_spec.rb

@@ -14,7 +14,7 @@ describe StackCommander::DependencyInjection do
     let(:scope) { double('scope', one: 'one value', two: 'two') }
 
     it do
-      expect(di).to be_matching(scope)
+      expect(di.matches?(scope)).to be
     end
 
     it do
@@ -22,30 +22,15 @@ describe StackCommander::DependencyInjection do
     end
   end
 
-  context 'scope does not have required methods' do
+  context 'scope does not have requried methods' do
     let(:scope) { double('scope', one: true) }
 
     it do
-      expect(di).not_to be_matching(scope)
+      expect(di.matches?(scope)).not_to be
     end
 
     it do
       expect{ di.extract(scope) }.to raise_error(StackCommander::DependencyInjection::InvalidScope)
     end
   end
-
-  context 'class has configured parameters' do
-    before do
-      custom_class.class_variable_set :@@dependency_injection, proc { [:three, :four] }
-    end
-
-    it do
-      expect(di.parameters).to eq([:three, :four])
-    end
-
-    it 'matches new scope' do
-      scope = double(three: true, four: true)
-      expect(di).to be_matching(scope)
-    end
-  end
 end

data/spec/stack_spec.rb

@@ -49,9 +49,13 @@ describe StackCommander::Stack do
         stack << other_command
       end
 
-      it 'calls action in stack manner' do
+      it 'calls actions in stack manner' do
         expect_any_instance_of(command).to receive(:action) do
-          expect_any_instance_of(other_command).to receive(:action)
+          expect_any_instance_of(other_command).to receive(:action) do
+            expect_any_instance_of(other_command).to receive(:cleanup) do
+              expect_any_instance_of(command).to receive(:cleanup)
+            end
+          end
         end
 
         stack.call

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stack_commander
 version: !ruby/object:Gem::Version
-  version: 0.0.5.pre.2
+  version: 0.0.5
 platform: ruby
 authors:
 - Michal Cichra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-16 00:00:00.000000000 Z
+date: 2014-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -108,9 +108,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2