stack_commander 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae92cb3f3a8d18e64d2db4c240119b96e1062e80
-  data.tar.gz: d5294e75db6fb3afb27f1d56db44270c38be8840
+  metadata.gz: 88727f317aeb1c15a2cf5125608b3307f006453d
+  data.tar.gz: d1112eadfc48d7f147da59051aa503bc82622e2b
 SHA512:
-  metadata.gz: cccf36d9c8c16c035f3f43aef5d88daf0cb75bd6d0f95a58fd4f0dd3d3817f10fd1b23199f11dba4b8b4163c0b5a0a9475f282fd66dc0a47c8ed8a77d7e5cee5
-  data.tar.gz: d93ec0f9f0f91166cac8099d6362ec66bf6d6b32e08a5065df8e8213a18ec9f7b03e900457499bbac34e3e148ca2056fc65a1ea9b91e6ceb8de2fd0ca43d5f89
+  metadata.gz: 838fbcc1b518d5c11d54be5bb408a5376c8baefac8c048d1089d901e18d4da3f892d17e89638e4d8b2c5b22935e8c1f59b132a2543661e97093a7723027f397e
+  data.tar.gz: 406882fa923046d3018e9a1119180e9e5e424157f05ad476ac1fd7b39fe0b7da9bc66172d26e8bfd5807363ef7419fc06049d79fc06523630285dcaee027390f

data/.gitignore

@@ -1,3 +1,4 @@
+.ruby-version
 *.gem
 *.rbc
 .bundle

data/Gemfile

@@ -3,6 +3,10 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in stack_commander.gemspec
 gemspec
 
-gem 'yard'
 gem 'redcarpet'
 gem 'github-markup'
+
+group :test do
+  gem 'pry-debugger'
+  gem 'pry-stack_explorer'
+end

data/README.md

@@ -1,4 +1,4 @@
-# StackCommander
+# StackCommander [![Build Status](https://travis-ci.org/mikz/stack_commander.svg?branch=master)](https://travis-ci.org/mikz/stack_commander)
 
 StackCommander takes fresh approach to Command Pattern in Ruby.
 We needed chaining of Commands with benefits of `rescue` and `ensure` which was hard to do without execution stack.
@@ -15,7 +15,7 @@ We tried: passing state to the `action` method, passing state to the `initialize
 * `initialize` is called by the stack with explicit parameters instead of whole state object
   * for easier testing
   * and not to break Law of Demeter
-* command's `action`, `rescue` and `insurance` are called without state parameter
+* command's `action`, `recover` and `insurance` are called without state parameter
 * command has internal variable `@scope`
 
 It is not final, so constructive feedback is very much appreciated.

data/Rakefile

@@ -1,2 +1,9 @@
 require 'bundler/gem_tasks'
 
+task :default do
+  exec 'rspec'
+end
+
+task :console do
+  exec 'irb', '-Ilib', '-rstack_commander'
+end

data/lib/stack_commander/stack.rb

@@ -1,9 +1,9 @@
-require 'thread'
+require 'stack_commander'
 
 module StackCommander
   class Stack
     def initialize(scope)
-      @queue = Queue.new
+      @queue = []
       @scope = scope
     end
 
@@ -18,21 +18,26 @@ module StackCommander
     end
 
     def call
-      return if @queue.empty?
-      command_class = @queue.pop
-
-      run_command(command_class)
+      if command_class = @queue.shift
+        run_command(command_class)
+      end
     end
 
-    private
-
-    def run_command(klass)
+    # TODO: maybe this should be responsibility of the command? it would make testing easier
+    def initialize_command(klass)
       parameters = StackCommander::DependencyInjection.new(klass).extract(@scope)
 
       command = klass.allocate
       command.instance_variable_set :@scope, @scope
       command.__send__(:initialize, *parameters)
 
+      command
+    end
+
+    private
+
+    def run_command(klass)
+      command = initialize_command(klass)
       command.call(self)
     end
   end

data/lib/stack_commander/version.rb

@@ -1,3 +1,3 @@
 module StackCommander
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/spec/stack_spec.rb

@@ -23,20 +23,39 @@ describe StackCommander::Stack do
   end
 
   context 'with commands' do
-    let(:command) { double('command').as_null_object }
+    let(:command) { Class.new(StackCommander::BaseCommand) }
 
     before do
       stack << command
     end
 
     it 'runs the commands' do
-      expect(command).to receive(:call).with(stack)
+      expect_any_instance_of(command).to receive(:call).with(stack).and_call_original
+      expect_any_instance_of(command).to receive(:action)
+
       stack.call
     end
 
     it 'initializes the command' do
-      expect(command).to receive(:new).with
+      # TODO: this could be responsibility of the command
+      expect(stack).to receive(:initialize_command).with(command).and_call_original
       stack.call
     end
+
+    context 'stacked' do
+      let(:other_command) { Class.new(StackCommander::BaseCommand) }
+
+      before do
+        stack << other_command
+      end
+
+      it 'calls action in stack manner' do
+        expect_any_instance_of(command).to receive(:action) do
+          expect_any_instance_of(other_command).to receive(:action)
+        end
+
+        stack.call
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: stack_commander
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Michal Cichra
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-08 00:00:00.000000000 Z
+date: 2014-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler