staccato-rack 0.3.1 → 0.3.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MzA4MWM1MTMwNzkxMjRkZDg0Njk5ODE3ZmMwNTk5NjI1OTc4ZWNiZQ==
+    ZjlmYTEyODk5YWM2NWVhYjMxMGViZjRkMDY4MTZlMjNjYmQzZGRjYw==
   data.tar.gz: !binary |-
-    NjZmMmYzMmE0YWM3ZmJjYjYzN2I5MjM2NzE4YjY4ZjczODEzOGU2NQ==
+    Yzg1YWQyODM4YmRhOThjMTFhODhjY2IyNWZjMzVmNzdkOWMxMzdmNw==
 SHA512:
   metadata.gz: !binary |-
-    Y2NmODRlYzAwMGVjODVmN2JiZTFjYjNkMDhiNmJjZTk2YmM3ZWFhNTc3ZjMz
-    ZjU0Y2Q2YzBkMjkxMzhiZTMyYmQ2Nzc3NjlkN2RkMjQzOTFkMGM5YWEwNDk2
-    MTZkNjdhNTZlNDE2ZWJlNjVjODI0YTljYmJhOTVkNDU3Yzg4MDc=
+    ZGQxZTc2MjQwNzNiMzMzZmQ0OTNlNWIxMTU4Y2ExODhlN2EzOTgzNzAyNGJj
+    YjA4ODg3YTQ3MTFiMmViMjc0ODVjNTcxNTMyODg4Mzk5MmM4MThmZmVlYWNk
+    MTJiNjk5MmU0YThmNTcyYWIxZWQzYTg3MGJlZjU0Y2ZlNDU3NDc=
   data.tar.gz: !binary |-
-    MzAwMDk3MWIzM2E2Y2RjZDZkZjQyZDVmOGE3YTFmOWQ0N2ViZDlmMTM1ZjZj
-    MWZiMWE2YzQ1YzgzNDllY2E3ZmI3N2NjN2QxMWU3OWI5YzE2NjY4M2FkMjE5
-    ZjY4NjM4OTRhZWU1YmIxMTgzMTY5ZTY4NmYzM2MzNmVkNjQ0N2Q=
+    M2ZiNjg4ZmRmZjY3ZDA2Y2E0ZjNlMWFmMWQ3NjEyNmNmNTY5OWQ2MWIzMmMx
+    NjA4NjdlNDgzMThjZTEzNDIzOTFmMTEyY2E4ODZjNjMzODhlYzgwYThmZDI0
+    ZGFmM2RlYmFkZDRkNTVhNDQwNmExNjYwZjAyY2EzNzgwNmE4ODk=

data/README.md

@@ -27,8 +27,17 @@ using in middleware:
 using in your Rails application, add the following line to your application config file (`config/application.rb` for Rails 3 and above, `config/environment.rb` for Rails 2):
 
 ```ruby
-  config.middleware.use Staccato::Rack::Middleware, 'UA-TRACKING-KEY-HERE', logger: Rails.logger
+  config.middleware.use Staccato::Rack::Middleware, 'UA-TRACKING-KEY-HERE'
 ```
+
+if you want logging in rails add a initializers file with the following
+
+```ruby
+  ContikiApi::Application.configure do
+    config.middleware.use Staccato::Rack::Middleware, Rails.application.secrets.ga_tracking_id, logger: Rails.logger
+  end
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/staccato/rack.rb

@@ -5,6 +5,7 @@ require 'ostruct'
 
 module Staccato
   module Rack
+    # Proxy Class to do page views
     class PageView < OpenStruct
       def initialize
         super
@@ -33,13 +34,12 @@ module Staccato
       private
 
       def track_hit(tracker, page_view_params, request)
-        hit = Staccato::Pageview.new(tracker, page_view_params.merge(path: request.fullpath,
-                                                                     hostname: request.host,
-                                                                     user_agent: request.env['HTTP_USER_AGENT'],
-                                                                     user_ip: request.ip))
+        hit = Staccato::Pageview.new(tracker, { path: request.fullpath,
+                                                user_agent: request.env['HTTP_USER_AGENT'],
+                                                user_ip: request.ip }.merge(page_view_params))
         add_custom_to_hit(hit)
         r = hit.track!
-        logger.info "GA Tracking: #{hit.params.inspect} => #{r.response.code if r}"
+        log_response(r, hit)
         hit
       end
 
@@ -51,8 +51,13 @@ module Staccato
           hit.add_custom_dimension(p, v)
         end
       end
+
+      def log_response(r, hit)
+        logger.info "GA Tracking: #{hit.params.inspect} => #{r.response.code if r}"
+      end
     end
 
+    # Null Logger clas
     class NullLogger
       def info(*)
       end
@@ -72,7 +77,7 @@ module Staccato
       end
 
       def call(env)
-        env['staccato.pageview'] = PageView.new.tap{|p| p.logger = @logger }
+        env['staccato.pageview'] = PageView.new.tap { |p| p.logger = @logger }
 
         @last_hit = nil
         status, headers, body  = @app.call(env)

data/lib/staccato/rack/version.rb

@@ -2,6 +2,6 @@
 module Staccato
   # rack module
   module Rack
-    VERSION = '0.3.1'
+    VERSION = '0.3.2'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: staccato-rack
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Grant Speelman