stable-cli-rails 0.8.0 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab8c647151029030baf0e96737f45f20cc6b067b952b032b98eac46e5e14e158
-  data.tar.gz: 5db558cabc869e1f6d6684d26b1d7b08178679194d09ebdbbd42aa67d828aee7
+  metadata.gz: 0a7c350e5e5b2858a8a8ceb9e35eb9772c0e3416accf9f8e3546ba072ae59833
+  data.tar.gz: ed890e3547579a9361c473a8b884166a87d4454f1b89874e53510138f38e43f9
 SHA512:
-  metadata.gz: fe68968ac73be6725262a224ceda502eaee576c2aa3a8822a2742577e9f5d6fc05f1c3092c6f7f1c0f011218aaa851949863e3473e8ea95de9e6fd91b94f31dc
-  data.tar.gz: e333ac1da62ceb50a7a77ec83d1c145900f90b8888249c4307102bc1dfb0e3661e0bf97c1efe5a33be27b1aa409e639278ca91643989c3c2c0954d763c665533
+  metadata.gz: 9f86445108712b6eb9cb99a14f5da5df53e14d11d646d3ccc9525dc23efec767ae2a6a2f6cb68c0ac032f75928992dfb0913580900ebae6d2426660051f5191b
+  data.tar.gz: 2965495aa69ea21c4c19c7020222a90ee84214d05530a1b6175e9ce6689dda13d94a508cb708c9d2c2447f8b484b6afe127e7ae19c08efcf5dfefea247757d03

data/lib/stable/cli.rb

@@ -75,6 +75,11 @@ module Stable
       Commands::Remove.new(name).call
     end
 
+    desc 'destroy NAME', 'Permanently delete a Rails app and all its files'
+    def destroy(name)
+      Commands::Destroy.new(name).call
+    end
+
     desc 'start NAME', 'Start a Rails app with its correct Ruby version'
     def start(name)
       Commands::Start.new(name).call
@@ -156,7 +161,7 @@ module Stable
     end
 
     def port_in_use?(port)
-      system("lsof -i tcp:#{port} > /dev/null 2>&1")
+      Stable::Utils::Platform.port_in_use?(port)
     end
   end
 end

data/lib/stable/commands/destroy.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+require 'io/console'
+
+module Stable
+  module Commands
+    # Destroy command - permanently deletes a Rails application with confirmation
+    class Destroy
+      def initialize(name)
+        @name = name
+      end
+
+      def call
+        app = Services::AppRegistry.find(@name)
+        abort 'App not found' unless app
+
+        display_warning(app)
+        return unless confirm_destruction
+
+        puts "\n🗑️  Destroying #{@name}..."
+        perform_destruction(app)
+        puts "✅ Successfully destroyed #{@name}"
+      end
+
+      private
+
+      def display_warning(app)
+        puts "⚠️  WARNING: This will permanently delete the application '#{@name}'"
+        puts "   Path: #{app[:path]}"
+        puts "   Domain: #{app[:domain]}"
+        puts '   This action CANNOT be undone!'
+        puts ''
+      end
+
+      def confirm_destruction
+        print "Type '#{@name}' to confirm destruction: "
+        confirmation = $stdin.gets&.strip
+        puts ''
+
+        if confirmation == @name
+          true
+        else
+          puts "❌ Destruction cancelled - confirmation didn't match"
+          false
+        end
+      end
+
+      def perform_destruction(app)
+        # Stop the app if running
+        Services::ProcessManager.stop(app)
+
+        # Remove from infrastructure
+        Services::HostsManager.remove(app[:domain])
+        Services::CaddyManager.remove(app[:domain])
+        Services::AppRegistry.remove(@name)
+
+        # Clean up RVM gemset
+        cleanup_rvm_gemset(app)
+
+        # Delete the project directory
+        delete_project_directory(app[:path])
+
+        # Reload Caddy
+        Services::CaddyManager.reload
+      end
+
+      def cleanup_rvm_gemset(app)
+        # Only clean up RVM gemsets on Unix-like systems (macOS/Linux)
+        # Windows uses different Ruby version managers
+        return unless Stable::Utils::Platform.unix?
+
+        ruby_version = app[:ruby]
+        # Handle different ruby version formats (e.g., "3.4.7", "ruby-3.4.7")
+        clean_ruby_version = ruby_version.to_s.sub(/^ruby-/, '')
+        gemset_name = "#{clean_ruby_version}@#{@name}"
+
+        puts "   Cleaning up RVM gemset #{gemset_name}..."
+        begin
+          # Use system to run RVM command to delete the gemset
+          system("bash -lc 'source ~/.rvm/scripts/rvm && rvm gemset delete #{gemset_name} --force' 2>/dev/null || true")
+          puts "   ✅ RVM gemset #{gemset_name} cleaned up"
+        rescue StandardError => e
+          puts "   ⚠️  Could not clean up RVM gemset #{gemset_name}: #{e.message}"
+        end
+      end
+
+      def delete_project_directory(path)
+        if File.exist?(path)
+          puts '   Deleting project directory...'
+          FileUtils.rm_rf(path)
+        else
+          puts '   Project directory not found (already deleted?)'
+        end
+      end
+    end
+  end
+end

data/lib/stable/commands/list.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative '../utils/platform'
+
 module Stable
   module Commands
     # List command - displays all registered applications
@@ -15,25 +17,22 @@ module Stable
         print_header
 
         apps.each do |app|
-          puts format_row(app)
+          # Determine status based on whether the app is actually running (port check)
+          status = app_running?(app) ? 'running' : 'stopped'
+          puts format_row(app, status)
         end
       end
 
       private
 
-      def print_header
-        puts 'APP                DOMAIN                     PORT     RUBY       STATUS    '
-        puts '-' * 78
-      end
+      def app_running?(app)
+        return false unless app && app[:port]
 
-      def format_row(app)
-        status =
-          if app[:started_at]
-            'running'
-          else
-            'stopped'
-          end
+        # Check if something is listening on the app's port (cross-platform)
+        Stable::Utils::Platform.port_in_use?(app[:port])
+      end
 
+      def format_row(app, status)
         format(
           '%<name>-18s %<domain>-26s %<port>-8s %<ruby>-10s %<status>-10s',
           name: app[:name],
@@ -43,6 +42,11 @@ module Stable
           status: status
         )
       end
+
+      def print_header
+        puts 'APP                DOMAIN                     PORT     RUBY       STATUS    '
+        puts '-' * 78
+      end
     end
   end
 end

data/lib/stable/registry.rb

@@ -66,6 +66,21 @@ module Stable
     def self.remove_app_config(app_name)
       config_file = Stable::Paths.app_config_file(app_name)
       FileUtils.rm_f(config_file)
+
+      # Also remove from legacy apps.yml file for backward compatibility
+      remove_from_legacy_file(app_name)
+    end
+
+    def self.remove_from_legacy_file(app_name)
+      legacy_file = Stable::Paths.apps_file
+      return unless File.exist?(legacy_file)
+
+      data = YAML.load_file(legacy_file) || []
+      filtered_data = data.reject { |entry| entry.is_a?(Hash) && entry['name'] == app_name }
+
+      return unless filtered_data != data
+
+      File.write(legacy_file, filtered_data.to_yaml)
     end
 
     def self.parse_config_file(config_file)

data/lib/stable/services/app_creator.rb

@@ -192,7 +192,7 @@ module Stable
       end
 
       def port_in_use?(port)
-        system("lsof -i tcp:#{port} > /dev/null 2>&1")
+        Stable::Utils::Platform.port_in_use?(port)
       end
 
       def wait_for_port(port, timeout: 20)

data/lib/stable/services/app_registry.rb

@@ -55,7 +55,31 @@ module Stable
           return unless app
 
           updated_app = app.merge(attrs)
-          Stable::Registry.save_app_config(name, updated_app)
+
+          # Check if this is a legacy app (from apps.yml) or new format app
+          config_file = Stable::Paths.app_config_file(name)
+          if File.exist?(config_file)
+            # New format: update individual config file
+            Stable::Registry.save_app_config(name, updated_app)
+          else
+            # Legacy format: update apps.yml file
+            update_legacy_app(name, updated_app)
+          end
+        end
+
+        def update_legacy_app(name, updated_app)
+          legacy_file = Stable::Paths.apps_file
+          return unless File.exist?(legacy_file)
+
+          data = YAML.load_file(legacy_file) || []
+          idx = data.find_index { |app| app['name'] == name || app[:name] == name }
+
+          return unless idx
+
+          # Convert symbols to strings for YAML compatibility
+          legacy_format = updated_app.transform_keys(&:to_s)
+          data[idx] = legacy_format
+          File.write(legacy_file, data.to_yaml)
         end
 
         def mark_stopped(name)

data/lib/stable/services/app_starter.rb

@@ -21,6 +21,14 @@ module Stable
 
         if app_running?(app)
           puts "#{@name} is already running on https://#{app[:domain]} (port #{port})"
+          # Update the registry with the correct PID if it's missing
+          if !app[:pid] || !app[:started_at]
+            rails_pid = find_rails_pid(port)
+            if rails_pid
+              AppRegistry.update(app[:name], started_at: Time.now.to_i, pid: rails_pid)
+              puts "Updated registry with correct PID (#{rails_pid})"
+            end
+          end
           return
         end
 
@@ -51,7 +59,9 @@ module Stable
 
         wait_for_port(port, timeout: 30)
 
-        AppRegistry.update(app[:name], started_at: Time.now.to_i, pid: pid)
+        # Find the actual Rails process PID by checking what's listening on the port
+        rails_pid = find_rails_pid(port)
+        AppRegistry.update(app[:name], started_at: Time.now.to_i, pid: rails_pid)
 
         Stable::Services::CaddyManager.add_app(app[:name], skip_ssl: false)
         Stable::Services::CaddyManager.reload
@@ -69,7 +79,7 @@ module Stable
       end
 
       def port_in_use?(port)
-        system("lsof -i tcp:#{port} > /dev/null 2>&1")
+        Stable::Utils::Platform.port_in_use?(port)
       end
 
       def wait_for_port(port, timeout: 20)
@@ -87,9 +97,20 @@ module Stable
       end
 
       def app_running?(app)
-        return false unless app && app[:port]
+        return false unless app
+
+        # First check if we have PID info and if the process is alive
+        return ProcessManager.pid_alive?(app[:pid]) if app[:pid] && app[:started_at]
+
+        # Fallback to port checking if no PID info available
+        return false unless app[:port]
+
+        Stable::Utils::Platform.port_in_use?(app[:port])
+      end
 
-        system("lsof -i tcp:#{app[:port]} -sTCP:LISTEN > /dev/null 2>&1")
+      def find_rails_pid(port)
+        pids = Stable::Utils::Platform.find_pids_by_port(port)
+        pids.first
       end
     end
   end

data/lib/stable/services/process_manager.rb

@@ -36,20 +36,27 @@ module Stable
 
         Process.detach(pid)
 
-        AppRegistry.update(app[:name], started_at: Time.now.to_i, pid: pid)
+        # Wait a moment for Rails to start, then find the actual Rails PID
+        sleep 2
+        rails_pid = find_rails_pid(app[:port])
 
-        pid
+        AppRegistry.update(app[:name], started_at: Time.now.to_i, pid: rails_pid || pid)
+
+        rails_pid || pid
       end
 
       def self.stop(app)
-        pid = app[:pid]
-        return unless pid
+        return unless app[:port]
 
-        output = `lsof -i tcp:#{app[:port]} -t`.strip
-        if output.empty?
+        pids = Stable::Utils::Platform.find_pids_by_port(app[:port])
+        if pids.empty?
           puts "No app running on port #{app[:port]}"
         else
-          output.split("\n").each { |pid| Process.kill('TERM', pid.to_i) }
+          pids.each do |pid|
+            Process.kill('TERM', pid.to_i)
+          rescue StandardError
+            nil
+          end
           puts "Stopped #{app[:name]} on port #{app[:port]}"
         end
 
@@ -57,6 +64,43 @@ module Stable
       rescue Errno::ESRCH
         AppRegistry.update(app[:name], started_at: nil, pid: nil)
       end
+
+      # Check if a process with the given PID is still running
+      def self.pid_alive?(pid)
+        return false unless pid
+
+        # Use a cross-platform method to check if PID exists
+        if RUBY_PLATFORM =~ /mingw|mswin|win32/
+          # Windows: use tasklist
+          system("tasklist /FI \"PID eq #{pid}\" 2>NUL | find /I \"#{pid}\" >NUL")
+        else
+          # Unix-like systems: check /proc or use ps
+          begin
+            Process.kill(0, pid)
+            true
+          rescue Errno::ESRCH
+            false
+          rescue Errno::EPERM
+            # Process exists but we don't have permission to signal it
+            true
+          end
+        end
+      end
+
+      # Validate and clean up stale app statuses
+      def self.validate_app_statuses
+        apps = AppRegistry.all
+        apps.each do |app|
+          next unless app[:started_at] && app[:pid]
+
+          AppRegistry.update(app[:name], started_at: nil, pid: nil) unless pid_alive?(app[:pid])
+        end
+      end
+
+      def self.find_rails_pid(port)
+        pids = Stable::Utils::Platform.find_pids_by_port(port)
+        pids.first
+      end
     end
   end
 end

data/lib/stable/utils/platform.rb

@@ -49,6 +49,36 @@ module Stable
           Dir.home
         end
 
+        def port_in_use?(port)
+          case current
+          when :macos, :linux
+            # Use lsof on Unix-like systems
+            system("lsof -i tcp:#{port} -sTCP:LISTEN > /dev/null 2>&1")
+          when :windows
+            # Use netstat on Windows
+            system("netstat -an | findstr :#{port} > nul 2>&1")
+          else
+            false
+          end
+        end
+
+        def find_pids_by_port(port)
+          case current
+          when :macos, :linux
+            # Use lsof to find PIDs listening on the port
+            output = `lsof -i tcp:#{port} -sTCP:LISTEN -t 2>/dev/null`.strip
+            return [] if output.empty?
+
+            output.split("\n").map(&:to_i)
+          when :windows
+            # On Windows, this is more complex. For now, return empty array
+            # Could potentially parse netstat output in the future
+            []
+          else
+            []
+          end
+        end
+
         private
 
         def detect_linux_package_manager

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: stable-cli-rails
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.8.2
 platform: ruby
 authors:
 - Danny Simfukwe
@@ -37,6 +37,7 @@ files:
 - lib/stable.rb
 - lib/stable/bootstrap.rb
 - lib/stable/cli.rb
+- lib/stable/commands/destroy.rb
 - lib/stable/commands/doctor.rb
 - lib/stable/commands/list.rb
 - lib/stable/commands/new.rb