sso 0.1.0.alpha2 → 0.1.0.alpha3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dcd7cedda8e78677b8c5ea0eff1a558659daa1c1
-  data.tar.gz: 79fe0ceb4869c29d8a1cf886018816e76ca0d616
+  metadata.gz: c4a6a80459c2744400e199338c38ffbf615e1eb3
+  data.tar.gz: 704b504eeb29a8533990c91ad3dc94690449fba8
 SHA512:
-  metadata.gz: 755b13e0c16bc4824e1c2bf33a0adc5a4a5078367ad0efccca69d7efc9295c44909722df80b73ca7d65bbc059f744bcf57715aa731c1d9e49a6df845e6c7957a
-  data.tar.gz: 5237534c2a282e8fb04cffe903774526c16f347f40b9dff1e3a8f73bd1eefd09fdcb74c922a148516b4bc8a9d9cbe946c037dafd6eea0143e221b2e9ff40a260
+  metadata.gz: b6ecb0b90995bfb8752ae003e76686d25686f70814529ce3aa9ddbf81e6c68e3b421173626a6cff9dddd208b40b22a9bd63fc4714361bea749effab9dc9c7ea2
+  data.tar.gz: 291961838cee93dbb188b90b2286decacb9290b39bd10a4bf85db80e2c615dfc4f1b98583e8a6a6b8b9c96091c191d7f1176627ebedca21e47929b284b391956

data/lib/sso/client/warden/hooks/after_fetch.rb

@@ -126,6 +126,7 @@ module SSO
             # This will be a hook for e.g. statistics, benchmarking, etc, measure everything
           end
 
+          # TODO Use ActionDispatch remote IP or you might get the Load Balancer's IP instead :(
           def ip
             warden.request.ip
           end

data/lib/sso/client.rb

@@ -2,6 +2,7 @@ require 'httparty'
 require 'signature'
 require 'warden'
 
+require 'sso'
 require 'sso/client/passport'
 require 'sso/client/omniauth/strategies/sso'
 require 'sso/client/warden/hooks/after_fetch'

data/lib/sso/server.rb

@@ -6,6 +6,7 @@ require 'omniauth'
 require 'signature'
 require 'warden'
 
+require 'sso'
 require 'sso/server/errors'
 require 'sso/server/passport'
 require 'sso/server/passports'

data/spec/dummy/config/initializers/warden.rb

@@ -7,6 +7,16 @@
   def authenticate!
     Rails.logger.debug(progname) { 'Authenticating from username and password...' }
 
+    # Note that at this point you might want to log the end-user IP for the attempted login.
+    # That's up to you to solve, but remember one thing:
+    # If you both have an untrusted OAuth client (iPhone) and a trusted one (Alpha Rails app)
+    # and the login at Alpha is performed using the "Resource Owner Password Credentials Grant"
+    # Then you will get Alphas IP, but not the end-users IP. So you might have to pass on the
+    # end user IP from Alpha via params. But you cannot trust params, since the iPhone Client
+    # is not trusted. Thus, in this particular scenario, you cannot blindly trust params['ip']
+    # but you'd have to work with the "insider" and "outsider" doorkeeper application scope
+    # restrictions much like SSO::Server::Authentications::Passport#ip does.
+
     user = ::User.authenticate params['username'], params['password']
 
     if user

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sso
 version: !ruby/object:Gem::Version
-  version: 0.1.0.alpha2
+  version: 0.1.0.alpha3
 platform: ruby
 authors:
 - halo