sslcheck 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a075cf5e3b713809cd61544cf345b165fdf1be2c
-  data.tar.gz: 7b89a07840bf5603d5d65335a88494cd0cbe508e
+  metadata.gz: 1c3ce9df50f1a9a75dfb026a443247e70f2af5c0
+  data.tar.gz: bc183a64ea589568f9040b5e1b3472ebd3b898e1
 SHA512:
-  metadata.gz: e8e4f729e4f9e7b0a397d00b691a0c545a96e30c6adb8d339662082002337af54dde35f53d8e1a07c1a7cb42015f80e0bf325e55e30c1dd705827c5c523decf0
-  data.tar.gz: 04b28414f967088e0fcb97bff3c530857bc83e5717ed871f5e28ea7870ae3571fb3b73d21d1bf37bab129f1b032c6c1c9e01d3e7c05cecd646fe2e73bed841b2
+  metadata.gz: e09b4272a3cbc40320f2e5d99d1bcebc8b5a94abdb0be054f5fb7964b68072923d071045e125a9c4bd80a7f99a30e8836a36e6cfbce3ac2759352cd1a3cfe8c0
+  data.tar.gz: db41d48b91c4beabf136608d2b94290403d9e95d63fe5efc50dcd38ade28b1a732d882d0b603f9720a5585cdd0d344edf0f94678e485be2b54c3a0134519d762

data/acceptance/checking_certificates_spec.rb

@@ -2,6 +2,17 @@ require 'spec_helper'
 
 module SSLCheck
   describe 'Checking Certificates' do
+    context "when the certificate is missing" do
+      before do
+        @check = Check.new.check("www.claytonlz.com")
+      end
+      it 'should not be valid' do
+        expect(@check.valid?).to_not be
+      end
+      it 'should have errors' do
+        expect(@check.errors).to_not be_empty
+      end
+    end
     context "when the certificate is valid" do
       before do
         @check = Check.new.check("http://www.sslinsight.com")

data/lib/sslcheck/check.rb

@@ -47,13 +47,17 @@ module SSLCheck
 
     def fetch(url)
       response = @client.get(url)
-      self.peer_cert = response.peer_cert
-      self.ca_bundle = response.ca_bundle
-      self.host_name = response.host_name
+
+      if response.errors.empty?
+        self.peer_cert = response.peer_cert
+        self.ca_bundle = response.ca_bundle
+        self.host_name = response.host_name
+      end
 
       response.errors.each do |error|
         @errors << error
       end
+
       true
     end
 

data/lib/sslcheck/client.rb

@@ -38,7 +38,7 @@ module SSLCheck
 
         sock = TCPSocket.new(uri.host, 443)
         ctx = OpenSSL::SSL::SSLContext.new
-        ctx.set_params(verify_mode: OpenSSL::SSL::VERIFY_PEER)
+        ctx.set_params(:verify_mode => OpenSSL::SSL::VERIFY_PEER)
 
         @socket = OpenSSL::SSL::SSLSocket.new(sock, ctx).tap do |socket|
           socket.sync_close = true

data/lib/sslcheck/validator.rb

@@ -55,57 +55,3 @@ module SSLCheck
 
   end
 end
-
-  #   class InvalidCertificate < StandardError;end
-  #   class InvalidCommonName < StandardError;end
-  #   class InvalidDates < StandardError;end
-  #   class MissingCACertificate < StandardError;end
-
-  #   def initialize(parser=nil)
-  #     @parser = parser
-  #     @url = parser.url
-  #   end
-
-  #   def validate
-  #     raise InvalidCertificate unless validate_certificates
-  #     raise InvalidCommonName, "expected #{@url} but got #{certificate.common_name}" unless validate_common_name
-  #     raise InvalidDates, "Issued On: #{certificate.not_before}, Expires On: #{certificate.not_after}" unless validate_dates
-  #     true
-  #   end
-
-  #   def validate_certificates
-  #     certificate.verify(ca_bundle)
-  #   end
-
-  #   def validate_common_name
-  #     matching_wildcard_domain || certificate.common_name.downcase == @url.downcase
-  #   end
-
-  #   def validate_expiration_date
-  #     !certificate.expired?
-  #   end
-
-  #   def validate_issue_date
-  #     certificate.issued?
-  #   end
-
-  #   def validate_dates
-  #     validate_expiration_date && validate_issue_date
-  #   end
-
-  # private
-  #   def certificate
-  #     @parser.certificate
-  #   end
-
-  #   def matching_wildcard_domain
-  #     true if (certificate.common_name.match(/\*\./) && @url.include?(certificate.common_name.gsub(/\*\./,'')))
-  #   end
-
-  #   def ca_bundle
-  #     begin
-  #       @parser.ca_bundle
-  #     rescue OpenSSL::X509::CertificateError => e
-  #       raise MissingCACertificate
-  #     end
-  #   end

data/lib/sslcheck/version.rb

@@ -1,3 +1,3 @@
 module SSLCheck
-  VERSION = "0.9.1"
+  VERSION = "0.9.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sslcheck
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Clayton Lengel-Zigich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-19 00:00:00.000000000 Z
+date: 2015-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler