sshkit 1.18.1 → 1.18.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b0eb90af6c1f3c123cafc1739b6c8783d5a41a18eb93c962cfd39909e955ad1d
-  data.tar.gz: a5fc8373c24f79313fd6ec129e5cc67f8f8a9e8db37edd6d6188489de9c828c7
+  metadata.gz: 886f5d73c7b9a9570763c9f0612130367e2eaf484056d937635661de55755c1b
+  data.tar.gz: 2bb004e4b0df817573f5908269388abf0f8f016c3b25822db5df337eb857d0f3
 SHA512:
-  metadata.gz: 218acec6e67c5e4c71e4db4a9f69e1417339038d8d585b3fc16822714c962676e06eecd84664dd190896d682fd25782ce42c094332c8060ae4bad319b7b11849
-  data.tar.gz: 2752f4f661e29a627e946f3b14f85aacdc3a97a3c744380a9deb1f81bbc2ac8b8e9cf778f889ac036133540b62870080ac56b03aa03d1996bc873990263ad522
+  metadata.gz: d3d4bbf920f05e70bfa1c9333e5f39d91b43fe28a63d726236b521315b6a0cf9b4132e29a26383992bf072d5186b0abbd4203c4c3c13c7c126666fe1a3876ed7
+  data.tar.gz: '082d51b64a6690cc09ed82f958c7bd9f3971c8ab6340075caf718fab56c72092a31f78fea493c5eb61e74b5e4994bbdec5eae6c6802cfe8b90766aa52789f60c'

data/CHANGELOG.md

@@ -7,6 +7,10 @@ appear at the top.
 
   * Your contribution here!
 
+## [1.18.2][] (2019-02-03)
+
+  * [#448](https://github.com/capistrano/sshkit/pull/448): Fix misbehaving connection eviction loop when disabling connection pooling - [Sebastian Cohnen](https://github.com/tisba)
+
 ## [1.18.1][] (2019-01-26)
 
   * [#447](https://github.com/capistrano/sshkit/pull/447): Fix broken thread safety by widening critical section - [Takumasa Ochi](https://github.com/aeroastro)
@@ -754,7 +758,8 @@ version `0.0.5`.
 
 First release.
 
-[Unreleased]: https://github.com/capistrano/sshkit/compare/v1.18.1...HEAD
+[Unreleased]: https://github.com/capistrano/sshkit/compare/v1.18.2...HEAD
+[1.18.2]: https://github.com/capistrano/sshkit/compare/v1.18.1...v1.18.2
 [1.18.1]: https://github.com/capistrano/sshkit/compare/v1.18.0...v1.18.1
 [1.18.0]: https://github.com/capistrano/sshkit/compare/v1.17.0...v1.18.0
 [1.17.0]: https://github.com/capistrano/sshkit/compare/v1.16.1...v1.17.0

data/lib/sshkit/backends/connection_pool.rb

@@ -21,7 +21,7 @@ end
 
 # The ConnectionPool caches connections and allows them to be reused, so long as
 # the reuse happens within the `idle_timeout` period. Timed out connections are
-# closed, forcing a new connection to be used in that case.
+# eventually closed, forcing a new connection to be used in that case.
 #
 # Additionally, a background thread is started to check for abandoned
 # connections that have timed out without any attempt at being reused. These
@@ -46,7 +46,11 @@ class SSHKit::Backend::ConnectionPool
     @caches = {}
     @caches.extend(MonitorMixin)
     @timed_out_connections = Queue.new
-    Thread.new { run_eviction_loop }
+
+    # Spin up eviction loop only if caching is enabled
+    if cache_enabled?
+      Thread.new { run_eviction_loop }
+    end
   end
 
   # Creates a new connection or reuses a cached connection (if possible) and
@@ -133,7 +137,7 @@ class SSHKit::Backend::ConnectionPool
       process_deferred_close
 
       # Periodically sweep all Caches to evict stale connections
-      sleep([idle_timeout, 5].min)
+      sleep(5)
       caches.values.each(&:evict)
     end
   end

data/lib/sshkit/version.rb

@@ -1,3 +1,3 @@
 module SSHKit
-  VERSION = "1.18.1".freeze
+  VERSION = "1.18.2".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sshkit
 version: !ruby/object:Gem::Version
-  version: 1.18.1
+  version: 1.18.2
 platform: ruby
 authors:
 - Lee Hambley
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-26 00:00:00.000000000 Z
+date: 2019-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-ssh
@@ -284,7 +284,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: SSHKit makes it easy to write structured, testable SSH commands in Ruby