sshkit 0.0.13 → 0.0.14

data/CHANGELOG.md

@@ -3,6 +3,13 @@
 This file is written in reverse chronological order, newer releases will
 appear at the top.
 
+## 0.0.14
+
+ * Umasks can now be set on `Command` instances. It can be set globally with
+   `SSHKit.config.umask` (default, nil; meaning take the system default). This
+   can be used to set, for example a umask of `007` for allowing users with
+   the same primary group to share code without stepping on eachother's toes.
+
 ## 0.0.13
 
  * Correctly quote `as(user)` commands, previously it would expand to:

data/lib/sshkit/command.rb

@@ -147,6 +147,9 @@ module SSHKit
         if options[:run_in_background]
           cs << 'nohup '
         end
+        if umask = SSHKit.config.umask
+          cs << "umask #{umask} && "
+        end
         cs << SSHKit.config.command_map[command.to_sym]
         if args.any?
           cs << ' '

data/lib/sshkit/configuration.rb

@@ -2,6 +2,7 @@ module SSHKit
 
   class Configuration
 
+    attr_accessor :umask
     attr_writer :output, :backend, :default_env, :command_map
 
     def output

data/lib/sshkit/version.rb

@@ -1,3 +1,3 @@
 module SSHKit
-  VERSION = "0.0.13"
+  VERSION = "0.0.14"
 end

data/test/unit/test_command.rb

@@ -96,6 +96,30 @@ module SSHKit
       assert_equal "( A=b sudo su anotheruser -c \"nohup /usr/bin/env sleep 15 > /dev/null &\" )", String(c)
     end
 
+    def test_umask
+      SSHKit.config.umask = '007'
+      c = Command.new(:touch, 'somefile')
+      assert_equal "umask 007 && /usr/bin/env touch somefile", String(c)
+    end
+
+    def test_umask_with_working_directory
+      SSHKit.config.umask = '007'
+      c = Command.new(:touch, 'somefile', in: '/opt')
+      assert_equal "cd /opt && umask 007 && /usr/bin/env touch somefile", String(c)
+    end
+
+    def test_umask_with_working_directory_and_user
+      SSHKit.config.umask = '007'
+      c = Command.new(:touch, 'somefile', in: '/var', user: 'alice')
+      assert_equal "cd /var && sudo su alice -c \"umask 007 && /usr/bin/env touch somefile\"", String(c)
+    end
+
+    def test_umask_with_env_and_working_directory_and_user
+      SSHKit.config.umask = '007'
+      c = Command.new(:touch, 'somefile', user: 'bob', env: {a: 'b'}, in: '/var')
+      assert_equal "cd /var && ( A=b sudo su bob -c \"umask 007 && /usr/bin/env touch somefile\" )", String(c)
+    end
+
     def test_complete?
       c = Command.new(:whoami, raise_on_non_zero_exit: false)
       refute c.complete?

data/test/unit/test_configuration.rb

@@ -15,6 +15,12 @@ module SSHKit
       assert SSHKit.config.output = $stderr
     end
 
+    def test_umask
+      assert SSHKit.config.umask.nil?
+      assert SSHKit.config.umask = '007'
+      assert_equal '007', SSHKit.config.umask
+    end
+
     def test_default_env
       assert SSHKit.config.default_env
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sshkit
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
   prerelease: 
 platform: ruby
 authors: