squared 0.4.14 → 0.5.0

data/lib/squared/workspace/project/git.rb

@@ -27,7 +27,7 @@ module Squared
           base = name
           @project.each_value { |proj| repo << proj if !proj.parent && check.call(proj) }
         else
-          warn log_message(Logger::WARN, name, subject: 'git', hint: 'invalid') if warning
+          warn log_message(Logger::WARN, name, subject: 'git', hint: 'invalid', pass: true) if warning
           return self
         end
         if base
@@ -91,13 +91,13 @@ module Squared
 
         data = @revdoc
         last = keys.pop
-        for key in keys
+        keys.each do |key|
           if data[key].is_a?(Hash)
             data = data[key]
           elsif create
             data = data[key] = {}
           else
-            return
+            return nil
           end
         end
         data[last] = val
@@ -157,13 +157,14 @@ module Squared
       class Git < Base
         OPT_GIT = {
           common: %w[c=q bare glob-pathspecs icase-pathspecs literal-pathspecs no-optional-locks no-pager
-                     no-replace-objects noglob-pathspecs paginate config-env=q exec-path=p namespace=p].freeze,
+                     no-replace-objects noglob-pathspecs paginate attr-source=b config-env=q exec-path=p
+                     namespace=p].freeze,
           add: %w[A|all e|edit f|force ignore-errors ignore-missing ignore-removal i|interactive no-all
                   no-ignore-removal n|dry-run p|patch pathspec-file-nul renormalize sparse u|update v|verbose
                   chmod=b pathspec-from-file=p].freeze,
-          branch: %w[a|all create-reflog i|ignore-case q|quiet r|remotes v|verbose vv abbrev=i color=b column=b
-                     contains=b format=q merged=b no-contains=b no-merged=b points-at=b u|set-upstream-to=b sort=q
-                     t|track=b].freeze,
+          branch: %w[a|all create-reflog i|ignore-case omit-empty q|quiet r|remotes v|verbose vv abbrev=i color=b
+                     column=b contains=b format=q merged=b no-contains=b no-merged=b points-at=b u|set-upstream-to=b
+                     sort=q t|track=b].freeze,
           checkout: %w[l d|detach f|force ignore-other-worktrees ignore-skip-worktree-bits m|merge p|patch
                        pathspec-file-nul q|quiet ours theirs conflict=b orphan=b pathspec-from-file=p t|track=b].freeze,
           diff: {
@@ -171,7 +172,8 @@ module Squared
             show: %w[s exit-code histogram].freeze
           }.freeze,
           fetch: {
-            base: %w[multiple progress P|prune-tags refetch stdin u|update-head-ok recurse-submodules-default=b].freeze,
+            base: %w[multiple porcelain progress P|prune-tags refetch stdin u|update-head-ok
+                     recurse-submodules-default=b].freeze,
             pull: %w[4 6 n t a|append atomic dry-run f|force k|keep negotiate-only prefetch p|prune q|quiet
                      set-upstream unshallow update-shallow v|verbose deepen=i depth=i j|jobs=i negotiation-tip=q
                      recurse-submodules=v refmap=q o|server-option=q shallow-exclude=b shallow-since=v
@@ -196,9 +198,9 @@ module Squared
                      branches=q? committer=q decorate=b decorate-refs=q decorate-refs-exclude=q exclude=q
                      exclude-hidden=b glob=q grep=q grep-reflog=q n|max-count=i max-parents=i min-parents=i no-walk=b?
                      remotes=q? since=q since-as-filter=q skip=i tags=q? until=q].freeze,
-            format: %w[t children combined-all-paths oneline left-right no-diff-merges parents relative-date
-                       show-signature date=q diff-merges=b encoding=b expand-tabs=i format=q notes=b pretty=q?
-                       show-linear-break=q?].freeze,
+            format: %w[t children combined-all-paths dd oneline left-right no-diff-merges parents relative-date
+                       show-notes-by-default show-signature date=q diff-merges=b encoding=b expand-tabs=i format=q
+                       notes=b pretty=q? show-linear-break=q?].freeze,
             diff: %w[p R u z B=bm? C=bm? l=im G=qm I=qm M=bm? O=qm S=qm U=im binary check compact-summary cumulative
                      find-copies-harder full-index W|function-context w|ignore-all-space ignore-blank-lines
                      ignore-cr-at-eol ignore-space-at-eol b|ignore-space-change D|irreversible-delete graph
@@ -228,12 +230,13 @@ module Squared
                       theirs W|worktree conflict=b pathspec-from-file=p s|source=b].freeze,
           rev_parse: %w[absolute-git-dir all git-common-dir git-dir is-bare-repository is-inside-git-dir
                         is-inside-work-tree is-shallow-repository local-env-vars no-revs not q|quiet revs-only
-                        shared-index-path show-cdup show-prefix show-superproject-working-tree show-toplevel sq sq-quote
-                        symbolic symbolic-full-name verify abbrev-ref=b? after=q before=q branches=q? default=q
-                        disambiguate=b exclude=q exclude-hidden=b git-path=p glob=q path-format=b? prefix=q remotes=q?
-                        resolve-git-dir=p short=i? show-object-format=b? since=q tags=q? until=q].freeze,
-          show: %w[t combined-all-paths no-diff-merges remerge-diff show-signature diff-merges=b encoding=b
-                   expand-tabs=i notes=q show-notes=q?].freeze,
+                        shared-index-path show-cdup show-prefix show-ref-format show-superproject-working-tree
+                        show-toplevel sq sq-quote symbolic symbolic-full-name verify abbrev-ref=b? after=q before=q
+                        branches=q? default=q disambiguate=b exclude=q exclude-hidden=b git-path=p glob=q
+                        output-object-format=b path-format=b? prefix=q remotes=q? resolve-git-dir=p short=i?
+                        show-object-format=b? since=q tags=q? until=q].freeze,
+          show: %w[t combined-all-paths no-diff-merges remerge-diff show-notes-by-default show-signature diff-merges=b
+                   encoding=b expand-tabs=i notes=q show-notes=q?].freeze,
           stash: {
             common: %w[q|quiet].freeze,
             push: %w[a|all u|include-untracked k|keep-index no-keep-index no-include-untracked pathspec-file-nul
@@ -242,8 +245,8 @@ module Squared
             apply: %w[index].freeze
           }.freeze,
           status: %w[u|ignore-submodules=bm? ignored=b? untracked-files=b?],
-          tag: %w[n=im cleanup=b create-reflog i|ignore-case color=b? column=b contains=b? format=q merged=b?
-                  no-contains=b? no-merged=b? points-at=q sort=q].freeze,
+          tag: %w[n=im cleanup=b create-reflog i|ignore-case omit-empty color=b? column=b contains=b? format=q merged=b?
+                  no-contains=b? no-merged=b? points-at=q sort=q trailer=q].freeze,
           no: {
             branch: %w[color color-moved column track].freeze,
             checkout: %w[overwrite-ignore guess overlay progress recurse-submodules track].freeze,
@@ -340,7 +343,7 @@ module Squared
           'restore' => %i[source staged worktree].freeze,
           'rev' => %i[commit build output].freeze,
           'show' => %i[format oneline textconv].freeze,
-          'stash' => %i[push pop apply branch drop clear list].freeze,
+          'stash' => %i[push pop apply drop clear list].freeze,
           'switch' => %i[create detach merge].freeze,
           'tag' => %i[add sign delete list].freeze
         })
@@ -367,13 +370,13 @@ module Squared
                   case action
                   when 'pull', 'fetch'
                     if flag == :remote
-                      format_desc action, flag, 'remote?,opts*'
+                      format_desc action, flag, 'remote,opts*'
                       task flag, [:remote] do |_, args|
                         if (remote = args.remote)
                           args = args.extras
                         else
                           remote = choice_remote
-                          args = args.to_a
+                          args = args.to_a.drop(1)
                         end
                         __send__(action, flag, args, remote: remote)
                       end
@@ -459,7 +462,6 @@ module Squared
                   when 'stash'
                     format_desc(action, flag, 'opts*', after: case flag
                                                               when :push then 'pathspec*'
-                                                              when :branch then 'name,stash?|:'
                                                               when :clear, :list then nil
                                                               else 'stash?|:' end)
                     task flag do |_, args|
@@ -914,7 +916,7 @@ module Squared
             cmd << '--autostash' if option('autostash')
           else
             cmd << '--autostash' if flag == :autostash
-            if (val = option('rebase', ignore: false))
+            option('rebase', ignore: false) do |val|
               cmd << case val
                      when '0', 'false'
                        '--no-rebase'
@@ -928,7 +930,7 @@ module Squared
           source(sync: sync, sub: if verbose
                                     [
                                       { pat: /^(.+)(\|\s+\d+\s+)([^-]*)(-+)(.*)$/, styles: color(:red), index: 4 },
-                                      { pat: /^(.+)(\|\s+\d+\s+)(\++)(.*)$/, styles: color(:green), index: 3 }
+                                      { pat: /^(.+)(\|\s+\d+\s+)(\++)(-*)(.*)$/, styles: color(:green), index: 3 }
                                     ]
                                   end, **threadargs)
         end
@@ -943,7 +945,7 @@ module Squared
             return unless upstream
 
             op = OptionPartition.new(opts, OPT_GIT[:rebase], cmd, project: self, no: OPT_GIT[:no][:rebase])
-            cmd << upstream
+            cmd << shell_escape(upstream)
             append_head op.shift
             op.clear(pass: false)
           when :onto
@@ -951,7 +953,7 @@ module Squared
 
             cmd << '--interactive' if option('interactive', 'i')
             cmd << shell_option('onto', commit) if commit
-            cmd << upstream
+            cmd << shell_escape(upstream)
             append_head branch
           else
             return unless VAL_GIT[:rebase][:send].include?(command)
@@ -977,23 +979,26 @@ module Squared
 
           cmd = git_session('clone', worktree: false)
           opts = data[1].dup
-          if (val = option('depth', ignore: false))
+          option('depth', ignore: false) do |val|
             if (n = val.to_i) > 0
               opts[:depth] = n
             else
               opts.delete(:depth)
             end
           end
-          opts[:origin] = val if (val = option('origin', ignore: false))
-          if (val = option('branch', strict: true))
-            opts[:branch] = val
+          option('origin', ignore: false) { |val| opts[:origin] = val }
+          if (branch = option('branch', strict: true))
+            opts[:branch] = branch
             opts.delete(:revision)
-          elsif (val = option('revision', strict: true))
-            opts[:revision] = val
-            opts.delete(:branch)
-            opts.delete(:mirror)
+          else
+            option('revision', strict: true) do |val|
+              opts[:revision] = val
+              opts.delete(:branch)
+              opts.delete(:mirror)
+            end
           end
-          opts[:local] = val != '0' if (val = option('local', strict: true))
+          option('local', strict: true) { |val| opts[:local] = val != '0' }
+          option('bare') { |val| opts[:bare] = val }
           opts.delete(:'recurse-submodules') || opts.delete(:'no-recurse-submodules') if append_submodules(from: :clone)
           append_hash opts
           cmd << '--quiet' unless verbose
@@ -1013,26 +1018,12 @@ module Squared
             case flag
             when :push
               append_pathspec op.extras
-            when :pop, :apply, :drop, :branch
+            when :pop, :apply, :drop
               if op.extras.delete(':')
-                if flag == :branch
-                  if op.empty?
-                    values = [['Branch name', true]]
-                  else
-                    op << op.pop
-                  end
-                end
-                out = choice_index('Choose a stash', git_spawn('stash list', stdout: false),
-                                   values: values, column: /^[^@]+@\{(\d+)\}/, force: true)
-                if values
-                  op.merge(out.reverse)
-                else
-                  op << out
-                end
+                op << choice_index('Choose a stash', git_spawn('stash list', stdout: false),
+                                   column: /^[^@]+@\{(\d+)\}/, force: true)
               elsif !op.empty?
-                op << op.pop
-              elsif flag == :branch
-                raise_error 'no branch name'
+                op << shell_escape(op.pop)
               end
               op.clear
             when :clear
@@ -1059,7 +1050,7 @@ module Squared
           cmd = git_session 'status'
           cmd << (option('long') ? '--long' : '--short')
           cmd << '--branch' if option('branch')
-          if (val = option('ignore-submodules', ignore: false))
+          option('ignore-submodules', ignore: false) do |val|
             cmd << basic_option('ignore-submodules', case val
                                                      when '0', 'none'
                                                        'none'
@@ -1080,7 +1071,7 @@ module Squared
                       { pat: /^(.)([A-Z?!])(.+)$/, styles: r, index: 2 },
                       { pat: /^([A-Z?!])(.+)$/, styles: g },
                       { pat: /^(\?\?)(.+)$/, styles: r },
-                      { pat: /^(## )(.+?)(\.{3})(.+)$/, styles: [nil, g, nil, r], index: -1 }
+                      { pat: /^(## )((?~\.{3}))(\.{3})(.+)$/, styles: [nil, g, nil, r], index: -1 }
                     ]
                   else
                     [pat: /^(\t+)([a-z]+: +.+)$/, styles: r, index: 2]
@@ -1094,8 +1085,8 @@ module Squared
         def revbuild(flag = nil, opts = [], sync: nil, **kwargs)
           statusargs = lambda do
             {
-              include: relativepath(Array(kwargs[:include]), all: true),
-              exclude: relativepath(Array(kwargs[:exclude]), all: true)
+              include: relativepath(as_a(kwargs[:include]), all: true),
+              exclude: relativepath(as_a(kwargs[:exclude]), all: true)
             }
           end
           unless workspace.closed
@@ -1118,9 +1109,9 @@ module Squared
             args = op.to_a
           else
             args = []
-            args << basic_option('untracked-files', flag) if (flag = option('untracked-files', prefix: 'git'))
-            args << basic_option('ignore-submodules', flag) if (flag = option('ignore-submodules', prefix: 'git'))
-            args << basic_option('ignored', flag) if (flag = option('ignored', prefix: 'git'))
+            option('untracked-files', prefix: 'git') { |val| args << basic_option('untracked-files', val) }
+            option('ignore-submodules', prefix: 'git') { |val| args << basic_option('ignore-submodules', val) }
+            option('ignored', prefix: 'git') { |val| args << basic_option('ignored', val) }
           end
           if (cur = workspace.rev_entry(name)) && cur['revision'] == sha && !env('REVBUILD_FORCE')
             files = status_digest(*args, **kwargs)
@@ -1204,14 +1195,13 @@ module Squared
           else
             op = OptionPartition.new(opts, OPT_GIT[:checkout], cmd, project: self, no: OPT_GIT[:no][:checkout],
                                                                     first: flag == :path ? matchpathspec : nil)
-            if flag == :path
+            if flag == :commit
+              op.append(commit)
+                .clear(pass: false)
+            else
               append_head
               append_pathspec(op.extras, pass: false)
-              print_success if success?(source)
-              return
             end
-            op.append(commit)
-              .clear(pass: false)
           end
           source
         end
@@ -1244,16 +1234,16 @@ module Squared
             list_result(ret, 'tags', from: from, grep: op.extras)
             return
           end
-          remote ||= option('remote')
+          remote ||= option 'remote'
           source
           git_spawn('push', flag == :delete ? '-d' : nil, remote, *refs.map { |val| shell_quote(val) }) if remote
         end
 
         def log!(flag, opts = [], range: [], index: [])
           cmd, opts = git_session('log', opts: opts)
-          op = OptionPartition.new(opts, collect_hash(OPT_GIT[:log]), cmd, project: self,
-                                                                           no: collect_hash(OPT_GIT[:no][:log]),
-                                                                           first: matchpathspec)
+          op = OptionPartition.new(opts, collect_hash(OPT_GIT[:log]), cmd,
+                                   project: self, no: collect_hash(OPT_GIT[:no][:log]),
+                                   first: matchpathspec)
           case flag
           when :between, :contain
             op << shell_quote(range.join(flag == :between ? '..' : '...'))
@@ -1411,12 +1401,12 @@ module Squared
           stdout = false
           case flag
           when :create
-            if (arg = option('track', ignore: false))
-              cmd << case arg
+            option('track', ignore: false) do |val|
+              cmd << case val
                      when '0', 'false'
                        '--no-track'
                      when 'direct', 'inherit'
-                       basic_option('track', arg)
+                       basic_option 'track', val
                      else
                        '--track'
                      end
@@ -1438,7 +1428,7 @@ module Squared
             remote&.each do |val|
               source git_output('push', '--delete', *val.split('/', 2).map { |s| shell_quote(s) })
             end
-            force, list = refs.partition { |val| val.match?(/^[~^]/) }
+            force, list = refs.partition { |val| val.start_with?(/[~^]/) }
             force.each do |val|
               dr = val[0, 2]
               d = dr.include?('^') ? '-D' : '-d'
@@ -1484,7 +1474,7 @@ module Squared
                 data = line.sub(/^\*\s+/, '').split(/\s+/)
                 a = sub_style(data[0], styles: theme[:inline])
                 b = sub_style(data[1], styles: theme[:extra])
-                r = /\A(?:\[(.+?)(?=\]\s)\]\s)?(.+)\z/m.match(data[2..-1].join(' '))
+                r = /\A(?:\[((?~\]\s))\]\s)?(.+)\z/m.match(data[2..-1].join(' '))
                 if (r1 = r[1]) && r1 =~ /^(.+):(?: ([a-z]+) (\d+),)? ([a-z]+) (\d+)$/
                   write = ->(s1, s2) { "#{s1.capitalize.rjust(7)}: #{sub_style(s2, styles: theme[:warn])}" }
                   r1 = $1
@@ -1528,7 +1518,7 @@ module Squared
                    when 'y', 'Y', '1', 'true'
                      '--track'
                    when 'direct', 'inherit'
-                     basic_option('track', track)
+                     basic_option 'track', track
                    end
           when :detach, :merge
             cmd << "--#{flag}"
@@ -1564,7 +1554,7 @@ module Squared
             when 'oneline', 'short', 'medium', 'full', 'fuller', 'reference', 'email', 'raw'
               cmd << basic_option('format', val)
             else
-              if format.match?(/^t?format:/) || format.include?('%')
+              if format.start_with?(/t?format:/) || format.include?('%')
                 cmd << quote_option('pretty', format)
               else
                 opts << format
@@ -1640,20 +1630,19 @@ module Squared
                 red = color(:red)
                 grep.map! { |val| Regexp.new(val[1..-2]) }
                 files = status_data.map! do |a, b|
-                  next if b.strip.empty? || (!grep.empty? && grep.none? { |pat| pat.match?(a) })
+                  next unless grep.empty? || grep.any? { |pat| pat.match?(a) }
 
                   "#{sub_style(b, styles: red)} #{a}"
                 end
                 .compact
                 unless files.empty?
                   files = choice_index('Select files', files, multiple: true, force: true, trim: /^\S+\s/,
-                                                              accept: [['Add?', false, true]])
+                                                              accept: 'Add?')
                 end
                 op.swap(list + files)
               end
             end
-            return source(git_session('status', '-s'), banner: false) unless append_pathspec(op.extras)
-
+            append_pathspec op.extras
             verbose = flag == :add && !op.arg?('verbose')
             print_success if success?(source) && verbose
             return
@@ -1682,36 +1671,30 @@ module Squared
         private
 
         def source(cmd = @session, exception: true, io: false, sync: true, stdout: false, stderr: false, banner: true,
-                   multiple: false, from: nil, **kwargs)
+                   multiple: false, **kwargs)
           cmd = cmd.target if cmd.is_a?(OptionPartition)
-          if io && banner == false
-            from = nil
-            banner = nil
-          else
-            banner = nil if banner && (multiple || !banner?)
-            if cmd.respond_to?(:done)
-              if from.nil? && (from = cmd.drop(1).find { |val| val.match?(/\A[a-z]{1,2}[a-z\-]*\z/) })
-                from = :"git:#{from}"
-              end
-              banner &&= cmd.temp { |val| val.start_with?('--work-tree') || val.start_with?('--git-dir') }
+          banner = nil if banner && (multiple || !banner?)
+          if cmd.respond_to?(:done)
+            if io && banner == false
+              from = nil
+            elsif !from && (from = cmd.drop(1).find { |val| val.match?(/\A[a-z]{1,2}[a-z\-]*\z/) })
+              from = :"git:#{from}"
             end
-            from = nil if from == false
+            banner &&= cmd.temp { |val| val.start_with?('--work-tree') || val.start_with?('--git-dir') }
           end
           cmd = session_done cmd
           log&.info cmd
+          on :first, from
           banner = if banner
                      format_banner((banner.is_a?(String) ? banner : cmd).gsub(File.join(path, ''), ''), banner: true)
                    end
-          on :first, from
           begin
             if io
-              ret = if stdout
-                      `#{cmd}`
-                    else
-                      banner ? [IO.popen(cmd), banner, from] : IO.popen(cmd)
-                    end
-              return ret
-            elsif stdin? ? sync : stdout
+              return `#{cmd}` if stdout
+
+              return banner ? [IO.popen(cmd), banner, from] : IO.popen(cmd)
+            end
+            if stdin? ? sync : stdout
               print_item banner unless multiple
               ret = `#{cmd}`
               if !ret.empty?
@@ -1719,7 +1702,7 @@ module Squared
               elsif success?(!banner.nil?)
                 print_success
               end
-            elsif !kwargs[:sub] && (sync || (!exception && !stderr))
+            elsif sync || (!exception && !stderr)
               print_item banner unless multiple
               ret = shell(cmd, exception: exception)
             else
@@ -1912,19 +1895,13 @@ module Squared
         def append_pathspec(files = [], target: @session, expect: false, parent: false, pass: true)
           if session_arg?('pathspec-from-file', target: target)
             option_clear files
-            true
           else
-            if files.empty? && (val = option('pathspec', target: target))
-              files = split_escape val
-            end
+            option('pathspec', target: target) { |val| files = split_escape val } if files.empty?
             files = projectmap(files, parent: parent, pass: pass)
             if !files.empty?
               target << '--' << files.join(' ')
-              true
             elsif expect
               raise_error(parent ? 'pathspec not present' : 'pathspec not within worktree')
-            else
-              false
             end
           end
         end
@@ -1941,36 +1918,34 @@ module Squared
         end
 
         def append_submodules(target: @session, from: nil)
-          return unless (val = option('recurse-submodules', target: target, ignore: false))
-
-          if from == :clone
-            case val
-            when '0', 'false'
-              target << '--no-recurse-submodules'
-            when '1', 'true'
-              target << '--recurse-submodules'
-            else
-              projectmap(split_escape(val)).each do |path|
-                target << basic_option('recurse-submodules', path)
+          option('recurse-submodules', target: target, ignore: false) do |val|
+            if from == :clone
+              case val
+              when '0', 'false'
+                target << '--no-recurse-submodules'
+              when '1', 'true'
+                target << '--recurse-submodules'
+              else
+                projectmap(split_escape(val)).each do |path|
+                  target << basic_option('recurse-submodules', path)
+                end
               end
+            else
+              target << case val
+                        when 'no', '0', 'false'
+                          '--no-recurse-submodules'
+                        when 'yes', 'on-demand'
+                          "--recurse-submodules=#{val}"
+                        else
+                          '--recurse-submodules'
+                        end
             end
-          else
-            target << case val
-                      when 'no', '0', 'false'
-                        '--no-recurse-submodules'
-                      when 'yes', 'on-demand'
-                        "--recurse-submodules=#{val}"
-                      else
-                        '--recurse-submodules'
-                      end
           end
         end
 
         def foreachref(path, *args, format: nil)
-          path = Array(path).map! { |val| "refs/#{val}" }
-          format &&= quote_option('format', format)
-          ret = git_spawn('for-each-ref', format, *args, *path, stdout: workspace.windows?)
-          ret.is_a?(String) ? ret.lines : ret
+          path = as_a(path).map! { |val| "refs/#{val}" }
+          git_spawn('for-each-ref', format && quote_option('format', format), *args, *path, stdout: false)
         end
 
         def git_session(*cmd, opts: nil, worktree: true, **kwargs)
@@ -2008,23 +1983,22 @@ module Squared
 
         def repotrack(origin, branch, quote: true)
           i = origin.index('/')
-          branch = "#{branch}:#{origin[(i + 1)..-1]}" unless origin.end_with?("/#{branch}")
-          ret = [origin[0..(i - 1)], branch]
-          quote ? ret.map! { |val| shell_quote(val) } : ret
+          branch = "#{branch}:#{origin[i + 1..-1]}" unless origin.end_with?("/#{branch}")
+          [origin[0..i - 1], branch].tap { |ret| ret.map! { |val| shell_quote(val) } if quote }
         end
 
         def commithash(val)
-          val[/\A:(\h{5,40})\z/, 1] || val[/\A#\{(\h{5,40})\}\z/, 1]
+          val[/\A:(\h{5,40})\z/, 1]
         end
 
         def commithead(val)
           return val unless (s = matchhead(val))
 
-          s.match?(/^\d/) ? "@~#{s}" : "@#{s}"
+          s.start_with?(/\d/) ? "@~#{s}" : "@#{s}"
         end
 
         def matchhead(val)
-          val && val =~ /^(?:(?:HEAD|@)([~^]\d*)?|H(\d+))$/ ? $2 || $1 || '' : nil
+          val =~ /^(?:(?:HEAD|@)([~^]\d*)?|H(\d+))$/ ? $2 || $1 || '' : nil
         end
 
         def matchpathspec