sqreen 1.10.3 → 1.10.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 294bf474df4e1beb0533d87876a9b27e984d47ab332482aab2485fee862de414
-  data.tar.gz: 6a4b0f5c640371ad280c0412c5b3c58f73d921df69f767522659e5c90d4ee663
+  metadata.gz: bdd2b054367e611564274927940b2cbc1f7d52c160b6288079a839da5a07c73a
+  data.tar.gz: 163fa3ce8ae72fe25635c1943eea48d00e5f54b6dfd222f66051ce2032f5763d
 SHA512:
-  metadata.gz: bb633499e38e67c6768ac77bbdedccd83710708abe7b2422bfb0f3e4f4a2797b532b35203c97fbdf445ea205fe5e63cb5a1613e4ea8237b74330111410065ddb
-  data.tar.gz: 8bf22330ac83b3c9133a96127f358e34f27fe3dd504985832fb8825a19cfcfbafa82a9a3db25284e4c460c76587a92923c331cac7a584c7e8e396e4145ff2070
+  metadata.gz: 6b142290e1c3f3f20d9a5a37da34c906f8ad3f3da4328d16f9354a9ba15bec6e0f9997eeb9837b6584fb6bf0e58f0118b2b38ac2c58641a2df376131373607b2
+  data.tar.gz: 2f8e8d35f50b9f4f1ef79fa7a7c695b3e816be16c422a65b21e55649991ecbd20a3f2781b891533af107e4027615f62368d609545e6a258e02b397511e0b910b

data/lib/sqreen/instrumentation.rb

@@ -176,10 +176,29 @@ module Sqreen
       end
     end
 
+    def self.guard_multi_call(instance, method, original_method, args, block)
+      @sqreen_multi_instr ||= nil
+      key = [method]
+      Instrumentation.guard_call(nil, :guard_multi_call) do
+        args.each{|e| key.push(e.object_id)}
+      end
+      if key && @sqreen_multi_instr && @sqreen_multi_instr[instance.object_id].member?(key)
+        return instance.send(original_method, *args, &block)
+      end
+      @sqreen_multi_instr ||= Hash.new {|h, k| h[k]=Set.new } # TODO this should probably be a thread local
+      @sqreen_multi_instr[instance.object_id].add(key)
+      r = yield
+      return r
+    ensure
+      if @sqreen_multi_instr && @sqreen_multi_instr[instance.object_id] && @sqreen_multi_instr[instance.object_id].delete(key).empty?
+        @sqreen_multi_instr.delete(instance.object_id)
+      end
+    end
+
     def self.guard_call(method, retval)
       @sqreen_in_instr ||= nil
       return retval if @sqreen_in_instr && @sqreen_in_instr.member?(method)
-      @sqreen_in_instr ||= Set.new
+      @sqreen_in_instr ||= Set.new # TODO this should probably be a thread local
       @sqreen_in_instr.add(method)
       r = yield
       @sqreen_in_instr.delete(method)
@@ -197,6 +216,7 @@ module Sqreen
           end
           return send(original_meth, *args, &block)
         end
+        Instrumentation.guard_multi_call(self, meth, original_meth, args, block) do
         Sqreen.stats.callbacks_calls += 1
 
         skip = false
@@ -271,6 +291,7 @@ module Sqreen
           result
         end
       end
+      end
     end
 
     def override_class_method(klass, meth)
@@ -325,8 +346,8 @@ module Sqreen
       end
     end
 
-    def get_saved_method_name(meth)
-      "#{meth}_not_modified".to_sym
+    def get_saved_method_name(meth, suffix=nil)
+      "#{meth}_sq#{suffix}_not_modified".to_sym
     end
 
     def override_instance_method(klass_name, meth)
@@ -403,6 +424,30 @@ module Sqreen
       is_instance_method?(obj, method)
     end
 
+    # Override a singleton method on an instance
+    def override_singleton_method(instance, klass_name, meth)
+      saved_meth_name = get_saved_method_name(meth, 'singleton')
+      if instance.respond_to?(saved_meth_name, true)
+        Sqreen.log.debug { "#{saved_meth_name} found #{instance.class}##{instance.object_id} already instrumented" }
+        return nil
+      elsif instance.frozen?
+        Sqreen.log.debug { "#{instance.class}##{instance.object_id} is frozen, not reinstrumenting" }
+        return nil
+      end
+      raise Sqreen::NotImplementedYet, "#{instance.inspect} doesn't respond to define_singleton_method" unless instance.respond_to?(:define_singleton_method)
+      p = Instrumentation.define_callback_method(meth, saved_meth_name,
+                                                 klass_name)
+      instance.define_singleton_method(saved_meth_name, instance.method(meth))
+      instance.define_singleton_method(meth, p)
+      # Hide saved method (its only available in this syntax)
+      eval <<-RUBY, binding, __FILE__, __LINE__ + 1
+      class << instance
+        private :#{saved_meth_name}
+      end
+      saved_meth_name
+      RUBY
+    end
+
     def add_callback(cb)
       @@override_semaphore.synchronize do
         klass = cb.klass
@@ -427,7 +472,7 @@ module Sqreen
             #  - method_missing
             #  ...
             #
-            msg = "#{cb} is neither singleton or instance"
+            msg = "#{cb} is neither class or instance"
             raise Sqreen::NotImplementedYet, msg
           end
 
@@ -436,6 +481,18 @@ module Sqreen
           Sqreen.log.debug "#{key} was already overriden"
         end
 
+        if klass != Object && klass != Kernel && !Sqreen.features['instrument_all_instances'] && !defined?(::JRUBY_VERSION)
+          insts = 0
+          ObjectSpace.each_object(klass) do |e|
+            next if e.is_a?(Class) || e.is_a?(Module)
+            next unless e.singleton_methods.include?(method.to_sym)
+            insts += 1 if override_singleton_method(e, klass, method)
+          end
+          if insts > 0
+            Sqreen.log.debug { "Reinstrumented #{insts} instances of #{klass}" }
+          end
+        end
+
         @@registered_callbacks.add(cb)
         @@instrumented_pid = Process.pid
       end

data/lib/sqreen/rules_signature.rb

@@ -7,6 +7,16 @@ require 'set'
 require 'openssl'
 require 'base64'
 require 'json'
+if defined?(::JRUBY_VERSION)
+  OJ_LOADED = false
+else
+  begin
+    require "oj"
+    OJ_LOADED = true
+  rescue LoadError
+    OJ_LOADED = false
+  end
+end
 
 ## Rules signature
 module Sqreen
@@ -25,7 +35,7 @@ module Sqreen
 
   # Normalize and verify a rule
   class SqreenSignedVerifier
-    REQUIRED_SIGNED_KEYS = %w(hookpoint name callbacks conditions).freeze
+    REQUIRED_SIGNED_KEYS = %w[hookpoint name callbacks conditions].freeze
     SIGNATURE_KEY        = 'signature'.freeze
     SIGNATURE_VALUE_KEY  = 'value'.freeze
     SIGNED_KEYS_KEY      = 'keys'.freeze
@@ -42,12 +52,14 @@ module Sqreen
     attr_accessor :pub_key
     attr_accessor :required_signed_keys
     attr_accessor :digest
+    attr_accessor :use_oj
 
     def initialize(required_keys = REQUIRED_SIGNED_KEYS,
                    public_key    = PUBLIC_KEY,
-                   digest        = OpenSSL::Digest::SHA512.new)
+                   digest        = OpenSSL::Digest::SHA512.new, use_oj_gem = nil)
       @required_signed_keys = required_keys
       @signature_verifier   = SignatureVerifier.new(public_key, digest)
+      @use_oj = use_oj_gem.nil? ? OJ_LOADED : use_oj_gem
     end
 
     def normalize_val(val, level)
@@ -62,6 +74,7 @@ module Sqreen
         end
         "[#{ary.join(',')}]"
       when String, Integer
+        return Oj.dump(val, :mode => :compat, :escape_mode => :json) if use_oj
         begin
           JSON.dump(val)
         rescue JSON::GeneratorError
@@ -76,6 +89,7 @@ module Sqreen
     def normalize_key(key)
       case key
       when String, Integer
+        return Oj.dump(key, :mode => :compat, :escape_mode => :json) if use_oj
         begin
           JSON.dump(key)
         rescue JSON::GeneratorError

data/lib/sqreen/version.rb

@@ -1,5 +1,5 @@
 # Copyright (c) 2015 Sqreen. All Rights Reserved.
 # Please refer to our terms for more information: https://www.sqreen.io/terms.html
 module Sqreen
-  VERSION = '1.10.3'.freeze
+  VERSION = '1.10.4'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sqreen
 version: !ruby/object:Gem::Version
-  version: 1.10.3
+  version: 1.10.4
 platform: ruby
 authors:
 - Sqreen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-15 00:00:00.000000000 Z
+date: 2018-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: execjs