spyke 5.3.2 → 5.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b4cc7a2c704c8dd15ed7c5aaa2f0f19e198643ea5ee5f91de7d5842da4b6c9b
-  data.tar.gz: 1b92e7a21d361198245a969be7e27635cafecfa17b3001649b0cb07d7f4ccc42
+  metadata.gz: a23847f907d4ea043e1ec560e1e74f4bedb2cd4d7771b607d325904e80531c0c
+  data.tar.gz: 40fd30b87643d2ad61206067644f324e70cdceef6e729fcab56ea40bd164a71e
 SHA512:
-  metadata.gz: f8748c573657622a373d25a234a2fc628385601a4651f2ce7308aebf929909b0c4bd4eb06aa24ccf7378e3dd3fa469a9b598457b2faf0092646ffba2a257b2a3
-  data.tar.gz: 05f35ee6a8e7d11755c784c0903e83de0f970f4b071108048045c1570009a5cc514d7ea8121b8b26a125f24b06db08b5138a65e52899b61d4c0e8929351603d7
+  metadata.gz: dd4d48776c197d2e2dafbbea11bd5705c32322334b116328c786742632e5a98d61086e370a0e0ad0c8a3b2587e22959fa1280c1e836db3c855e08d68651d9f81
+  data.tar.gz: 753de2bd8d0491b041cceac1c8dce57d1ea3dfe6b0115be1f081cbf30b90cf786bc2e47cf2720fa33e78e46494e91b5d243536e91d88690be899dd19d89274cd

data/lib/spyke/attribute_assignment.rb

@@ -6,7 +6,6 @@ module Spyke
     extend ActiveSupport::Concern
 
     included do
-      attr_reader :attributes
       delegate :[], :[]=, to: :attributes
     end
 
@@ -40,8 +39,12 @@ module Spyke
       yield self if block_given?
     end
 
+    def attributes
+      @spyke_attributes
+    end
+
     def attributes=(new_attributes)
-      @attributes ||= Attributes.new(scope.params)
+      @spyke_attributes ||= Attributes.new(scope.params)
       use_setters(new_attributes) if new_attributes
     end
 

data/lib/spyke/version.rb

@@ -1,3 +1,3 @@
 module Spyke
-  VERSION = '5.3.2'
+  VERSION = '5.3.3'
 end

data/test/activemodel_dirty_test.rb

@@ -0,0 +1,12 @@
+require 'test_helper'
+
+module Spyke
+  class ActiveModelDirtyTest < MiniTest::Test
+    def test_attributes_instance_var_compatibility
+      recipe = RecipeWithDirty.new(title: 'Cheeseburger')
+
+      # If @attributes is set on recipe ActiveModel::Dirty will crash
+      assert_equal false, recipe.attribute_changed_in_place?(:title)
+    end
+  end
+end

data/test/support/fixtures.rb

@@ -152,3 +152,10 @@ module Cookbook
     include_root_in_json :foto
   end
 end
+
+class RecipeWithDirty < Recipe
+  # NOTE: Simply including ActiveModel::Dirty doesn't provide all the dirty
+  # functionality. This is left intentionally incomplete as it's all we need
+  # for testing compatibility.
+  include ActiveModel::Dirty
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spyke
 version: !ruby/object:Gem::Version
-  version: 5.3.2
+  version: 5.3.3
 platform: ruby
 authors:
 - Jens Balvig
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-01 00:00:00.000000000 Z
+date: 2018-11-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -285,6 +285,7 @@ files:
 - lib/spyke/scoping.rb
 - lib/spyke/version.rb
 - spyke.gemspec
+- test/activemodel_dirty_test.rb
 - test/associations_test.rb
 - test/attributes_test.rb
 - test/callbacks_test.rb
@@ -322,6 +323,7 @@ signing_key:
 specification_version: 4
 summary: Interact with REST services in an ActiveRecord-like manner
 test_files:
+- test/activemodel_dirty_test.rb
 - test/associations_test.rb
 - test/attributes_test.rb
 - test/callbacks_test.rb