spyke 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b1e4e0a09a6e130d78cdfc11ad4c46baee78c332
-  data.tar.gz: ef161ce8bdf5013e36e41e5054ac461d58c84b88
+  metadata.gz: e6613906c7dbb4e350d7d7bbe598b0775b8283ec
+  data.tar.gz: c1532061ab3a9fb149ffcdd23edf6212e489b1cc
 SHA512:
-  metadata.gz: bf368cf28410559c6fdc38f3f14c24b28effe957d05249aced614adfcbcb39869dc6092c329c46c1bc79ce30200167e481db4c1a1925005c21d6072596d5a3e5
-  data.tar.gz: be1d98fa2a3fab4ef8e19cee15d179a4a937a8108bfe5f789a6406aa9e2c9652bd754e256eb25ecbbb59dea79d40585a3d29351d505e335a65eb14d04e2d6c2a
+  metadata.gz: 3facc112e5940a263ee4ab013061c89302629e181db8d077e55d5e9307fc4cb00d5e11c394e0ced52d7de987b8bc92026ab0ee04731386e52ee41b622e79f306
+  data.tar.gz: e4c8ffd32b2befab7ea1aa7a0387f82c71a0063c32c538ace19f701957914abc10e792a685957137f35eaea5dc117e010c54b088356f14c9a62e76fc91064bef

data/README.md

@@ -14,13 +14,14 @@
 
 ---
 
-Spyke basically ~~rips off~~ takes inspiration :innocent: from [Her](https://github.com/remiprev/her), a gem which we sadly had to abandon as it gave us some performance problems and maintenance seemed to had gone stale.
+Spyke basically ~~rips off~~ takes inspiration :innocent: from [Her](https://github.com/remiprev/her), a gem which we sadly had to abandon as it gave us some performance problems and maintenance seemed to have gone stale.
 
-We therefore made Spyke which adds a few fixes/features that we needed for our projects:
+We therefore made Spyke which adds a few fixes/features needed for our projects:
 
 - Fast handling of even large amounts of JSON
 - Proper support for scopes
 - Ability to define custom URIs for associations
+- ActiveRecord-like log output
 - Googlable name! :)
 
 ## Configuration
@@ -104,10 +105,10 @@ You can specify custom URIs on both the class and association level:
 
 ```ruby
 class User < Spyke::Base
-  uri '/v1/users/(:id)' # id optional, both /v1/users and /v1/users/4 are usable
+  uri '/v1/users/(:id)' # id optional, both /v1/users and /v1/users/4 are valid
 
-  has_one :image, uri: nil
   has_many :posts, uri: '/posts/for_user/:user_id' # user_id is required
+  has_one :image, uri: nil # only use embedded JSON
 end
 
 class Post < Spyke::Base
@@ -134,5 +135,5 @@ Completed 200 OK in 75ms (Views: 64.6ms | Spyke: 40.3ms | ActiveRecord: 0ms)
 
 ## Contributing
 
-If possible please take a look at the tests marked "wishlisted"!
+If possible please take a look at the [tests marked "wishlisted"](https://github.com/balvig/spyke/search?utf8=%E2%9C%93&q=wishlisted)!
 These are features/fixes we want to implement but haven't gotten around to doing yet :)

data/lib/spyke/path.rb

@@ -43,7 +43,13 @@ module Spyke
       end
 
       def missing_required_params
-        required_params - @params.keys
+        required_params - params_with_values
+      end
+
+      def params_with_values
+        @params.map do |key, value|
+          key if value.present?
+        end.compact
       end
 
       def required_params

data/lib/spyke/version.rb

@@ -1,3 +1,3 @@
 module Spyke
-  VERSION = '1.7.0'
+  VERSION = '1.7.1'
 end

data/test/relation_test.rb

@@ -124,5 +124,11 @@ module Spyke
       assert_requested tip_endpoint
       assert_requested likes_endpoint
     end
+
+    def test_path_validation
+      assert_raises Spyke::InvalidPathError do
+        Recipe.new.groups.to_a
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spyke
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Jens Balvig