spy 0.1.0 → 0.2.1

data/test/integration/test_constant_spying.rb

@@ -22,7 +22,7 @@ class TestConstantSpying < MiniTest::Unit::TestCase
     end
   end
 
-  def setup
+  def teardown
     Spy::Agency.instance.dissolve!
   end
 

data/test/integration/test_instance_method.rb

@@ -0,0 +1,32 @@
+require 'test_helper'
+
+class TestAnyInstanceOf < MiniTest::Unit::TestCase
+  class Foo
+    def bar
+      "foobar"
+    end
+  end
+
+  class Bar < Foo
+    def bar
+      super
+    end
+  end
+
+  def teardown
+    Spy::Agency.instance.dissolve!
+  end
+
+  def test_it_overides_all_methods
+    assert_equal Foo.new.bar, "foobar"
+    spy = Spy.on_instance_method(Foo, bar: "timshel")
+    assert_equal spy, Spy::Subroutine.get(Foo, :bar, false)
+    assert_equal "timshel", Foo.new.bar
+    assert_equal "timshel", Foo.new.bar
+    assert_equal "timshel", Bar.new.bar
+    assert_equal 3, spy.calls.size
+
+    spy = Spy.off_instance_method(Foo, :bar)
+    assert_equal Foo.new.bar, "foobar"
+  end
+end

data/test/integration/test_subroutine_spying.rb

@@ -2,13 +2,16 @@ require 'test_helper'
 
 class TestSpy < MiniTest::Unit::TestCase
   def setup
-    Spy::Agency.instance.dissolve!
     @pen = Pen.new
   end
 
+  def teardown
+    Spy::Agency.instance.dissolve!
+  end
+
   def test_spy_on_hooks_and_saves_spy_with_array
-    pen_write_spy, pen_write_hello_spy = Spy::Subroutine.on(@pen, :write, :write_hello)
-    assert_nil @pen.write(nil)
+    pen_write_spy, pen_write_hello_spy = Spy.on(@pen, :write, :write_hello)
+    assert_nil @pen.write("hello")
     assert_nil @pen.write_hello
 
     assert_kind_of Spy::Subroutine, pen_write_spy
@@ -25,7 +28,7 @@ class TestSpy < MiniTest::Unit::TestCase
 
     assert_kind_of Spy::Subroutine, pen_write_spy
     assert_kind_of Spy::Subroutine, pen_write_hello_spy
-    assert_equal [pen_write_spy, pen_write_hello_spy], Spy::Agency.instance.subroutines
+    assert_equal [pen_write_spy, pen_write_hello_spy], Spy::Agency.instance.spies
     assert pen_write_spy.has_been_called?
     assert pen_write_hello_spy.has_been_called?
   end

data/test/spy/test_double.rb

@@ -2,6 +2,10 @@ require 'test_helper'
 
 module Spy
   class TestDouble < MiniTest::Unit::TestCase
+    def teardown
+      Spy::Agency.instance.dissolve!
+    end
+
     def test_double_creation
       double = Double.new("NewDouble", :meth_1, :meth_2)
 

data/test/spy/test_subroutine.rb

@@ -7,15 +7,18 @@ module Spy
     end
 
     def setup
-      Agency.instance.dissolve!
       @pen = Pen.new
     end
 
+    def teardown
+      Spy::Agency.instance.dissolve!
+    end
+
     def test_spy_on_hook_and_saves_spy
       pen_write_spy = spy_on(@pen, :write).and_return("hello")
       assert_equal "hello", @pen.write(nil)
       assert_kind_of Subroutine, pen_write_spy
-      assert_equal [pen_write_spy], Agency.instance.subroutines
+      assert_equal [pen_write_spy], Agency.instance.spies
       assert pen_write_spy.has_been_called?
     end
 
@@ -36,10 +39,30 @@ module Spy
       assert_equal "another", Pen.another
     end
 
+    def test_spy_can_hook_and_record_a_meta_method_call_on_a_constant
+      assert_equal "meta_method", Pen.meta_method
+      meta_spy = spy_on(Pen, :meta_method)
+      refute meta_spy.has_been_called?
+      assert_nil Pen.meta_method
+      assert meta_spy.has_been_called?
+      meta_spy.unhook
+      assert_equal "meta_method", Pen.meta_method
+    end
+
+    def test_spy_can_hook_record_and_unhook_a_meta_method
+      assert_equal "meta_method", @pen.meta_method
+      meta_spy = spy_on(@pen, :meta_method)
+      refute meta_spy.has_been_called?
+      assert_nil @pen.meta_method
+      assert meta_spy.has_been_called?
+      meta_spy.unhook
+      assert_equal "meta_method", @pen.meta_method
+    end
+
     def test_spy_can_unhook_a_method
       pen_write_spy = spy_on(@pen, :write)
       pen_write_spy.unhook
-      @pen.write("hello")
+      assert_equal "hello", @pen.write("hello")
       refute pen_write_spy.has_been_called?
     end
 
@@ -124,11 +147,13 @@ module Spy
       args = ["hello world"]
       block = Proc.new {}
       pen_write_spy = spy_on(@pen, :write)
+      called_from = "#{__FILE__}:#{__LINE__ + 1}:in `#{__method__}'"
       @pen.write(*args, &block)
       call_log = pen_write_spy.calls.first
       assert_equal @pen, call_log.object
       assert_equal args, call_log.args
       assert_equal block, call_log.block
+      assert_equal called_from, call_log.called_from
     end
 
     def test_that_method_spy_keeps_arity

data/test/support/pen.rb

@@ -34,6 +34,10 @@ class Pen
   def public_method
   end
 
+  def another
+    "another"
+  end
+
   protected
   def protected_method
   end
@@ -48,3 +52,14 @@ class Pen
     end
   end
 end
+
+another = "meta_method"
+
+Pen.define_singleton_method(:meta_method) do
+  another
+end
+
+Pen.send(:define_method, :meta_method) do
+  another
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spy
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-20 00:00:00.000000000 Z
+date: 2013-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -67,6 +67,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - .yardopts
 - Gemfile
 - LICENSE.txt
@@ -74,6 +75,7 @@ files:
 - Rakefile
 - lib/spy.rb
 - lib/spy/agency.rb
+- lib/spy/call_log.rb
 - lib/spy/constant.rb
 - lib/spy/core_ext/marshal.rb
 - lib/spy/double.rb
@@ -83,35 +85,23 @@ files:
 - spec/spec_helper.rb
 - spec/spy/and_call_original_spec.rb
 - spec/spy/and_yield_spec.rb
-- spec/spy/bug_report_10260_spec.rb
-- spec/spy/bug_report_10263_spec.rb
-- spec/spy/bug_report_496_spec.rb
-- spec/spy/bug_report_600_spec.rb
-- spec/spy/bug_report_7611_spec.rb
-- spec/spy/bug_report_8165_spec.rb
-- spec/spy/bug_report_830_spec.rb
-- spec/spy/bug_report_957_spec.rb
-- spec/spy/double_spec.rb
-- spec/spy/failing_argument_matchers_spec.rb
+- spec/spy/any_instance_spec.rb
 - spec/spy/hash_excluding_matcher_spec.rb
 - spec/spy/hash_including_matcher_spec.rb
 - spec/spy/mock_spec.rb
 - spec/spy/mutate_const_spec.rb
 - spec/spy/nil_expectation_warning_spec.rb
 - spec/spy/null_object_mock_spec.rb
-- spec/spy/options_hash_spec.rb
 - spec/spy/partial_mock_spec.rb
 - spec/spy/passing_argument_matchers_spec.rb
-- spec/spy/precise_counts_spec.rb
 - spec/spy/serialization_spec.rb
 - spec/spy/stash_spec.rb
 - spec/spy/stub_implementation_spec.rb
 - spec/spy/stub_spec.rb
-- spec/spy/stubbed_message_expectations_spec.rb
-- spec/spy/test_double_spec.rb
 - spec/spy/to_ary_spec.rb
 - spy.gemspec
 - test/integration/test_constant_spying.rb
+- test/integration/test_instance_method.rb
 - test/integration/test_subroutine_spying.rb
 - test/spy/test_double.rb
 - test/spy/test_subroutine.rb
@@ -145,34 +135,22 @@ test_files:
 - spec/spec_helper.rb
 - spec/spy/and_call_original_spec.rb
 - spec/spy/and_yield_spec.rb
-- spec/spy/bug_report_10260_spec.rb
-- spec/spy/bug_report_10263_spec.rb
-- spec/spy/bug_report_496_spec.rb
-- spec/spy/bug_report_600_spec.rb
-- spec/spy/bug_report_7611_spec.rb
-- spec/spy/bug_report_8165_spec.rb
-- spec/spy/bug_report_830_spec.rb
-- spec/spy/bug_report_957_spec.rb
-- spec/spy/double_spec.rb
-- spec/spy/failing_argument_matchers_spec.rb
+- spec/spy/any_instance_spec.rb
 - spec/spy/hash_excluding_matcher_spec.rb
 - spec/spy/hash_including_matcher_spec.rb
 - spec/spy/mock_spec.rb
 - spec/spy/mutate_const_spec.rb
 - spec/spy/nil_expectation_warning_spec.rb
 - spec/spy/null_object_mock_spec.rb
-- spec/spy/options_hash_spec.rb
 - spec/spy/partial_mock_spec.rb
 - spec/spy/passing_argument_matchers_spec.rb
-- spec/spy/precise_counts_spec.rb
 - spec/spy/serialization_spec.rb
 - spec/spy/stash_spec.rb
 - spec/spy/stub_implementation_spec.rb
 - spec/spy/stub_spec.rb
-- spec/spy/stubbed_message_expectations_spec.rb
-- spec/spy/test_double_spec.rb
 - spec/spy/to_ary_spec.rb
 - test/integration/test_constant_spying.rb
+- test/integration/test_instance_method.rb
 - test/integration/test_subroutine_spying.rb
 - test/spy/test_double.rb
 - test/spy/test_subroutine.rb

data/spec/spy/bug_report_10260_spec.rb

@@ -1,8 +0,0 @@
-require 'spec_helper'
-
-describe "An RSpec Mock" do
-  it "hides internals in its inspect representation" do
-    m = double('cup')
-    expect(m.inspect).to match /#<RSpec::Mocks::Mock:0x[a-f0-9.]+ @name="cup">/
-  end
-end

data/spec/spy/bug_report_10263_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-
-describe "Double" do
-  let(:test_double) { double }
-
-  specify "when one example has an expectation inside the block passed to should_receive" do
-    Spy.stub(test_double, :msg).and_return do |arg|
-      expect(arg).to be_true #this call exposes the problem
-    end
-    begin
-      test_double.msg(false)
-    rescue Exception
-    end
-  end
-
-  specify "then the next example should behave as expected instead of saying" do
-    test_double_spy = Spy.stub(test_double, :foobar)
-    test_double.foobar
-    expect(test_double_spy).to have_been_called
-    test_double.foobar
-    expect(test_double_spy.calls.count).to equal(2)
-  end
-end
-

data/spec/spy/bug_report_496_spec.rb

@@ -1,18 +0,0 @@
-require 'spec_helper'
-
-module BugReport496
-  describe "a message expectation on a base class object" do
-    class BaseClass
-    end
-
-    class SubClass < BaseClass
-    end
-
-    it "is received" do
-      new_spy = Spy.on(BaseClass, :new)
-      SubClass.new
-      expect(new_spy.calls.count).to equal(1)
-    end
-  end
-end
-

data/spec/spy/bug_report_600_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-
-module BugReport600
-  describe "stubbing a class method" do
-    class ExampleClass
-      def self.method_that_uses_define_method
-        define_method "defined_method" do |attributes|
-          load_address(address, attributes)
-        end
-      end
-    end
-
-    it "works" do
-      define_method_spy = Spy.on(ExampleClass, :define_method)
-      ExampleClass.method_that_uses_define_method
-
-      expect(define_method_spy).to have_been_called_with("defined_method")
-    end
-
-    it "restores the original method" do
-      ExampleClass.method_that_uses_define_method
-    end
-  end
-end

data/spec/spy/bug_report_7611_spec.rb

@@ -1,16 +0,0 @@
-require 'spec_helper'
-
-module Bug7611
-  describe "A Partial Mock" do
-    class Foo; end
-    class Bar < Foo; end
-
-    it "respects subclasses" do
-      Spy.on(Foo, :new).and_return(Object.new)
-    end
-
-    it "should" do
-      expect(Bar.new.class).to eq Bar
-    end
-  end
-end

data/spec/spy/bug_report_8165_spec.rb

@@ -1,31 +0,0 @@
-require 'spec_helper'
-
-describe "An object where respond_to? is true and does not have method" do
-  # When should_receive(message) is sent to any object, the Proxy sends
-  # respond_to?(message) to that object to see if the method should be proxied.
-  #
-  # If respond_to? itself is proxied, then when the Proxy sends respond_to?
-  # to the object, the proxy is invoked and responds yes (if so set in the spec).
-  # When the object does NOT actually respond to `message`, an exception is thrown
-  # when trying to proxy it.
-  #
-  # The fix was to keep track of whether `respond_to?` had been proxied and, if
-  # so, call the munged copy of `respond_to?` on the object.
-
-  it "does not raise an exception for Object" do
-    obj = Object.new
-    obj.should_receive(:respond_to?).with(:foobar).and_return(true)
-    obj.should_receive(:foobar).and_return(:baz)
-    expect(obj.respond_to?(:foobar)).to be_true
-    expect(obj.foobar).to eq :baz
-  end
-
-  it "does not raise an exception for mock" do
-    obj = double("obj")
-    obj.should_receive(:respond_to?).with(:foobar).and_return(true)
-    obj.should_receive(:foobar).and_return(:baz)
-    expect(obj.respond_to?(:foobar)).to be_true
-    expect(obj.foobar).to eq :baz
-  end
-
-end

data/spec/spy/bug_report_830_spec.rb

@@ -1,21 +0,0 @@
-require 'spec_helper'
-
-module RSpec
-  module Mocks
-    describe 'Calling a method that catches StandardError' do
-      class Foo
-        def self.foo
-          bar
-        rescue StandardError
-        end
-      end
-
-      it 'still reports mock failures' do
-        Foo.should_not_receive :bar
-        expect {
-          Foo.foo
-        }.to raise_error(RSpec::Mocks::MockExpectationError)
-      end
-    end
-  end
-end

data/spec/spy/bug_report_957_spec.rb

@@ -1,22 +0,0 @@
-require 'spec_helper'
-
-module RSpec
-  module Mocks
-    describe "stubbing a base class class method" do
-      before do
-        @base_class     = Class.new
-        @concrete_class = Class.new(@base_class)
-
-        Spy.stub(@base_class, :find).and_return "stubbed_value"
-      end
-
-      it "returns the value for the stub on the base class" do
-        expect(@base_class.find).to eq "stubbed_value"
-      end
-
-      it "returns the value for the descendent class" do
-        expect(@concrete_class.find).to eq "stubbed_value"
-      end
-    end
-  end
-end