sps_king 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31b32c348bef762b07d56477514a4a2bfd8e8f0e3747efc868dfc87c5c2d2611
-  data.tar.gz: a35d23dcca002639fe9fd1f81ef31c9da0fdb1211b5c3486f6d563451ad10fb9
+  metadata.gz: 40a4c8071cb8bcda13c6ac4e7195dbbd838ad297ce4c5ea908dd377d68613c3e
+  data.tar.gz: c0dd7c10e1349329763a6780fcb32f081858a0332dc63b6bb09b90bf7c7dfb28
 SHA512:
-  metadata.gz: b1945d74086db0e92cb5ad8dae6e091d40df533fa77cc44c8e58057f1c9ccb1b48bc153cccde657de747ef882b4f886aa1d5c994c2f90022a4b340ba20a1c70d
-  data.tar.gz: 336173dab180c320bb5bb201ed7ef06463c2cd1a1bf09fb7b4b84947a33def1190432c5d6bc1d5951b4e0956fdc1f4b455c7ad59d880928905e48e6f3c7cb710
+  metadata.gz: 127713638985e72a657d2db062e9eabce93dc04e5b358fb1e33f1b08ba2feaa9a9c89bebb977bee66b14b3e51ee088557f0dabd3810effcc7665cfba74bab159
+  data.tar.gz: 4d1b2f43c5f272923f955617e8255d82d77f602092781368819bf47d3ae9528b48477295d57f019103bf4929c15435d1ec1190f68897af0838cd5554a841e6b7

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## What's Changed in in v0.8.0
+
+* Add support for validating debitor account proprietary field by @Nymuxyzo in [#23](https://github.com/viafintech/sps_king/pull/23)
+* Fix missing schema version in `schema_compatible?` in [#24](https://github.com/viafintech/sps_king/pull/24)
+
+**Full Changelog**: https://github.com/viafintech/sps_king/compare/v0.7.0...v0.8.0
+
 ## What's Changed in v0.7.0
 
 * Add support for pain.001.001.09.ch.03 in [#20](https://github.com/viafintech/sps_king/pull/20)

data/lib/sps_king/account/debtor_account.rb

@@ -2,5 +2,20 @@
 
 module SPS
   class DebtorAccount < Account
+
+    extend Converter
+
+    attr_accessor :proprietary
+
+    ### Proprietary values
+    # NOA No Advice
+    # SIA Single Advice
+    # CND Collective Advice No Details
+    # CWD Collective Advice With Details
+    PROPRIETARY_VALUES = %w[NOA SIA CND CWD].freeze
+
+    validates :proprietary, inclusion: PROPRIETARY_VALUES, allow_nil: true
+
+    convert :proprietary, to: :text
   end
 end

data/lib/sps_king/message/credit_transfer.rb

@@ -60,6 +60,11 @@ module SPS
               builder.Id do
                 builder.IBAN(account.iban)
               end
+              if account.proprietary.present?
+                builder.Tp do
+                  builder.Prtry(account.proprietary)
+                end
+              end
             end
             builder.DbtrAgt do
               builder.FinInstnId do

data/lib/sps_king/message.rb

@@ -62,7 +62,7 @@ module SPS
       raise ArgumentError.new("Schema #{schema_name} is unknown!") unless self.known_schemas.include?(schema_name)
 
       case schema_name
-      when PAIN_001_001_03_CH_02
+      when PAIN_001_001_03_CH_02, PAIN_001_001_09_CH_03
         transactions.all? { |t| t.schema_compatible?(schema_name) }
       when PAIN_008_001_02_CH_03
         transactions.all? { |t| t.schema_compatible?(schema_name) } &&

data/lib/sps_king/transaction/credit_transfer_transaction.rb

@@ -4,6 +4,7 @@ module SPS
   class CreditTransferTransaction < Transaction
 
     attr_accessor :service_level,
+                  :local_instrument,
                   :creditor_address,
                   :category_purpose,
                   :charge_bearer

data/lib/sps_king/version.rb

@@ -2,6 +2,6 @@
 
 module SPS
 
-  VERSION = '0.7.0'
+  VERSION = '0.8.0'
 
 end

data/spec/lib/sps_king/account/debtor_account_spec.rb

@@ -8,7 +8,8 @@ describe SPS::DebtorAccount do
       SPS::DebtorAccount.new(
         name: 'Gläubiger GmbH',
         bic:  'BANKDEFFXXX',
-        iban: 'DE87200500001234567890'
+        iban: 'DE87200500001234567890',
+        proprietary: 'CWD'
       )
     ).to be_valid
   end

data/spec/lib/sps_king/message/credit_transfer_spec.rb

@@ -78,6 +78,12 @@ describe SPS::CreditTransfer do
           subject.to_xml(SPS::PAIN_001_001_03_CH_02)
         ).to validate_against('pain.001.001.03.ch.02.xsd')
       end
+
+      it 'should validate against pain.001.001.09.ch.03' do
+        expect(
+          subject.to_xml(SPS::PAIN_001_001_09_CH_03)
+        ).to validate_against('pain.001.001.09.ch.03.xsd')
+      end
     end
 
     context 'setting creditor address with structured fields' do
@@ -136,6 +142,10 @@ describe SPS::CreditTransfer do
         it 'should validate against pain.001.001.03.ch.02' do
           expect(subject.to_xml('pain.001.001.03.ch.02')).to validate_against('pain.001.001.03.ch.02.xsd')
         end
+
+        it 'should validate against pain.001.001.09.ch.03' do
+          expect(subject.to_xml('pain.001.001.09.ch.03')).to validate_against('pain.001.001.09.ch.03.xsd')
+        end
       end
 
       context 'without requested_date given' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: sps_king
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Tobias Schoknecht
@@ -231,7 +231,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Ruby gem for creating SPS XML files
 test_files: