sps_king 0.4.0 → 0.6.0

data/spec/lib/sps_king/transaction/direct_debit_transaction_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 require 'spec_helper'
 
 describe SPS::DirectDebitTransaction do
@@ -13,12 +14,12 @@ describe SPS::DirectDebitTransaction do
     it 'should create a valid transaction' do
       expect(
         SPS::DirectDebitTransaction.new(
-          name:                      'Zahlemann & Söhne Gbr',
-          iban:                      'CH7081232000001998736',
-          amount:                    39.99,
-          reference:                 'XYZ-1234/123',
-          instruction:               '123',
-          remittance_information:    'Vielen Dank für Ihren Einkauf!',
+          name:                              'Zahlemann & Söhne Gbr',
+          iban:                              'CH7081232000001998736',
+          amount:                            39.99,
+          reference:                         'XYZ-1234/123',
+          instruction:                       '123',
+          remittance_information:            'Vielen Dank für Ihren Einkauf!',
           structured_remittance_information: structured_remittance_information
         )
       ).to be_valid
@@ -50,7 +51,7 @@ describe SPS::DirectDebitTransaction do
 
     it 'should not allow invalid value' do
       expect(SPS::DirectDebitTransaction)
-        .not_to accept(Date.new(1995,12,21), Date.today - 1, Date.today, for: :requested_date)
+        .not_to accept(Date.new(1995, 12, 21), Date.today - 1, Date.today, for: :requested_date)
     end
   end
 end

data/spec/lib/sps_king/transaction_spec.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 require 'spec_helper'
 
 describe SPS::Transaction do
@@ -18,7 +19,12 @@ describe SPS::Transaction do
 
   context 'Name' do
     it 'should accept valid value' do
-      expect(SPS::Transaction).to accept('Manfred Mustermann III.', 'Zahlemann & Söhne GbR', 'X' * 70, for: :name)
+      expect(SPS::Transaction).to accept(
+                                    'Manfred Mustermann III.',
+                                    'Zahlemann & Söhne GbR',
+                                    'X' * 70,
+                                    for: :name
+                                  )
     end
 
     it 'should not accept invalid value' do
@@ -29,51 +35,67 @@ describe SPS::Transaction do
   context 'Adress' do
     context 'with address_line' do
       it 'should accept valid value' do
-        expect(SPS::Transaction).to accept(SPS::DebtorAddress.new(
-          country_code: "CH",
-          address_line1: "Musterstrasse 123",
-          address_line2: "1234 Musterstadt"
-        ), for: :debtor_address)
+        expect(SPS::Transaction).to accept(
+                                      SPS::DebtorAddress.new(
+                                        country_code:  "CH",
+                                        address_line1: "Musterstrasse 123",
+                                        address_line2: "1234 Musterstadt"
+                                      ),
+                                      for: :debtor_address
+                                    )
       end
 
       it 'should accept valid value' do
-        expect(SPS::Transaction).to accept(SPS::CreditorAddress.new(
-          country_code: "CH",
-          address_line1: "Musterstrasse 123",
-          address_line2: "1234 Musterstadt"
-        ), for: :creditor_address)
+        expect(SPS::Transaction).to accept(
+                                      SPS::CreditorAddress.new(
+                                        country_code:  "CH",
+                                        address_line1: "Musterstrasse 123",
+                                        address_line2: "1234 Musterstadt"
+                                      ),
+                                      for: :creditor_address
+                                    )
       end
     end
 
     context 'with individual address fields' do
       it 'should accept valid value' do
-        expect(SPS::Transaction).to accept(SPS::DebtorAddress.new(
-          country_code: "CH",
-          street_name:     'Mustergasse',
-          post_code:       '1234',
-          town_name:       'Musterstadt'
-        ), for: :debtor_address)
+        expect(SPS::Transaction).to accept(
+                                      SPS::DebtorAddress.new(
+                                        country_code: "CH",
+                                        street_name:  'Mustergasse',
+                                        post_code:    '1234',
+                                        town_name:    'Musterstadt'
+                                      ),
+                                      for: :debtor_address
+                                    )
       end
 
       it 'should accept valid value' do
-        expect(SPS::Transaction).to accept(SPS::CreditorAddress.new(
-          country_code: "CH",
-          street_name:     'Mustergasse',
-          building_number: '123',
-          post_code:       '1234',
-          town_name:       'Musterstadt'
-        ), for: :creditor_address)
+        expect(SPS::Transaction).to accept(
+                                      SPS::CreditorAddress.new(
+                                        country_code:    "CH",
+                                        street_name:     'Mustergasse',
+                                        building_number: '123',
+                                        post_code:       '1234',
+                                        town_name:       'Musterstadt'
+                                      ),
+                                      for: :creditor_address
+                                    )
       end
     end
 
     it 'should not accept invalid value' do
-      expect(SPS::Transaction).not_to accept('', {} , for: :name)
+      expect(SPS::Transaction).not_to accept('', {}, for: :name)
     end
   end
 
   context 'IBAN' do
     it 'should accept valid value' do
-      expect(SPS::Transaction).to accept('DE21500500009876543210', 'PL61109010140000071219812874', for: :iban)
+      expect(SPS::Transaction).to accept(
+                                    'DE21500500009876543210',
+                                    'PL61109010140000071219812874',
+                                    for: :iban
+                                  )
     end
 
     it 'should not accept invalid value' do
@@ -93,7 +115,20 @@ describe SPS::Transaction do
 
   context 'Amount' do
     it 'should accept valid value' do
-      expect(SPS::Transaction).to accept(0.01, 1, 100, 100.00, 99.99, 1234567890.12, BigDecimal('10'), '42', '42.51', '42.512', 1.23456, for: :amount)
+      expect(SPS::Transaction).to accept(
+                                    0.01,
+                                    1,
+                                    100,
+                                    100.00,
+                                    99.99,
+                                    1234567890.12,
+                                    BigDecimal('10'),
+                                    '42',
+                                    '42.51',
+                                    '42.512',
+                                    1.23456,
+                                    for: :amount
+                                  )
     end
 
     it 'should not accept invalid value' do

data/spec/lib/sps_king/validator_spec.rb

@@ -1,26 +1,37 @@
 # encoding: utf-8
+
 require 'spec_helper'
 
 describe SPS::IBANValidator do
   class Validatable
+
     include ActiveModel::Model
     attr_accessor :iban, :iban_the_terrible
+
     validates_with SPS::IBANValidator, message: "%{value} seems wrong"
     validates_with SPS::IBANValidator, field_name: :iban_the_terrible
+
   end
 
   it 'should accept valid IBAN' do
     expect(Validatable)
-      .to accept('DE21500500009876543210', 'DE87200500001234567890', for: [:iban, :iban_the_terrible])
+      .to accept(
+            'DE21500500009876543210',
+            'DE87200500001234567890',
+            for: [:iban, :iban_the_terrible]
+          )
   end
 
   it 'should not accept an invalid IBAN' do
-    expect(Validatable).not_to accept('', 'xxx',                     # Oviously no IBAN
-                                      'DE22500500009876543210',      # wrong checksum
-                                      'DE2150050000987654321',       # too short
-                                      'de87200500001234567890',      # downcase characters
-                                      'DE87 2005 0000 1234 5678 90', # spaces included
-                               for: [:iban, :iban_the_terrible])
+    expect(Validatable).not_to accept(
+                                 '',
+                                 'xxx', # Oviously no IBAN
+                                 'DE22500500009876543210',      # wrong checksum
+                                 'DE2150050000987654321',       # too short
+                                 'de87200500001234567890',      # downcase characters
+                                 'DE87 2005 0000 1234 5678 90', # spaces included
+                                 for: [:iban, :iban_the_terrible]
+                               )
   end
 
   it "should customize error message" do
@@ -32,10 +43,13 @@ end
 
 describe SPS::BICValidator do
   class Validatable
+
     include ActiveModel::Model
     attr_accessor :bic, :custom_bic
+
     validates_with SPS::BICValidator, message: "%{value} seems wrong"
     validates_with SPS::BICValidator, field_name: :custom_bic
+
   end
 
   it 'should accept valid BICs' do
@@ -56,18 +70,33 @@ end
 
 describe SPS::CreditorIdentifierValidator do
   class Validatable
+
     include ActiveModel::Model
     attr_accessor :creditor_identifier, :crid
+
     validates_with SPS::CreditorIdentifierValidator, message: "%{value} seems wrong"
     validates_with SPS::CreditorIdentifierValidator, field_name: :crid
+
   end
 
   it 'should accept valid creditor_identifier' do
-    expect(Validatable).to accept('DE98ZZZ09999999999', 'AT12ZZZ00000000001', 'FR12ZZZ123456', 'NL97ZZZ123456780001', 'ABC1W', for: [:creditor_identifier, :crid])
+    expect(Validatable).to accept(
+                             'DE98ZZZ09999999999',
+                             'AT12ZZZ00000000001',
+                             'FR12ZZZ123456',
+                             'NL97ZZZ123456780001',
+                             'ABC1W',
+                             for: [:creditor_identifier, :crid]
+                           )
   end
 
   it 'should not accept an invalid creditor_identifier' do
-    expect(Validatable).not_to accept('', 'xxx', 'DE98ZZZ099999999990', for: [:creditor_identifier, :crid])
+    expect(Validatable).not_to accept(
+                                 '',
+                                 'xxx',
+                                 'DE98ZZZ099999999990',
+                                 for: [:creditor_identifier, :crid]
+                               )
   end
 
   it "should customize error message" do

data/spec/spec_helper.rb

@@ -5,9 +5,11 @@
 
 require 'simplecov'
 
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
-  SimpleCov::Formatter::HTMLFormatter
-])
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new(
+                        [
+                          SimpleCov::Formatter::HTMLFormatter
+                        ]
+                      )
 SimpleCov.start do
   add_filter '/spec/'
 end
@@ -16,7 +18,9 @@ require 'sps_king'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}
+Dir[File.expand_path(File.join(File.dirname(__FILE__), 'support', '**', '*.rb'))].each { |f|
+  require f
+}
 
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|

data/spec/support/active_model.rb

@@ -5,6 +5,7 @@ unless defined?(ActiveModel::Model)
   # https://github.com/rails/rails/blob/master/activemodel/lib/active_model/model.rb
   module ActiveModel
     module Model
+
       def self.included(base)
         base.class_eval do
           extend  ActiveModel::Naming
@@ -14,7 +15,7 @@ unless defined?(ActiveModel::Model)
         end
       end
 
-      def initialize(params={})
+      def initialize(params = {})
         params.each do |attr, value|
           self.public_send("#{attr}=", value)
         end if params
@@ -25,6 +26,7 @@ unless defined?(ActiveModel::Model)
       def persisted?
         false
       end
+
     end
   end
 end

data/spec/support/factories.rb

@@ -1,7 +1,8 @@
 # encoding: utf-8
 
-def credit_transfer_transaction(attributes={})
-  { name:                   'Contoso AG',
+def credit_transfer_transaction(attributes = {})
+  {
+    name:                   'Contoso AG',
     bic:                    'RAIFCH22',
     iban:                   'CH5481230000001998736',
     amount:                 102.50,
@@ -10,15 +11,15 @@ def credit_transfer_transaction(attributes={})
   }.merge(attributes)
 end
 
-def direct_debt_transaction(attributes={})
+def direct_debt_transaction(attributes = {})
   {
-    name:                      'Müller & Schmidt oHG',
-    iban:                      'CH5481230000001998736',
-    amount:                    750.00,
-    instruction:               '123',
-    reference:                 'XYZ/2013-08-ABO/6789',
-    remittance_information:    'Vielen Dank für Ihren Einkauf!',
-    requested_date:            Date.today + 1,
+    name:                              'Müller & Schmidt oHG',
+    iban:                              'CH5481230000001998736',
+    amount:                            750.00,
+    instruction:                       '123',
+    reference:                         'XYZ/2013-08-ABO/6789',
+    remittance_information:            'Vielen Dank für Ihren Einkauf!',
+    requested_date:                    Date.today + 1,
     structured_remittance_information: structured_remittance_information
   }.merge(attributes)
 end

data/spec/support/validations.rb

@@ -2,6 +2,7 @@
 # https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/extensions/active_record/base.rb
 
 module ::ActiveModel::Validations
+
   # Extension to enhance `to have` on AR Model instances.  Calls
   # model.valid? in order to prepare the object's errors object. Accepts
   # a :context option to specify the validation context.
@@ -24,4 +25,5 @@ module ::ActiveModel::Validations
   end
 
   alias :error_on :errors_on
+
 end

data/sps_king.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'sps_king/version'

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: sps_king
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Tobias Schoknecht
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-03 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -126,13 +125,14 @@ files:
 - README.md
 - Rakefile
 - cliff.toml
-- gemfiles/Gemfile-activemodel-6.1.x
-- gemfiles/Gemfile-activemodel-7.0.x
 - gemfiles/Gemfile-activemodel-7.1.x
+- gemfiles/Gemfile-activemodel-7.2.x
+- gemfiles/Gemfile-activemodel-8.0.x
 - lib/schema/pain.001.001.03.ch.02.xsd
 - lib/schema/pain.008.001.02.ch.03.xsd
 - lib/sps_king.rb
 - lib/sps_king/account.rb
+- lib/sps_king/account/address.rb
 - lib/sps_king/account/creditor_account.rb
 - lib/sps_king/account/creditor_address.rb
 - lib/sps_king/account/debtor_account.rb
@@ -150,10 +150,9 @@ files:
 - lib/sps_king/version.rb
 - spec/examples/pain.001.001.03.ch.02.xml
 - spec/examples/pain.008.001.02.ch.03.xml
+- spec/lib/sps_king/account/address_spec.rb
 - spec/lib/sps_king/account/creditor_account_spec.rb
-- spec/lib/sps_king/account/creditor_address_spec.rb
 - spec/lib/sps_king/account/debtor_account_spec.rb
-- spec/lib/sps_king/account/debtor_address_spec.rb
 - spec/lib/sps_king/account_spec.rb
 - spec/lib/sps_king/converter_spec.rb
 - spec/lib/sps_king/message/credit_transfer_spec.rb
@@ -175,7 +174,6 @@ homepage: http://github.com/Barzahlen/sps_king
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -190,17 +188,15 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
-signing_key:
+rubygems_version: 3.6.8
 specification_version: 4
 summary: Ruby gem for creating SPS XML files
 test_files:
 - spec/examples/pain.001.001.03.ch.02.xml
 - spec/examples/pain.008.001.02.ch.03.xml
+- spec/lib/sps_king/account/address_spec.rb
 - spec/lib/sps_king/account/creditor_account_spec.rb
-- spec/lib/sps_king/account/creditor_address_spec.rb
 - spec/lib/sps_king/account/debtor_account_spec.rb
-- spec/lib/sps_king/account/debtor_address_spec.rb
 - spec/lib/sps_king/account_spec.rb
 - spec/lib/sps_king/converter_spec.rb
 - spec/lib/sps_king/message/credit_transfer_spec.rb

data/spec/lib/sps_king/account/creditor_address_spec.rb

@@ -1,14 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe SPS::CreditorAddress do
-  it 'should initialize a new address' do
-    expect(
-      SPS::CreditorAddress.new(
-        country_code:  'CH',
-        address_line1: 'Mustergasse 123',
-        address_line2: '12345 Musterstadt'
-      )
-    ).to be_valid
-  end
-end

data/spec/lib/sps_king/account/debtor_address_spec.rb

@@ -1,14 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-
-describe SPS::DebtorAddress do
-  it 'should initialize a new address' do
-    expect(
-      SPS::DebtorAddress.new(
-        country_code:  'CH',
-        address_line1: 'Mustergasse 123',
-        address_line2: '12345 Musterstadt'
-      )
-    ).to be_valid
-  end
-end