sproutit-sproutcore 1.0.20090721145281 → 1.0.20090721145282

data/frameworks/sproutcore/frameworks/datastore/tests/system/query/find_all.js

@@ -9,6 +9,7 @@
 var MyApp;
 module("SC.Query querying findAll on a store", {
   setup: function() {
+    SC.RunLoop.begin();
     // setup dummy app and store
     MyApp = SC.Object.create({});
     
@@ -44,10 +45,15 @@ module("SC.Query querying findAll on a store", {
     
     // load some data
     MyApp.DataSource.storeKeys = MyApp.store.loadRecords(MyApp.Foo, records);
+    SC.RunLoop.end();
+    
+    SC.RunLoop.begin();
     // for sanity check, load two record types
     MyApp.store.loadRecords(MyApp.Faa, records);
+    SC.RunLoop.end();
     
   }
+  
 });
 
 
@@ -56,7 +62,6 @@ module("SC.Query querying findAll on a store", {
 // 
 
 test("should find records based on boolean", function() {
-  
   var q = SC.Query.create({recordType: MyApp.Foo, conditions:"married=true"});
   
   var records = MyApp.store.findAll(q);
@@ -140,7 +145,7 @@ test("loading more data into the store should propagate to record array", functi
 });
 
 test("loading more data into the store should propagate to record array with query", function() {
-  
+  SC.RunLoop.begin();
   var q = SC.Query.create({recordType: MyApp.Foo, conditions:"firstName = 'John'"});
   
   var records = MyApp.store.findAll(q);
@@ -155,16 +160,17 @@ test("loading more data into the store should propagate to record array with que
   // and should fire original SC.Query again
   
   MyApp.DataSource.storeKeys.replace(0,0,newStoreKeys);
-  
+  SC.RunLoop.end();
   equals(records.get('length'), 2, 'record length after should be 2');
   
   // subsequent updates to store keys should also work
-  
+  SC.RunLoop.begin();
   var newStoreKeys2 = MyApp.store.loadRecords(MyApp.Foo, [
     { guid: 11, firstName: "John", lastName: "Norman" }
   ]);
   
   MyApp.DataSource.storeKeys.replace(0,0,newStoreKeys2);
+  SC.RunLoop.end();
   
   equals(records.get('length'), 3, 'record length after should be 3');
   
@@ -182,6 +188,7 @@ test("SC.Query returned from fetchRecords() should return result set", function(
 
 test("Loading records after SC.Query is returned in fetchRecords() should show up", function() {
   
+  SC.RunLoop.begin();
   var q = SC.Query.create({recordType: MyApp.Foo, conditions:"firstName = 'John'"});
   
   var records = MyApp.store.findAll(q);
@@ -195,6 +202,7 @@ test("Loading records after SC.Query is returned in fetchRecords() should show u
   ];
   
   MyApp.store.loadRecords(MyApp.Foo, recordsToLoad);
+  SC.RunLoop.end();
   
   equals(records.get('length'), 3, 'record length should be 3');
   
@@ -206,6 +214,7 @@ test("Loading records after SC.Query is returned in fetchRecords() should show u
 
 test("Loading records after getting empty record array based on SC.Query should update", function() {
   
+  SC.RunLoop.begin();
   var q = SC.Query.create({recordType: MyApp.Foo, conditions:"firstName = 'Maria'"});
   
   var records = MyApp.store.findAll(q);
@@ -216,6 +225,7 @@ test("Loading records after getting empty record array based on SC.Query should
   ];
   
   MyApp.store.loadRecords(MyApp.Foo, recordsToLoad);
+  SC.RunLoop.end();
   
   equals(records.get('length'), 1, 'record length should be 1');
   
@@ -225,6 +235,8 @@ test("Loading records after getting empty record array based on SC.Query should
 
 test("Changing a record should make it show up in RecordArrays based on SC.Query", function() {
   
+  SC.RunLoop.begin();
+  
   var q = SC.Query.create({recordType: MyApp.Foo, conditions:"firstName = 'Maria'"});
   
   var records = MyApp.store.findAll(q);
@@ -233,6 +245,8 @@ test("Changing a record should make it show up in RecordArrays based on SC.Query
   var record = MyApp.store.find(MyApp.Foo, 1);
   record.set('firstName', 'Maria');
   
+  SC.RunLoop.end();
+  
   equals(records.get('length'), 1, 'record length should be 1');
   
   equals(records.objectAt(0).get('firstName'), 'Maria', 'name should be Maria');
@@ -241,13 +255,14 @@ test("Changing a record should make it show up in RecordArrays based on SC.Query
 
 test("Deleting a record should make the RecordArray based on SC.Query update accordingly", function() {
   
+  SC.RunLoop.begin();
   var q = SC.Query.create({recordType: MyApp.Foo, conditions:"firstName = 'John'"});
   
   var records = MyApp.store.findAll(q);
   equals(records.get('length'), 1, 'record length should be 1');
   
   MyApp.store.destroyRecord(MyApp.Foo, 1);
-  MyApp.store.commitRecords();
+  SC.RunLoop.end();
   
   equals(records.get('length'), 0, 'record length should be 0');
   
@@ -255,6 +270,7 @@ test("Deleting a record should make the RecordArray based on SC.Query update acc
 
 test("Using findAll with SC.Query on store with no data source should work", function() {
   
+  SC.RunLoop.begin();
   // create a store with no data source
   MyApp.store3 = SC.Store.create();
   
@@ -268,9 +284,11 @@ test("Using findAll with SC.Query on store with no data source should work", fun
     { guid: 21, firstName: "John", lastName: "Anderson" },
     { guid: 22, firstName: "Barbara", lastName: "Jones" }
   ];
-  
+
   MyApp.store3.loadRecords(MyApp.Foo, recordsToLoad);
   
+  SC.RunLoop.end();
+  
   equals(records.get('length'), 2, 'record length should be 2');
   
 });
@@ -288,6 +306,7 @@ test("Using orderBy in SC.Query returned from findAll()", function() {
 
 test("Using orderBy in SC.Query returned from findAll() and loading more records to original store key array", function() {
   
+  SC.RunLoop.begin();
   var q = SC.Query.create({recordType: MyApp.Foo, orderBy:"firstName ASC"});
   
   var records = MyApp.store.findAll(q);
@@ -301,6 +320,7 @@ test("Using orderBy in SC.Query returned from findAll() and loading more records
   ]);
   
   MyApp.DataSource.storeKeys.replace(0,0,newStoreKeys2);
+  SC.RunLoop.end();
   
   equals(records.objectAt(0).get('firstName'), 'Anna', 'name should be Anna');
   equals(records.objectAt(1).get('firstName'), 'Bert', 'name should be Bert');
@@ -311,6 +331,7 @@ test("Using orderBy in SC.Query returned from findAll() and loading more records
 
 test("Using orderBy in SC.Query and loading more records to the store", function() {
   
+  SC.RunLoop.begin();
   var q = SC.Query.create({recordType: MyApp.Foo, orderBy:"firstName ASC"});
   
   var records = MyApp.store.findAll(q);
@@ -320,6 +341,7 @@ test("Using orderBy in SC.Query and loading more records to the store", function
   MyApp.store.loadRecords(MyApp.Foo, [
     { guid: 11, firstName: "Anna", lastName: "Petterson" }
   ]);
+  SC.RunLoop.end();
   
   equals(records.get('length'), 6, 'record length should be 6');
   
@@ -347,6 +369,7 @@ test("Chaining findAll() queries", function() {
 
 test("Chaining findAll() queries and loading more records", function() {
   
+  SC.RunLoop.begin();
   var q = SC.Query.create({recordType: MyApp.Foo, conditions:"lastName='Doe'"});
   var q2 = SC.Query.create({recordType: MyApp.Foo, conditions:"firstName='John'"});
   
@@ -356,7 +379,34 @@ test("Chaining findAll() queries and loading more records", function() {
   MyApp.store.loadRecords(MyApp.Foo, [
     { guid: 11, firstName: "John", lastName: "Doe" }
   ]);
+  SC.RunLoop.end();
   
   equals(records.get('length'), 2, 'record length should be 2');
   
 });
+
+
+module("create record");
+
+test("creating record appears in future findAll", function() {
+  var Rec = SC.Record.extend({ title: SC.Record.attr(String) });
+  var store = SC.Store.create();
+  SC.run(function() {
+    store.loadRecords(Rec, 
+      [{ title: "A", guid: 1 }, { title: "B", guid: 2 }]);
+  });
+  
+  equals(store.findAll(Rec).get('length'), 2, 'should have two initial record');
+
+  var r;
+  
+  SC.run(function() {
+    store.createRecord(Rec, { title: "C" });
+    r = store.findAll(Rec);
+    equals(r.get('length'), 3, 'should return additional record');
+  });
+
+  r = store.findAll(Rec);
+  equals(r.get('length'), 3, 'should return additional record');
+  
+});

data/frameworks/sproutcore/frameworks/datastore/tests/system/store/commitRecord.js

@@ -56,6 +56,7 @@ module("SC.Store#commitRecord", {
       bool:   YES
     };
     
+    SC.RunLoop.begin();
     storeKey1 = SC.Store.generateStoreKey();
     store.writeDataHash(storeKey1, json1, SC.Record.READY_CLEAN);
     storeKey2 = SC.Store.generateStoreKey();
@@ -70,7 +71,7 @@ module("SC.Store#commitRecord", {
     store.writeDataHash(storeKey6, json6, SC.Record.READY_ERROR);
     storeKey7 = SC.Store.generateStoreKey();
     store.writeDataHash(storeKey7, json7, SC.Record.READY_DESTROYED_CLEAN);
-
+    SC.RunLoop.end();
   }
 });
 
@@ -89,11 +90,15 @@ test("Confirm that all the states are switched as expected after running commitR
   status = store.readStatus( storeKey3);
   equals(status, SC.Record.BUSY_COMMITTING, "the status should be SC.Record.BUSY_COMMITTING");
   
+  store.dataSourceDidComplete(storeKey3);
+  status = store.readStatus( storeKey3);
+  equals(status, SC.Record.READY_CLEAN, "the status should be SC.Record.READY_CLEAN");
+  
   store.commitRecord(undefined, undefined, storeKey4);
   status = store.readStatus( storeKey4);
   equals(status, SC.Record.BUSY_DESTROYING, "the status should be SC.Record.BUSY_DESTROYING");
   
-  try{
+  try {
     store.commitRecord(undefined, undefined, storeKey5);
     throwError=false;
     msg='';
@@ -123,4 +128,6 @@ test("Confirm that all the states are switched as expected after running commitR
   }
   equals(msg, SC.Record.NOT_FOUND_ERROR.message, "commitRecord should throw the following error");
   
+  
+  
 });

data/frameworks/sproutcore/frameworks/datastore/tests/system/store/core_methods.js

@@ -5,11 +5,17 @@
 // ==========================================================================
 /*globals module ok equals same test MyApp Sample */
 
-var store, Application;
+var store, Application, dataSource;
 
 module("SC.Store Core Methods", {
   setup: function() {
-    var dataSource = SC.DataSource.create({});
+    dataSource = SC.DataSource.create({ 
+      
+      gotParams: NO,
+      
+      updateRecord: function(store, storeKey, params) {
+        this.gotParams = params && params['param1'] ? YES: NO;
+      }});
     
     Application = {};
     
@@ -35,10 +41,12 @@ module("SC.Store Core Methods", {
       ]
     };
     
+    SC.RunLoop.begin();
     store = SC.Store.create().from(dataSource);
     for(var i in Application.Data) {
       store.loadRecords(Application[i], Application.Data[i]);
     }
+    SC.RunLoop.end();
     
     // make sure RecordType by String can map
     window.Application = Application;
@@ -71,3 +79,38 @@ test("find() should take both SC.Record object and SC.Record string as recordtyp
   
 });
 
+test("loading more records should not sending _flushRecordChanges() until the end of the runloop", function() {
+
+  var moreData = [
+      { guid: '55', name: 'Home', url: '/emily_parker', isDirectory: true, parent: null, children: 'Collection'},
+      { guid: '56', name: 'Documents', fileType: 'documents', url: '/emily_parker/Documents', isDirectory: true, parent: '10', children: 'Collection', createdAt: 'June 15, 2007', modifiedAt: 'October 21, 2007', filetype: 'directory', isShared: false},
+      { guid: '57',name: 'Library', fileType: 'library', url: '/emily_parker/Library', isDirectory: true, parent: '10', children: 'Collection', createdAt: 'June 15, 2007', modifiedAt: 'October 21, 2007', filetype: 'directory', isShared: false}
+  ];
+  
+  SC.RunLoop.begin();
+  
+  var storeKeys = store.loadRecords(Application.File, moreData);
+  equals(storeKeys.length, 3, 'precon - should have loaded three records');
+  equals(store.recordPropertyChanges.storeKeys.length, 3, 'should be three storeKeys in changelog');
+  
+  SC.RunLoop.end();
+  
+  // recordPropertyChanges may not exist after notifications have gone out.
+  // treat that like having len=0
+  var changes = store.recordPropertyChanges;
+  var len = (changes && changes.storeKeys) ? changes.storeKeys.length : 0;
+  equals(len, 0, 'should be zero storeKeys in changelog');
+  
+});
+
+test("Passing params through commitRecords()", function() {
+  
+  var file = store.find(Application.File, '14');
+  file.set('name', 'My Great New Name');
+  
+  store.commitRecords(null, null, null, { param1: 'value1' });
+  
+  equals(dataSource.gotParams, YES, 'params should have travelled through to dataSource updateRecord() call');
+  
+
+});

data/frameworks/sproutcore/frameworks/datastore/tests/system/store/recordDidChange.js

@@ -70,5 +70,4 @@ test("recordDidChange", function() {
    status = store.readStatus( storeKey4);
    equals(status, SC.Record.READY_DIRTY, "the status shouldn't have changed.");
   
- 
 });

data/frameworks/sproutcore/frameworks/datastore/tests/system/store/retrieveRecord.js

@@ -82,20 +82,36 @@ module("SC.Store#retrieveRecord", {
     store.writeDataHash(storeKey8, json8, SC.Record.READY_CLEAN);
     }
 });
-    
-test("Retrieve a record and check for different errors and states", function() {
+  
+function testStates(canLoad) {
   var msg, status;
+  
+  SC.RunLoop.begin();
+  
   store.retrieveRecord(undefined, undefined, storeKey1, YES);
   status = store.readStatus( storeKey1);
-  equals(status, SC.Record.BUSY_LOADING, "the status should have changed to BUSY_LOADING");
+  if (canLoad) {
+    equals(status, SC.Record.BUSY_LOADING, "the status should have changed to BUSY_LOADING");
+  } else {
+    equals(status, SC.Record.ERROR, "the status should remain empty");
+  }
+  
   
   store.retrieveRecord(undefined, undefined, storeKey2, YES);
   status = store.readStatus( storeKey2);
-  equals(status, SC.Record.BUSY_LOADING, "the status should have changed to BUSY_LOADING");
+  if (canLoad) {
+    equals(status, SC.Record.BUSY_LOADING, "the status should have changed to BUSY_LOADING");
+  } else {
+    equals(status, SC.Record.ERROR, "the status should become empty");
+  }
   
   store.retrieveRecord(undefined, undefined, storeKey3, YES);
   status = store.readStatus( storeKey3);
-  equals(status, SC.Record.BUSY_LOADING, "the status should have changed to BUSY_LOADING");
+  if (canLoad) {
+    equals(status, SC.Record.BUSY_LOADING, "the status should have changed to BUSY_LOADING");
+  } else {
+    equals(status, SC.Record.ERROR, "the status should become empty");
+  }
   
   try{
     store.retrieveRecord(undefined, undefined, storeKey4, YES);
@@ -132,6 +148,37 @@ test("Retrieve a record and check for different errors and states", function() {
 
   store.retrieveRecord(undefined, undefined, storeKey8, YES);
   status = store.readStatus( storeKey8);
-  ok(SC.Record.BUSY_REFRESH | (status & 0x03), "the status changed to BUSY_REFRESH.");
+  if (canLoad) {
+    ok(SC.Record.BUSY_REFRESH | (status & 0x03), "the status changed to BUSY_REFRESH.");
+  } else {
+    equals(status, SC.Record.READY_CLEAN, "the status should remain ready clean");
+  }
   
+  SC.RunLoop.end();
+}  
+
+test("Retrieve a record without a data source", function() {
+  testStates(NO);
+});
+
+test("Retrieve a record without a working data source and check for different errors and states", function() {
+  // build a fake data source that claims to NOT handle retrieval
+  var source = SC.DataSource.create({
+    retrieveRecords: function() { return NO ; }
+  });
+  store.set('dataSource', source);
+
+  testStates(NO);
+
+});
+
+test("Retrieve a record with working data source and check for different errors and states", function() {
+  // build a fake data source that claims to handle retrieval
+  var source = SC.DataSource.create({
+    retrieveRecords: function() { return YES ; }
+  });
+  store.set('dataSource', source);
+
+  testStates(YES);
+
 });

data/frameworks/sproutcore/frameworks/datastore/tests/system/store/writeDataHash.js

@@ -123,8 +123,3 @@ test("change should not propogate to child if child edit state = EDITABLE", func
 
 
 
-
-
-
-
-

data/frameworks/sproutcore/frameworks/desktop/panes/menu.js

@@ -31,8 +31,9 @@ SC.MenuPane = SC.PickerPane.extend(
 
     @readOnly
     @type Boolean
+    @default isEnabled
   */
-  itemIsEnabledKey: YES,
+  itemIsEnabledKey: "isEnabled",
   
   /**
     The key that contains the title for each item.  If omitted, no icons will
@@ -40,8 +41,9 @@ SC.MenuPane = SC.PickerPane.extend(
 
     @readOnly
     @type String
+    @default title
   */
-  itemTitleKey: null,
+  itemTitleKey: 'title',
 
   /**
     The array of items to display.  This can be a simple array of strings,
@@ -59,8 +61,9 @@ SC.MenuPane = SC.PickerPane.extend(
 
     @readOnly
     @type String
+    @default value
   */
-  itemValueKey: null,
+  itemValueKey: 'value',
 
   /** 
     The key that contains the icon for each item.  If omitted, no icons will
@@ -68,8 +71,9 @@ SC.MenuPane = SC.PickerPane.extend(
 
     @readOnly
     @type String
+    @default icon
   */
-  itemIconKey: null,
+  itemIconKey: 'icon',
 
   /** 
     The width for each menu item and ultimately the menu itself.
@@ -97,8 +101,18 @@ SC.MenuPane = SC.PickerPane.extend(
 
     @readOnly
     @type String
+    @default height
   */
-  itemHeightKey: null,
+  itemHeightKey: 'height',
+  
+  /** 
+    The submenu for a menu item if any.
+
+    @readOnly
+    @type String
+    @default subMenu
+  */
+  subMenuKey: 'subMenu',
 
   /**
     If YES, titles will be localized before display.
@@ -110,56 +124,63 @@ SC.MenuPane = SC.PickerPane.extend(
 
     @readOnly
     @type Boolean
+    @default separator
   */  
-  itemSeparatorKey: null,
+  itemSeparatorKey: 'separator',
 
   /** 
     This key is need to assign an action to the menu item.
 
     @readOnly
     @type String
+    @default action
   */
-  itemActionKey: null,
+  itemActionKey: 'action',
 
   /** 
     The key for setting a checkbox for the menu item.
 
     @readOnly
     @type String
+    @default checkbox
   */
-  itemCheckboxKey: null,
+  itemCheckboxKey: 'checkbox',
 
   /** 
     The key for setting a branch for the menu item.
 
     @readOnly
     @type String
+    @default branchItem
   */
-  itemBranchKey: null,
+  itemBranchKey: 'branchItem',
   
   /** 
     The key for setting a branch for the menu item.
 
     @readOnly
     @type String
+    @default shortcut
   */
-  itemShortCutKey: null,
+  itemShortCutKey: 'shortcut',
   
   /** 
     The key for setting Key Equivalent for the menu item.
 
     @readOnly
     @type String
+    @default keyEquivalent
   */
-  itemKeyEquivalentKey: null,
+  itemKeyEquivalentKey: 'keyEquivalent',
   
   /** 
     The key for setting Key Equivalent for the menu item.
 
     @readOnly
     @type String
+    @default target
   */
-  itemTargetKey: null,
+  itemTargetKey: 'target',
   
   /** @private */
   isKeyPane: YES,
@@ -270,7 +291,7 @@ SC.MenuPane = SC.PickerPane.extend(
           if (loc && cur[0]) cur[0] = cur[0].loc() ;
           ret[rel] = SC.Object.create({ title: cur[0], value: cur[1],
                                               isEnabled: cur[2], icon: cur[3], 
-                                              isSeparator: cur[4], action: cur[5],
+                                              isSeparator: cur[4]||NO , action: cur[5],
                                               isCheckbox: cur[6], isShortCut: cur[7],
                                               menuItemNumber: idx, isBranch: cur[8],
                                               itemHeight: cur[9], subMenu: cur[10], 
@@ -462,7 +483,7 @@ SC.MenuPane = SC.PickerPane.extend(
   */
   isAnchorMenuItemType: function() {
     var anchor = this.get('anchor') ;
-    return (anchor && anchor.kindOf(SC.MenuItemView)) ;
+    return (anchor && anchor.kindOf && anchor.kindOf(SC.MenuItemView)) ;
   },
   
   //..........................................................
@@ -480,12 +501,11 @@ SC.MenuPane = SC.PickerPane.extend(
     var items, len, menuItems, item, keyEquivalent, 
         action, isEnabled, target;
     if(!this.get('isEnabled')) return NO ;
-
+    this.displayItems() ;
     items = this.get('displayItemsArray') ;
     if (!items) return NO;
 
     len = items.length ;
-    menuItems = this.get('menuItemViews');
     for(var idx=0; idx<len; ++idx) {
       item          = items[idx] ;
       keyEquivalent = item.get('keyEquivalent') ;
@@ -493,13 +513,11 @@ SC.MenuPane = SC.PickerPane.extend(
       isEnabled     = item.get('isEnabled') ;
       target        = item.get('target') || this ;
       if(keyEquivalent == keyString && isEnabled) {
-        if(menuItems && menuItems[idx]) {
-          var retVal = menuItems[idx].triggerAction(evt);
-          return retVal;
-        }
+        var retVal = SC.RootResponder.responder.sendAction(action,target);
+        return retVal;
       }
     }
-    return YES ;
+    return NO ;
   },
   
   //Mouse and Key Events
@@ -558,17 +576,18 @@ SC.MenuPane = SC.PickerPane.extend(
     var menuItemViews = this.get('menuItemViews') ;
     if(menuItemViews) {
       var len = menuItemViews.length ;
-      var idx = (menuItemViews.indexOf(menuItem) === -1) ? len : menuItemViews.indexOf(menuItem) ;
+      var menuIdx = idx = (menuItemViews.indexOf(menuItem) === -1) ? 
+        len : menuItemViews.indexOf(menuItem) ;
       var isEnabled = NO ;
       var isSeparator = NO ;
-      while(--idx >= 0 && !isEnabled && !isSeparator) {
+      while((!isEnabled || isSeparator) && --idx !== menuIdx) {
+        if(idx === -1) idx = len - 1;
         isEnabled = menuItemViews[idx].get('isEnabled') ;
         var content = menuItemViews[idx].get('content') ;
         if(content) {
           isSeparator = content.get(menuItemViews[idx].get('isSeparatorKey'));
         }
       }
-      if(idx === -1) idx = len - 1;
       return menuItemViews[idx];
     }
   },
@@ -582,17 +601,18 @@ SC.MenuPane = SC.PickerPane.extend(
     var menuItemViews = this.get('menuItemViews') ;
     if(menuItemViews) {
       var len = menuItemViews.length ;
-      var idx = (menuItemViews.indexOf(menuItem) === -1) ? 0 : menuItemViews.indexOf(menuItem) ;
+      var menuIdx = idx = (menuItemViews.indexOf(menuItem) === -1) ? 
+        0 : menuItemViews.indexOf(menuItem) ;
       var isEnabled = NO ;
       var isSeparator = NO ;
-      while(!isEnabled && !isSeparator && ++idx < len) {
+      while((!isEnabled || isSeparator) && ++idx !== menuIdx) {
+        if(idx === len) idx = 0;
         isEnabled = menuItemViews[idx].get('isEnabled') ;
         var content = menuItemViews[idx].get('content') ;
         if(content) {
           isSeparator = content.get(menuItemViews[idx].get('isSeparatorKey'));
         }
       }
-      if(idx === len) idx = 0 ;
       return menuItemViews[idx] ;
     }
   },

data/frameworks/sproutcore/frameworks/desktop/system/drag.js

@@ -334,9 +334,9 @@ SC.Drag = SC.Object.extend(
       return ; // quickly ignore duplicate calls
     } 
     
-    // cache the current location to avoid processing duplicate mouseDragged 
-    // calls
-    this.set('location', { x: evt.pageX, y: evt.pageY }) ;
+    // save the new location to avoid duplicate mouseDragged event processing
+    loc = { x: evt.pageX, y: evt.pageY };
+    this.set('location', loc) ;
     
     // STEP 1: Determine the deepest drop target that allows an operation.
     // if the drop target selected the last time this method was called 
@@ -543,7 +543,8 @@ SC.Drag = SC.Object.extend(
     for (var idx=0, len=ary.length; idx<len; idx++) {
       target = ary[idx] ;
       
-      // FIXME if (!target.get('isVisibleInWindow')) continue ;
+      // If the target is not visible, it is not valid.
+      if (!target.get('isVisibleInWindow')) continue ;
       
       // get clippingFrame, converted to the pane.
       frame = target.convertFrameToView(target.get('clippingFrame'), null) ;