sproutit-sproutcore 1.0.0.20090416161445 → 1.0.0.20090720093355

data/frameworks/sproutcore/frameworks/runtime/mixins/copyable.js

@@ -0,0 +1,64 @@
+// ==========================================================================
+// Project:   SproutCore Costello - Property Observing Library
+// Copyright: ©2006-2009 Sprout Systems, Inc. and contributors.
+//            Portions ©2008-2009 Apple, Inc. All rights reserved.
+// License:   Licened under MIT license (see license.js)
+// ==========================================================================
+
+/**
+  @namespace
+  
+  Implements some standard methods for copying an object.  Add this mixin to
+  any object you create that can create a copy of itself.  This mixin is 
+  added automatically to the built-in array.
+  
+  You should generally implement the copy() method to return a copy of the 
+  recevier.
+  
+  Note that frozenCopy() will only work if you implement SC.Freezable as well.
+
+  @since SproutCore 1.0
+*/
+SC.Copyable = {
+  
+  /**
+    walk like a duck.  Indicates that the object can be copied.
+    
+    @type Boolean
+  */
+  isCopyable: YES,
+  
+  /**
+    Override to return a copy of the receiver.  Default implementation raises
+    an exception.
+    
+    @returns {Object} copy of receiver
+  */
+  copy: function() {
+    throw "%@.copy() is not implemented";
+  },
+  
+  /**
+    If the object implements SC.Freezable, then this will return a new copy 
+    if the object is not frozen and the receiver if the object is frozen.  
+    
+    Raises an exception if you try to call this method on a object that does
+    not support freezing.
+    
+    You should use this method whenever you want a copy of a freezable object
+    since a freezable object can simply return itself without actually 
+    consuming more memory.
+  
+    @returns {Object} copy of receiver or receiver
+  */
+  frozenCopy: function() {
+    var isFrozen = this.get ? this.get('isFrozen') : this.isFrozen;
+    if (isFrozen === YES) return this;
+    else if (isFrozen === undefined) throw "%@ does not support freezing";
+    else return this.copy().freeze();
+  }
+};
+
+// Make Array copyable
+SC.mixin(Array.prototype, SC.Copyable);
+Array.prototype.copy = Array.prototype.slice;

data/frameworks/sproutcore/frameworks/runtime/mixins/delegate_support.js

@@ -34,6 +34,31 @@
 */
 SC.DelegateSupport = {  
   
+  /**
+    Selects the delegate that implements the specified method name.  Pass one
+    or more delegates.  The receiver is automatically included as a default.
+    
+    This can be more efficient than using invokeDelegateMethod() which has
+    to marshall arguments into a delegate call.
+    
+    @param {String} methodName
+    @param {Object...} delegate one or more delegate arguments
+    @returns {Object} delegate or null
+  */
+  delegateFor: function(methodName) {
+    var idx = 1,
+        len = arguments.length,
+        ret ;
+        
+    while(idx<len) {
+      ret = arguments[idx];
+      if (ret && ret[methodName] !== undefined) return ret ;
+      idx++;      
+    }
+    
+    return (this[methodName] !== undefined) ? this : null;
+  },
+  
   /**
     Invokes the named method on the delegate that you pass.  If no delegate
     is defined or if the delegate does not implement the method, then a 
@@ -49,7 +74,7 @@ SC.DelegateSupport = {
     @returns value returned by delegate
   */
   invokeDelegateMethod: function(delegate, methodName, args) {
-    args = SC.$A(arguments); args = args.slice(2, args.length) ;
+    args = SC.A(arguments); args = args.slice(2, args.length) ;
     if (!delegate || !delegate[methodName]) delegate = this ;
     
     var method = delegate[methodName];
@@ -57,14 +82,27 @@ SC.DelegateSupport = {
   },
   
   /**
-    Gets the named property from the delegate if the delegate exists and it
-    defines the property.  Otherwise, gets the property from the receiver.
+    Search the named delegates for the passed property.  If one is found, 
+    gets the property value and returns it.  If none of the passed delegates 
+    implement the property, search the receiver for the property as well.
     
-    @param {Object} delegate the delegate or null
     @param {String} key the property to get.
+    @param {Object} delegate one or more delegate
+    @returns {Object} property value or undefined
   */
-  getDelegateProperty: function(delegate, key) {
-    return (delegate && (delegate[key] !== undefined) && delegate[key]!==null) ? delegate.get(key) : this.get(key) ;
+  getDelegateProperty: function(key, delegate) {
+    var idx = 1,
+        len = arguments.length,
+        ret ;
+        
+    while(idx<len) {
+      ret = arguments[idx++];
+      if (ret && ret[key] !== undefined) {
+        return ret.get ? ret.get(key) : ret[key] ;
+      }
+    }
+    
+    return (this[key] !== undefined) ? this.get(key) : undefined ;
   }
   
 };

data/frameworks/sproutcore/frameworks/runtime/mixins/enumerable.js

@@ -8,6 +8,8 @@
 require('core') ;
 require('system/enumerator');
 
+/*globals Prototype */
+
 /**
   @namespace
 
@@ -48,6 +50,11 @@ require('system/enumerator');
 */
 SC.Enumerable = {
 
+  /** 
+    Walk like a duck.
+  */
+  isEnumerable: YES,
+  
   /**
     Implement this method to make your class enumerable.
     
@@ -80,9 +87,32 @@ SC.Enumerable = {
     @returns {Object} the next object in the iteration or undefined   
   */ 
   nextObject: function(index, previousObject, context) {
-    return (this.objectAt) ? this.objectAt(index) : this[index] ;
+    return this.objectAt ? this.objectAt(index) : this[index] ;
   },
   
+  /**
+    Helper method returns the first object from a collection.  This is usually
+    used by bindings and other parts of the framework to extract a single 
+    object if the enumerable contains only one item.
+    
+    If you override this method, you should implement it so that it will 
+    always return the same value each time it is called.  If your enumerable
+    contains only one object, this method should always return that object.
+    If your enumerable is empty, this method should return undefined.
+    
+    @returns {Object} the object or undefined
+  */
+  firstObject: function() {
+    if (this.get('length')===0) return undefined ;
+    if (this.objectAt) return this.objectAt(0); // support arrays out of box
+    
+    // handle generic enumerables
+    var context = SC.Enumerator._popContext(), ret;
+    ret = this.nextObject(0, null, context);
+    context = SC.Enumerator._pushContext(context);  
+    return ret ;
+  }.property(),
+  
   /**
     Returns a new enumerator for this object.  See SC.Enumerator for
     documentation on how to use this object.  Enumeration is an alternative
@@ -118,7 +148,7 @@ SC.Enumerable = {
   */
   forEach: function(callback, target) {
     if (typeof callback !== "function") throw new TypeError() ;
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     if (target === undefined) target = null;
     
     var last = null ;
@@ -143,14 +173,14 @@ SC.Enumerable = {
     @returns {Array} extracted values
   */
   getEach: function(key) {
-    var len = (this.get)? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     var ret = [] ;
 
     var last = null ;
     var context = SC.Enumerator._popContext();
     for(var idx=0;idx<len;idx++) {
       var next = this.nextObject(idx, last, context) ;
-      var obj = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+      var obj = next ? (next.get ? next.get(key) : next[key]) : null;
       ret[ret.length] = obj;
       last = next ;
     }
@@ -170,7 +200,7 @@ SC.Enumerable = {
     @returns {Object} receiver
   */
   setEach: function(key, value) {
-    var len = (this.get)? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
 
     var last = null ;
     var context = SC.Enumerator._popContext();
@@ -215,7 +245,7 @@ SC.Enumerable = {
   */
   map: function(callback, target) {
     if (typeof callback !== "function") throw new TypeError() ;
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     if (target === undefined) target = null;
     
     var ret  = [];
@@ -239,13 +269,13 @@ SC.Enumerable = {
     @returns {Array} The mapped array.
   */
   mapProperty: function(key) {
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     var ret  = [];
     var last = null ;
     var context = SC.Enumerator._popContext();
     for(var idx=0;idx<len;idx++) {
       var next = this.nextObject(idx, last, context) ;
-      ret[idx] = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+      ret[idx] = next ? (next.get ? next.get(key) : next[key]) : null;
       last = next ;
     }
     last = null ;
@@ -281,7 +311,7 @@ SC.Enumerable = {
   */
   filter: function(callback, target) {
     if (typeof callback !== "function") throw new TypeError() ;
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     if (target === undefined) target = null;
     
     var ret  = [];
@@ -297,6 +327,41 @@ SC.Enumerable = {
     return ret ;
   },
 
+  /** 
+    Returns an array sorted by the value of the passed key parameters.
+    null objects will be sorted first.  You can pass either an array of keys
+    or multiple parameters which will act as key names
+    
+    @param {String} key one or more key names
+    @returns {Array}
+  */
+  sortProperty: function(key) {
+    var keys = (typeof key === SC.T_STRING) ? arguments : key,
+        len  = keys.length,
+        src;
+     
+    // get the src array to sort   
+    if (this instanceof Array) src = this;
+    else {
+      src = [];
+      this.forEach(function(i) { src.push(i); });
+    }
+    
+    if (!src) return [];
+    return src.sort(function(a,b) {
+      var idx, key, aValue, bValue, ret = 0;
+      
+      for(idx=0;ret===0 && idx<len;idx++) {
+        key = keys[idx];
+        aValue = a ? (a.get ? a.get(key) : a[key]) : null;
+        bValue = b ? (b.get ? b.get(key) : b[key]) : null;
+        ret = SC.compare(aValue, bValue);
+      }
+      return ret ;
+    });
+  },
+  
+
   /**
     Returns an array with just the items with the matched property.  You
     can pass an optional second argument with the target value.  Otherwise
@@ -307,13 +372,13 @@ SC.Enumerable = {
     @returns {Array} filtered array
   */
   filterProperty: function(key, value) {
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     var ret  = [];
     var last = null ;
     var context = SC.Enumerator._popContext();
     for(var idx=0;idx<len;idx++) {
       var next = this.nextObject(idx, last, context) ;
-      var cur = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+      var cur = next ? (next.get ? next.get(key) : next[key]) : null;
       var matched = (value === undefined) ? !!cur : SC.isEqual(cur, value);
       if (matched) ret.push(next) ;
       last = next ;
@@ -351,10 +416,10 @@ SC.Enumerable = {
   */
   find: function(callback, target) {
     if (typeof callback !== "function") throw new TypeError() ;
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     if (target === undefined) target = null;
-    
-    var next, found = NO, ret = null ;
+
+    var last = null, next, found = NO, ret = null ;
     var context = SC.Enumerator._popContext();
     for(var idx=0;idx<len && !found;idx++) {
       next = this.nextObject(idx, last, context) ;
@@ -378,12 +443,12 @@ SC.Enumerable = {
     @returns {Object} found item or null
   */
   findProperty: function(key, value) {
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     var found = NO, ret = null, last = null, next, cur ;
     var context = SC.Enumerator._popContext();
     for(var idx=0;idx<len && !found;idx++) {
       next = this.nextObject(idx, last, context) ;
-      cur = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+      cur = next ? (next.get ? next.get(key) : next[key]) : null;
       found = (value === undefined) ? !!cur : SC.isEqual(cur, value);
       if (found) ret = next ;
       last = next ;
@@ -426,7 +491,7 @@ SC.Enumerable = {
   */
   every: function(callback, target) {
     if (typeof callback !== "function") throw new TypeError() ;
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     if (target === undefined) target = null;
     
     var ret  = YES;
@@ -451,13 +516,13 @@ SC.Enumerable = {
     @returns {Array} filtered array
   */
   everyProperty: function(key, value) {
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     var ret  = YES;
     var last = null ;
     var context = SC.Enumerator._popContext();
     for(var idx=0;ret && (idx<len);idx++) {
       var next = this.nextObject(idx, last, context) ;
-      var cur = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+      var cur = next ? (next.get ? next.get(key) : next[key]) : null;
       ret = (value === undefined) ? !!cur : SC.isEqual(cur, value);
       last = next ;
     }
@@ -500,7 +565,7 @@ SC.Enumerable = {
   */
   some: function(callback, target) {
     if (typeof callback !== "function") throw new TypeError() ;
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     if (target === undefined) target = null;
     
     var ret  = NO;
@@ -525,13 +590,13 @@ SC.Enumerable = {
     @returns {Boolean} YES 
   */
   someProperty: function(key, value) {
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     var ret  = NO;
     var last = null ;
     var context = SC.Enumerator._popContext();
     for(var idx=0; !ret && (idx<len); idx++) {
       var next = this.nextObject(idx, last, context) ;
-      var cur = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+      var cur = next ? (next.get ? next.get(key) : next[key]) : null;
       ret = (value === undefined) ? !!cur : SC.isEqual(cur, value);
       last = next ;
     }
@@ -574,7 +639,7 @@ SC.Enumerable = {
   */
   reduce: function(callback, initialValue, reducerProperty) {
     if (typeof callback !== "function") throw new TypeError() ;
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
 
     // no value to return if no initial value & empty
     if (len===0 && initialValue === undefined) throw new TypeError();
@@ -588,7 +653,7 @@ SC.Enumerable = {
       // while ret is still undefined, just set the first value we get as ret.
       // this is not the ideal behavior actually but it matches the FireFox
       // implementation... :(
-      if (next != null) {
+      if (next !== null) {
         if (ret === undefined) {
           ret = next ;
         } else {
@@ -615,23 +680,25 @@ SC.Enumerable = {
     @returns {Array} return values from calling invoke.
   */
   invoke: function(methodName) {
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     if (len <= 0) return [] ; // nothing to invoke....
-
+    
+    var idx;
+    
     // collect the arguments
     var args = [] ;
     var alen = arguments.length ;
     if (alen > 1) {
-      for(var idx=1;idx<alen;idx++) args.push(arguments[idx]) ;
+      for(idx=1;idx<alen;idx++) args.push(arguments[idx]) ;
     }
     
     // call invoke
     var ret = [] ;
     var last = null ;
     var context = SC.Enumerator._popContext();
-    for(var idx=0;idx<len;idx++) {
+    for(idx=0;idx<len;idx++) {
       var next = this.nextObject(idx, last, context) ;
-      var method = (next) ? next[methodName] : null ;
+      var method = next ? next[methodName] : null ;
       if (method) ret[idx] = method.apply(next, args) ;
       last = next ;
     }
@@ -652,23 +719,25 @@ SC.Enumerable = {
     @returns {Array} return values from calling invoke.
   */
   invokeWhile: function(targetValue, methodName) {
-    var len = (this.get) ? this.get('length') : this.length ;
+    var len = this.get ? this.get('length') : this.length ;
     if (len <= 0) return null; // nothing to invoke....
 
+    var idx;
+
     // collect the arguments
     var args = [] ;
     var alen = arguments.length ;
     if (alen > 2) {
-      for(var idx=2;idx<alen;idx++) args.push(arguments[idx]) ;
+      for(idx=2;idx<alen;idx++) args.push(arguments[idx]) ;
     }
     
     // call invoke
     var ret = targetValue ;
     var last = null ;
     var context = SC.Enumerator._popContext();
-    for(var idx=0;(ret === targetValue) && (idx<len);idx++) {
+    for(idx=0;(ret === targetValue) && (idx<len);idx++) {
       var next = this.nextObject(idx, last, context) ;
-      var method = (next) ? next[methodName] : null ;
+      var method = next ? next[methodName] : null ;
       if (method) ret = method.apply(next, args) ;
       last = next ;
     }
@@ -685,22 +754,11 @@ SC.Enumerable = {
     @returns {Array} the enumerable as an array.
   */
   toArray: function() {
-    var len = (this.get) ? this.get('length') : this.length ;
-    if (len <= 0) return [] ; // nothing to invoke....
-    
-    // call invoke
-    var ret = [] ;
-    var last = null ;
-    var context = SC.Enumerator._popContext();
-    for(var idx=0;idx<len;idx++) {
-      var next = this.nextObject(idx, last, context) ;
-      ret.push(next) ;
-      last = next ;
-    }
-    last = null ;
-    context = SC.Enumerator._pushContext(context);
+    var ret = [];
+    this.forEach(function(o) { ret.push(o); }, this);
     return ret ;
   }        
+  
 } ;
 
 // Build in a separate function to avoid unintential leaks through closures...
@@ -708,7 +766,7 @@ SC._buildReducerFor = function(reducerKey, reducerProperty) {
   return function(key, value) {
     var reducer = this[reducerKey] ;
     if (SC.typeOf(reducer) !== SC.T_FUNCTION) {
-      return (this.unknownProperty) ? this.unknownProperty(key, value) : null;
+      return this.unknownProperty ? this.unknownProperty(key, value) : null;
     } else {
       // Invoke the reduce method defined in enumerable instead of using the
       // one implemented in the receiver.  The receiver might be a native 
@@ -784,7 +842,7 @@ SC.Reducers = {
     
     var reducerKey = matches[1]; // = 'max' if key = '@max(balance)'
     var reducerProperty = matches[3] ; // = 'balance' if key = '@max(balance)'
-    var reducerKey = "reduce" + reducerKey.slice(0,1).toUpperCase() + reducerKey.slice(1);
+    reducerKey = "reduce" + reducerKey.slice(0,1).toUpperCase() + reducerKey.slice(1);
     var reducer = this[reducerKey] ;
 
     // if there is no reduce function defined for this key, then we can't 
@@ -820,9 +878,9 @@ SC.Reducers = {
   */
   reduceMax: function(previousValue, item, index, e, reducerProperty) {
     if (reducerProperty && item) {
-      item = (item.get) ? item.get(reducerProperty) : item[reducerProperty];
+      item = item.get ? item.get(reducerProperty) : item[reducerProperty];
     }
-    if (previousValue == null) return item ;
+    if (previousValue === null) return item ;
     return (item > previousValue) ? item : previousValue ;
   },
 
@@ -836,14 +894,14 @@ SC.Reducers = {
     var previousValue = previousItem, itemValue = item ;
     if (reducerProperty) {
       if (item) {
-        itemValue = (item.get) ? item.get(reducerProperty) : item[reducerProperty] ;
+        itemValue = item.get ? item.get(reducerProperty) : item[reducerProperty] ;
       }
       
       if (previousItem) {
-        previousItemValue = (previousItem.get) ? previousItem.get(reducerProperty) : previousItem[reducerProperty] ;
+        previousValue = previousItem.get ? previousItem.get(reducerProperty) : previousItem[reducerProperty] ;
       }
     }
-    if (previousValue == null) return item ;
+    if (previousValue === null) return item ;
     return (itemValue > previousValue) ? item : previousItem ;
   },
 
@@ -852,9 +910,9 @@ SC.Reducers = {
   */
   reduceMin: function(previousValue, item, index, e, reducerProperty) {
     if (reducerProperty && item) {
-      item = (item.get) ? item.get(reducerProperty) : item[reducerProperty];
+      item = item.get ? item.get(reducerProperty) : item[reducerProperty];
     }
-    if (previousValue == null) return item ;
+    if (previousValue === null) return item ;
     return (item < previousValue) ? item : previousValue ;
   },
 
@@ -868,14 +926,14 @@ SC.Reducers = {
     var previousValue = previousItem, itemValue = item ;
     if (reducerProperty) {
       if (item) {
-        itemValue = (item.get) ? item.get(reducerProperty) : item[reducerProperty] ;
+        itemValue = item.get ? item.get(reducerProperty) : item[reducerProperty] ;
       }
       
       if (previousItem) {
-        previousItemValue = (previousItem.get) ? previousItem.get(reducerProperty) : previousItem[reducerProperty] ;
+        previousValue = previousItem.get ? previousItem.get(reducerProperty) : previousItem[reducerProperty] ;
       }
     }
-    if (previousValue == null) return item ;
+    if (previousValue === null) return item ;
     return (itemValue < previousValue) ? item : previousItem ;
   },
 
@@ -884,10 +942,10 @@ SC.Reducers = {
   */
   reduceAverage: function(previousValue, item, index, e, reducerProperty) {
     if (reducerProperty && item) {
-      item = (item.get) ? item.get(reducerProperty) : item[reducerProperty];
+      item = item.get ? item.get(reducerProperty) : item[reducerProperty];
     }
     var ret = (previousValue || 0) + item ;
-    var len = (e.get) ? e.get('length') : e.length;
+    var len = e.get ? e.get('length') : e.length;
     if (index >= len-1) ret = ret / len; //avg after last item.
     return ret ; 
   },
@@ -897,15 +955,16 @@ SC.Reducers = {
   */
   reduceSum: function(previousValue, item, index, e, reducerProperty) {
     if (reducerProperty && item) {
-      item = (item.get) ? item.get(reducerProperty) : item[reducerProperty];
+      item = item.get ? item.get(reducerProperty) : item[reducerProperty];
     }
-    return (previousValue == null) ? item : previousValue + item ;
+    return (previousValue === null) ? item : previousValue + item ;
   }
 } ;
 
 // Apply reducers...
 SC.mixin(SC.Enumerable, SC.Reducers) ;
 SC.mixin(Array.prototype, SC.Reducers) ;
+Array.prototype.isEnumerable = YES ;
 
 // ......................................................
 // ARRAY SUPPORT
@@ -924,14 +983,16 @@ SC.mixin(Array.prototype, SC.Reducers) ;
     // possible.
     nextObject: SC.Enumerable.nextObject,
     enumerator: SC.Enumerable.enumerator,
-
+    firstObject: SC.Enumerable.firstObject,
+    sortProperty: SC.Enumerable.sortProperty,
+    
     // see above...
     mapProperty: function(key) {
       var len = this.length ;
       var ret  = [];
       for(var idx=0;idx<len;idx++) {
         var next = this[idx] ;
-        ret[idx] = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+        ret[idx] = next ? (next.get ? next.get(key) : next[key]) : null;
       }
       return ret ;
     },
@@ -941,7 +1002,7 @@ SC.mixin(Array.prototype, SC.Reducers) ;
       var ret  = [];
       for(var idx=0;idx<len;idx++) {
         var next = this[idx] ;
-        var cur = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+        var cur = next ? (next.get ? next.get(key) : next[key]) : null;
         var matched = (value === undefined) ? !!cur : SC.isEqual(cur, value);
         if (matched) ret.push(next) ;
       }
@@ -966,7 +1027,7 @@ SC.mixin(Array.prototype, SC.Reducers) ;
       var len = this.length ;
       var next, cur, found=NO, ret=null;
       for(var idx=0;idx<len && !found;idx++) {
-        cur = (next=this[idx]) ? ((next.get) ? next.get(key): next[key]):null;
+        cur = (next=this[idx]) ? (next.get ? next.get(key): next[key]):null;
         found = (value === undefined) ? !!cur : SC.isEqual(cur, value);
         if (found) ret = next ;
       }
@@ -979,7 +1040,7 @@ SC.mixin(Array.prototype, SC.Reducers) ;
       var ret  = YES;
       for(var idx=0;ret && (idx<len);idx++) {
         var next = this[idx] ;
-        var cur = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+        var cur = next ? (next.get ? next.get(key) : next[key]) : null;
         ret = (value === undefined) ? !!cur : SC.isEqual(cur, value);
       }
       return ret ;
@@ -990,7 +1051,7 @@ SC.mixin(Array.prototype, SC.Reducers) ;
       var ret  = NO;
       for(var idx=0; !ret && (idx<len); idx++) {
         var next = this[idx] ;
-        var cur = (next) ? ((next.get) ? next.get(key) : next[key]) : null;
+        var cur = next ? (next.get ? next.get(key) : next[key]) : null;
         ret = (value === undefined) ? !!cur : SC.isEqual(cur, value);
       }
       return ret ;  // return the invert
@@ -1000,18 +1061,20 @@ SC.mixin(Array.prototype, SC.Reducers) ;
       var len = this.length ;
       if (len <= 0) return [] ; // nothing to invoke....
 
+      var idx;
+
       // collect the arguments
       var args = [] ;
       var alen = arguments.length ;
       if (alen > 1) {
-        for(var idx=1;idx<alen;idx++) args.push(arguments[idx]) ;
+        for(idx=1;idx<alen;idx++) args.push(arguments[idx]) ;
       }
 
       // call invoke
       var ret = [] ;
-      for(var idx=0;idx<len;idx++) {
+      for(idx=0;idx<len;idx++) {
         var next = this[idx] ;
-        var method = (next) ? next[methodName] : null ;
+        var method = next ? next[methodName] : null ;
         if (method) ret[idx] = method.apply(next, args) ;
       }
       return ret ;
@@ -1021,18 +1084,20 @@ SC.mixin(Array.prototype, SC.Reducers) ;
       var len = this.length ;
       if (len <= 0) return null ; // nothing to invoke....
 
+      var idx;
+
       // collect the arguments
       var args = [] ;
       var alen = arguments.length ;
       if (alen > 2) {
-        for(var idx=2;idx<alen;idx++) args.push(arguments[idx]) ;
+        for(idx=2;idx<alen;idx++) args.push(arguments[idx]) ;
       }
 
       // call invoke
       var ret = targetValue ;
-      for(var idx=0;(ret === targetValue) && (idx<len);idx++) {
+      for(idx=0;(ret === targetValue) && (idx<len);idx++) {
         var next = this[idx] ;
-        var method = (next) ? next[methodName] : null ;
+        var method = next ? next[methodName] : null ;
         if (method) ret = method.apply(next, args) ;
       }
       return ret ;
@@ -1056,7 +1121,7 @@ SC.mixin(Array.prototype, SC.Reducers) ;
       var len = this.length ;
       for(var idx=0;idx<len;idx++) {
         var obj = this[idx];
-        ret[idx] = (obj) ? ((obj.get) ? obj.get(key) : obj[key]) : null;
+        ret[idx] = obj ? (obj.get ? obj.get(key) : obj[key]) : null;
       }
       return ret ;
     },
@@ -1158,7 +1223,7 @@ SC.mixin(Array.prototype, SC.Reducers) ;
         // while ret is still undefined, just set the first value we get as 
         // ret. this is not the ideal behavior actually but it matches the 
         // FireFox implementation... :(
-        if (next != null) {
+        if (next !== null) {
           if (ret === undefined) {
             ret = next ;
           } else {