sproutcore 1.6.0.beta.3-java → 1.6.0-java

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/template/collection.js

@@ -247,3 +247,138 @@ test("should re-render when the content object changes", function() {
   equals(view.$('li:eq(0)').text(), "ramalamadingdong");
 
 });
+
+test("should allow changes to content object before layer is created", function() {
+  var view = SC.TemplateCollectionView.create({
+    content: null
+  });
+
+  view.set('content', []);
+  view.set('content', [1, 2, 3]);
+  view.set('content', [1, 2]);
+
+  view.createLayer();
+  ok(view.$('li').length);
+});
+
+test("should allow changing content property to be null", function() {
+  var view = SC.TemplateCollectionView.create({
+    content: [1, 2, 3]
+  });
+
+  view.createLayer();
+  equals(view.$('li').length, 3, "precond - creates three elements");
+
+  view.set('content', null);
+  equals(view.$('li').length, 0, "should not create any li elements");
+});
+
+test("collection view within a collection view with default content should render content once", function() {
+  TemplateTests.InnerCollectionView = SC.TemplateCollectionView.extend();
+
+  TemplateTests.OuterItemView = SC.TemplateView.extend({
+    template: SC.Handlebars.compile('{{#collection "TemplateTests.InnerCollectionView" content=content.things}} {{content}} {{/collection}}')
+  });
+
+  TemplateTests.OuterCollectionView = SC.TemplateCollectionView.extend({
+    content: [
+      SC.Object.create({things: ['1', '2', '3']}),
+      SC.Object.create({things: ['4', '5']}),
+      SC.Object.create({things: ['6']})
+    ],
+    itemView: TemplateTests.OuterItemView
+  });
+
+  var view = SC.TemplateView.create({
+    template: SC.Handlebars.compile('{{collection "TemplateTests.OuterCollectionView"}}')
+  });
+
+  view.createLayer();
+
+  equals(view.$('ul ul:eq(0) li').length, 3, 'first nested collection view should have 3 list items');
+  equals(view.$('ul ul:eq(1) li').length, 2, 'second nested collection view should have 2 list items');
+  equals(view.$('ul ul:eq(2) li').length, 1, 'third nested collection view should have 1 list items');
+});
+
+test("collection view within a collection view should have the right childViews", function() {
+  TemplateTests.InnerCollectionView = SC.TemplateCollectionView.extend();
+
+  TemplateTests.OuterItemView = SC.TemplateView.extend({
+    template: SC.Handlebars.compile('{{#collection "TemplateTests.InnerCollectionView" content=content.things}} {{content}} {{/collection}}')
+  });
+
+  TemplateTests.OuterCollectionView = SC.TemplateCollectionView.extend({
+    content: [
+      SC.Object.create({things: ['1', '2', '3']}),
+      SC.Object.create({things: ['4', '5']}),
+      SC.Object.create({things: ['6']})
+    ],
+    itemView: TemplateTests.OuterItemView
+  });
+
+  var view = SC.TemplateView.create({
+    template: SC.Handlebars.compile('{{collection "TemplateTests.OuterCollectionView"}}')
+  });
+
+  view.createLayer();
+
+  var outer       = view.childViews[0];
+  var firstInner  = outer.childViews[0].childViews[0];
+  var secondInner = outer.childViews[1].childViews[0];
+  var thirdInner  = outer.childViews[2].childViews[0];
+
+  ok(outer.kindOf(TemplateTests.OuterCollectionView), 'first child view should be instance of outer collection view');
+  ok(firstInner.kindOf(TemplateTests.InnerCollectionView), 'first child view of outer should be instance of inner');
+  ok(secondInner.kindOf(TemplateTests.InnerCollectionView), 'second child view of outer should be instance of inner');
+  ok(thirdInner.kindOf(TemplateTests.InnerCollectionView), 'third child view of outer should be instance of inner');
+});
+
+test("should render inverse template when its present and there is no content", function() {
+  TemplateTests.CollectionTestView = SC.TemplateCollectionView.create({
+    content: [],
+    inverseTemplate: SC.Handlebars.compile('<h1>inverse<h1>')
+  });
+
+  var view = SC.TemplateView.create({
+    template: SC.Handlebars.compile('{{collection "TemplateTests.CollectionTestView"}}')
+  });
+
+  view.createLayer();
+
+  equals(view.$('h1').text(), 'inverse', 'collection view with no content and inverse template should render inverse template')
+});
+
+test("should render inverse template name when its present and there is no content", function() {
+  TemplateTests.CollectionTestView = SC.TemplateCollectionView.create({
+    content: [],
+    inverseTemplateName: 'inverse_template',
+
+    templates: SC.Object.create({
+      inverse_template: function(dataSource) {
+        return "<h1>inverse template from file</h1>";
+      }
+    })
+  });
+
+  var view = SC.TemplateView.create({
+    template: SC.Handlebars.compile('{{collection "TemplateTests.CollectionTestView"}}')
+  });
+
+  view.createLayer();
+
+  equals(view.$('h1').text(), 'inverse template from file', 'collection view with no content and inverse template name should render template')
+});
+
+test("#collection helper should allow relative paths for the collection view class", function() {
+  var view = SC.TemplateView.create({
+    template: SC.Handlebars.compile('{{#collection "myCollectionView"}}{{content}}{{/collection}}'),
+    myCollectionView: SC.TemplateCollectionView.create({
+      content: ['foo', 'bar', 'baz']
+    })
+  });
+
+  SC.run(function() { view.createLayer(); });
+
+  equals(view.$('li').length, 3, '#collection should find relative collection view path');
+});
+

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/template/handlebars.js

@@ -1,9 +1,10 @@
 // ==========================================================================
 // Project:   SproutCore - JavaScript Application Framework
 // Copyright: ©2006-2011 Strobe Inc. and contributors.
-//            ©2008-2011 Apple Inc. All rights reserved.
 // License:   Licensed under MIT license (see license.js)
 // ==========================================================================
+
+/*globals TemplateTests module */
 /**
   This module specifically tests integration with Handlebars and SproutCore-specific
   Handlebars extensions.
@@ -293,23 +294,29 @@ test("Handlebars templates update properties if a content object changes", funct
   equals(view.$('h2').text(), "brown coffee", "precond - renders color correctly");
   equals(view.$('#price').text(), '$4', "precond - renders price correctly");
 
-  view.set('coffee', SC.Object.create({
-    color: "mauve",
-    price: "$4.50"
-  }));
+  SC.run(function() {
+    view.set('coffee', SC.Object.create({
+      color: "mauve",
+      price: "$4.50"
+    }));
+  });
 
   equals(view.$('h2').text(), "mauve coffee", "should update name field when content changes");
   equals(view.$('#price').text(), "$4.50", "should update price field when content changes");
 
-  view.set('coffee', SC.Object.create({
-    color: "mauve",
-    price: "$5.50"
-  }));
+  SC.run(function() {
+    view.set('coffee', SC.Object.create({
+      color: "mauve",
+      price: "$5.50"
+    }));
+  });
 
   equals(view.$('h2').text(), "mauve coffee", "should update name field when content changes");
   equals(view.$('#price').text(), "$5.50", "should update price field when content changes");
 
-  view.setPath('coffee.price', "$5");
+  SC.run(function() {
+    view.setPath('coffee.price', "$5");
+  });
 
   equals(view.$('#price').text(), "$5", "should update price field when price property is changed");
 });
@@ -334,11 +341,11 @@ test("Template updates correctly if a path is passed to the bind helper", functi
 
   equals(view.$('h1').text(), "$4", "precond - renders price");
 
-  view.setPath('coffee.price', "$5");
+  SC.run(function() { view.setPath('coffee.price', "$5"); });
 
   equals(view.$('h1').text(), "$5", "updates when property changes");
 
-  view.set('coffee', { price: "$6" });
+  SC.run(function() { view.set('coffee', { price: "$6" }); });
   equals(view.$('h1').text(), "$6", "updates when parent property changes");
 });
 
@@ -354,7 +361,7 @@ test("Template updates correctly if a path is passed to the bind helper and the
     price: "$4"
   });
 
-  controller.set('content', realObject);
+  SC.run(function() { controller.set('content', realObject); });
 
   var view = SC.TemplateView.create({
     templateName: 'menu',
@@ -367,7 +374,7 @@ test("Template updates correctly if a path is passed to the bind helper and the
 
   equals(view.$('h1').text(), "$4", "precond - renders price");
 
-  realObject.set('price', "$5");
+  SC.run(function() { realObject.set('price', "$5"); });
 
   equals(view.$('h1').text(), "$5", "updates when property is set on real object");
 
@@ -891,7 +898,7 @@ test("should be able to bind class attribute with {{bindAttr}}", function() {
 });
 
 test("should be able to bind boolean element attributes using {{bindAttr}}", function() {
-  var template = SC.Handlebars.compile('<input type="check" {{bindAttr disabled="content.isDisabled" checked="content.isChecked"}} />');
+  var template = SC.Handlebars.compile('<input type="checkbox" {{bindAttr disabled="content.isDisabled" checked="content.isChecked"}} />');
   var content = SC.Object.create({
     isDisabled: false,
     isChecked: true
@@ -907,8 +914,10 @@ test("should be able to bind boolean element attributes using {{bindAttr}}", fun
   ok(!view.$('input').attr('disabled'), 'attribute does not exist upon initial render');
   ok(view.$('input').attr('checked'), 'attribute is present upon initial render');
 
-  content.set('isDisabled', true);
-  content.set('isChecked', false);
+  SC.run(function() {
+    content.set('isDisabled', true);
+    content.set('isChecked', false);
+  });
 
   ok(view.$('input').attr('disabled'), 'attribute exists after update');
   ok(!view.$('input').attr('checked'), 'attribute is not present after update');
@@ -931,7 +940,9 @@ test("should be able to add multiple classes using {{bindAttr class}}", function
   ok(view.$('div').hasClass('is-awesome-sauce'), "dasherizes first property and sets classname");
   ok(view.$('div').hasClass('is-also-cool'), "dasherizes second property and sets classname");
 
-  content.set('isAwesomeSauce', false);
+  SC.run(function() {
+    content.set('isAwesomeSauce', false);
+  });
 
   ok(!view.$('div').hasClass('is-awesome-sauce'), "removes dasherized class when property is set to false");
 });

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/clippingFrame.js

@@ -115,3 +115,14 @@ test("notifies receiver and each child if parent clipping frame changes", functi
   // number.
   equals(callCount, 2, 'should invoke observer on child and nested child');
 });
+
+test("returns 0, 0, W, H if parentView has no clippingFrame", function(){
+  a.clippingFrame = null;
+
+  var targetFrame = aa.get('clippingFrame');
+
+  equals(targetFrame.x, 0, "x should be 0");
+  equals(targetFrame.y, 0, "y should be 0");
+  equals(targetFrame.width, 40, "width should be 40");
+  equals(targetFrame.height, 40, "height should be 40");
+});

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/didAppendToDocument.js

@@ -21,6 +21,7 @@ module("SC.View#didAppendToDocument", {
             context.push('new string');
           },
           didAppendToDocument: function(){
+            ok(document.getElementById(this.get('layerId')), "view layer should exist");
             counter++;
           }
         })
@@ -30,6 +31,7 @@ module("SC.View#didAppendToDocument", {
 
     additionalView = SC.View.create({
       didAppendToDocument: function(){
+        ok(document.getElementById(this.get('layerId')), "additionalView layer should exist");
         counter++;
       }
     });
@@ -59,11 +61,12 @@ test("Check that didAppendToDocument gets called at the right moment", function(
   equals(counter, 3, "");
 });
 
+
 // Test for bug: when a childView has a non-fixed layout and we request its frame before the parentView has
 // a layer and the parentView uses static layout, then the frame returned will be {x: 0, y:0, width: 0, height: 0}
 // and any further requests for the childView's frame will not return a new value unless the parentViewDidChange
 // or parentViewDidResize.  A weird case, but we prevent it from failing anyhow.
-test("Check that childView is updated if we have static layout and they don't have a fixed layout", function() {
+test("Check that childView is updated if the pane has a static layout and view doesn't have a fixed layout", function() {
   var childFrame,
       wrongFrame = {x:0, y:0, width: 0, height: 0},
       correctFrame;
@@ -80,4 +83,17 @@ test("Check that childView is updated if we have static layout and they don't ha
   correctFrame = pane.get('frame');
 
   same(childFrame, correctFrame, 'getting frame after layer exists on non-fixed layout childView should return actual frame');
-});
+});
+
+
+test("Check that childView is updated if it has a static layout", function() {
+  var childFrame,
+      wrongFrame = {x:0, y:0, width: 0, height: 0},
+      correctFrame;
+
+  view.set('useStaticLayout', YES);
+
+  equals(counter, 0, "precond - has not been called yet");
+  pane.append(); // make sure there is a layer...
+  equals(counter, 1, "didAppendToDocument was called once");
+});

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/insertBefore.js

@@ -80,7 +80,7 @@ test("invokes willAddChild() on receiver if defined before adding child" ,functi
 
 	  
   parent.insertBefore(child, otherChild);
-  ok(callCount, 1, 'invoked');
+  equals(callCount, 1, 'invoked');
 });
 
 test("invokes willAddToParent() on child view if defined before adding child" ,function() {
@@ -102,7 +102,7 @@ test("invokes willAddToParent() on child view if defined before adding child" ,f
 
 	  
   parent.insertBefore(child, otherChild);
-  ok(callCount, 1, 'invoked');
+  equals(callCount, 1, 'invoked');
 });
 
 test("invokes didAddChild() on receiver if defined after adding child" ,function() {
@@ -122,9 +122,11 @@ test("invokes didAddChild() on receiver if defined after adding child" ,function
   	callCount++;
   };
 
-	  
+  SC.RunLoop.begin();
   parent.insertBefore(child, otherChild);
-  ok(callCount, 1, 'invoked');
+  SC.RunLoop.end();
+
+  equals(callCount, 1, 'invoked');
 });
 
 test("invokes didAddToParent() on child view if defined after adding child" ,function() {
@@ -144,9 +146,11 @@ test("invokes didAddToParent() on child view if defined after adding child" ,fun
   	callCount++;
   };
 
-	  
+  SC.RunLoop.begin();
   parent.insertBefore(child, otherChild);
-  ok(callCount, 1, 'invoked');
+  SC.RunLoop.end();
+
+  equals(callCount, 1, 'invoked');
 });
 
 test("invokes parentViewDidChange() on child view.  this is used by the view internals to update layer loc", function() {

data/lib/frameworks/sproutcore/frameworks/core_foundation/tests/views/view/keyboard.js

@@ -4,7 +4,18 @@
 //            ©2008-2011 Apple Inc. All rights reserved.
 // License:   Licensed under MIT license (see license.js)
 // ==========================================================================
-module("SC.View - Keyboard support");
+
+var originalTabbing;
+
+module("SC.View - Keyboard support with Tabbing Only Inside Document", {
+  setup: function(){
+    originalTabbing = SC.TABBING_ONLY_INSIDE_DOCUMENT;
+    SC.TABBING_ONLY_INSIDE_DOCUMENT = YES;
+  },
+  teardown: function(){
+    SC.TABBING_ONLY_INSIDE_DOCUMENT = originalTabbing;
+  }
+});
 
 test("Views only attempt to call performKeyEquivalent on child views that support it", function() {
   var performKeyEquivalentCalled = 0;
@@ -26,3 +37,405 @@ test("Views only attempt to call performKeyEquivalent on child views that suppor
   
   ok(performKeyEquivalentCalled > 0, "performKeyEquivalent is called on the view that supports it");
 });
+
+/**
+  nextValidKeyView tests
+*/
+
+test("nextValidKeyView is receiver if it is the only view that acceptsFirstResponder", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: SC.View,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: SC.View,
+
+      view6: SC.View
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  equals(pane.view1.view4.get('nextValidKeyView'), pane.view1.view4, "nextValidKeyView is receiver");
+});
+
+test("nextValidKeyView is null if no views have acceptsFirstResponder === YES", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: SC.View,
+
+      view4: SC.View
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: SC.View,
+
+      view6: SC.View
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  ok(SC.none(pane.view1.view4.get('nextValidKeyView')), "nextValidKeyView is null");
+});
+
+test("firstKeyView and nextKeyView of parents are respected", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2', 'view7'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: testView,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: testView,
+
+      view6: testView
+    }),
+
+    view7: SC.View.extend({
+      childViews: ['view8', 'view9'],
+
+      view8: testView,
+
+      view9: testView
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  equals(pane.view2.view6.get('nextValidKeyView'), pane.view7.view8, "order is correct when first and next not set");
+
+  pane.set('firstKeyView', pane.view2);
+  pane.view2.set('nextKeyView', pane.view1);
+  pane.view1.set('nextKeyView', pane.view7);
+
+  equals(pane.view2.view6.get('nextValidKeyView'), pane.view1.view3, "order is respected when first and next are set");
+});
+
+test("nextValidKeyView is chosen correctly when nextKeyView is not a sibling", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: SC.View,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: testView,
+
+      view6: SC.View
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  pane.view1.view4.set('nextKeyView', pane.view2.view5);
+  pane.view2.view5.set('nextKeyView', pane.view1.view4);
+
+  equals(pane.view1.view4.get('nextValidKeyView'), pane.view2.view5, "nextValidKeyView is correct");
+  equals(pane.view2.view5.get('nextValidKeyView'), pane.view1.view4, "nextValidKeyView is correct");
+});
+
+test("nextValidKeyView is chosen correctly when child of parent's previous sibling has nextKeyView set", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: testView,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: testView,
+
+      view6: testView
+    })
+  });
+
+  pane.view1.view3.set('nextKeyView', pane.view1.view4);
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  equals(pane.view2.view5.get('nextValidKeyView'), pane.view2.view6, "nextValidKeyView chosen is next sibling");
+});
+
+test("nextValidKeyView checks for acceptsFirstResponder", function() {
+  var pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      acceptsFirstResponder: YES
+    }),
+
+    view2: SC.View.extend({
+      acceptsFirstResponder: NO
+    })
+  });
+
+  pane.view1.set('nextKeyView', pane.view2);
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  ok(pane.view1.get('nextValidKeyView') !== pane.view2, "nextValidKeyView is not nextKeyView because nextKeyView acceptsFirstResponder === NO");
+});
+
+test("nextValidKeyView prioritizes parent's lastKeyView even if nextKeyView is set", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      lastKeyView: function() {
+        return this.view3;
+      }.property(),
+
+      view3: testView,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: testView,
+
+      view6: testView
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  equals(pane.view1.view3.get('nextValidKeyView'), pane.view2.view5, "lastKeyView was respected; views after lastKeyView were skipped");
+});
+
+/**
+  previousValidKeyView tests
+*/
+
+test("previousValidKeyView is receiver if it is the only view that acceptsFirstResponder", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: SC.View,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: SC.View,
+
+      view6: SC.View
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  equals(pane.view1.view4.get('previousValidKeyView'), pane.view1.view4, "previousValidKeyView is receiver");
+});
+
+test("previousValidKeyView is null if no views have acceptsFirstResponder === YES", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: SC.View,
+
+      view4: SC.View
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: SC.View,
+
+      view6: SC.View
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  ok(SC.none(pane.view1.view4.get('previousValidKeyView')), "previousValidKeyView is null");
+});
+
+test("lastKeyView and previousKeyView of parents are respected", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2', 'view7'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: testView,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: testView,
+
+      view6: testView
+    }),
+
+    view7: SC.View.extend({
+      childViews: ['view8', 'view9'],
+
+      view8: testView,
+
+      view9: testView
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  equals(pane.view2.view5.get('previousValidKeyView'), pane.view1.view4, "order is correct when last and previous not set");
+
+  pane.set('lastKeyView', pane.view2);
+  pane.view2.set('previousKeyView', pane.view7);
+  pane.view1.set('previousKeyView', pane.view1);
+
+  equals(pane.view2.view5.get('previousValidKeyView'), pane.view7.view9, "order is respected when last and previous are set");
+});
+
+test("previousValidKeyView is chosen correctly when previousKeyView is not a sibling", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: SC.View,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      view5: testView,
+
+      view6: SC.View
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  pane.view1.view4.set('previousKeyView', pane.view2.view5);
+  pane.view2.view5.set('previousKeyView', pane.view1.view4);
+
+  equals(pane.view1.view4.get('previousValidKeyView'), pane.view2.view5, "previousValidKeyView is correct");
+  equals(pane.view2.view5.get('previousValidKeyView'), pane.view1.view4, "previousValidKeyView is correct");
+});
+
+test("previousValidKeyView prioritizes parent's firstKeyView even if previousKeyView is set", function() {
+  var testView = SC.View.extend({acceptsFirstResponder: YES}),
+  pane = SC.Pane.create({
+    childViews: ['view1', 'view2'],
+
+    view1: SC.View.extend({
+      childViews: ['view3', 'view4'],
+
+      view3: testView,
+
+      view4: testView
+    }),
+
+    view2: SC.View.extend({
+      childViews: ['view5', 'view6'],
+
+      firstKeyView: function() {
+        return this.view6;
+      }.property(),
+
+      view5: testView,
+
+      view6: testView
+    })
+  });
+
+  // fake the pane being attached
+  pane.set('isPaneAttached', YES);
+  pane.recomputeIsVisibleInWindow();
+
+  equals(pane.view2.view6.get('previousValidKeyView'), pane.view1.view4, "firstKeyView was respected; views before firstKeyView were skipped");
+});
+
+
+module("SC.View - Keyboard support with Tabbing Outside of Document");
+
+test("forward tab with no next responder moves out of document");
+
+test("backwards tab with no previous responder moves out of document");