sproutcore 1.4.2 → 1.4.3

data/lib/frameworks/sproutcore/frameworks/desktop/tests/views/radio/ui.js

@@ -10,7 +10,8 @@
 htmlbody('<style> .sc-static-layout { border: 1px red dotted; } </style>');
 
 var itemList = [{ title: "Red", value: "red", enabled: YES }, { title: "Green", value: "green" }, { title: "Blue", value: "blue" }],
-itemList2 = [{ title: "Cyan", value: "cyan", enabled: YES }, { title: "Magenta", value: "magenta" }, { title: "Yellow", value: "yellow" },{ title: "blacK", value: "black"}];
+itemList2 = [{ title: "Cyan", value: "cyan", enabled: YES }, { title: "Magenta", value: "magenta" }, { title: "Yellow", value: "yellow" },{ title: "blacK", value: "black"}],
+itemList3 = [{ title: "Red", value: "red", enabled: YES, width: 30 }, { title: "Green", value: "green", width: 50 }, { title: "Blue", value: "blue", width: 40 }];
 
 var pane = SC.ControlTestPane.design()
   .add("basic", SC.RadioView, {
@@ -56,6 +57,16 @@ var pane = SC.ControlTestPane.design()
     items: 'Yes No'.w(),
     // LAYOUT_VERTICAL is default
     layoutDirection: SC.LAYOUT_HORIZONTAL
+  })
+  
+  .add("horizontal widths", SC.RadioView, {
+    value: "",
+    isEnabled: YES,
+    items: itemList3,
+    layoutDirection: SC.LAYOUT_HORIZONTAL,
+    itemTitleKey: 'title',
+    itemValueKey: 'value',
+    itemWidthKey: 'width'
   });
 
 pane.show(); // add a test to show the test pane
@@ -230,3 +241,13 @@ test("enabled first", function() {
   });
 });
 
+test("item widths", function() {
+  var radioButtons = pane.view('horizontal widths').$('.sc-radio-button'),
+      widths = [30, 50, 40],
+      idx = 0, radio;
+  
+  radioButtons.forEach(function(elem) {
+    equals(SC.$(elem).width(), widths[idx], 'radio button %@ should width specified by itemWidthKey'.fmt(idx, widths[idx]));
+    idx++;
+  });
+});

data/lib/frameworks/sproutcore/frameworks/desktop/views/collection.js

@@ -905,7 +905,7 @@ SC.CollectionView = SC.View.extend(
         // to reuse it.
         // (Charles Jolley personally guarantees this code)
         layer = existing.get('layer');
-        layer.parentNode.removeChild(layer);
+        if (layer && layer.parentNode) layer.parentNode.removeChild(layer);
         
         containerView.removeChild(existing);
       }

data/lib/frameworks/sproutcore/frameworks/desktop/views/list.js

@@ -217,7 +217,7 @@ SC.ListView = SC.CollectionView.extend(
       // prefill the cache with custom rows.
       cache = this._sclv_offsetCache;
       if (!cache) {
-        cache = this._sclv_offsetCache = [];
+        cache = [];
         delta = max = 0 ;
         custom.forEach(function(idx) {
           delta += this.rowHeightForContentIndex(idx)-rowHeight;
@@ -225,6 +225,8 @@ SC.ListView = SC.CollectionView.extend(
           max = idx ;
         }, this);
         this._sclv_max = max+1;
+        // moved down so that the cache is not marked as initialized until it actually is
+        this._sclv_offsetCache = cache;
       }
       
       // now just get the delta for the last custom row before the current 
@@ -259,11 +261,13 @@ SC.ListView = SC.CollectionView.extend(
     if (del.customRowHeightIndexes && (indexes=del.get('customRowHeightIndexes'))) {
       cache = this._sclv_heightCache ;
       if (!cache) {
-        cache = this._sclv_heightCache = [];
+        cache = [];
         content = this.get('content');
         indexes.forEach(function(idx) {
           cache[idx] = del.contentIndexRowHeight(this, content, idx);
         }, this);
+        // moved down so that the cache is not marked as initialized until it actually is
+        this._sclv_heightCache = cache;
       }
       
       ret = cache[idx];

data/lib/frameworks/sproutcore/frameworks/desktop/views/list_item.js

@@ -500,7 +500,7 @@ SC.ListItemView = SC.View.extend(
   */
   _isInsideRightIcon: function(evt) {
     var del = this.displayDelegate ;
-    var rightIconKey = this.getDelegateProperty('hasContentRightIcon', del) ;
+    var rightIconKey = this.getDelegateProperty('hasContentRightIcon', del) || !SC.none(this.rightIcon);
     return rightIconKey && this._isInsideElementWithClassName('right-icon', evt);
   },
   

data/lib/frameworks/sproutcore/frameworks/desktop/views/radio.js

@@ -89,6 +89,17 @@ SC.RadioView = SC.View.extend(SC.Control,
     the title with this itemTitleKey property.
   */
   itemTitleKey: null,
+  
+  /**
+    If items property is a hash, specify which property will function as
+    the item width with this itemWidthKey property. This is only used when
+    layoutDirection is set to SC.LAYOUT_HORIONZTAL and can be used to override
+    the default value provided by the framework or theme CSS.
+    
+    @property {String}
+    @default null
+  */
+  itemWidthKey: null,
 
   /** 
     If items property is a hash, specify which property will function as
@@ -142,9 +153,12 @@ SC.RadioView = SC.View.extend(SC.Control,
   displayProperties: ['value', '_displayItems'],
 
   render: function(context, firstTime) {
-    var item, idx, icon, name, itemsLength, url, className, disabled, sel, labelText, selectionState, selectionStateClassNames, items = this.get('_displayItems'),
-    value = this.get('value'),
-    isArray = SC.isArray(value);
+    var items = this.get('_displayItems'),
+        value = this.get('value'),
+        isArray = SC.isArray(value),
+        item, idx, icon, name, width, itemsLength, url,
+        className, disabled, sel, labelText,
+        selectionState, selectionStateClassNames;
 
     context.addClass(this.get('layoutDirection'));
 
@@ -186,8 +200,11 @@ SC.RadioView = SC.View.extend(SC.Control,
 
         labelText = this.escapeHTML ? SC.RenderContext.escapeHTML(item[0]) : item[0];
         
-        context.push('<div class="sc-radio-button ', 
-                    selectionStateClassNames, '" ', 
+        width = item[4];
+        
+        context.push('<div class="sc-radio-button ',
+                    selectionStateClassNames, '" ',
+                    width ? 'style="width: ' + width + 'px;" ' : '',
                     'aria-checked="', sel ? 'true':'false','" ',
                     'role="radio"' , ' index="', idx,'">',
                     '<span class="button"></span>',
@@ -209,6 +226,10 @@ SC.RadioView = SC.View.extend(SC.Control,
         } else {
           sel = NO;
         }
+        
+        width = item[4];
+        if (width) button.width(width);
+        
         selectionState = this._getSelectionStateClassNames(item, sel, value, isArray, true);
         button.attr('aria-checked', sel ? 'true': 'false');
         // set class of label
@@ -232,11 +253,14 @@ SC.RadioView = SC.View.extend(SC.Control,
   _displayItems: function() {
     var items = this.get('items'), 
         loc = this.get('localize'),
-        titleKey = this.get('itemTitleKey'), valueKey = this.get('itemValueKey'),
+        titleKey = this.get('itemTitleKey'),
+        valueKey = this.get('itemValueKey'),
+        widthKey = this.get('itemWidthKey'),
+        isHorizontal = this.get('layoutDirection') === SC.LAYOUT_HORIZONTAL,
         isEnabledKey = this.get('itemIsEnabledKey'), 
         iconKey = this.get('itemIconKey'),
         ret = [], max = (items)? items.get('length') : 0,
-        item, title, value, idx, isArray, isEnabled, icon;
+        item, title, width, value, idx, isArray, isEnabled, icon;
     
     for(idx=0;idx<max;idx++) {
       item = items.objectAt(idx); 
@@ -253,7 +277,11 @@ SC.RadioView = SC.View.extend(SC.Control,
         if (titleKey) {
           title = item.get ? item.get(titleKey) : item[titleKey];
         } else title = (item.toString) ? item.toString() : null;
-
+        
+        if (widthKey && isHorizontal) {
+          width = item.get ? item.get(widthKey) : item[widthKey];
+        }
+        
         if (valueKey) {
           value = item.get ? item.get(valueKey) : item[valueKey];
         } else value = item;
@@ -274,11 +302,11 @@ SC.RadioView = SC.View.extend(SC.Control,
 
       // localize title if needed
       if (loc) title = title.loc();
-      ret.push([title, value, isEnabled, icon]);
+      ret.push([title, value, isEnabled, icon, width]);
     }
 
     return ret; // done!
-  }.property('items', 'itemTitleKey', 'itemValueKey', 'itemIsEnabledKey', 'localize', 'itemIconKey').cacheable(),
+  }.property('items', 'itemTitleKey', 'itemWidthKey', 'itemValueKey', 'itemIsEnabledKey', 'localize', 'itemIconKey').cacheable(),
 
   /** @private - 
     Will figure out what class names to assign each radio button.

data/lib/frameworks/sproutcore/frameworks/desktop/views/scroller.js

@@ -198,7 +198,7 @@ SC.ScrollerView = SC.View.extend(
     @private
   */
   render: function(context, firstTime) {
-    var classNames = [],
+    var classNames = {},
         buttons = '',
         thumbPosition, thumbLength, thumbCenterLength, thumbElement,
         value, max, scrollerLength, length, pct;
@@ -207,21 +207,21 @@ SC.ScrollerView = SC.View.extend(
     // style them differently using CSS.
     switch (this.get('layoutDirection')) {
       case SC.LAYOUT_VERTICAL:
-        classNames.push('sc-vertical');
+        classNames['sc-vertical'] = YES;
         break;
       case SC.LAYOUT_HORIZONTAL:
-        classNames.push('sc-horizontal');
+        classNames['sc-horizontal'] = YES;
         break;
     }
 
     // The appearance of the scroller changes if disabled
-    if (!this.get('isEnabled')) classNames.push('disabled');
+    classNames['disabled'] = !this.get('isEnabled');
     // Whether to hide the thumb and buttons
-    if (this.get('controlsHidden')) classNames.push('controls-hidden');
+    classNames['controls-hidden'] = this.get('controlsHidden');
 
     // Change the class names of the DOM element all at once to improve
     // performance
-    context.addClass(classNames);
+    context.setClass(classNames);
 
     // Calculate the position and size of the thumb
     thumbLength = this.get('thumbLength');
@@ -240,7 +240,7 @@ SC.ScrollerView = SC.View.extend(
         context.push('<div class="track"></div>',
                       '<div class="cap"></div>',
                       buttons,
-                      '<div class="thumb" style="height: '+thumbLength+'px;">',
+                      '<div class="thumb" style="height: '+thumbLength+'px; top: ' + thumbPosition + 'px;">',
                       '<div class="thumb-center"></div>',
                       '<div class="thumb-top"></div>',
                       '<div class="thumb-bottom"></div></div>');
@@ -249,7 +249,7 @@ SC.ScrollerView = SC.View.extend(
         context.push('<div class="track"></div>',
                       '<div class="cap"></div>',
                       buttons,
-                      '<div class="thumb" style="width: '+thumbLength+'px;">',
+                      '<div class="thumb" style="width: '+thumbLength+'px; left: ' + thumbPosition + 'px;">',
                       '<div class="thumb-center"></div>',
                       '<div class="thumb-top"></div>',
                       '<div class="thumb-bottom"></div></div>');

data/lib/frameworks/sproutcore/frameworks/desktop/views/segmented.js

@@ -2,7 +2,7 @@
 // Project:   SproutCore - JavaScript Application Framework
 // Copyright: ©2006-2010 Sprout Systems, Inc. and contributors.
 //            Portions ©2008-2010 Apple Inc. All rights reserved.
-// License:   Licened under MIT license (see license.js)
+// License:   Licensed under MIT license (see license.js)
 // ==========================================================================
 
 /**

data/lib/frameworks/sproutcore/frameworks/desktop/views/select_field.js

@@ -122,7 +122,9 @@ SC.SelectFieldView = SC.FieldView.extend(
       var objects = this.get('objects') ;
       var fieldValue = this.get('value') ;
       var el, selectElement;
-    
+
+      if ( !this.get('isEnabled') ) context.attr('disabled','disabled');
+        
       // get the localization flag.
       var shouldLocalize = this.get('localize'); 
    
@@ -208,12 +210,17 @@ SC.SelectFieldView = SC.FieldView.extend(
     }
   },
   
-  displayProperties: ['objects','nameKey','valueKey'],
+  displayProperties: ['objects','nameKey','valueKey','isEnabled'],
 
   _objectsObserver: function() {
     this.set('cpDidChange', YES);
   }.observes('objects'),
-   
+
+  _objectArrayObserver: function() {
+    this.set('cpDidChange', YES);
+    this.propertyDidChange('objects');
+  }.observes('*objects.[]'),
+    
   _nameKeyObserver: function() {
     this.set('cpDidChange', YES);
   }.observes('nameKey'),
@@ -247,7 +254,8 @@ SC.SelectFieldView = SC.FieldView.extend(
     var value = sc_super(); // get raw value... 
     var valueKey = this.get('valueKey') ;
     var objects = this.get('objects') ;
-    var found, object;
+    var found = null; // matching object goes here.
+    var object;
     
     // Handle empty selection.
     if (value == '***') {
@@ -260,7 +268,6 @@ SC.SelectFieldView = SC.FieldView.extend(
       
       var loc = (SC.typeOf(objects.length) === SC.T_FUNCTION) ? objects.length() : objects.length;
       
-      found = null ; // matching object goes here.
       while(!found && (--loc >= 0)) {
         object = objects.objectAt? objects.objectAt(loc) : objects[loc] ;
         if (!object) continue; // null means placeholder; just skip

data/lib/frameworks/sproutcore/frameworks/foundation/mixins/button.js

@@ -219,17 +219,17 @@ SC.Button = {
 
     var valueKey = this.getDelegateProperty('contentValueKey', del) ;
     if (valueKey && (key === valueKey || key === '*')) {
-      this.set('value', content ? content.get(valueKey) : null) ;
+      this.set('value', content ? (content.get ? content.get(valueKey) : content[valueKey]) : null) ;
     }
 
     var titleKey = this.getDelegateProperty('contentTitleKey', del) ;
     if (titleKey && (key === titleKey || key === '*')) {
-      this.set('title', content ? content.get(titleKey) : null) ;
+      this.set('title', content ? (content.get ? content.get(titleKey) : content[titleKey]) : null) ;
     }
 
     var iconKey = this.getDelegateProperty('contentIconKey', del);
     if (iconKey && (key === iconKey || key === '*')) {
-      this.set('icon', content ? content.get(iconKey) : null) ;
+      this.set('icon', content ? (content.get ? content.get(iconKey) : content[iconKey]) : null) ;
     }
     
     return this ;

data/lib/frameworks/sproutcore/frameworks/foundation/mixins/inline_text_field.js

@@ -54,7 +54,7 @@ sc_require('views/text_field') ;
   editor expects your source view to implement the InlineTextFieldViewDelegate
   protocol.
 
-  h2. Commiting or Discarding Changes
+  h2. Committing or Discarding Changes
   
   Normally the editor will automatically commit or discard its changes 
   whenever the user exits the edit mode.  If you need to force the editor to
@@ -66,13 +66,13 @@ sc_require('views/text_field') ;
   }}}
   
   Both methods will try to end the editing context and will call the 
-  relevent delegate methods on the delegate you passed to beginEditing().
+  relevant delegate methods on the delegate you passed to beginEditing().
   
   Note that it is possible an editor may not be able to commit editing 
   changes because either the delegate disallowed it or because its validator
   failed.  In this case commitEditing() will return NO.  If you want to
   end editing anyway, you can discard the editing changes instead by calling
-  discardEditing().  This method will generally suceed unless your delegate
+  discardEditing().  This method will generally succeed unless your delegate
   refuses it as well.
   
   @extends SC.TextFieldView
@@ -133,7 +133,9 @@ SC.InlineTextFieldView = SC.TextFieldView.extend(SC.DelegateSupport,
       throw "At least frame and delegate options are required for inline editor";
     }
     
-    this._originalValue = options.value || '' ;
+    this._originalValue = options.value;
+    if (SC.none(this._originalValue))
+      this._originalValue = "";
     this._multiline = (options.multiline !== undefined) ? options.multiline : NO ;
     if (this._multiline) {
       this.set('isTextArea', YES);
@@ -420,10 +422,11 @@ SC.InlineTextFieldView = SC.TextFieldView.extend(SC.DelegateSupport,
   // editable, begins editing.
   /** @private */
   insertTab: function(evt) {
+    var delegate = this._delegate; // removed by commitEditing()
     this.resignFirstResponder();
     this.commitEditing() ;
-    if(this._delegate){
-      var next = this._delegate.nextValidKeyView();
+    if(delegate){
+      var next = delegate.get('nextValidKeyView');
       if(next && next.beginEditing) next.beginEditing();
     }
     return YES ;
@@ -431,10 +434,12 @@ SC.InlineTextFieldView = SC.TextFieldView.extend(SC.DelegateSupport,
 
   /** @private */
   insertBacktab: function(evt) {
+    var delegate = this._delegate; // removed by commitEditing()
+    this.resignFirstResponder();
     this.commitEditing() ;
-    if(this._delegate){
-      var prev = this._delegate.previousValidKeyView();
-      if(prev) prev.beginEditing();
+    if(delegate){
+      var prev = delegate.get('previousValidKeyView');
+      if(prev && prev.beginEditing) prev.beginEditing();
     }
     return YES ;
   },

data/lib/frameworks/sproutcore/frameworks/foundation/system/datetime.js

@@ -893,7 +893,9 @@ SC.DateTime.mixin(SC.Comparable,
     @returns {DateTime} the DateTime corresponding to the string parameter
   */
   parse: function(str, fmt) {
-    var re = /(?:\%([aAbBcdHIjmMpSUWwxXyYZ\%])|(.))/g;
+    // Declared as an object not a literal since in some browsers the literal
+    // retains state across function calls
+    var re = new RegExp('(?:%([aAbBcdHIjmMpSUWwxXyYZ%])|(.))', "g");
     var d, parts, opts = {}, check = {}, scanner = SC.Scanner.create({string: str});
     
     if (SC.none(fmt)) fmt = SC.DATETIME_ISO8601;

data/lib/frameworks/sproutcore/frameworks/foundation/system/root_responder.js

@@ -1808,29 +1808,37 @@ SC.RootResponder = SC.Object.extend({
        } else {
          var lh = this._lastHovered || [] , nh = [] , exited, loc, len,
              view = this.targetViewForEvent(evt) ;
-
-         // work up the view chain.  Notify of mouse entered and
-         // mouseMoved if implemented.
-         while(view && (view !== this)) {
+         
+         // first collect all the responding view starting with the 
+         // target view from the given mouse move event
+         while (view && (view !== this)) {
+           nh.push(view);
+           view = view.get('nextResponder');
+         }
+        
+         // next exit views that are no longer part of the 
+         // responding chain
+         for (loc=0, len=lh.length; loc < len; loc++) {
+           view = lh[loc] ;
+           exited = view.respondsTo('mouseExited');
+           if (exited && nh.indexOf(view) === -1) {
+             view.tryToPerform('mouseExited', evt);
+           }
+         }
+         
+         // finally, either perform mouse moved or mouse entered depending on
+         // whether a responding view was or was not part of the last
+         // hovered views
+         for (loc=0, len=nh.length; loc < len; loc++) {
+           view = nh[loc];
            if (lh.indexOf(view) !== -1) {
              view.tryToPerform('mouseMoved', evt);
-             nh.push(view) ;
            } else {
              view.tryToPerform('mouseEntered', evt);
-             nh.push(view) ;
-           }
-
-           view = view.get('nextResponder');
-         }
-         // now find those views last hovered over that were no longer found
-         // in this chain and notify of mouseExited.
-         for(loc=0, len=lh.length; loc < len; loc++) {
-           view = lh[loc] ;
-           exited = view.respondsTo('mouseExited') ;
-           if (exited && !(nh.indexOf(view) !== -1)) {
-             view.tryToPerform('mouseExited',evt);
            }
          }
+
+         // Keep track of the view that were last hovered
          this._lastHovered = nh;
 
          // also, if a mouseDownView exists, call the mouseDragged action, if

data/lib/frameworks/sproutcore/frameworks/foundation/tests/mixins/inline_text_field/beginEditing.js

@@ -6,7 +6,7 @@
 // ==========================================================================
 /*global module test htmlbody ok equals same stop start Q$ */
 
-var pane, optionsForLabel1, optionsForLabel2, delegate;
+var pane, optionsForLabel1, optionsForLabel2, delegate, optionsForLabelFromView;
 
 pane = SC.ControlTestPane.design().add("label1", SC.LabelView, {
   value: 'Some Text',
@@ -50,6 +50,30 @@ pane.resetView = function(view) {
   view.set('notifiedDidBegin', NO);
 };
 
+
+optionsForLabelFromView = function(view) {
+  var el = view.$(),
+  f = SC.viewportOffset(el[0]),
+  frameTemp = view.convertFrameFromView(view.get('frame'), null);
+
+  f.width = frameTemp.width;
+  f.height = frameTemp.height;
+
+  var optionsForLabel = {
+    frame: f,
+    delegate: view,
+    exampleElement: view.$(),
+    value: view.get('value'),
+    multiline: view.get('isInlineEditorMultiline'),
+    isCollection: NO,
+    validator: view.get('validator'),
+    exampleInlineTextFieldView: view.get('exampleInlineTextFieldView')
+  };
+
+  return optionsForLabel;
+};
+
+
 /**
   
 */
@@ -64,41 +88,8 @@ module("Test the beginEditing() function of SC.InlineTextFieldView", {
     // Reset view1 delegate functions
     pane.resetView(view1);
 
-    var el = view1.$(),
-    f = SC.viewportOffset(el[0]),
-    frameTemp = view1.convertFrameFromView(view1.get('frame'), null);
-
-    f.width = frameTemp.width;
-    f.height = frameTemp.height;
-
-    optionsForLabel1 = {
-      frame: f,
-      delegate: view1,
-      exampleElement: view1.$(),
-      value: view1.get('value'),
-      multiline: view1.get('isInlineEditorMultiline'),
-      isCollection: NO,
-      validator: view1.get('validator'),
-      exampleInlineTextFieldView: view1.get('exampleInlineTextFieldView')
-    };
-
-    el = view2.$();
-    f = SC.viewportOffset(el[0]);
-    frameTemp = view2.convertFrameFromView(view2.get('frame'), null);
-
-    f.width = frameTemp.width;
-    f.height = frameTemp.height;
-
-    optionsForLabel2 = {
-      frame: f,
-      delegate: view2,
-      exampleElement: view2.$(),
-      value: view2.get('value'),
-      multiline: view2.get('isInlineEditorMultiline'),
-      isCollection: NO,
-      validator: view2.get('validator'),
-      exampleInlineTextFieldView: view2.get('exampleInlineTextFieldView')
-    };
+    optionsForLabel1 = optionsForLabelFromView(view1);
+    optionsForLabel2 = optionsForLabelFromView(view2);
   },
 
   teardown: function() {
@@ -225,3 +216,22 @@ function() {
 
   ok(view1.get('notifiedDidBegin'), "the delegate should have been notified of begin editing at this point");
 });
+
+test("inline editor does not display the defaultValue if the label's value is the number 0",
+function() {
+  var view1 = pane.view('label1');;
+  view1.set('value', 0);
+  optionsForLabel1 = optionsForLabelFromView(view1);
+
+  SC.RunLoop.begin();
+  SC.InlineTextFieldView.beginEditing(optionsForLabel1);
+  SC.RunLoop.end();
+
+  // The inline editor is the last view appended to the pane
+  var length = pane._pane.childViews.length,
+  editor = pane._pane.childViews[length - 1];
+  same(editor.get('value'), 0, "editor should have number 0 as value");
+  editor.blurEditor();
+
+  same(view1.get('value'), 0, "view should still have number 0 as value");
+});

data/lib/frameworks/sproutcore/frameworks/foundation/tests/mixins/validatable/ui.js

@@ -2,7 +2,7 @@
 // Project:   SproutCore - JavaScript Application Framework
 // Copyright: ©2006-2010 Sprout Systems, Inc. and contributors.
 //            portions copyright @2009 Apple Inc.
-// License:   Licened under MIT license (see license.js)
+// License:   Licensed under MIT license (see license.js)
 // ==========================================================================
 
 /*global module test htmlbody ok equals same stop start */

data/lib/frameworks/sproutcore/frameworks/foundation/tests/system/datetime.js

@@ -302,6 +302,11 @@ test('parse without a format uses default ISO8601', function() {
   equals(SC.DateTime.parse("2010-09-17T18:35:08Z").toISO8601(), "2010-09-17T18:35:08+00:00");
 });
 
+test('bad parsing', function() {
+  equals(SC.DateTime.parse(SC.DateTime.parse("foo")), null);
+  equals(SC.DateTime.parse("2010-09-17T18:35:08Z", SC.DATETIME_ISO8601).toISO8601(), "2010-09-17T18:35:08+00:00");
+});
+
 test('binding', function() {
   var fromObject = SC.Object.create({value: dt});
   var toObject = SC.Object.create({value: ''});

data/lib/frameworks/sproutcore/frameworks/foundation/tests/validators/not_empty.js

@@ -0,0 +1,56 @@
+// ==========================================================================
+// Project:   SproutCore - JavaScript Application Framework
+// Copyright: ©2006-2010 Apple Inc. and contributors.
+// License:   Licensed under MIT license (see license.js)
+// ==========================================================================
+
+/*global module test equals context ok same */
+var notEmptyValidator, field;
+
+module("SC.Validator.NotEmpty", {
+    setup: function () {
+        notEmptyValidator = SC.Validator.NotEmpty.create();
+        field = SC.Object.create();
+    },
+    teardown: function () {
+        notEmptyValidator.destroy();
+        notEmptyValidator = null;
+    }
+});
+
+test("Recognizes a non-empty string as valid",function(){
+    field.set('fieldValue', "fnord");
+    var isValid = notEmptyValidator.validate(undefined, field);
+    ok(isValid, "Not empty string is valid");
+});
+
+test("Recognizes empty string as invalid",function(){
+    field.set('fieldValue', "");
+    var isValid = notEmptyValidator.validate(undefined, field);
+    ok( ! isValid, "Empty string is not valid");
+});
+
+test("Recognizes null as empty",function(){
+    field.set('fieldValue', null);
+    var isValid = notEmptyValidator.validate(undefined, field);
+    ok( ! isValid, "null string is not valid");
+});
+
+test("Recognizes undefined as empty",function(){
+    field.set('fieldValue', undefined);
+    var isValid = notEmptyValidator.validate(undefined, field);
+    ok( ! isValid, "null string is not valid");
+});
+
+test("Recognizes some number as non-empty",function(){
+    field.set('fieldValue', 42);
+    var isValid = notEmptyValidator.validate(undefined, field);
+    ok(isValid, "42 string is not empty");
+});
+
+test("Recognizes zero as non-empty",function(){
+    field.set('fieldValue', 0);
+    var isValid = notEmptyValidator.validate(undefined, field);
+    ok(isValid, "0 string is not empty");
+});
+

data/lib/frameworks/sproutcore/frameworks/foundation/validators/date_time.js

@@ -2,7 +2,7 @@
 // Project:   SproutCore - JavaScript Application Framework
 // Copyright: ©2006-2010 Sprout Systems, Inc. and contributors.
 //            Portions ©2008-2010 Apple Inc. All rights reserved.
-// License:   Licened under MIT license (see license.js)
+// License:   Licensed under MIT license (see license.js)
 // ==========================================================================
 
 require('validators/validator');