sproutcore 1.10.2 → 1.10.3.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MmM2OWQzMTljMWNmN2U5OTczMWNkYjBlNTdkNGY1NjdiMjYyMjM0Mw==
+    N2VkZDQ3ZWNjMGJhZjA3ZmQ1MTFjMmM1ZjAzM2JjYThiZTQyODY1OA==
   data.tar.gz: !binary |-
-    N2NkMmVhOGVlOTg1MjFjNDM0MTUwNzcyOTY3Mzg2MTY5ZmVkOTQyMA==
+    YmI0NTE1M2U0NTRlM2I5ZDE2YWJiNGJhODMyYzg1NzFlYWJkYjA0Zg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NjBjNDc3NTczZjlkNmZmZTE2ZDI0OTM0YWY2MTkzZTUyNzM1YWU4MDBlMjg5
-    ZmUzNzM5ZmZmOGMwMTkxZGU1NjU1MWUzZTVkNzM0M2JiZmRlNTczYzNlYWM1
-    MjZmZjE1YTY4NzU2ODhhMjg2ODA2N2ZkZTBkMjE5ZjkwODM0MjQ=
+    ODJhNTc0NWNkOTM2NmYwNDVjMWQ1YTZmNjljMjFiNzdjZGVhNGQyMzg0OWM1
+    MWRkMDBkZTRiZjg4MDViNjkyODE1NjE3MjgzYTc4MDM1ODU3NDhiMjdjMDRk
+    NTM0ZDNiODE5MjFkYzc0MzI1YzJjY2JhNGFmMGIyODcyMmYzZWM=
   data.tar.gz: !binary |-
-    NzMxNDA0ZWI5OGM4YmMxZGRmZjU2ZGI4NDg0NTg1MWZmOTdiMmQyYTFhMjVh
-    YWIxNzg5NmRhNjMwODI1NGNkM2IxYmUzOGI2Y2NlM2M2Yzc2ODY1MWFkMWE3
-    YzRkZjBmNTA4N2QyM2EyMTM1MGVkN2JmYThkMGQ0ZDMxZTM0ZTA=
+    YmZlNWFlYzIyNWM2NjE3ODVjMDRiOTg3MmY0YWRiYWIwMWYyNWY2OTA5MmEw
+    MzQwMWQyOGExMTUzMWVkMDY2OGQ3YTFjNTM5MGE0ODAzYzExZjNmOWNjZjEz
+    OWIyZTU5MDk0NzgzZGI0ZTI1M2EwODQ2MDg4NWMzNjBhODlhZjk=

data/CHANGELOG

@@ -1,8 +1,19 @@
+SproutCore 1.10.3
+-----------------
+
+* Makes logging each individual path a debug level mode and moves the build path message to info level.
+* Adds a bit of default messaging to the build process.
+* Bumps the listen gem minimum requirement as earlier versions seem to result in not being able to kill sc-server.
+* Updates YUICompressor to version 2.4.8.
+* Moves some unneeded code into the polling listener block and adds all matched .git directories as an ignored path. This prevents excessive CPU usage when dealing with submodules and frameworks checked out within a project.
+
+
 SproutCore 1.10.2
 -----------------
 
 * Uses a file system change listener rather than polling.
 
+
 SproutCore 1.10.0
 -----------------
 

data/VERSION.yml

@@ -1,4 +1,4 @@
 ---
 :major: 1
 :minor: 10
-:patch: 2
+:patch: 3.1

data/lib/frameworks/sproutcore/CHANGELOG.md

@@ -17,6 +17,35 @@ CHANGE LOG
 
 * Some fixes for deprecated template view framework.
 
+
+1.10.3
+-----------
+
+### INTERNAL CHANGES
+
+* Adds a new state to the view statechart, SC.CoreView.ATTACHED_SHOWN_ANIMATING. This state is for views that are manually animated via a call to `animate` when in the ATTACHED_SHOWN state and is used to cancel manual animations if a view is hidden or removed, which would cause the animation callbacks to fail to trigger. Also prevents animate from running on views that are not visible in the window. 
+* Removes double clone of observable members array. The `getMembers` function already does a slice of the array, so SC.clone (which just does another slice of the array) is unnecessary.
+* Prevents bindings that are disconnected at the moment of updating from continuing, which would throw an exception because the binding would try to resolve both sides of the connection and become connected to the window (which doesn’t support the KVC methods the binding uses).
+
+One scenario that this has been seen in is an observer that destroys an old binding and creates a new binding to a *store query based computed property*. As the binding is about to update, it first has to get the value of the query based computed property from the target, which results in the store flushing and indicating certain records did change which in turn triggers the original observer function where the binding is replaced. In the very next step, the old binding, which is now disconnected, tries to syncronize its value, which will fail.
+
+### BUG FIXES
+
+* Fixes problems with SC.GridView when its width goes to 0 (which would calculate infinite items per row).
+* Fixes a bug where separator items gained the value of the previous item such that the separator item would appear selected in the menu when the previous item was actually selected.
+* Fixes regression that the icon of the selected item doesn’t update the view.
+Adds ability to set the value of the view and have the view’s title and icon update.
+* Fixes regression with transitionIn due to animate rejecting non-visible states.
+* Fixes double invokeNext call when runAnimationCallback is wrapped in an invokeNext.
+* Fixes direct duplicate call to commitEditing in SC.InlineTextField when using the tab or shift-tab keys, also cleans whitespace in SC.Editable.
+* Fixes cancellation of view transitions. If the transition is cancelled, the plugin should not fire the callback. Cancels show/hide transitions when the state changes before they complete.
+* Fixes bugs where logic bindings (and & or) defined on classes were being serviced by a shared underlying object, causing issues when two instances wanted different values or to be destroyed at different times.
+* Stacked child layout views: don't add padding or margins if none of the children are visible.
+* Fixes animations failing when browser tab not visible.
+* Takes a new approach to transition and animation callbacks. Instead of waiting for the exact right event name to be determined, we listen to all the possible combinations for the browser and then remove the unnecessary listeners when the test completes. This allows code to run that uses transitions and animations in the application’s main function and doesn’t require blocking the launch of the application for the tests to complete.
+* Fixes animations failing when tab loaded and not visible. Because animation callbacks are paused when some browsers’ tabs are not visible, we can’t apply animations based on the browser support for CSS transitions alone. We also need to set up our animation event listeners and so any animations that occur while the page is loading should simply apply directly.
+* Fixes the case that a layout observer calls adjust due to an animate layout being set. The observer would fire before the _animateLayout internal property would be cleared, leading a later adjust method to fail.
+
 1.10.2
 -----------
 
@@ -26,6 +55,11 @@ CHANGE LOG
 * Added a debug-mode only developer error to prevent double calls to materializeRecord from within materializeRecord. The result is duplicated objects that appear to be the same record instance but are in fact not, which can be very time-consuming to debug. Hopefully this saves developers a lot of grief.
 * Added several *debug-mode only* `toString` methods for easy debugging.
 * Added a tiny bit of debug mode only developer support. If manually connecting/disconnecting bindings it's possible to accidentally try to bind to a missing object. The normal stack trace this would produce is hard to follow so we present a more traceable error message with the stack.
+* Fixed issue with property chain notifications.
+
+Property chains would by notified during teardownEnumerablePropertyChains, but this could result in computed properties trying to access the array before it was finished mutating. This was observed with SC.ChildArray's.
+
+Instead, wait until setupEnumerablePropertyChains to notify, and always notify with the assumption that changes were made.
 
 ### BUG FIXES
 

data/lib/frameworks/sproutcore/frameworks/core_foundation/child_view_layouts/horizontal_stack_layout.js

@@ -272,7 +272,9 @@ SC.mixin(SC.View,
       }
 
       // Adjust our frame to fit as well, this ensures that scrolling works.
-      position += Math.max(lastMargin, paddingAfter);
+      // If the current size is 0 (all children are hidden), it doesn't make sense to add the padding
+      if (position !== 0)
+        position += Math.max(lastMargin, paddingAfter);
       if (resizeToFit && view.getPath('layout.width') !== position) {
         view.adjust('width', position);
       }

data/lib/frameworks/sproutcore/frameworks/core_foundation/child_view_layouts/vertical_stack_layout.js

@@ -273,7 +273,9 @@ SC.mixin(SC.View,
       }
 
       // Adjust our frame to fit as well, this ensures that scrolling works.
-      position += Math.max(lastMargin, paddingAfter);
+      // If the current size is 0 (all children are hidden), it doesn't make sense to add the padding
+      if (position !== 0)
+        position += Math.max(lastMargin, paddingAfter);
       if (resizeToFit && view.getPath('layout.height') !== position) {
         view.adjust('height', position);
       }

data/lib/frameworks/sproutcore/frameworks/core_foundation/system/platform.js

@@ -446,8 +446,8 @@ SC.platform = SC.Object.create({
   we would get it wrong.  Instead we perform actual tests to find out the proper
   names and only add the proper listeners.
 
-  Once the tests are completed the RootResponder is notified in order to add
-  transition and animation event listeners for the appropriate event names.
+  Once the tests are completed the RootResponder is notified in order to clean up
+  unnecessary transition and animation event listeners.
 */
 SC.ready(function () {
   // This will add 4 different variations of the named event listener and clean
@@ -508,14 +508,13 @@ SC.ready(function () {
       // If an end event never fired, we can't really support CSS transitions in SproutCore.
       if (success) {
         // Set up the SC transition event listener.
-        SC.RootResponder.responder.setupTransitionListener();
+        SC.RootResponder.responder.cleanUpTransitionListeners();
       } else {
         SC.platform.supportsCSSTransitions = NO;
       }
 
       transitionEl.parentNode.removeChild(transitionEl);
       transitionEl = null;
-
     });
 
     // Append the test element.
@@ -525,86 +524,86 @@ SC.ready(function () {
     setTimeout(function () {
       transitionEl.style.opacity = '0';
     });
-  }
-
-  // Set up and execute the animation event test.
-  if (SC.platform.supportsCSSAnimations) {
-    var animationEl = document.createElement('div'),
-      keyframes,
-      prefixedKeyframes;
-
-    // Generate both the regular and prefixed version of the style.
-    keyframes = '@keyframes _sc_animation_test { from { opacity: 1; } to { opacity: 0; } }';
-    prefixedKeyframes = '@' + SC.browser.cssPrefix + 'keyframes _sc_prefixed_animation_test { from { opacity: 1; } to { opacity: 0; } }';
-
-    // Add test animation styles.
-    animationEl.innerHTML = '<style>' + keyframes + '\n' + prefixedKeyframes + '</style>';
 
     // Set up and execute the animation event test.
-    animationEl.style.animation = '_sc_animation_test 1ms linear';
-    animationEl.style[SC.browser.domPrefix + 'Animation'] = '_sc_prefixed_animation_test 5ms linear';
-
-    // NOTE: We could test start, but it's extra work and easier just to test the end
-    // and infer the start event name from it.  Keeping this code for example.
-    // executeTest(animationEl, 'animationstart', 'AnimationStart', function (success) {
-    //   // If an iteration start never fired, we can't really support CSS transitions in SproutCore.
-    //   if (!success) {
-    //     SC.platform.supportsCSSAnimations = NO;
-    //   }
-    // });
-
-    // NOTE: Testing iteration event support proves very problematic.  Many
-    // browsers can't iterate less than several milliseconds which means we
-    // have to wait too long to find out this event name.  Instead we test
-    // the end only and infer the iteration event name from it. Keeping this
-    // code for example, but it wont' work reliably unless the animation style
-    // is something like '_sc_animation_test 30ms linear' (i.e. ~60ms wait time)
-    // executeTest(animationEl, 'animationiteration', 'AnimationIteration', function (success) {
-    //   // If an iteration event never fired, we can't really support CSS transitions in SproutCore.
-    //   if (!success) {
-    //     SC.platform.supportsCSSAnimations = NO;
-    //   }
-    // });
-
-    // Test animation events.
-    executeTest(animationEl, 'animationend', 'AnimationEnd', function (success) {
-      // If an end event never fired, we can't really support CSS animations in SproutCore.
-      if (success) {
-        // Infer the start and iteration event names based on the success of the end event.
-        var domPrefix = SC.browser.domPrefix,
-          lowerDomPrefix = domPrefix.toLowerCase(),
-          endEventName = SC.platform.animationendEventName;
-
-        switch (endEventName) {
-        case lowerDomPrefix + 'animationend':
-          SC.platform.animationstartEventName = lowerDomPrefix + 'animationstart';
-          SC.platform.animationiterationEventName = lowerDomPrefix + 'animationiteration';
-          break;
-        case lowerDomPrefix + 'AnimationEnd':
-          SC.platform.animationstartEventName = lowerDomPrefix + 'AnimationStart';
-          SC.platform.animationiterationEventName = lowerDomPrefix + 'AnimationIteration';
-          break;
-        case domPrefix + 'AnimationEnd':
-          SC.platform.animationstartEventName = domPrefix + 'AnimationStart';
-          SC.platform.animationiterationEventName = domPrefix + 'AnimationIteration';
-          break;
-        default:
-          SC.platform.animationstartEventName = 'animationstart';
-          SC.platform.animationiterationEventName = 'animationiteration';
+    if (SC.platform.supportsCSSAnimations) {
+      var animationEl = document.createElement('div'),
+        keyframes,
+        prefixedKeyframes;
+
+      // Generate both the regular and prefixed version of the style.
+      keyframes = '@keyframes _sc_animation_test { from { opacity: 1; } to { opacity: 0; } }';
+      prefixedKeyframes = '@' + SC.browser.cssPrefix + 'keyframes _sc_prefixed_animation_test { from { opacity: 1; } to { opacity: 0; } }';
+
+      // Add test animation styles.
+      animationEl.innerHTML = '<style>' + keyframes + '\n' + prefixedKeyframes + '</style>';
+
+      // Set up and execute the animation event test.
+      animationEl.style.animation = '_sc_animation_test 1ms linear';
+      animationEl.style[SC.browser.domPrefix + 'Animation'] = '_sc_prefixed_animation_test 5ms linear';
+
+      // NOTE: We could test start, but it's extra work and easier just to test the end
+      // and infer the start event name from it.  Keeping this code for example.
+      // executeTest(animationEl, 'animationstart', 'AnimationStart', function (success) {
+      //   // If an iteration start never fired, we can't really support CSS transitions in SproutCore.
+      //   if (!success) {
+      //     SC.platform.supportsCSSAnimations = NO;
+      //   }
+      // });
+
+      // NOTE: Testing iteration event support proves very problematic.  Many
+      // browsers can't iterate less than several milliseconds which means we
+      // have to wait too long to find out this event name.  Instead we test
+      // the end only and infer the iteration event name from it. Keeping this
+      // code for example, but it wont' work reliably unless the animation style
+      // is something like '_sc_animation_test 30ms linear' (i.e. ~60ms wait time)
+      // executeTest(animationEl, 'animationiteration', 'AnimationIteration', function (success) {
+      //   // If an iteration event never fired, we can't really support CSS transitions in SproutCore.
+      //   if (!success) {
+      //     SC.platform.supportsCSSAnimations = NO;
+      //   }
+      // });
+
+      // Test animation events.
+      executeTest(animationEl, 'animationend', 'AnimationEnd', function (success) {
+        // If an end event never fired, we can't really support CSS animations in SproutCore.
+        if (success) {
+          // Infer the start and iteration event names based on the success of the end event.
+          var domPrefix = SC.browser.domPrefix,
+            lowerDomPrefix = domPrefix.toLowerCase(),
+            endEventName = SC.platform.animationendEventName;
+
+          switch (endEventName) {
+          case lowerDomPrefix + 'animationend':
+            SC.platform.animationstartEventName = lowerDomPrefix + 'animationstart';
+            SC.platform.animationiterationEventName = lowerDomPrefix + 'animationiteration';
+            break;
+          case lowerDomPrefix + 'AnimationEnd':
+            SC.platform.animationstartEventName = lowerDomPrefix + 'AnimationStart';
+            SC.platform.animationiterationEventName = lowerDomPrefix + 'AnimationIteration';
+            break;
+          case domPrefix + 'AnimationEnd':
+            SC.platform.animationstartEventName = domPrefix + 'AnimationStart';
+            SC.platform.animationiterationEventName = domPrefix + 'AnimationIteration';
+            break;
+          default:
+            SC.platform.animationstartEventName = 'animationstart';
+            SC.platform.animationiterationEventName = 'animationiteration';
+          }
+
+          // Set up the SC animation event listeners.
+          SC.RootResponder.responder.cleanUpAnimationListeners();
+        } else {
+          SC.platform.supportsCSSAnimations = NO;
         }
 
-        // Set up the SC animation event listeners.
-        SC.RootResponder.responder.setupAnimationListeners();
-      } else {
-        SC.platform.supportsCSSAnimations = NO;
-      }
+        // Clean up.
+        animationEl.parentNode.removeChild(animationEl);
+        animationEl = null;
+      });
 
-      // Clean up.
-      animationEl.parentNode.removeChild(animationEl);
-      animationEl = null;
-    });
-
-    // Break execution to allow the browser to update the DOM before altering the style.
-    document.documentElement.appendChild(animationEl);
+      // Break execution to allow the browser to update the DOM before altering the style.
+      document.documentElement.appendChild(animationEl);
+    }
   }
 });

data/lib/frameworks/sproutcore/frameworks/core_foundation/system/root_responder.js

@@ -650,6 +650,57 @@ SC.RootResponder = SC.Object.extend(
       }
     }
 
+    // Add an array of transition listeners for immediate use (these will be cleaned up when actual testing completes).
+    // Because the transition test happens asynchronously and because we don't want to
+    // delay the launch of the application in order to a transition test (the app won't
+    // load if the browser tab is not visible), we start off by listening to everything
+    // and when the test is completed, we remove the extras to avoid double callbacks.
+    if (SC.platform.supportsCSSTransitions) {
+      var domPrefix = SC.browser.domPrefix,
+        lowerDomPrefix = domPrefix.toLowerCase(),
+        variation1 = lowerDomPrefix + 'transitionend',
+        variation2 = lowerDomPrefix + 'TransitionEnd',
+        variation3 = domPrefix + 'TransitionEnd';
+
+      // Ensure that the callback name used maps to our implemented function name.
+      this[variation1] = this[variation2] = this[variation3] = this.transitionend;
+
+      // ex. transitionend, webkittransitionend, webkitTransitionEnd, WebkitTransitionEnd
+      this.listenFor(['transitionend', variation1, variation2, variation3], document);
+
+      if (SC.platform.supportsCSSAnimations) {
+        variation1 = lowerDomPrefix + 'animationstart';
+        variation2 = lowerDomPrefix + 'AnimationStart';
+        variation3 = domPrefix + 'AnimationStart';
+
+        // Ensure that the callback name used maps to our implemented function name.
+        this[variation1] = this[variation2] = this[variation3] = this.animationstart;
+
+        // ex. animationstart, webkitanimationstart, webkitAnimationStart, WebkitAnimationStart
+        this.listenFor(['animationstart', variation1, variation2, variation3], document);
+
+        variation1 = lowerDomPrefix + 'animationiteration';
+        variation2 = lowerDomPrefix + 'AnimationIteration';
+        variation3 = domPrefix + 'AnimationIteration';
+
+        // Ensure that the callback name used maps to our implemented function name.
+        this[variation1] = this[variation2] = this[variation3] = this.animationiteration;
+
+        // ex. animationiteration, webkitanimationiteration, webkitAnimationIteration, WebkitAnimationIteration
+        this.listenFor(['animationiteration', variation1, variation2, variation3], document);
+
+        variation1 = lowerDomPrefix + 'animationend';
+        variation2 = lowerDomPrefix + 'AnimationEnd';
+        variation3 = domPrefix + 'AnimationEnd';
+
+        // Ensure that the callback name used maps to our implemented function name.
+        this[variation1] = this[variation2] = this[variation3] = this.animationend;
+
+        // ex. animationend, webkitanimationend, webkitAnimationEnd, WebkitAnimationEnd
+        this.listenFor(['animationend', variation1, variation2, variation3], document);
+      }
+    }
+
     // handle these two events specially in IE
     ['drag', 'selectstart'].forEach(function (keyName) {
       var method = this[keyName];
@@ -763,37 +814,79 @@ SC.RootResponder = SC.Object.extend(
   },
 
   /**
-    Sets up the transition end event listener.
+    Cleans up the additional transition event listeners.
 
-    NOTE: requires that SC.platform.transitionendEventName has been determined.
+    NOTE: requires that SC.RootResponser.responder.transitionendEventName
+    has been determined.
 
     @returns {void}
   */
-  setupTransitionListener: function () {
-    // CSS Transitions (tested asynchronously)
-    if (SC.platform.supportsCSSTransitions) {
-      // Ensure that the callback name used maps to our implemented function name.
-      this[SC.platform.transitionendEventName] = this.transitionend;
-      this.listenFor([SC.platform.transitionendEventName], document);
-    }
+  cleanUpTransitionListeners: function () {
+    var actualEventName = SC.platform.transitionendEventName,
+      domPrefix = SC.browser.domPrefix,
+      lowerDomPrefix = domPrefix.toLowerCase(),
+      variation1 = lowerDomPrefix + 'transitionend',
+      variation2 = lowerDomPrefix + 'TransitionEnd',
+      variation3 = domPrefix + 'TransitionEnd';
+
+    // Once the actual event name is determined, simply remove all the extras.
+    // This should prevent any problems with browsers that fire multiple events.
+    ['transitionend', variation1, variation2, variation3].forEach(function (keyName) {
+      if (keyName != actualEventName) {
+        SC.Event.remove(document, keyName, this, this[keyName]);
+        this[keyName] = null;
+      }
+    });
   },
 
   /**
-    Sets up the animation event listeners.
+    Cleans up the additional animation event listeners.
 
-    NOTE: requires that SC.platform.animationstartEventName, SC.platform.animationendEventName & SC.platform.animationiterationEventName has been determined.
+    NOTE: requires that SC.RootResponser.responder.animationstartEventName,
+    SC.RootResponser.responder.animationendEventName and
+    SC.RootResponser.responder.animationiterationEventName have been
+    determined.
 
     @returns {void}
   */
-  setupAnimationListeners: function () {
-    // CSS Animations (tested asynchronously)
-    if (SC.platform.supportsCSSAnimations) {
-      // Ensure that the callback name used maps to our implemented function name.
-      this[SC.platform.animationstartEventName] = this.animationstart;
-      this[SC.platform.animationendEventName] = this.animationend;
-      this[SC.platform.animationiterationEventName] = this.animationiteration;
-      this.listenFor([SC.platform.animationstartEventName, SC.platform.animationendEventName, SC.platform.animationiterationEventName], document);
-    }
+  cleanUpAnimationListeners: function () {
+    var domPrefix = SC.browser.domPrefix,
+      lowerDomPrefix = domPrefix.toLowerCase(),
+      actualEventName = SC.platform.animationendEventName,
+      variation1 = lowerDomPrefix + 'animationend',
+      variation2 = lowerDomPrefix + 'AnimationEnd',
+      variation3 = domPrefix + 'AnimationEnd';
+
+    // Once the actual event name is determined, simply remove all the extras.
+    // This should prevent any problems with browsers that fire multiple events.
+    ['animationend', variation1, variation2, variation3].forEach(function (keyName) {
+      if (keyName != actualEventName) {
+        SC.Event.remove(document, keyName, this, this[keyName]);
+        this[keyName] = null;
+      }
+    });
+
+    actualEventName = SC.platform.animationiterationEventName;
+    variation1 = lowerDomPrefix + 'animationiteration';
+    variation2 = lowerDomPrefix + 'AnimationIteration';
+    variation3 = domPrefix + 'AnimationIteration';
+    ['animationiteration', variation1, variation2, variation3].forEach(function (keyName) {
+      if (keyName != actualEventName) {
+        SC.Event.remove(document, keyName, this, this[keyName]);
+        this[keyName] = null;
+      }
+    });
+
+    actualEventName = SC.platform.animationstartEventName;
+    variation1 = lowerDomPrefix + 'animationstart';
+    variation2 = lowerDomPrefix + 'AnimationStart';
+    variation3 = domPrefix + 'AnimationStart';
+    ['animationstart', variation1, variation2, variation3].forEach(function (keyName) {
+      if (keyName != actualEventName) {
+        SC.Event.remove(document, keyName, this, this[keyName]);
+        this[keyName] = null;
+      }
+    });
   },
 
   // ...........................................................................
@@ -1615,7 +1708,7 @@ SC.RootResponder = SC.Object.extend(
     handles the event, then it will be sent as a regular keyDown event.
     This function is only valid when called with a keydown event.
   */
-  _isFunctionOrNonPrintableKey: function(evt) {
+  _isFunctionOrNonPrintableKey: function (evt) {
     return !!(evt.altKey || evt.ctrlKey || evt.metaKey || SC.FUNCTION_KEYS[evt.which]);
   },
 
@@ -1636,7 +1729,7 @@ SC.RootResponder = SC.Object.extend(
      @param {KeyboardEvent} evt keypress event
      @returns {Boolean}
    */
-  _isPrintableKey: function(evt) {
+  _isPrintableKey: function (evt) {
     return ((evt.originalEvent.which === undefined || evt.originalEvent.which > 0) &&
       !(evt.which === 8 || evt.which === 9 || evt.which === 13 || evt.which === 27));
   },