sproutcore 0.9.13 → 0.9.14

data/frameworks/sproutcore/tests/controllers/object.rhtml

@@ -236,6 +236,32 @@ Test.context("SC.ObjectController", {
       this.single.didCommitChanges.shouldEqual(YES) ;
     },
     
+    "Should update both values when commitChanges() on content objects" : function() {
+      cc = SC.CollectionController.create({
+        allowsEmptySelection: false,
+        allowsMultipleSelection: false
+      });
+      var oc = SC.ObjectController.create({
+        contentBinding: 'cc.selection',
+        commitChangesImmediately: false
+      });
+      var Contact = SC.Record.extend({});
+      
+      var rcrds = Contact.collection();
+      cc.set('content', rcrds);
+      rcrds.refresh();
+      var single = Contact.create({'test' : 'NAME1', 'value' : 0});
+      
+      rcrds.count().shouldEqual(1);
+      
+      oc.set('test', 'NAME2');
+      oc.set('value', 123);
+      
+      $ok(oc.commitChanges()).shouldEqual(YES);
+      single.get('test').shouldEqual('NAME2');
+      single.get('value').shouldEqual(123);
+    },
+    
     "Support content objects that implement SC.Array but are not arrays": function() {
       this.c.set('content', this.dummy_a) ;
 

data/frameworks/sproutcore/tests/views/collection/incremental_rendering.rhtml

@@ -155,7 +155,7 @@ Test.context("CASE 3: Autoscrolling, no incremental rendering, no custom layout"
       }),
       
       init: function() {
-        arguments.callee.base.apply(this, arguments) ;
+        sc_super() ;
         this.setStyle({ overflow: "auto", height: '200px' }) ;
       }
     }) ;
@@ -198,7 +198,7 @@ Test.context("CASE 4: Autoscrolling, no incremental rendering, custom layout",
       },
 
       init: function() {
-        arguments.callee.base.apply(this, arguments) ;
+        sc_super() ;
         this.setStyle({ overflow: "auto", height: '200px' }) ;
       }
       

data/frameworks/sproutcore/views/button/disclosure.js

@@ -33,7 +33,7 @@ SC.DisclosureView = SC.ButtonView.extend(
   valueBindingDefault: SC.Binding.Bool,
   
   init: function() {
-    arguments.callee.base.apply(this,arguments) ;
+    sc_super() ;
     if (this.get('value') == this.get('toggleOnValue')) {
       this.set('isSelected', true) ;
     }

data/frameworks/sproutcore/views/collection/collection.js

@@ -670,11 +670,6 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate,
     // updateChildren again.
     var clippingFrame = this._lastClippingFrame = this.get('clippingFrame') ;
 	
-	// this is a workaround for the clippingFrame bug in ie7 clippingFrame is always returning dimensions 0,0
-	if(clippingFrame.width==0 && clippingFrame.height==0){
-		clippingFrame = this._lastClippingFrame = f;
-	}
-    
     // STEP 2: Calculate the new range of content to display in 
     // the clipping frame.  Determine if we need to do a full update or
     // not.
@@ -709,10 +704,13 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate,
         var key = SC.guidFor(c) ;
         var itemView = this._insertItemViewFor(c, groupBy, idx) ;
 
-        // add item view to new hash and remove from old hash.
-        itemViewsByContent[key] = itemView;
-       
-        delete this._itemViewsByContent[key];
+        if(itemView)
+        {
+          // add item view to new hash and remove from old hash.
+          itemViewsByContent[key] = itemView;
+
+          delete this._itemViewsByContent[key];
+        }
       }
       
       // Now iterate through the old hash.  Any left over item views should
@@ -1151,11 +1149,14 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate,
     
     // negative length == remove item views
     if (length < 0) {
-      while(++length < 0) {
-        var c = content.objectAt(start + length) ;
-        var itemView = this.itemViewForContent(c) ;
-        if (itemView) this._removeItemView(itemView, groupBy) ;
-      }
+      // TEMPORARY OPTIMIZATION:  Do not remove views when they go out of
+      // range.  This way they don't need to be created/addred later on.
+      //
+      // while(++length < 0) {
+      //   var c = content.objectAt(start + length) ;
+      //   var itemView = this.itemViewForContent(c) ;
+      //   if (itemView) this._removeItemView(itemView, groupBy) ;
+      // }
       
     // positive length == add item views.
     } else if (length > 0) {
@@ -1475,6 +1476,9 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate,
   */
   scrollToContent: function(record) {
     // find the itemView.  if not present, add one.
+    var content = Array.from(this.get('content'));
+    if (content.indexOf(record) < 0) return ; // do nothing if not in content.
+    
     var itemView = this.itemViewForContent(record) ;
     if (!itemView) {
       var content = Array.from(this.get('content')) ;
@@ -2608,7 +2612,7 @@ SC.CollectionView = SC.View.extend(SC.CollectionViewDelegate,
     this._itemViewPool= [];
     this._groupViewPool= [];
 
-    arguments.callee.base.apply(this, arguments) ;
+    sc_super() ;
     this._dropTargetObserver();
   },
 

data/frameworks/sproutcore/views/collection/source_list.js

@@ -153,7 +153,7 @@ SC.SourceListView = SC.CollectionView.extend(
   // cached group rows to make sure we get an accurate count.
   updateChildren: function(deep) {
     if (deep) this._groupRows = null ;
-    return arguments.callee.base.apply(this, arguments) ;  
+    return sc_super() ;  
   },
   
   // determines if the group at the specified content index is visible or

data/frameworks/sproutcore/views/collection/table.js

@@ -43,7 +43,7 @@ SC.TableView = SC.CollectionView.extend(
     var min = Math.max(0,Math.floor(SC.minY(frame) / rowHeight)-1) ;
     var max = Math.ceil(SC.maxY(frame) / rowHeight) ;
     var ret = { start: min, length: max - min } ; 
-//    console.log('contentRangeInFrame(%@) = %@'.fmt($H(frame).inspect(), $H(ret).inspect()));
+    // console.log('contentRangeInFrame(%@) = %@'.fmt($H(frame).inspect(), $H(ret).inspect()));
     //if (frame.height < 100) debugger ;
     return ret ;
   },
@@ -78,7 +78,7 @@ SC.TableView = SC.CollectionView.extend(
 
     f.x = f.y = 0;
     f.height = Math.max(f.height, rows * rowHeight) ;
-//    console.log('computeFrame(%@)'.fmt($H(f).inspect())) ;
+    // console.log('computeFrame(%@)'.fmt($H(f).inspect())) ;
     return f ;
   },
   

data/frameworks/sproutcore/views/error_explanation.js

@@ -51,7 +51,7 @@ SC.ErrorExplanationView = SC.View.extend(SC.Control,
   }.observes('value'),
   
   init: function() {
-    arguments.callee.base.apply(this,arguments) ;
+    sc_super() ;
     this._valueObserver() ;
   }
   

data/frameworks/sproutcore/views/field/checkbox_field.js

@@ -32,7 +32,7 @@ SC.CheckboxFieldView = SC.FieldView.extend(
   valueBindingDefault: SC.Binding.Bool,
   
   init: function() {
-    arguments.callee.base.apply(this,arguments) ;
+    sc_super() ;
     var f = this.fieldValueDidChange.bind(this, false) ;
     Event.observe(this.rootElement,'click', f) ;
   }

data/frameworks/sproutcore/views/field/field.js

@@ -181,7 +181,7 @@ SC.FieldView = SC.View.extend(SC.Control, SC.Validatable,
   */
   isEnabledObserver: function() {
     isEnabled = this.get('isEnabled') ;
-    arguments.callee.base.apply(this, arguments);
+    sc_super();
     (isEnabled) ? this.enableField() : this.disableField(); 
   }.observes('isEnabled'),
 

data/frameworks/sproutcore/views/field/radio_field.js

@@ -102,7 +102,7 @@ SC.RadioFieldView = SC.FieldView.extend(
   },
   
   init: function() {
-    arguments.callee.base.apply(this,arguments) ;
+    sc_super() ;
     
     // find all inputs.
     this._fields = {} ;

data/frameworks/sproutcore/views/field/select_field.js

@@ -269,7 +269,7 @@ SC.SelectFieldView = SC.FieldView.extend(
   // rebuild the menu when this happens, but only one time.
   _objectsItemObserver: function(item, key, value) {
     if (item.didChangeFor(this._guid, key)) {
-      console.log('rebuildMenu') ;
+      // console.log('rebuildMenu') ;
       this._rebuildMenu() ;
     }
   },

data/frameworks/sproutcore/views/form.js

@@ -453,7 +453,7 @@ SC.FormView = SC.View.extend({
   
   // When the form is first created, go find all the fields and save them.
   init: function() {
-    arguments.callee.base.apply(this,arguments) ;
+    sc_super() ;
     
     // disable the normal submission system so we can take over.
     if (this.rootElement && this.rootElement.tagName.toLowerCase() == "form") {

data/frameworks/sproutcore/views/image.js

@@ -152,7 +152,7 @@ SC.ImageView = SC.View.extend(SC.Control,
   },
   
   init: function() {
-    arguments.callee.base.apply(this,arguments) ;
+    sc_super() ;
     this.valueObserver() ;
     if (this.rootElement.src) {
       this.set('imageWidth',parseInt(this.rootElement.width,0)) ;

data/frameworks/sproutcore/views/menu_item.js

@@ -81,7 +81,7 @@ SC.MenuItemView = SC.ButtonView.extend({
   
   mouseUp: function(evt)
   {
-    arguments.callee.base.apply(this, arguments);
+    sc_super();
     this._closeParentMenu();
   },
   didTriggerAction: function()

data/frameworks/sproutcore/views/popup_button.js

@@ -23,7 +23,7 @@ SC.PopupButtonView = SC.ButtonView.extend({
     if (!this.get('isEnabled')) return false;
     
     // is it our own keyEquivalent? 
-    if (arguments.callee.base.apply(this,arguments)) return true;
+    if (sc_super()) return true;
 
     // is it any of our menu items keyEquivalent?
     var menu = this.get('menu');

data/frameworks/sproutcore/views/popup_menu.js

@@ -113,7 +113,7 @@ SC.PopupMenuView = SC.View.extend({
       if (!target) sender.set('isEnabled', false);
     }
     // call the superclasses _show method to make the menu visible
-    arguments.callee.base.apply(this, arguments);
+    sc_super();
   },
   
   resizeWithOldParentSize: function() {

data/frameworks/sproutcore/views/progress.js

@@ -93,8 +93,8 @@ SC.ProgressView = SC.View.extend({
       var isIndeterminate = this.get('isIndeterminate') ;
       var isEnabled = this.get('isEnabled') ;
       
-      Element.setClassName(this,'indeterminate',isIndeterminate) ;
-      Element.setClassName(this,'disabled',!isEnabled) ;
+      this.setClassName('indeterminate',isIndeterminate);
+      this.setClassName('disabled',!isEnabled);
       
       // compute value for setting the width of the inner progress
       var value ;
@@ -109,6 +109,8 @@ SC.ProgressView = SC.View.extend({
         value = (value - minimum) / (maximum - minimum) ; 
         if (value > 1.0) value = 1.0 ;
       }
+      if(isNaN(value))
+        value = 0.0;
       value = value * 100 ;
       if (this.innerView) this.innerView.setStyle({ width: (value + '%') }) ;
     }

data/frameworks/sproutcore/views/radio_group.js

@@ -19,7 +19,7 @@ SC.RadioGroupView = SC.View.extend({
 
    // PRIVATE METHODS
    init: function() {
-     arguments.callee.base.apply(this, arguments) ;
+     sc_super() ;
      
      // find the list of buttons to update and set them up.
      var loc = this.outlets.length ;

data/frameworks/sproutcore/views/scroll.js

@@ -50,7 +50,7 @@ SC.ScrollView = SC.ContainerView.extend(SC.Scrollable, {
   }.observes('canScrollHorizontal'),
 
   init: function() {
-    arguments.callee.base.apply(this, arguments) ;
+    sc_super() ;
     this._canScrollVerticalObserver() ;
     this._canScrollHorizontalObserver() ;
   },

data/frameworks/sproutcore/views/source_list_group.js

@@ -77,7 +77,7 @@ SC.SourceListGroupView = SC.View.extend(SC.Control, SC.DelegateSupport, {
     
     // set the group visibility if changed
     var groupVisibleKey = this.getDelegateProperty(this.displayDelegate, 'groupVisibleKey') ;
-    if ((key == '*') || (groupVisibleKey && (key == groupVisibileKey))) {
+    if ((key == '*') || (groupVisibleKey && (key == groupVisibleKey))) {
 
       if (groupVisibleKey) {
         

data/frameworks/sproutcore/views/split.js

@@ -282,7 +282,7 @@ SC.SplitView = SC.View.extend(SC.DelegateSupport,
   
   /** @private */
   init: function() {
-    arguments.callee.base.apply(this, arguments) ;
+    sc_super() ;
     this.addClassName(this.get('layoutDirection')) ;
   }
   

data/frameworks/sproutcore/views/tab.js

@@ -6,6 +6,8 @@
 require('views/view') ;
 require('views/container') ;
 
+SC.TAB_VIEW_TAB_REGEXP = /Tab$/ ;
+
 /** @class
 
   To use a TabView, just declare the views and buttons you want to manage
@@ -56,7 +58,7 @@ SC.TabView = SC.ContainerView.extend(
     while(--loc >= 0) {
       var outlet = this.outlets[loc] ;
       // look for outlets ending in 'Tab'
-      if (outlet.slice(outlet.length-3,outlet.length) == "Tab") { 
+      if (outlet.match(SC.TAB_VIEW_TAB_REGEXP)) { 
         var key = outlet.slice(0,-3) ; // remove 'Tab' 
         var tab = view.get(outlet) ; // find tab view
         var button = view.get(key + 'Button') ; // find button view (opt)

data/frameworks/sproutcore/views/view.js

@@ -115,8 +115,12 @@ SC.View = SC.Responder.extend(SC.PathModule,  SC.DelegateSupport,
     // call notices.
     view.didAddToParent(this, beforeView) ;
     this.didAddChild(view, beforeView) ;
-    
-    return this ;
+    try{
+    	return this ;
+	}finally{
+		if(beforeElement)
+		  beforeElement=null;
+	}
   },
 
   /**
@@ -163,7 +167,11 @@ SC.View = SC.Responder.extend(SC.PathModule,  SC.DelegateSupport,
     
     view.didRemoveFromParent(this) ;
     this.didRemoveChild(view);
+	try{
     return this;
+}finally{
+	el=null;
+}
   },
 
   /**
@@ -2197,11 +2205,19 @@ if (SC.Platform.IE) {
   SC.View._collectInnerFrame = function() {
     var el = this.rootElement ;
     var hasLayout = (el.currentStyle) ? el.currentStyle.hasLayout : NO ;
+    var borderTopWidth = parseInt(el.currentStyle.borderTopWidth, 0) || 0 ;
+    var borderBottomWidth = parseInt(el.currentStyle.borderBottomWidth, 0) || 0 ;
+    var scrollHeight = el.offsetHeight-borderTopWidth-borderBottomWidth;
+    if(el.clientWidth > el.scrollWidth)
+    {
+      scrollHeight-15;
+    }
+    
     return { 
       x: el.offsetLeft, 
       y: el.offsetTop, 
       width: (hasLayout) ? Math.min(el.scrollWidth, el.clientWidth) : el.scrollWidth, 
-      height: (hasLayout) ? Math.min(el.scrollHeight, el.clientHeight) : el.scrollHeight 
+      height: (hasLayout) ? Math.min(scrollHeight, el.clientHeight) : scrollHeight
     };
   } ;
   

data/jsdoc/README.txt

@@ -1,104 +1,136 @@
-=====================================================================
+======================================================================
 
 DESCRIPTION:
 
-JsDoc Toolkit is an automatic documentation generation tool for
-JavaScript. It is written in JavaScript and is run from a command line
-(or terminal) using Mozilla Rhino JavaScript engine. Using this tool
-you can automatically turn JavaDoc-like comments in your JavaScript
-source code into published output, such as HTML or XML.
+** NOTICE ** THIS VERSION OF THE SOFTWARE IS "BETA," MEANING IT IS IS
+NOT YET READY FOR USE IN A PRODUCTION ENVIRONEMNT. IT IS MADE
+AVAILABLE FOR PREVIEW AND TESTING PURPOSES ONLY.
 
-For more information, to report a bug or to browse the technical
+This is Version 2 of JsDoc Toolkit, an automatic documentation
+generation tool for JavaScript. It is written in JavaScript and is run
+from a command line (or terminal) using the Java runtime engine.
+
+Using this tool you can automatically turn JavaDoc-like comments in
+your JavaScript source code into published output files, such as HTML
+or XML.
+
+For more information, to report a bug, or to browse the technical
 documentation for this tool please visit the official JsDoc Toolkit
-project homepage: http://code.google.com/p/jsdoc-toolkit/
+project homepage at http://code.google.com/p/jsdoc-toolkit/
 
-This project is based on the JSDoc.pm tool, created by Michael 
-Mathews, maintained by Gabriel Reid. More information on JsDoc can
-be found on the JSDoc.pm homepage: http://jsdoc.sourceforge.net/
+For the most up-to-date documentation on Version 2 of JsDoc Toolkit
+see the Verion 2 wiki at http://jsdoctoolkit.org/wiki
 
-Complete documentation on JsDoc Toolkit can be found on the project
-wiki at http://code.google.com/p/jsdoc-toolkit/w/list
 
+======================================================================
+
+REQUIREMENTS:
+
+JsDoc Toolkit is known to work with:
+java version "1.6.0_03"
+Java(TM) SE Runtime Environment (build 1.6.0_03-b05)
+on Windows XP,
+and java version "1.5.0_13"
+Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_13-b05-241)
+on Mac OS X 10.4.
 
-=====================================================================
+Other versions of java may or may not work with JsDoc Toolkit.
+
+======================================================================
 
 USAGE:
 
-Running JsDoc Toolkit on your desktop requires you to have Java
-installed and the Mozilla Rhino JavaScript jar file (named "js.jar")
-available. A copy of this jar file is included with the JsDoc Toolkit
-distribution. To download Rhino yourself or to find out more go to 
-the official Rhino web page: http://www.mozilla.org/rhino/
+Running JsDoc Toolkit requires you to have Java installed on your
+computer. For more information see http://www.java.com/getjava/
 
-Before running the JsDoc Toolkit app you must change your current
+Before running the JsDoc Toolkit app you should change your current
 working directory to the jsdoc-toolkit folder. Then follow the
 examples below, or as shown on the project wiki.
 
 On a computer running Windows a valid command line to run JsDoc
 Toolkit might look like this:
 
- > java -jar app\js.jar app\run.js -a -t=templates\htm test\data\test.js
+> java -jar jsrun.jar app\run.js -a -t=templates\jsdoc mycode.js
 
 On Mac OS X or Linux the same command would look like this:
 
- $ java -jar app/js.jar app/run.js -a -t=templates/htm test/data/test.js
+$ java -jar jsrun.jar app/run.js -a -t=templates/jsdoc mycode.js
 
-The above assumes your current working directory contains the app, test
-and templates subdirectories from the standard JsDoc Toolkit 
-distribution. If you have the js.jar file saved to a place in your
-system's Java CLASSPATH, it can safely be omitted from the command.
+The above assumes your current working directory contains jsrun.jar,
+the "app" and "templates" subdirectories from the standard JsDoc
+Toolkit distribution and that the relative path to the code you wish
+to document is "mycode.js".
 
-To run JsDoc Toolkit from any directory, specify the path to the app
-folder like so:
+The output documentation files will be saved to a new directory named
+"out" (by default) in the current directory, or if you specify a
+-d=somewhere_else option, to the somewhere_else directory.
 
- > java -Djsdoc.dir=%BASE_DIR% -jar %RHINO% %RUN% %OPTS% %SRC_FILES%
+For help (usage notes) enter this on the command line:
 
-So assuming the JsDoc Toolkit "app" directory is in "lib\jsdoc-toolkit"
-you would specify that like so:
+$ java -jar jsrun.jar app/run.js --help
 
- > java -Djsdoc.dir=lib\jsdoc-toolkit <etc>
+More information about the various command line options used by JsDoc
+Toolkit are available on the project wiki.
 
-The output documentation files will be saved to a new directory named
-"js_docs_out" (by default) in the current directory, or if you specify
-a -d=somewhere_else option, to the somewhere_else directory.
+======================================================================
 
-For help (usage notes) enter this on the command line:
-
- > java -jar app\js.jar app\run.js -h
+TESTING:
 
-To run the unit tests included with JsDoc Toolkit enter this on the
-command line:
+To run the suite of unit tests included with JsDoc Toolkit enter this
+on the command line:
 
- > java -jar app\js.jar test\run.js
+$ java -jar jsrun.jar app/run.js -T
 
-To run any example in the included examples enter this on the
-command line:
+To see a dump of the internal data structure that JsDoc Toolkit has
+built from your source files use this command:
 
- $ java -jar app/js.jar examples/run.js -a  examples/data/whatever.js
+$ java -jar jsrun.jar app/run.js mycode.js -Z
 
 
-=====================================================================
+======================================================================
 
 LICENSE:
 
+JSDoc.pm
+
+This project is based on the JSDoc.pm tool, created by Michael
+Mathews and Gabriel Reid. More information on JsDoc.pm can
+be found on the JSDoc.pm homepage: http://jsdoc.sourceforge.net/
+
+Complete documentation on JsDoc Toolkit can be found on the project
+wiki at http://code.google.com/p/jsdoc-toolkit/w/list
+
+Rhino
+
 Rhino (JavaScript in Java) is open source and licensed by Mozilla
-under the MPL 1.1 or later/GPL 2.0 or later licenses, the text of which
-is available at http://www.mozilla.org/MPL/
+under the MPL 1.1 or later/GPL 2.0 or later licenses, the text of
+which is available at http://www.mozilla.org/MPL/
 
-You can obtain the source code for Rhino via the Mozilla web site at
+You can obtain the source code for Rhino from the Mozilla web site at
 http://www.mozilla.org/rhino/download.html
 
-The Tango base icon theme is licensed under the Creative Commons 
-Attribution Share-Alike license. The palette is in the public domain.
-For more details visit the Tango! Desktop Project page at
-http://tango.freedesktop.org/Tango_Desktop_Project
-
 JsDoc Toolkit is a larger work that uses the Rhino JavaScript engine
-without modification and without any claims whatsoever. The portions of
-code specific to JsDoc Toolkit are open source and licensed under the
-X11/MIT License.
+but is not derived from it in any way. The Rhino library is used 
+without modification and without any claims whatsoever.
+
+The Rhino Debugger
+
+You can obtain more information about the Rhino Debugger from the 
+Mozilla web site at http://www.mozilla.org/rhino/debugger.html
+
+JsDoc Toolkit is a larger work that uses the Rhino Debugger but
+is not derived from it in any way. The Rhino Debugger is used
+without modification and without any claims whatsoever.
+
+JsDoc Toolkit
+
+All code specific to JsDoc Toolkit are free, open source and licensed
+for use under the X11/MIT License.
+
+JsDoc Toolkit is Copyright (c)2008 Michael Mathews <micmath@gmail.com>
 
-Copyright (c) 2007 Michael Mathews <micmath@gmail.com>
+This program is free software; you can redistribute it and/or
+modify it under the terms below.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the