sprockets_better_errors 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 82e5beaa51f3638f3705da3d09d0e17a3c87cab0
-  data.tar.gz: a6cb373b070b9bde834a36037997bb69617c07b4
+  metadata.gz: d41a6ace0ae7ca72a5dee2e473ccf1b9a375b6ec
+  data.tar.gz: bc78b2ca3ce506b8834d63ee9074c4222efa0992
 SHA512:
-  metadata.gz: 9611d176a7f7b08ab072a0fb3ea7bae5bedc5b618b7849bd6474d5a7abff3c87f9f5a583c30816aca6336e3ac1c1ea988b586d578a30523b4381a1195f288f1b
-  data.tar.gz: 9d5f8ac38de36a23efd8c31e0db3fa1dcc3dc2dce90cf54d6b608946ef2d680e29a2edc8cd3a3102f2b72d7dcdedd8cd99525566ec484e956ab797b2525ce0ec
+  metadata.gz: 74c60c85a5ffb0c931007acc08ccebf6adc538d755b502476368bf6197725087b58139cbd7e2482b41e875b32696943f7df830f80209962e7fcecbedec8f0d22
+  data.tar.gz: 5bcfd12df8306422b41d31114f46cd87480857efb8bb672fb5de2a7a10acf4e5b7fa4a61eacef14b058e8c237bed2ea04ba1e5dbae5f58d5a4ac58faba6e2e27

data/README.md

@@ -36,6 +36,12 @@ Then run:
 $ bundle install
 ```
 
+And add this line to your `config/environments/development.rb`:
+
+```
+config.assets.raise_production_errors = true
+```
+
 Now develop with some sprockets super powers!
 
 
@@ -85,6 +91,15 @@ Why not add this code upstream? I allready tried, there are several PR awaiting
 - [Raise on improper dependency use](https://github.com/rails/sprockets-rails/pull/96)
 - Bonus, not mine: [Raise if ERB ](https://github.com/sstephenson/sprockets/pull/426)
 
+
+## Tests
+
+Here's a one liner to running tests
+
+```
+$ export RAILS_VERSION=4.0.0; bundle update; bundle exec rake test
+```
+
 ## License
 
 MIT

data/lib/sprockets_better_errors/sprockets_rails_helper.rb

@@ -1,7 +1,7 @@
 module Sprockets::Rails::Helper
 
   # == BEGIN Hacks for checking if dependencies are listed correctly
-  class DependencyError <StandardError
+  class DependencyError < StandardError
     def initialize(path, dep)
       msg =  "Asset depends on '#{dep}' to generate properly but has not declared the dependency\n"
       msg << "Please add: `//= depend_on_asset \"#{dep}\"` to '#{path}'"
@@ -11,6 +11,7 @@ module Sprockets::Rails::Helper
 
 
   def check_dependencies!(dep)
+    return unless Sprockets::Rails::Helper.raise_asset_errors
     return unless @_dependency_assets
     return if     @_dependency_assets.detect { |asset| asset.include?(dep) }
     raise DependencyError.new(self.pathname, dep)

data/lib/sprockets_better_errors/sprockets_railtie.rb

@@ -1,9 +1,9 @@
 module Sprockets
   class Railtie < ::Rails::Railtie
     config.after_initialize do |app|
-      Sprockets::Rails::Helper.precompile         ||= app.config.assets.precompile
-      Sprockets::Rails::Helper.assets             ||= app.assets
-      Sprockets::Rails::Helper.raise_asset_errors  = ::Rails.env.development?
+      Sprockets::Rails::Helper.precompile         = app.config.assets.precompile
+      Sprockets::Rails::Helper.assets             = app.assets
+      Sprockets::Rails::Helper.raise_asset_errors = app.config.assets.raise_production_errors
     end
   end
 end

data/lib/sprockets_better_errors/version.rb

@@ -1,3 +1,3 @@
 module SprocketsBetterErrors
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/sprockets_better_errors.gemspec

@@ -18,6 +18,15 @@ Gem::Specification.new do |gem|
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
 
+msg = <<-MSG
+
+To enable sprockets_better_errors
+add this line to your `config/environments/development.rb:
+  config.assets.raise_production_errors = true
+
+MSG
+
+  gem.post_install_message = msg
 
   gem.add_dependency 'sprockets-rails', ">= 1.0.0"
   gem.add_development_dependency "capybara", ">= 0.4.0"

data/test/dummy/app/assets/javascripts/no_errors.js

@@ -0,0 +1,3 @@
+//= depend_on_asset "application.css"
+
+var foo = '<%= asset_path("application.css") %>';

data/test/dummy/app/views/foo/no_erb_tag_error.html.erb

@@ -1 +1 @@
-<%= asset_path('no_erb_tag_error.js') %>
+<%= asset_path("no_erb_tag_error.js") %>

data/test/dummy/app/views/foo/no_errors.html.erb

@@ -0,0 +1 @@
+<%= asset_path("no_errors.js") %>

data/test/dummy/app/views/foo/no_reference_error.html.erb

@@ -1 +1 @@
-<%= asset_path('no_reference_error.js') %>
+<%= asset_path("no_reference_error.js") %>

data/test/dummy/config/application.rb

@@ -33,7 +33,9 @@ module Dummy
     # JavaScript files you want as :defaults (application.js is always included).
     # config.action_view.javascript_expansions[:defaults] = %w(jquery rails)
 
-    config.assets.precompile += %w( no_reference_error.js no_erb_tag_error.js )
+    config.assets.precompile += %w( no_reference_error.js
+                                    no_errors.js
+                                    no_erb_tag_error.js )
 
     # Configure the default encoding used in templates for Ruby 1.9.
     config.encoding = "utf-8"
@@ -42,5 +44,7 @@ module Dummy
     config.filter_parameters += [:password]
 
     config.assets.enabled = true
+
+    config.assets.raise_production_errors = true
   end
 end

data/test/integration/precompile_raise_test.rb

@@ -16,10 +16,7 @@ class InheritNavigationTest < ActiveSupport::IntegrationCase
     assert_match "depends on 'application.css'", error.message
   end
 
-  # test 'erb' do
-  #    error = assert_raise(ActionView::Template::Error) do
-  #     visit('/foo/no_erb_tag_error')
-  #   end
-  # end
-
+  test 'no failure' do
+    visit('/foo/no_errors')
+  end
 end

data/test/test_helper.rb

@@ -8,9 +8,6 @@ ENGINE_RAILS_ROOT=File.join(File.dirname(__FILE__), '../')
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
 require "rails/test_help"
 
-
-
-
 ActionMailer::Base.delivery_method = :test
 ActionMailer::Base.perform_deliveries = true
 ActionMailer::Base.default_url_options[:host] = "test.com"
@@ -23,10 +20,16 @@ require 'capybara/poltergeist'
 Capybara.javascript_driver = :poltergeist
 Capybara.default_selector = :css
 
-
-
 # Run any available migration
 ActiveRecord::Migrator.migrate File.expand_path("../dummy/db/migrate/", __FILE__)
 
 # Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
+
+clear_assets = Proc.new do
+  `bundle exec rake -f ./test/dummy/Rakefile assets:clobber`
+  raise "could not clear assets" unless $?.success?
+end
+
+clear_assets.call

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sprockets_better_errors
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Richard Schneeman
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-18 00:00:00.000000000 Z
+date: 2013-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sprockets-rails
@@ -101,6 +101,7 @@ files:
 - test/dummy/app/assets/images/.keep
 - test/dummy/app/assets/javascripts/application.js
 - test/dummy/app/assets/javascripts/no_erb_tag_error.js
+- test/dummy/app/assets/javascripts/no_errors.js
 - test/dummy/app/assets/javascripts/no_reference_error.js.erb
 - test/dummy/app/assets/javascripts/not_precompiled.js
 - test/dummy/app/assets/javascripts/welcome.js.coffee
@@ -110,6 +111,7 @@ files:
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/views/foo/index.html
 - test/dummy/app/views/foo/no_erb_tag_error.html.erb
+- test/dummy/app/views/foo/no_errors.html.erb
 - test/dummy/app/views/foo/no_reference_error.html.erb
 - test/dummy/app/views/foo/precompile_error.html.erb
 - test/dummy/app/views/layouts/application.html.erb
@@ -164,7 +166,12 @@ homepage: https://github.com/schneems/sprockets_better_errors
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message: |2+
+
+  To enable sprockets_better_errors
+  add this line to your `config/environments/development.rb:
+    config.assets.raise_production_errors = true
+
 rdoc_options: []
 require_paths:
 - lib
@@ -190,6 +197,7 @@ test_files:
 - test/dummy/app/assets/images/.keep
 - test/dummy/app/assets/javascripts/application.js
 - test/dummy/app/assets/javascripts/no_erb_tag_error.js
+- test/dummy/app/assets/javascripts/no_errors.js
 - test/dummy/app/assets/javascripts/no_reference_error.js.erb
 - test/dummy/app/assets/javascripts/not_precompiled.js
 - test/dummy/app/assets/javascripts/welcome.js.coffee
@@ -199,6 +207,7 @@ test_files:
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/views/foo/index.html
 - test/dummy/app/views/foo/no_erb_tag_error.html.erb
+- test/dummy/app/views/foo/no_errors.html.erb
 - test/dummy/app/views/foo/no_reference_error.html.erb
 - test/dummy/app/views/foo/precompile_error.html.erb
 - test/dummy/app/views/layouts/application.html.erb
@@ -249,3 +258,4 @@ test_files:
 - test/route_inspector_test.rb
 - test/support/integration_case.rb
 - test/test_helper.rb
+has_rdoc: