sprockets-svg 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b586a285d7659583918ac48a90a7e03ae09cbdbb
-  data.tar.gz: 5f582344fde414f8a5ec3005b7694e9b0a85bf58
+  metadata.gz: ca8ee0ce977bf5c0d1140265953cf17b190ad529
+  data.tar.gz: 369619d9d2d2104abcd51e0c9601cc20767d2281
 SHA512:
-  metadata.gz: b2bef4d6f33651aa2cb7cfccc06ec89aac8a9b06d14794030b84fff2c0af408e396d7e6e59f1ba05dd4a1167de3027e93b7f74ab75289457330ecbc0db2e2b40
-  data.tar.gz: 7a1c248d2a2e82b125987c08f7c51c863d1119db9dfba072343191ce40f81b3a4fa8e8444f1825acba2e8973957734a04585b7723a08aecbf0a4abce17169352
+  metadata.gz: 67479b3fa111293006e1f3770120e43eb9bfdef0e6e6fcec190fa22829f40f6e96befa03d5a5f06c9cc2f71aae3c712f6638bff60003d7fae6a75159341418a3
+  data.tar.gz: 8531492ffb4c19fdc63b1ce3ebd89625523a3e1e283bcccda14b944619193728ebbc513c2baad640f0b00737a97fcd747f6ae3111541d6d4270e9b92b16478c1

data/lib/sprockets/svg/cleaner.rb

@@ -6,10 +6,11 @@ module Sprockets
       # TODO: integrate svgo instead: https://github.com/svg/svgo
       # See https://github.com/lautis/uglifier on how to integrate a npm package as a gem.
       def self.process(svg)
-        document = Nokogiri::XML(svg)
-        document.css('[display=none]').remove()
-        document.to_s
+        document = Nokogiri::XML(svg).css('svg')
+        document.css('[display=none]').remove
+        document.xpath('//comment()').remove
+        document.to_s.gsub("\n", '').gsub(/>\s+</, '><').strip
       end
     end
   end
-end
+end

data/lib/sprockets/svg/version.rb

@@ -1,5 +1,5 @@
 module Sprockets
   module Svg
-    VERSION = '0.3.0'
+    VERSION = '0.4.0'
   end
 end

data/spec/cleaner_spec.rb

@@ -0,0 +1,30 @@
+require 'spec_helper'
+
+describe Sprockets::Svg::Cleaner do
+
+  let(:source_svg) { File.read(__dir__ + '/fixtures/source.svg') }
+
+  let(:minified_svg) { described_class.process(source_svg) }
+
+  it 'reduce the SVG size from 1064 to 493 bytes' do
+    expect(source_svg.bytesize).to be == 1064
+    expect(minified_svg.bytesize).to be == 493
+  end
+
+  it 'remove comments' do
+    expect(minified_svg).to_not include('<!--')
+  end
+
+  it 'remove hidden elements' do
+    expect(minified_svg).to_not include('display="none"')
+  end
+
+  it 'remove doctype' do
+    expect(minified_svg).to_not include('DOCTYPE')
+  end
+
+  it 'remove the xml header' do
+    expect(minified_svg).to_not include('<?xml')
+  end
+
+end

data/spec/fixtures/source.svg

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Generator: Adobe Illustrator 17.1.0, SVG Export Plug-In . SVG Version: 6.00 Build 0)  -->
+<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
+<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
+	 viewBox="0 0 24 24" enable-background="new 0 0 24 24" xml:space="preserve">
+<path id="Error_1_" fill="#666B6D" d="M12,0C5.4,0,0,5.4,0,12s5.4,12,12,12s12-5.4,12-12S18.6,0,12,0z M12,4c1.4,0,2.7,0.4,3.9,1
+	L12,8.8L8.8,12L5,15.9c-0.6-1.1-1-2.5-1-3.9C4,7.6,7.6,4,12,4z M12,20c-1.4,0-2.7-0.4-3.9-1l3.9-3.9l3.2-3.2L19,8.1
+	c0.6,1.1,1,2.5,1,3.9C20,16.4,16.4,20,12,20z"/>
+<path display="none" fill="#B7B7B7" d="M15,2H1C0.447,2,0,2.447,0,3v10c0,0.553,0.447,1,1,1h14c0.553,0,1-0.447,1-1V3
+	C16,2.447,15.553,2,15,2z M8,8.586L3.414,4h9.172L8,8.586z M4.586,8L2,10.586V5.414L4.586,8z M6,9.414l1.647,1.646
+	c0.195,0.195,0.512,0.195,0.707,0L10,9.414L12.586,12H3.414L6,9.414z M11.414,8L14,5.414v5.172L11.414,8z"/>
+</svg>

data/spec/rails_spec.rb

@@ -9,15 +9,15 @@ ASSETS = Pathname.new(COMPILED_ASSETS_PATH)
 
 describe 'Sprockets::Svg' do
 
-  let(:svg_name) { 'facebook-213385e4d9304ef93b23578fc4c93440.svg' }
+  let(:svg_name) { 'facebook-83a94368b23ba9e928820abc2cc12254.svg' }
 
-  let(:png_name) { 'facebook.svg-213385e4d9304ef93b23578fc4c93440.png' }
+  let(:png_name) { 'facebook.svg-83a94368b23ba9e928820abc2cc12254.png' }
 
   let(:svg_path) { ASSETS.join(svg_name) }
 
   let(:png_path) { ASSETS.join(png_name) }
 
-  let(:font_path) { ASSETS.join('fontawesome-webfont-040e9dcf8f420c96cbb5f0985fe09185.svg') }
+  let(:font_path) { ASSETS.join('fontawesome-webfont-be512ff93d0957609a535f25f438ac42.svg') }
 
   let(:svg_fingerprint) { Digest::MD5.hexdigest(svg_path.read) }
 
@@ -44,7 +44,7 @@ describe 'Sprockets::Svg' do
       expect(svg_path).to be_exist
       expect(png_path).to be_exist
 
-      expect(svg_fingerprint).to be == '85385a2b8357015a4ae6d8ab782d5389'
+      expect(svg_fingerprint).to be == '2d8738f246e37a7befd06db8dc2f7e11'
       # Metadata etc are kinda time dependant, so this assertion is the best I can do.
       expect(png_source).to be_starts_with("\x89PNG\r\n")
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sprockets-svg
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-11 00:00:00.000000000 Z
+date: 2014-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -102,6 +102,8 @@ files:
 - spec/app/config/environments/test.rb
 - spec/app/config/initializers/secret_token.rb
 - spec/app/config/routes.rb
+- spec/cleaner_spec.rb
+- spec/fixtures/source.svg
 - spec/rails_spec.rb
 - spec/spec_helper.rb
 - sprockets-svg.gemspec
@@ -144,5 +146,7 @@ test_files:
 - spec/app/config/environments/test.rb
 - spec/app/config/initializers/secret_token.rb
 - spec/app/config/routes.rb
+- spec/cleaner_spec.rb
+- spec/fixtures/source.svg
 - spec/rails_spec.rb
 - spec/spec_helper.rb