sprockets-commoner 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee42f65a12ad9e9a4b5dedb998af38e8fcdd2f4d
-  data.tar.gz: 020f3d0f782c8a1fcc6afd382a5162e667328e32
+  metadata.gz: 0e07853296174bca18616b5f0a8021b4830b33de
+  data.tar.gz: f3a207b0a0b047889f21c1d75d5a3f1b2d491822
 SHA512:
-  metadata.gz: 180123fc5d46f1bb21f9a60938e42fb8fd2d2662087e5473a53a6c13f276068825d4a2c8c34f05e5b4247f2f3844801e91afaab020b85df9afb328d957930f06
-  data.tar.gz: 2c3938f74a7664b7c1b78aedeb76036b960ed3eb82650af95b9183a943e7a1fd2d5c29ec86787a337291bc70fbbdee265c932dc7fa41e9203ceeff02b16b0688
+  metadata.gz: 081005224d924d04f646d027e6c618efc591bc157533f21b805ff48ec85ec7ccc199ffe4aaa4561d12fed8ab22ecaa067758b8f343d18ef75f864e4531a44a47
+  data.tar.gz: 1d24a89e58c518190f34c6192c3a132d7f53235d533b518080afcbb02cef51afa1acf3a300c5f2964acbeddff95683d2d2ee37b8a2be0dd6a208cf632ba4e84d

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## v0.2.2
+
+* Don't cache Babel output as this can lead to bugs.
+* Avoid imports of files that won't be processed by Commoner, to defend against bugs.
+* Exclude vendor/bundle by default.
+
 ## v0.2.1
 
 * Fix bug with `browser` field stubbing out modules.
@@ -9,6 +15,14 @@
 
 * Add support for requiring JSON files.
 
+## v0.1.2
+
+* Backport fixes from v0.2.2
+
+## v0.1.1
+
+* Backport fixes from v0.2.1.
+
 ## v0.1.0
 
 * Initial version.

data/README.md

@@ -61,8 +61,8 @@ Rails.application.config.assets.configure do |env|
     # include, exclude, and babel_exclude patterns can be path prefixes or regexes.
     # Explicitely list paths to include. The default is `[env.root]`
     include: ['app/assets/javascripts/subdirectory'],
-    # List files to ignore and not process require calls or apply any Babel transforms to. Default is empty.
-    exclude: [/ignored/],
+    # List files to ignore and not process require calls or apply any Babel transforms to. Default is ['vendor/bundle'].
+    exclude: ['vendor/bundle', /ignored/],
     # Anything listed in babel_exclude has its require calls resolved, but no transforms listed in .babelrcs applied.
     # Default is [/node_modules/]
     babel_exclude: [/node_modules/]

data/bin/console

@@ -0,0 +1,9 @@
+#!/usr/bin/env ruby
+
+require 'bundler/setup'
+require 'sprockets'
+require 'sprockets/commoner'
+
+require 'pry'
+
+Pry.start

data/lib/sprockets/commoner/processor.rb

@@ -4,10 +4,14 @@ require 'open3'
 module Sprockets
   module Commoner
     class Processor < Schmooze::Base
+
+      ExcludedFileError = Class.new(::StandardError)
+
       BABELRC_FILE = '.babelrc'.freeze
       PACKAGE_JSON = 'package.json'.freeze
       JS_PACKAGE_PATH = File.expand_path('../../../js', __dir__)
       ALLOWED_EXTENSIONS = /\.js(?:on)?(?:\.erb)?\z/
+      COFFEE_EXTENSION = /\.coffee(:?\.erb)?\z/
 
       dependencies babel: 'babel-core', commoner: 'babel-plugin-sprockets-commoner-internal'
 
@@ -44,7 +48,7 @@ module Sprockets
       end
 
       attr_reader :include, :exclude, :babel_exclude
-      def initialize(root, include: [root], exclude: [], babel_exclude: [/node_modules/])
+      def initialize(root, include: [root], exclude: ['vendor/bundle'], babel_exclude: [/node_modules/])
         @include = include.map {|path| expand_to_root(path, root) }
         @exclude = exclude.map {|path| expand_to_root(path, root) }
         @babel_exclude = babel_exclude.map {|path| expand_to_root(path, root) }
@@ -52,12 +56,6 @@ module Sprockets
       end
 
       def call(input)
-        @cache_key ||= [
-          self.class.name,
-          version,
-          VERSION,
-        ].freeze
-
         filename = input[:filename]
 
         return unless should_process?(filename)
@@ -70,12 +68,13 @@ module Sprockets
 
         babel_config = babelrc_data(filename)
 
-        result = input[:cache].fetch([filename, @cache_key, input[:data], babel_config]) do
-          transform(input[:data], options(input), paths: @env.paths)
-        end
+        result = transform(input[:data], options(input), paths: @env.paths)
 
         if result['metadata'].has_key?('required')
           result['metadata']['required'].each do |r|
+            unless COFFEE_EXTENSION =~ r || should_process?(r)
+              raise ExcludedFileError, "#{r} was imported from #{filename} but this file won't be processed by Sprockets::Commoner"
+            end
             asset = resolve(r, accept: input[:content_type], pipeline: :self)
             @required.insert(insertion_index, asset)
           end

data/lib/sprockets/commoner/version.rb

@@ -1,5 +1,5 @@
 module Sprockets
   module Commoner
-    VERSION = '0.2.1'
+    VERSION = '0.2.2'
   end
 end

data/sprockets-commoner.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
   spec.add_dependency "sprockets", ">= 3", "< 4"
-  spec.add_dependency "schmooze", "~> 0.1.5"
+  spec.add_dependency "schmooze", "~> 0.1.6"
 
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "minitest", "~> 5.0"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: sprockets-commoner
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Bouke van der Bijl
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-05-06 00:00:00.000000000 Z
+date: 2016-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sprockets
@@ -36,14 +36,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.5
+        version: 0.1.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.1.5
+        version: 0.1.6
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -130,6 +130,7 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/console
 - circle.yml
 - js/babel-plugin-sprockets-commoner-internal/.gitignore
 - js/babel-plugin-sprockets-commoner-internal/README.md