springboard-retail 4.2.0 → 4.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 13eaf04ac55ef152f9c444f235656ad9899634d173aff26f6d87d287d9c07b94
-  data.tar.gz: ec8edecf083f85ce0750ba307080a00044daff4020acd8defd2ef6ce50ea45f2
+  metadata.gz: 75887540f522a54dbca3eb013bffa99780b96d17846797c8072963c2567ebf89
+  data.tar.gz: 9b72a1e965fedce2afd7c25da5a68e85b2caf587916fbccda22f0e9a3dbe1a99
 SHA512:
-  metadata.gz: 158b90cf3fe6e854ec8aaa1ca77d503e7b43e3ce7aa106ad832bb5e85e3b6cde8712f6981d6f49827605d1fa636ed7dfb271edd32de805dac2deeac10412bf6d
-  data.tar.gz: 00e9ce7b716561a0994c06e2f8c78159f68346999f063cad57f9fb11ab2e1e5a1b66cef00849a5ee34950156ee81d1c6b37c287988783ba7a73cc2fcb7991d3a
+  metadata.gz: a06be6e7ecf83216be6d5200b0044615719e7605911f5c1bf3f1ccf76b8bdf9a7480ae334028254ba49d50134e43ba7c858f5769b6fadde6fa4a9b27a5458121
+  data.tar.gz: 4095a672bdeb383b19cffb6657137456e8dc8801255e7f43548ef0db9a2c3db01491f666d5508dd79e9b6275715b250cb13a683d1cbce812b966bc7fa616b5ad

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    springboard-retail (4.2.0)
+    springboard-retail (4.2.1)
       addressable (~> 2.2.8)
       hashie
       json (>= 1.7.4)

data/README.md

@@ -4,7 +4,6 @@
 [![Build Status](https://travis-ci.org/springboardretail/springboard-client-ruby.png?branch=master)](https://travis-ci.org/springboardretail/springboard-client-ruby)
 [![Code Climate](https://codeclimate.com/github/springboardretail/springboard-client-ruby.png)](https://codeclimate.com/github/springboardretail/springboard-client-ruby)
 [![Coverage Status](https://coveralls.io/repos/github/springboardretail/springboard-client-ruby/badge.svg?branch=master)](https://coveralls.io/github/springboardretail/springboard-client-ruby?branch=master)
-[![Dependency Status](https://gemnasium.com/springboardretail/springboard-client-ruby.png)](https://gemnasium.com/springboardretail/springboard-client-ruby)
 
 This is the [Springboard Retail](http://springboardretail.com/) (a point-of-sale/retail management system) client library for Ruby. It provides access to the Springboard Retail HTTP API.
 

data/lib/springboard/client/uri.rb

@@ -10,7 +10,7 @@ module Springboard
       #
       # @return [URI]
       def self.parse(value)
-        return value if value.is_a?(self)
+        return value.dup if value.is_a?(self)
         new(::Addressable::URI.parse(value))
       end
 
@@ -30,6 +30,14 @@ module Springboard
         @uri = uri
       end
 
+      ##
+      # Clones the URI object
+      #
+      # @return [URI]
+      def dup
+        self.class.new(@uri.dup)
+      end
+
       ##
       # Returns a new URI with the given subpath appended to it. Ensures a single
       # forward slash between the URI's path and the given subpath.

data/spec/springboard/client/resource_spec.rb

@@ -48,6 +48,12 @@ describe Springboard::Client::Resource do
         it "should add bracket notation for array parameters" do
           expect(resource.__send__(method, :somearray => [1, 2, 3]).uri.to_s).to eq("/some/path?somearray[]=1&somearray[]=2&somearray[]=3")
         end
+
+        it "should return a new resource without modifying the existing URI" do
+          new_resource = resource.query(per_page: 1)
+          expect(new_resource.uri.to_s).to eq("/some/path?per_page=1")
+          expect(resource.uri.to_s).to eq("/some/path")
+        end
       end
 
       describe "when called without arguments" do
@@ -107,7 +113,7 @@ describe Springboard::Client::Resource do
     end
   end
 
-  %w{count each each_page}.each do |method|
+  %w{each each_page}.each do |method|
     describe method do
       it "should call the client's #{method} method with the resource's URI" do
         expect(client).to receive(method).with(resource.uri)
@@ -134,6 +140,37 @@ describe Springboard::Client::Resource do
     end
   end
 
+  describe "count" do
+    let(:response_data) {
+      {
+        :status => 200,
+        :body => {total: 123}.to_json
+      }
+    }
+
+    it "should call the client's count method with the resource's URI" do
+      expect(client).to receive(:count).with(resource.uri)
+      resource.count
+    end
+
+    it "should set the per_page query string param to 1" do
+      request_stub = stub_request(:get, "#{base_url}/some/path?page=1&per_page=1").to_return(response_data)
+      resource.count
+      expect(request_stub).to have_been_requested
+    end
+
+    it "should return the resource count" do
+      request_stub = stub_request(:get, "#{base_url}/some/path?page=1&per_page=1").to_return(response_data)
+      expect(resource.count).to eq(123)
+    end
+
+    it "should not modify the original resource URI" do
+      request_stub = stub_request(:get, "#{base_url}/some/path?page=1&per_page=1").to_return(response_data)
+      resource.count
+      expect(resource.uri.to_s).to eq("/some/path")
+    end
+  end
+
   describe "first" do
     let(:response_data) {
       {
@@ -152,6 +189,12 @@ describe Springboard::Client::Resource do
       request_stub = stub_request(:get, "#{base_url}/some/path?page=1&per_page=1").to_return(response_data)
       expect(resource.first).to eq({"id" => "Me first!"})
     end
+
+    it "should not modify the original resource URI" do
+      request_stub = stub_request(:get, "#{base_url}/some/path?page=1&per_page=1").to_return(response_data)
+      resource.first
+      expect(resource.uri.to_s).to eq("/some/path")
+    end
   end
 
   describe "embed" do

data/spec/springboard/client/uri_spec.rb

@@ -12,10 +12,39 @@ describe Springboard::Client::URI do
   end
 
   describe "parse" do
-    it "should return a URI based on the given string" do
-      uri = described_class.parse('/some_path')
-      expect(uri).to be_a(described_class)
-      expect(uri.to_s).to eq('/some_path')
+    describe "when called with a URI object" do
+      it "should return a cloned URI object" do
+        parsed_uri = described_class.parse(uri)
+        expect(uri.class).to eq(parsed_uri.class)
+        expect(uri.object_id).not_to eq(parsed_uri.object_id)
+        expect(parsed_uri.to_s).to eq(uri.to_s)
+      end
+    end
+
+    describe "when called with a URI string" do
+      it "should return a URI based on the given string" do
+        uri = described_class.parse('/some_path')
+        expect(uri).to be_a(described_class)
+        expect(uri.to_s).to eq('/some_path')
+      end
+    end
+  end
+
+  describe "dup" do
+    it "should return a duplicate URI object" do
+      dup_uri = uri.dup
+      expect(uri.class).to eq(dup_uri.class)
+      expect(uri.to_s).to eq(dup_uri.to_s)
+      expect(uri.object_id).not_to eq(dup_uri.object_id)
+    end
+
+    describe "when mutating the copy" do
+      it "should not affect the original" do
+        dup_uri = uri.dup
+        dup_uri.query_values = {per_page: 1}
+        expect(uri.to_s).to eq('/relative/path')
+        expect(dup_uri.to_s).to eq('/relative/path?per_page=1')
+      end
     end
   end
 

data/springboard-retail.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name              = 'springboard-retail'
-  s.version           = '4.2.0'
+  s.version           = '4.2.1'
   s.platform          = Gem::Platform::RUBY
   s.authors           = ['Jay Stotz']
   s.summary           = 'Springboard Retail API client library'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: springboard-retail
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.2.1
 platform: ruby
 authors:
 - Jay Stotz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-25 00:00:00.000000000 Z
+date: 2018-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: patron
@@ -104,8 +104,8 @@ files:
 - vendor/cache/crack-0.4.2.gem
 - vendor/cache/diff-lcs-1.2.5.gem
 - vendor/cache/docile-1.1.5.gem
-- vendor/cache/hashie-3.5.5.gem
-- vendor/cache/json-2.0.3.gem
+- vendor/cache/hashie-3.5.7.gem
+- vendor/cache/json-2.1.0.gem
 - vendor/cache/method_source-0.8.2.gem
 - vendor/cache/mime-types-2.4.3.gem
 - vendor/cache/multi_json-1.11.0.gem