spring_onion 0.1.4 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5dc46f208b6c23dee53529598492e790c4b7335a694540312932b27eb4613889
-  data.tar.gz: d94debb3984be7370cefccd527e38ae56d90fcef1a42fac8277b011a171359bd
+  metadata.gz: 797e6837cbc8fb508afac284d54509ce175ac77346320bcc0697c0cd54b49a06
+  data.tar.gz: 487f8a88353cce686f0b259cd83f2401cb3d599a4d05e403250018b2e3ae4fdc
 SHA512:
-  metadata.gz: 89f5da00f467539f3829439824b3610886893e3cf7b47ada519f178d96b99e85b07885c3390e05a1a15c3850038625a5ae2e3bed64bd1ac19cf34538dd2a2bac
-  data.tar.gz: be8e4de6c3fd4a4e5758761047f57eb6145fc0739911171756092c2006479d1d4d742262bbd485275ceae7844684b3cf389e76785b08977811e6b0b25a09e377
+  metadata.gz: bc53955a16cd100e68ef306b798966f62937963ce8a3a67b819779379892fa50125b61c30e127cd1d1c3c0bd23cf58b9961a13a196430b15f55705b553ec9f0e
+  data.tar.gz: d0c482e0864d25b05d3dc002de0b36d6b6b2d5414d8af7402bf86390f7a1182dc2d0cd745afb6cd8dcfe5d4c889141c351f4d3f6414acd957c4d2bd43322af41

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    spring_onion (0.1.4)
+    spring_onion (0.2.0)
       activerecord
       coderay
       mysql2

data/README.md

@@ -40,7 +40,7 @@ SpringOnion.source_filter_re = //
 class Employee < ActiveRecord::Base; end
 
 Employee.all.to_a.count
-#=> SpringOnion	INFO	2020-07-18 01:53:27 +0900	{"sql":"SELECT `employees`.* FROM `employees`","explain":[{"line":1,"select_type":"SIMPLE","table":"employees","partitions":null,"type":"ALL","possible_keys":null,"key":null,"key_len":null,"ref":null,"rows":298936,"filtered":100.0,"Extra":null}],"violations":{"line 1":["slow_type"]},"backtrace":["/foo/bar/zoo/baz.rb:18:in `\u003ctop (required)\u003e'"]}
+#=> SpringOnion	INFO	2020-07-18 01:53:27 +0900	{"sql":"SELECT `employees`.* FROM `employees`","explain":[{"line":1,"select_type":"SIMPLE","table":"employees","partitions":null,"type":"ALL","possible_keys":null,"key":null,"key_len":null,"ref":null,"rows":298936,"filtered":100.0,"Extra":null}],"warnings":{"line 1":["slow_type"]},"backtrace":["/foo/bar/zoo/baz.rb:18:in `\u003ctop (required)\u003e'"]}
 #=> 300024
 ```
 
@@ -65,7 +65,7 @@ Employee.all.to_a.count
             "Extra": null
         }
     ],
-    "violations": {
+    "warnings": {
         "line 1": [
             "slow_type"
         ]

data/lib/spring_onion/config.rb

@@ -17,7 +17,7 @@ module SpringOnion
     'Using temporary'
   )
 
-  @violations = {
+  @warnings = {
     slow_select_type: ->(exp) { SLOW_SELECT_TYPE_RE =~ exp['select_type'] },
     slow_type: ->(exp) { SLOW_TYPE_RE =~ exp['type'] },
     slow_possible_keys: ->(exp) { SLOW_POSSIBLE_KEYS_RE =~ exp['possible_keys'] },
@@ -75,7 +75,7 @@ module SpringOnion
   class << self
     attr_accessor :enabled,
                   :connection,
-                  :violations,
+                  :warnings,
                   :sql_filter_re, :ignore_sql_filter_re, :sql_filter,
                   :source_filter_re, :ignore_source_filter_re, :source_filter,
                   :logger,

data/lib/spring_onion/explainer.rb

@@ -30,23 +30,23 @@ module SpringOnion
     end
 
     def _validate(exp, sql, trace)
-      violations = SpringOnion.violations
-      violation_names_by_line = {}
+      warnings = SpringOnion.warnings
+      warning_names_by_line = {}
 
       exp.each_with_index do |row, i|
-        violation_names = violations.select do |_name, validator|
+        warning_names = warnings.select do |_name, validator|
           validator.call(row)
         end.keys
 
-        violation_names_by_line["line #{i + 1}"] = violation_names unless violation_names.empty?
+        warning_names_by_line["line #{i + 1}"] = warning_names unless warning_names.empty?
       end
 
-      return if violation_names_by_line.empty?
+      return if warning_names_by_line.empty?
 
       h = {
         sql: sql,
         explain: exp.each_with_index.map { |r, i| { line: i + 1 }.merge(r) },
-        violations: violation_names_by_line,
+        warnings: warning_names_by_line,
         backtrace: trace.slice(0, SpringOnion.trace_len),
       }
 

data/lib/spring_onion/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module SpringOnion
-  VERSION = '0.1.4'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: spring_onion
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.2.0
 platform: ruby
 authors:
 - winebarrel