spreewald 4.4.4 → 4.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: be47f16ea0fa8339c8edcb4c262b3af8a45bc4b3dc9c3521418d696e202f0fa3
-  data.tar.gz: 3d6ee00c9d70a268de045e63b48c7af9f21596a61127f93f1c302d667aacd09c
+  metadata.gz: 7fc8c05a08753163728b0fc4f49ba18329fa74982395ccc42f0a846d307808e8
+  data.tar.gz: 7601c85d5993c5c82212067422943e818f7ab9b1b0b90f439935fb21d07d922c
 SHA512:
-  metadata.gz: d153eaeab487f112100fd45c66bd3f26ddb50d7c6d660a20ade0f18a719bd04095c2a7f8a07ba4af8690a869081085f3c5f70a4c328ff594f8af110e9fe6f007
-  data.tar.gz: 1f2bbf29fffe40f234634cd111419a80d508c308b15313142642e4f114b82d48addf1d130c979d38b8c08fc8040b92a9039bd1e01f59ab50dcefcc0e776baa43
+  metadata.gz: 39deb82f5ad22c87a9291dc9a90fd65da1c867bb662ff35176e371e6034b9d12efa7216d198ca2a5bbca8b8a7fad9a55d603a39c9aca3f951b9b938813c0982c
+  data.tar.gz: ff6288ad06c31a8c77ac25071d7f9e627134a898c2c3d5df65ef646d0df07c18412b841efc0dc1bccf81eb5bffb705e10b0f836fab4c1d2873394c5acae2b2d1

data/CHANGELOG.md

@@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 4.5.1
+- Make `I should see an element for` and `I click on the element for` compatible for Ruby 3.0.  ([#204](https://github.com/makandra/spreewald/issues/204))
+
+## 4.5.0
+- `patiently` retries one more time in certain edge cases where the alloted time was used up within the last retry of the `patiently` block (usually by Capybara).
+
 ## 4.4.4
 - Make `When /^(?:|I )attach the file "([^"]*)" to "([^"]*)"$/` compatible for Ruby 3.0.
 

data/lib/spreewald/web_steps.rb

@@ -279,7 +279,8 @@ Then /^I should( not)? see (?:an|the) element for (.*?)$/ do |negate, locator|
   expectation = negate ? :not_to : :to
   selector = _selector_for(locator)
   patiently do
-    expect(page).send(expectation, have_selector(*selector))
+    args, kwargs = deconstruct_selector(selector)
+    expect(page).send(expectation, have_selector(*args, **kwargs))
   end
 end.overridable(:priority => -5) # priority must be lower than the "within" step
 
@@ -578,7 +579,8 @@ end.overridable
 When /^I click on the element for (.+?)$/ do |locator|
   patiently do
     selector = _selector_for(locator)
-    page.find(*selector).click
+    args, kwargs = deconstruct_selector(selector)
+    page.find(*args, **kwargs).click
   end
 end.overridable(priority: -5) # priority lower than within
 

data/lib/spreewald_support/tolerance_for_selenium_sync_issues.rb

@@ -39,16 +39,17 @@ module ToleranceForSeleniumSyncIssues
     WAIT_PERIOD = 0.05
 
     def patiently(seconds, &block)
-      started = monotonic_time
+      patiently_started = monotonic_time
       tries = 0
       begin
         tries += 1
+        block_started = monotonic_time
         block.call
       rescue Exception => e
         raise e unless retryable_error?(e)
-        raise e if (monotonic_time - started > seconds && tries >= 2)
+        raise e if (block_started - patiently_started > seconds && tries >= 2)
         sleep(WAIT_PERIOD)
-        raise Capybara::FrozenInTime, "time appears to be frozen, Capybara does not work with libraries which freeze time, consider using time travelling instead" if monotonic_time == started
+        raise Capybara::FrozenInTime, "time appears to be frozen, Capybara does not work with libraries which freeze time, consider using time travelling instead" if monotonic_time == patiently_started
         retry
       end
     end

data/lib/spreewald_support/version.rb

@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '4.4.4'
+  VERSION = '4.5.1'
 end

data/spec/spreewald_support/tolerance_for_selenium_sync_issues_spec.rb

@@ -105,6 +105,18 @@ describe ToleranceForSeleniumSyncIssues do
       expect(count).to be > 1
     end
 
+    it 'retries the block if the given time has been used within the last retry (see issue #202)' do
+      count = 0
+      expect {
+        subject.patiently do
+          count += 1
+          sleep wait_time if count == 2
+          raise Capybara::ElementNotFound
+        end
+      }.to raise_error(Capybara::ElementNotFound)
+      expect(count).to be > 2
+    end
+
     it 'will retry an outer patiently block if an inner patiently block took up all the time' do
       try = 0
       expect {

data/tests/rails-7_capybara-3/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (4.4.4)
+    spreewald (4.5.1)
       cucumber
       cucumber_priority (>= 0.3.0)
       rspec (>= 2.13.0)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreewald
 version: !ruby/object:Gem::Version
-  version: 4.4.4
+  version: 4.5.1
 platform: ruby
 authors:
 - Tobias Kraze
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-09 00:00:00.000000000 Z
+date: 2023-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -354,7 +354,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.6
+rubygems_version: 3.4.20
 signing_key: 
 specification_version: 4
 summary: Collection of useful cucumber steps.