spreewald 4.4.2 → 4.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ce046682ec3812d9b7b5ca4cf7286a44d7e683cdf2d60c259865cc5734bc14b
-  data.tar.gz: 7d1f7914f2b7621b509ac3fdc60cac9cfc39201760697aa041e9eb96e28c2d5d
+  metadata.gz: fafd6c66aa09488c02f829c4b64352d5fc0b8c313cbfcf3da8c8bfc9ef486192
+  data.tar.gz: 2839f5ae1583910b595d9df1166cf3a26696d23a7850c444715e0b965b137782
 SHA512:
-  metadata.gz: 89a78a3a31b2e46374cc21213b072a4fb36a8cd50d75d752cce156a449af0159e486911d99543bb16af9c5ed0be414f62197e7b51d917e01d80ad2b1c919877b
-  data.tar.gz: 797a519e0d97151108433d94a6a88ed2615ff2ec4cc0ae0b57079825dc72e98df882fd2d3160214abe0bafd9078c5102fd2513795662f588f74c5866623b99e5
+  metadata.gz: e75c55d4e317c6e67fb93f35b0eac0ed1c9aa9bc4b28a6b68f45976734e5e4ad684549052529b2ce3d3fa31e2b3ef2835cbd16da1d91af991b85811e2cfdf2fa
+  data.tar.gz: ab32078bf86d139a1ee68f21b27217a780eaad1784cf7dd1cf777a7fb2a4a0ceed42f7bf58e657fde8f1157984858bcd430c0d81e6dce79d51c2e032e9a20036

data/CHANGELOG.md

@@ -3,6 +3,32 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 4.4.3
+- Improve performance of the `I should (not) see a field ...` step to not retry the query when the element is **not** expected to be there.
+- Improve the `an email should have been sent with` step to ignore successive whitespaces after newlines in HTML mail bodies, effectively improving text matching in formatted HTML-tags.
+
+  For example, when searching for `Test` inside of the following HTML, you **no longer** need to use asterisks, because the leading whitespaces/tabs in front of `Test` are ignored:
+    ```html
+    <dt>
+      Test
+    </dt>
+    ```
+  
+    ```Gherkin
+    Then a mail should have been sent with
+    """
+    Test
+    """
+    ```
+    
+    Up to this version, the plain text was resolved to `\n  Test\n` (not `\nTest\n`) so it was necessary to declare a placeholder (`*`) for whitespaces:
+    ```Gherkin
+    Then a mail should have been sent with
+    """
+    *Test
+    """
+    ```
+
 ## 4.4.2
 - Add `ActionController::UrlGenerationError` to `patiently`'s retry errors.
   - This will solve timing issues when e.g. using step `I should be on ...` after creating a record via AJAX

data/README.md

@@ -25,7 +25,7 @@ Require all Spreewald steps by putting
 into either your `support/env.rb` or `step_definitions/spreewald_steps.rb`.
 
 Steps are grouped into a number of categories. If you only want to use a subset
-of Spreewald's steps, insead of `require 'spreewald/all_steps'`, you can pick 
+of Spreewald's steps, instead of `require 'spreewald/all_steps'`, you can pick 
 and choose single categories by requiring [single files](https://github.com/makandra/spreewald/tree/master/lib/spreewald) like this:
 
     require 'spreewald/email_steps'

data/lib/spreewald/web_steps.rb

@@ -194,17 +194,12 @@ end.overridable
 
 # Checks for the existance of an input field (given its id or label)
 Then /^I should( not)? see a field "([^"]*)"$/ do |negate, name|
-  expectation = negate ? :not_to : :to
-  patiently do
-    begin
-      # In old Capybaras find returns nil, so we assign it to `field`
-      field = find_with_disabled(:field, name)
-    rescue Capybara::ElementNotFound
-      # In Capybara 0.4+ #find raises an error instead of returning nil
-      # We must explicitely reset the field variable from a previous patiently iteration
-      field = nil
+  if negate
+    expect(page).to have_no_field(name)
+  else
+    patiently do
+      expect(page).to have_field(name, disabled: :all)
     end
-    expect(field).send(expectation, be_present)
   end
 end.overridable
 

data/lib/spreewald_support/mail_to_plaintext_converter.rb

@@ -36,7 +36,11 @@ module Spreewald
     end
   
     def text_from_html(html)
-      Nokogiri::HTML(html).at_css('body').text.gsub(/[\r\n]+/, "\n")
+      Nokogiri::HTML(html)
+        .at_css('body')
+        .text
+        .gsub(/[\r\n]+/, "\n")
+        .gsub(/\n\s+/, "\n")
     end
   end
 end

data/lib/spreewald_support/version.rb

@@ -1,3 +1,3 @@
 module Spreewald
-  VERSION = '4.4.2'
+  VERSION = '4.4.3'
 end

data/tests/rails-7_capybara-3/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    spreewald (4.4.2)
+    spreewald (4.4.3)
       cucumber
       cucumber_priority (>= 0.3.0)
       rspec (>= 2.13.0)

data/tests/shared/app/views/mailer/html_email_with_linebreaks.html

@@ -1,6 +1,6 @@
 <p>
-Hello!
+  Hello!
 </p>
 <p>
-Bye!
+  Bye!
 </p>

data/tests/shared/features/shared/web_steps.feature

@@ -362,6 +362,7 @@ Feature: Web steps
     When I go to "/forms/disabled_elements"
     Then I should see a field "Enabled field #1"
       And I should see a field "Disabled field #1"
+    But I should not see a field "Non-existing field"
 
 
   Scenario: /^I should( not)? see the (?:number|amount) ([\-\d,\.]+)(?: (.*?))?$/

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: spreewald
 version: !ruby/object:Gem::Version
-  version: 4.4.2
+  version: 4.4.3
 platform: ruby
 authors:
 - Tobias Kraze
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-16 00:00:00.000000000 Z
+date: 2022-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
@@ -351,7 +351,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: Collection of useful cucumber steps.